ach_client 3.1.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d140b0751adee4c2f924f737d9533bf084656ff330e6ebd2f764cede1cac4bf7
-  data.tar.gz: 91340a5b05226ad8e2f1eeeeac110415187a7bb7341c45d155720e143e93b165
+  metadata.gz: 3448884b23a8ca502b1506b354632c449c3f1436aa80398dccc280887abd1f49
+  data.tar.gz: ac997cdf2dc1a57e0c65e603e0f337a1e5c85ade85fdd4cf6915fad7ea31e729
 SHA512:
-  metadata.gz: 4affcfdf1085e60c06bf45916cea073f02b83e70bcae42e6e0f4ba9b774aa7695c82676344a2de91a4e0b294663aad91af3cbd055a34b9012f009e2775fcaecf
-  data.tar.gz: 2d9dc7b4c4f4ec66665e8cb74b646d8f21606adab21058c44a74b5451926f1e98cf4a8bf40f905167bfa8f9e388ce7aec2e18d163ee8cffd26e00c3227e3c259
+  metadata.gz: e7c7c0ca64f40107ab389e5fcb92bdcd841054a32f29b636a71f9b4e3db47ea291899664d4c102afd6ff7bae2e31850a3353e875022232e98c6e838deb30a551
+  data.tar.gz: 9c1f70ab5fa6691e8ec6f998dd5bf38f023ac880648a9cc5ee2169d870f75af82fe8d5103ee2104605e7dfef6f76464526c6512c84761b09787d0a37a5a25682

data/.ruby-version

@@ -1 +1 @@
-2.6.8
+3.1.3

data/.tool-versions

@@ -1 +1 @@
-ruby 2.6.8
+ruby 3.1.3

data/README.md

@@ -70,7 +70,7 @@ AchClient::Provider::AchTransaction.new(
   # The merchant's account type (see account types note above)
   account_type: AchClient::AccountTypes::BusinessChecking,
   # The amount of the ACH transaction, should be positive
-  amount: BigDecimal.new('575.45'),
+  amount: BigDecimal('575.45'),
   # The date on which you would like the transaction to take effect.
   # Beware that some providers may use this field to charge you extra for
   # same-day ACH ( a recent feature for ACH providers )

data/ach_client.gemspec

@@ -28,20 +28,22 @@ Gem::Specification.new do |spec|
     'config'
   ]
 
+  #spec.required_ruby_version = '>= 2.7.0'
+
   # NACHA library
   spec.add_dependency 'ach', '~> 0'
 
   # Handy ruby behavior from rails
-  spec.add_dependency 'activesupport', '< 6' # Need to rename .parent to .module_parent before upgrade
+  spec.add_dependency 'activesupport', '>= 6.0'
 
   # SFTP client (for Bank providers)
   spec.add_dependency 'net-sftp'
 
   # SOAP client (for AchWorks and ICheckGateway clients)
-  spec.add_dependency 'savon', '~> 2'
+  spec.add_dependency 'savon', '~> 2.12.0'
 
   # Asynchronocity w/out extra infrastucture dependency (database/redis)
-  spec.add_dependency 'sucker_punch', '~> 2'
+  spec.add_dependency 'sucker_punch', '~> 3'
 
   spec.add_development_dependency 'codeclimate-test-reporter'
   spec.add_development_dependency 'minitest-reporters'

data/lib/ach_client/logging/savon_observer.rb

@@ -11,7 +11,14 @@ module AchClient
       # @param globals [Savon::GlobalOptions] Savon's global options
       # @param locals [Savon::LocalOptions] Savon's global options
       # @return [NilClass] returns nothing so the request is not mutated
-      def notify(operation_name, builder, _globals, _locals)
+      def notify(operation_name, builder, globals, _locals)
+        # Since Savon only lets us register observers globally this method is called by any other Savon clients outside
+        #   this library. We don't want to log for those other clients so we check to see that the request came from
+        #   AchClient by comparing the wsdl to our known wsdls
+        return unless [
+          AchClient::ICheckGateway.wsdl,
+          AchClient::AchWorks.wsdl
+        ].include?(globals.instance_variable_get(:@options)[:wsdl])
         # Send the xml body to the logger job
         AchClient::Logging::LogProviderJob.perform_async(
           body: builder.to_s,

data/lib/ach_client/providers/abstract/company_info.rb

@@ -17,11 +17,10 @@ module AchClient
       end
 
       private_class_method def self.build_from_config(args)
-        self.new(
-          args.map do |arg|
+        args_hash = args.map do |arg|
             {arg => self.to_s.deconstantize.constantize.send(arg)}
           end.reduce(&:merge)
-        )
+        self.new(**args_hash)
       end
     end
   end

data/lib/ach_client/providers/sftp/ach_batch.rb

@@ -12,15 +12,15 @@ module AchClient
       # The filename used for the batch
       # @return [String] filename to use
       def batch_file_name
-        self.class.parent.file_naming_strategy.(@batch_number)
+        self.class.module_parent.file_naming_strategy.(@batch_number)
       end
 
       # Sends the batch to SFTP provider
       # @return [Array<String>]
       def do_send_batch
-        self.class.parent.write_remote_file(
+        self.class.module_parent.write_remote_file(
           file_path: File.join(
-            self.class.parent.outgoing_path,
+            self.class.module_parent.outgoing_path,
             batch_file_name
           ),
           file_body: cook_some_nachas.to_s
@@ -65,7 +65,7 @@ module AchClient
           :immediate_origin_name,
           :transmission_datetime
         ].each do |attribute|
-          file_header.send("#{attribute}=", self.class.parent.send(attribute))
+          file_header.send("#{attribute}=", self.class.module_parent.send(attribute))
         end
         file_header
       end
@@ -80,14 +80,14 @@ module AchClient
         batch_header = batch.header
         batch_header.company_name = originator_name
         batch_header.company_identification =
-          self.class.parent.company_identification
+          self.class.module_parent.company_identification
         batch_header.standard_entry_class_code = sec_code
         batch_header.company_entry_description =
-          self.class.parent.company_entry_description
+          self.class.module_parent.company_entry_description
         batch_header.company_descriptive_date = effective_entry_date
         batch_header.effective_entry_date = effective_entry_date
         batch_header.originating_dfi_identification =
-          self.class.parent.originating_dfi_identification
+          self.class.module_parent.originating_dfi_identification
         transactions.each do |transaction|
           batch.entries << transaction.to_entry_detail
         end

data/lib/ach_client/providers/sftp/ach_status_checker.rb

@@ -22,7 +22,7 @@ module AchClient
       #   values
       def self.in_range(start_date:, end_date:)
         in_range = {}
-        self.parent.with_sftp_connection do |connection|
+        self.module_parent.with_sftp_connection do |connection|
           in_range = process_files(
             files_in_range(
               connection: connection,
@@ -92,7 +92,7 @@ module AchClient
       end
 
       private_class_method def self.inbox_path_to(filename)
-        "#{self.parent.incoming_path}/#{filename}"
+        "#{self.module_parent.incoming_path}/#{filename}"
       end
 
       private_class_method def self.files_in_range(
@@ -101,7 +101,7 @@ module AchClient
         end_date: nil
       )
         # Get info on all files - equivalent to `ls`
-        connection.dir.entries(self.parent.incoming_path)
+        connection.dir.entries(self.module_parent.incoming_path)
                       .select do |file|
           last_modified_time = Time.at(file.attributes.mtime) - 1.minute
           # Filter to files modified in date range
@@ -148,7 +148,7 @@ module AchClient
 
       private_class_method def self.most_recent_files
         files = []
-        self.parent.with_sftp_connection do |connection|
+        self.module_parent.with_sftp_connection do |connection|
           files = files_in_range(
             connection: connection,
             start_date: last_most_recent_check_date(connection: connection)

data/lib/ach_client/providers/sftp/ach_transaction.rb

@@ -20,7 +20,7 @@ module AchClient
         entry.individual_id_number = remove_newlines(external_ach_id) # Doesn't need to be a number
         entry.individual_name = remove_newlines(merchant_name)
         entry.originating_dfi_identification = remove_newlines(
-          self.class.parent.originating_dfi_identification
+          self.class.module_parent.originating_dfi_identification
         )
         entry.trace_number = remove_non_digits(external_ach_id).to_i # Must be number
         entry

data/lib/ach_client/providers/soap/ach_works/response_record_processor.rb

@@ -30,7 +30,7 @@ module AchClient
       # @return [AchClient::ProcessingAchResponse] processing response
       def self.process_1SNT(record)
         AchClient::ProcessingAchResponse.new(
-          amount: BigDecimal.new(record[:trans_amount]),
+          amount: BigDecimal(record[:trans_amount]),
           date: record[:action_date]
         )
       end
@@ -40,7 +40,7 @@ module AchClient
       # @return [AchClient::SettledAchResponse] settled response
       def self.process_2STL(record)
         AchClient::SettledAchResponse.new(
-          amount: BigDecimal.new(record[:trans_amount]),
+          amount: BigDecimal(record[:trans_amount]),
           date: record[:action_date]
         )
       end
@@ -51,7 +51,7 @@ module AchClient
       # @return [AchClient::ReturnedAchResponse] returned response
       def self.process_3RET(record)
         AchClient::ReturnedAchResponse.new(
-          amount: BigDecimal.new(record[:trans_amount]),
+          amount: BigDecimal(record[:trans_amount]),
           date: record[:action_date],
           return_code: AchClient::ReturnCodes.find_by(
             code: record[:action_detail][0..2]
@@ -75,7 +75,7 @@ module AchClient
       # @return [AchClient::CorrectedAchResponse] corrected response
       def self.process_5COR(record)
         AchClient::CorrectedAchResponse.new(
-          amount: BigDecimal.new(record[:trans_amount]),
+          amount: BigDecimal(record[:trans_amount]),
           date: record[:action_date],
           return_code: AchClient::ReturnCodes.find_by(
             code: record[:action_detail][0..2]

data/lib/ach_client/version.rb

@@ -1,4 +1,4 @@
 module AchClient
   # Increment this when changes are published
-  VERSION = '3.1.0'
+  VERSION = '5.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ach_client
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Zach Cotter
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-11-14 00:00:00.000000000 Z
+date: 2023-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ach
@@ -28,16 +28,16 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: net-sftp
   requirement: !ruby/object:Gem::Requirement
@@ -58,28 +58,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: 2.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: sucker_punch
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -258,7 +258,6 @@ files:
 - ".codeclimate.yml"
 - ".github/CODEOWNERS"
 - ".gitignore"
-- ".rubocop.yml"
 - ".ruby-version"
 - ".tool-versions"
 - ".tool-versions-e"
@@ -349,7 +348,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Adapter to interact with various ACH service providers