ach_client 2.0.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bdcfddb63a2f873af45df29f8fcf6765ec99aff800eb04e8ec2b7500f0827e3c
-  data.tar.gz: 3bfa32675ec76f4e31b830b3616cc913b13f865c2c789394d49cc07758e93b89
+  metadata.gz: db2454a8ff3bb7662637a5cee010020ed14a3515d6eb47efe369ccbdc9bc4be4
+  data.tar.gz: 57751a71e4e2b8875da5d045d21f2c75c9261ff909bb20a765b1dc6eeb7faf00
 SHA512:
-  metadata.gz: 25670e16c050eb8248d80f22ffeea4a649cef6f624828118e32c866b7b7e0b0e19f0735150b7b636e5cb88dafc7d57fe7a2ac3225b8c507100b42a3a9fba668e
-  data.tar.gz: ed197b466da4182a732f463b7c51f4a0bd24fdfbfa58755bd058d2f830790719e5f6d6c600abf480e045430e186c962f331ee0a7e17534546d93f7ed44cc8819
+  metadata.gz: 42622b2e2e29a203713131b2f0523110b52ec3e61a3f5c8c2a5166da5787f045daee6886ea1d5fb52a498b0bc9ca771cd3cb475706b5e542e4f037f265ffbea5
+  data.tar.gz: febbaf712c3749e5417d55d9b247a7cde525a55e051be93bd44c0568392a6a5050cf42657971541869855516a66bc606d2ae16daf8da444a9b85b845816d66c2

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+* @ForwardFinancing/funding-app-smes

data/.ruby-version

@@ -1 +1 @@
-2.5.0
+2.6.8

data/.tool-versions

@@ -1 +1 @@
-ruby 2.5.0
+ruby 2.6.8

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 2.1.0
+
+* Add AchClient::Fake::AchStatusChecker to facilitate response poller testing
+
 ### 2.0.0
 
 * Add new AchClient::ICheckGateway::InstantRejectionError to handle API errors raised by ICheckGateway in situations

data/LICENSE

@@ -0,0 +1,29 @@
+BSD 3-Clause License
+
+Copyright (c) 2022, ForwardFinancing
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice, this
+   list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright notice,
+   this list of conditions and the following disclaimer in the documentation
+   and/or other materials provided with the distribution.
+
+3. Neither the name of the copyright holder nor the names of its
+   contributors may be used to endorse or promote products derived from
+   this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

data/README.md

@@ -11,7 +11,7 @@
 ## Overview
 
 The AchClient gem provides a common interface for working with a variety of
-ACH providers.
+ACH providers.  This is an **OPEN SOURCE PROJECT, PUBLICLY ACCESSIBLE**, and licensed under the BSD 3-Clause license
 
 Supported features include:
 
@@ -197,6 +197,12 @@ information has changed. Check the return code on the response object for
 details on what happened. Check the corrections hash on the response object for
 the new attributes
 
+### Testing
+
+The fake ACH provider namespace provides a status checker `AchClient::Fake::AchStatusChecker` that always returns the
+same responses. The external_ach_id for each response will be one of
+`['processing', 'settled', 'returned', 'corrected', 'late_returned']`
+
 ## Logging
 
 For record keeping purposes, there is a log provider that allows you to hook

data/ach_client.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'ach', '~> 0'
 
   # Handy ruby behavior from rails
-  spec.add_dependency 'activesupport'
+  spec.add_dependency 'activesupport', '< 6' # Need to rename .parent to .module_parent before upgrade
 
   # SFTP client (for Bank providers)
   spec.add_dependency 'net-sftp'

data/lib/ach_client/providers/soap/fake/ach_status_checker.rb

@@ -0,0 +1,42 @@
+module AchClient
+  class Fake
+    # Fake ACH polling that always returns the same set of results.
+    class AchStatusChecker < Abstract::AchStatusChecker
+
+      def self.most_recent
+        in_range(start_date: Date.today - 3.days, end_date: Date.today)
+      end
+
+      def self.in_range(start_date:, end_date:)
+        {
+          'processing' => [AchClient::ProcessingAchResponse.new(amount: 100.0, date: start_date)],
+          'settled' => [AchClient::SettledAchResponse.new(amount: 100.0, date: start_date)],
+          'returned' => [
+            AchClient::ReturnedAchResponse.new(
+              amount: 100.0,
+              date: start_date,
+              return_code: AchClient::ReturnCodes.find_by(code: 'R01')
+            )
+          ],
+          'corrected' => [
+            AchClient::CorrectedAchResponse.new(
+              amount: 100.0,
+              date: start_date,
+              return_code: AchClient::ReturnCodes.find_by(code: 'XZ2'),
+              corrections: '123456789'
+            )
+          ],
+          'late_returned' => [
+            AchClient::SettledAchResponse.new(amount: 100.0, date: start_date),
+            AchClient::ReturnedAchResponse.new(
+              amount: 100.0,
+              date: end_date,
+              return_code: AchClient::ReturnCodes.find_by(code: 'R08')
+            )
+          ]
+        }
+      end
+
+    end
+  end
+end

data/lib/ach_client/providers/soap/i_check_gateway/ach_status_checker.rb

@@ -14,6 +14,8 @@ module AchClient
         "ACCESS DENIED"
       ]
 
+      EMPTY_RETURNS_RESPONSE = 'NO RETURNS REPORTED'.freeze
+
       ##
       # ICheckGateway does not support this
       def self.most_recent
@@ -34,31 +36,74 @@ module AchClient
         end
       end
 
-      # Wrapper for the range response endpoint
-      # @return [Hash{String => [AchClient::AchResponse]}] Hash with
+      # @return Hash{String => [AchClient::AchResponse]} Hash with
       # confirmation number as the key, lists of AchResponse objects as values
       def self.in_range(start_date:, end_date:)
         Helpers::Utils.hashlist_merge(
+          check_for_late_returns(start_date: start_date, end_date: end_date) +
+            pull_transaction_report(start_date: start_date, end_date: end_date)
+        )
+      end
+
+      # @return [Hash{String => [AchClient::AchResponse]}] List of hashes with
+      # confirmation number as the key, lists of AchResponse objects as values
+      private_class_method def self.pull_transaction_report(start_date:, end_date:)
+        AchClient::ICheckGateway.wrap_request(
+          method: :pull_transaction_report,
+          message: AchClient::ICheckGateway::CompanyInfo.build.to_hash.merge({
+            startDate: start_date,
+            endDate: end_date
+          })
+        ).split("\n").select do |record|
+          check_for_errors(record)
+          # Only the records that start with ICHECK are ACH transactions.
+          # Everything else is other types of transactions such as credit card swipes which are outside
+          # the scope of this library
+          record.start_with?('ICHECK')
+        end.map do |record|
+          # The 4th column is the external_ach_id which becomes the hash key
+          {
+            record.split('|')[3] =>
+              [
+                AchClient::ICheckGateway::ResponseRecordProcessor
+                  .process_response_record(record)
+              ]
+          }
+        end
+      end
+
+      # The pull_transaction_report method returns ACHs by effective entry date, which won't necessarily include
+      #   any late returns that were returned outside the window of pending ACHs.
+      # This uses a separate endpoint which gives back returned ACHs by the return date, which will include late
+      #  returns
+      # @return [Hash{String => [AchClient::AchResponse]}] List of hashes with
+      # confirmation number as the key, lists of AchResponse objects as values
+      private_class_method def self.check_for_late_returns(start_date:, end_date:)
+        (start_date..end_date).map do |date|
           AchClient::ICheckGateway.wrap_request(
-            method: :pull_transaction_report,
+            method: :pull_returned_checks,
             message: AchClient::ICheckGateway::CompanyInfo.build.to_hash.merge({
-              startDate: start_date,
-              endDate: end_date
+              ReturnedDate: date
             })
-          ).split("\n").select do |record|
-            check_for_errors(record)
-            # Ignore credit card swipes if there are any
-            record.start_with?('ICHECK')
-          end.map do |record|
-            {
-              record.split('|')[3] =>
-                [
-                  AchClient::ICheckGateway::ResponseRecordProcessor
-                    .process_response_record(record)
-                ]
-            }
+          ).split("\n").map do |record|
+            if record.include?("|")
+              # Each record returned by the API is a pipe separated list with 2 columns:
+              # Example: external_ach_id|R01\r\n
+              external_ach_id, return_code = record.split('|')
+              {external_ach_id => [AchClient::ReturnedAchResponse.new(
+                amount: nil, # response does not include amount
+                date: date,
+                return_code: AchClient::ReturnCodes.find_by(code: return_code)
+              )]}
+            elsif record.include?(EMPTY_RETURNS_RESPONSE)
+              # Server returns an error message instead of an empty list, so we catch the error message and return our
+              #  own empty response
+              {}
+            else
+              raise "Couldnt process ICheckGateway Late Returns Response: #{record}"
+            end
           end
-        )
+        end.reduce(&:+)
       end
     end
   end

data/lib/ach_client/providers/soap/i_check_gateway/response_record_processor.rb

@@ -10,11 +10,13 @@ module AchClient
       AMOUNT_COLUMN = 15
       # The column index with the record submission date
       DATE_COLUMN = 17
-      # THe string index range within the record status with the return code
+      # The string index range within the record status with the return code
       RETURN_CODE_INDEX = 3..5
 
       ## Transforms ICheckGateway transaction report response records into
-      # AchClient::Response objects
+      # AchClient::Response object
+      # Here is an example record:
+      # ICHECK|N||external_ach_id|abc||||||||BC|012345678|********1234|250.00|D|9/12/2016|05:03:04|C1234-1234||AutoCheck|||abcde|CCD|||\r\ns
       # @param record [String] the | separated record string from ICheckGateway
       # @return [AchClient::AchResponse] our representation of the response
       def self.process_response_record(record)

data/lib/ach_client/version.rb

@@ -1,4 +1,4 @@
 module AchClient
   # Increment this when changes are published
-  VERSION = '2.0.0'
+  VERSION = '3.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ach_client
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Zach Cotter
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-05-12 00:00:00.000000000 Z
+date: 2022-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ach
@@ -28,16 +28,16 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: net-sftp
   requirement: !ruby/object:Gem::Requirement
@@ -248,7 +248,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - zach@zachcotter.com
 executables: []
@@ -256,14 +256,15 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/CODEOWNERS"
 - ".gitignore"
 - ".rubocop.yml"
 - ".ruby-version"
 - ".tool-versions"
 - ".tool-versions-e"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- LICENSE
 - README.md
 - Rakefile
 - ach_client.gemspec
@@ -314,6 +315,7 @@ files:
 - lib/ach_client/providers/soap/ach_works/response_record_processor.rb
 - lib/ach_client/providers/soap/ach_works/transaction_type_transformer.rb
 - lib/ach_client/providers/soap/fake/ach_batch.rb
+- lib/ach_client/providers/soap/fake/ach_status_checker.rb
 - lib/ach_client/providers/soap/fake/ach_transaction.rb
 - lib/ach_client/providers/soap/fake/fake.rb
 - lib/ach_client/providers/soap/i_check_gateway/account_type_transformer.rb
@@ -331,7 +333,7 @@ homepage: https://github.com/ForwardFinancing/ach_client
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -347,9 +349,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.0.3.1
+signing_key:
 specification_version: 4
 summary: Adapter to interact with various ACH service providers
 test_files: []

data/.travis.yml

@@ -1,15 +0,0 @@
-language: ruby
-before_install:
-  - export TZ=US/Eastern
-  - export CODECLIMATE_REPO_TOKEN=1fc324a28beed303e632765cca14487904a23023d85b9127a288f04cc007d28d
-  - export CC_TEST_REPORTER_ID=1fc324a28beed303e632765cca14487904a23023d85b9127a288f04cc007d28d
-  - date
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-script:
-  - bundle exec rake test
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
-notifications:
-  email: false