ach_client 0.7.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a4f5db8a27b5ba348d4a2b98c3219350528ba763
-  data.tar.gz: e067d4721f6225444a0c9d740cabe5b7bc4c2c8f
+SHA256:
+  metadata.gz: 1592b86e14d743c487591e1a205a85ac072cf23a43e27a8dc8e6a7d8dd860acc
+  data.tar.gz: e4ad0a3ae01d345b4dbd8e224fd4d336737d297d82669af08a58d1b858c04dfc
 SHA512:
-  metadata.gz: 3936c72ff9eff2330f3b06d8ead56d03d5c858cbe7ab783d9840f9c4da79751bb7c8c94658551e22da0cfa7a53d2cee7449505c2ea7da52d022f5f046a8b288f
-  data.tar.gz: b207d8ac87d006dcb3c3aebc81107db555583ee88eab300e0c2277a7c8531d613a76316c22ee3d157202ec73f1a9b5155dfb9ee2cbf127f7b335b2b929566074
+  metadata.gz: 9a6cbf086b1b6424fcdd034a4131403c00d5e04bf74a01a86176b6c9ff0d24cc8e40020005b3bb06c194b9dd890999c08d82d2c79cd271e510d73cfe9975f910
+  data.tar.gz: 7130cdd271cecff3efd4297284ccca59d36985eca2868b1df9c3dc2ce1eed6d986b1b633127e025b8bea175387be9a25d5b4eaa1f925be27f847e5c6ff90bf96

data/.ruby-version

@@ -1 +1 @@
-2.4.2
+2.5.0

data/.tool-versions

@@ -1 +1 @@
-ruby 2.4.2
+ruby 2.5.0

data/.tool-versions-e

@@ -0,0 +1 @@
+ruby 2.5.0

data/README.md

@@ -163,7 +163,9 @@ To check statuses:
 ```
 
 Both of these methods return a `Hash` with the `external_ach_id` for ach_transaction as the keys and
-instances of AchClient::AchResponse as values.
+a list of instances of AchClient::AchResponse as values. A polling response may contain
+more than one response record for each `external_ach_id` if that ACH has changed
+statuses more than once within the polling range.
 
 ### Responses
 

data/lib/ach_client/helpers/utils.rb

@@ -0,0 +1,17 @@
+module AchClient
+  class Helpers
+    class Utils
+      # Given a list of hashes where the hashes values are lists, merge the
+      #   list of hashes by appending the two lists when there is a key
+      #   collision
+      # @param hashlist [Array(Hash{String => Array})]
+      def self.hashlist_merge(hashlist)
+        hashlist.reduce do |map, record|
+          map.merge(record) do |_key, left_value, right_value|
+            left_value + right_value
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ach_client/providers/abstract/ach_status_checker.rb

@@ -4,15 +4,15 @@ module AchClient
     # Interface for polling provider for ACH status responses
     class AchStatusChecker
       # Wrapper for a provider's "most recent bucket"
-      # @return [Hash{String => AchClient::AchResponse}] Hash with provider's
-      #   external ACH id as the key, AchResponse objects as values
+      # @return [Hash{String => [AchClient::AchResponse]}] Hash with provider's
+      #   external ACH id as the key, list of AchResponse objects as values
       def self.most_recent
         raise AbstractMethodError
       end
 
       # Wrapper for a providers range response endpoint
-      # @return [Hash{String => AchClient::AchResponse}] Hash with provider's
-      #   external ACH id as the key, AchResponse objects as values
+      # @return [Hash{String => [AchClient::AchResponse]}] Hash with provider's
+      #   external ACH id as the key, list of AchResponse objects as values
       def self.in_range(*)
         raise AbstractMethodError
       end

data/lib/ach_client/providers/sftp/ach_status_checker.rb

@@ -6,8 +6,9 @@ module AchClient
       ##
       # Gets the status of ach transactions since the last time we ran this
       # method
-      # @return [Hash{String => AchClient::AchResponse}] Hash with
-      #   individual_id_number values as keys, AchResponse objects as values
+      # @return [Hash{String => [AchClient::AchResponse]}] Hash with
+      #   individual_id_number values as keys, list of AchResponse objects
+      #   as values
       def self.most_recent
         process_files(most_recent_files)
       end
@@ -16,8 +17,9 @@ module AchClient
       # Gets the status of ach transactions between the given dates
       # @param start_date [String] lower bound of date ranged status query
       # @param end_date [String] upper bound of date ranged status query
-      # @return [Hash{String => AchClient::AchResponse}] Hash with
-      #   individual_id_number values as keys, AchResponse objects as values
+      # @return [Hash{String => [AchClient::AchResponse]}] Hash with
+      #   individual_id_number values as keys, list of AchResponse objects as
+      #   values
       def self.in_range(start_date:, end_date:)
         in_range = {}
         self.parent.with_sftp_connection do |connection|
@@ -33,14 +35,16 @@ module AchClient
       end
 
       private_class_method def self.process_files(files)
-        (files || []).reduce({}) do |acc, entry|
-          ACH::ACHFile.new(entry.last).batches.map do |batch|
-            batch.entries.map do |ach|
-              # return trace ==> response
-              { ach.individual_id_number => process_ach(batch, ach) }
-            end.reduce({}, &:merge)
-          end.reduce({}, &:merge).merge(acc)
-        end
+        Helpers::Utils.hashlist_merge(
+          (files || []).reduce([]) do |acc, entry|
+            ACH::ACHFile.new(entry.last).batches.map do |batch|
+              batch.entries.map do |ach|
+                # return trace ==> response
+                { ach.individual_id_number => [process_ach(batch, ach)] }
+              end
+            end.reduce([], &:+) + acc
+          end
+        )
       end
 
       private_class_method def self.process_ach(batch, ach)

data/lib/ach_client/providers/soap/ach_works/ach_status_checker.rb

@@ -49,21 +49,25 @@ module AchClient
         if response[:total_num_records] == '0'
           []
         else
-          response[:ach_return_records][:ach_return_record].select do |record|
-            # Exclude records with no front end trace
-            # They are probably 9BNK response codes, not actual transactions
-            # 9BNK is when AchWorks gives us an aggregate record, containing
-            #   the total debit/credit to your actual bank account.
-            # We don't care about those here.
-            record[:front_end_trace].present?
-          end.map do |record|
-            {
-              # Strips the first characther because it is always the added Z
-              record[:front_end_trace][1..-1] =>
-              AchClient::AchWorks::ResponseRecordProcessor
-                .process_response_record(record)
-            }
-          end.reduce(&:merge)
+          Helpers::Utils.hashlist_merge(
+            response[:ach_return_records][:ach_return_record].select do |record|
+              # Exclude records with no front end trace
+              # They are probably 9BNK response codes, not actual transactions
+              # 9BNK is when AchWorks gives us an aggregate record, containing
+              #   the total debit/credit to your actual bank account.
+              # We don't care about those here.
+              record[:front_end_trace].present?
+            end.map do |record|
+              {
+                # Strips the first characther because it is always the added Z
+                record[:front_end_trace][1..-1] =>
+                  [
+                    AchClient::AchWorks::ResponseRecordProcessor
+                    .process_response_record(record)
+                  ]
+              }
+            end
+          )
         end
       end
 

data/lib/ach_client/providers/soap/i_check_gateway/ach_status_checker.rb

@@ -35,26 +35,30 @@ module AchClient
       end
 
       # Wrapper for the range response endpoint
-      # @return [Hash{String => AchClient::AchResponse}] Hash with confirmation
-      # number as the key, AchResponse objects as values
+      # @return [Hash{String => [AchClient::AchResponse]}] Hash with
+      # confirmation number as the key, lists of AchResponse objects as values
       def self.in_range(start_date:, end_date:)
-        AchClient::ICheckGateway.wrap_request(
-          method: :pull_transaction_report,
-          message: AchClient::ICheckGateway::CompanyInfo.build.to_hash.merge({
-            startDate: start_date,
-            endDate: end_date
-          })
-        ).split("\n").select do |record|
-          check_for_errors(record)
-          # Ignore credit card swipes if there are any
-          record.start_with?('ICHECK')
-        end.map do |record|
-          {
-            record.split('|')[3] =>
-              AchClient::ICheckGateway::ResponseRecordProcessor
-                .process_response_record(record)
-          }
-        end.reduce(&:merge)
+        Helpers::Utils.hashlist_merge(
+          AchClient::ICheckGateway.wrap_request(
+            method: :pull_transaction_report,
+            message: AchClient::ICheckGateway::CompanyInfo.build.to_hash.merge({
+              startDate: start_date,
+              endDate: end_date
+            })
+          ).split("\n").select do |record|
+            check_for_errors(record)
+            # Ignore credit card swipes if there are any
+            record.start_with?('ICHECK')
+          end.map do |record|
+            {
+              record.split('|')[3] =>
+                [
+                  AchClient::ICheckGateway::ResponseRecordProcessor
+                    .process_response_record(record)
+                ]
+            }
+          end
+        )
       end
     end
   end

data/lib/ach_client/version.rb

@@ -1,4 +1,4 @@
 module AchClient
   # Increment this when changes are published
-  VERSION = '0.7.0'
+  VERSION = '1.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ach_client
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Zach Cotter
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-07 00:00:00.000000000 Z
+date: 2018-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ach
@@ -274,6 +274,7 @@ files:
 - ".rubocop.yml"
 - ".ruby-version"
 - ".tool-versions"
+- ".tool-versions-e"
 - ".travis.yml"
 - Gemfile
 - README.md
@@ -286,6 +287,7 @@ files:
 - lib/ach_client/abstract/abstract_method_error.rb
 - lib/ach_client/abstract/invalid_ach_transaction_error.rb
 - lib/ach_client/helpers/dollars_to_cents.rb
+- lib/ach_client/helpers/utils.rb
 - lib/ach_client/logging/log_provider_job.rb
 - lib/ach_client/logging/log_providers/log_provider.rb
 - lib/ach_client/logging/log_providers/null_log_provider.rb
@@ -355,7 +357,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Adapter to interact with various ACH service providers