ach_client 0.6.8 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2d11d4f11d7798de68161c055bd3813b48c8c825
-  data.tar.gz: f16abf9d6efe1cf2b98e82645658e178a698309d
+  metadata.gz: a4f5db8a27b5ba348d4a2b98c3219350528ba763
+  data.tar.gz: e067d4721f6225444a0c9d740cabe5b7bc4c2c8f
 SHA512:
-  metadata.gz: 36dfae94d6242fafd729fc5d0a21cf9ff23d130ceb303f14ca0b1d9181d0c72630f5cfc32af3df290b9f5c4128c47190775d016af1977d7536f4ec0a8fde1d8d
-  data.tar.gz: d0ebf4105244973ee008d7441a10e2e74881d701afce322e6fc05e0a9685cc7393e66e01dd5a01c383533fbe172469fafa866608dc7994e9f828e69b2f859548
+  metadata.gz: 3936c72ff9eff2330f3b06d8ead56d03d5c858cbe7ab783d9840f9c4da79751bb7c8c94658551e22da0cfa7a53d2cee7449505c2ea7da52d022f5f046a8b288f
+  data.tar.gz: b207d8ac87d006dcb3c3aebc81107db555583ee88eab300e0c2277a7c8531d613a76316c22ee3d157202ec73f1a9b5155dfb9ee2cbf127f7b335b2b929566074

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+2.4.2

data/.tool-versions

@@ -0,0 +1 @@
+ruby 2.4.2

data/ach_client.gemspec

@@ -55,4 +55,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'
   spec.add_development_dependency 'yard'
+  spec.add_development_dependency 'bundler-audit'
 end

data/lib/ach_client/abstract/invalid_ach_transaction_error.rb

@@ -0,0 +1,3 @@
+# To be raised when an ACH transaction can not be sent because it is invalid
+class InvalidAchTransactionError < RuntimeError
+end

data/lib/ach_client/providers/abstract/ach_batch.rb

@@ -16,6 +16,18 @@ module AchClient
       # @return [Array<String>] Identifiers to use to poll for result of batch
       # processing later on.
       def send_batch
+        if @ach_transactions.all?(&:sendable?)
+          do_send_batch
+        else
+          raise InvalidAchTransactionError
+        end
+      end
+
+      # Implementation of sending the ACH batch to the provider, to be
+      #   implemented by the subclass
+      # @return [Array<String>] Identifiers to use to poll for result of batch
+      # processing later on.
+      def do_send_batch
         raise AbstractMethodError
       end
     end

data/lib/ach_client/providers/abstract/ach_transaction.rb

@@ -62,9 +62,27 @@ module AchClient
         transaction_type == AchClient::TransactionTypes::Credit
       end
 
+      # Check if the transaction is sendable, and if so, send it according
+      #   to the subclass implementation
       def send
+        if sendable?
+          do_send
+        else
+          raise InvalidAchTransactionError
+        end
+      end
+
+      # The implementation of sending the transaction, as implemented by the
+      #   subclass
+      def do_send
         raise AbstractMethodError
       end
+
+      # Prevent sending of invalid transactions, such as those where the
+      #   effective entry date is in the past
+      def sendable?
+        effective_entry_date&.future? || effective_entry_date&.today?
+      end
     end
   end
 end

data/lib/ach_client/providers/sftp/ach_batch.rb

@@ -17,7 +17,7 @@ module AchClient
 
       # Sends the batch to SFTP provider
       # @return [Array<String>]
-      def send_batch
+      def do_send_batch
         self.class.parent.write_remote_file(
           file_path: File.join(
             self.class.parent.outgoing_path,

data/lib/ach_client/providers/sftp/ach_transaction.rb

@@ -4,7 +4,7 @@ module AchClient
     class AchTransaction < Abstract::AchTransaction
 
       # Most SFTP providers only support batch transactions
-      def send
+      def do_send
         raise 'NACHA/SFTP providers do not support individual transactions'
       end
 

data/lib/ach_client/providers/soap/ach_works/ach_batch.rb

@@ -10,7 +10,7 @@ module AchClient
       # gives us. We can use that to track the batch processing later on.
       # If it fails, an exception will be thrown.
       # @return [Array<String>] the external_ach_id's for each transaction
-      def send_batch
+      def do_send_batch
         AchClient::AchWorks.wrap_request(
           method: :send_ach_trans_batch,
           message: self.to_hash,

data/lib/ach_client/providers/soap/ach_works/ach_transaction.rb

@@ -18,7 +18,7 @@ module AchClient
 
       # Send this transaction individually to AchWorks
       # @return [String] the front end trace
-      def send
+      def do_send
         AchClient::AchWorks.wrap_request(
           method: :send_ach_trans,
           message: AchClient::AchWorks::CompanyInfo.build.to_hash.merge({

data/lib/ach_client/providers/soap/i_check_gateway/ach_batch.rb

@@ -4,7 +4,7 @@ module AchClient
     class AchBatch < Abstract::AchBatch
 
       # ICheckGateway does not support ACH batching
-      def send_batch
+      def do_send_batch
         raise 'ICheckGateway does not support ACH batching'
       end
     end

data/lib/ach_client/providers/soap/i_check_gateway/ach_status_checker.rb

@@ -11,7 +11,7 @@ module AchClient
         # The date range can't be wider than 15 days
         "ACCESS DENIED: Date Range Exceeds 15 Days",
         # Because so far they all contain ACCESS_DENIED:
-        "ACCESS_DENIED"
+        "ACCESS DENIED"
       ]
 
       ##

data/lib/ach_client/providers/soap/i_check_gateway/ach_transaction.rb

@@ -9,7 +9,7 @@ module AchClient
       # Raises an exception with as much info as possible if something goes
       # wrong
       # @return [String] a string returned by ICheckGateway - external_ach_id
-      def send
+      def do_send
         # The response comes back as a | separated list of field values with
         #   no header field/keys. It seems that the first column will contain
         #   'APPROVED' if the request was successful. The 8th column is the

data/lib/ach_client/version.rb

@@ -1,4 +1,4 @@
 module AchClient
   # Increment this when changes are published
-  VERSION = '0.6.8'
+  VERSION = '0.7.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ach_client
 version: !ruby/object:Gem::Version
-  version: 0.6.8
+  version: 0.7.0
 platform: ruby
 authors:
 - Zach Cotter
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-19 00:00:00.000000000 Z
+date: 2017-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ach
@@ -248,6 +248,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler-audit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - zach@zachcotter.com
@@ -259,6 +273,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".ruby-version"
+- ".tool-versions"
 - ".travis.yml"
 - Gemfile
 - README.md
@@ -269,6 +284,7 @@ files:
 - config/return_codes.yml
 - lib/ach_client.rb
 - lib/ach_client/abstract/abstract_method_error.rb
+- lib/ach_client/abstract/invalid_ach_transaction_error.rb
 - lib/ach_client/helpers/dollars_to_cents.rb
 - lib/ach_client/logging/log_provider_job.rb
 - lib/ach_client/logging/log_providers/log_provider.rb
@@ -339,7 +355,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Adapter to interact with various ACH service providers