ach 0.5.16 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6f2cdcb923998c4fc08e11bd9efeb320e349187e657ab7b29ff79c325447510
-  data.tar.gz: 951a8528fb40feebb2ed689649b86cce1b25623a51fab780c0c6f994bfa8ffee
+  metadata.gz: 2675fc4115782f0d7fca900b070cebd739e9ceceee0c32d197b0ecd24e56f985
+  data.tar.gz: 3cb59f5617acdad57d7272124ca83999313c7675d48239a3cc0e510dcb095130
 SHA512:
-  metadata.gz: 1bbc5ff04f7a5ee0196495e00c8a31077dc0a2ad1439953ff6c5c7971d2bb256ad03321261c187a8364c96ddfe6db0983104b07f10266ada86ad24699c09dab2
-  data.tar.gz: 6d8158a6e81466d7d6017e4d017a948a898dfed6ed96880ff5b6be19cc4496890bd585da757d800dd921287e4334889d942d67390f7d020ebbefda9e2c69cbc8
+  metadata.gz: 8426fe5b8944fb11d7ca51bbc631a14f64e9e5dbd7ca668833905ac0f05b14c8f91248b4f43ff0c8245f705ec0b07e8588cb168ba82bb7160a880965414bbdfa
+  data.tar.gz: 5b403f8700e4ecc92f41f619f960455df6d88538f989ba3a545f28ff98632506dfeb76753622ff4d7ffbeecba71d91783110cb555cb4021097be9a71d2e9fdfd

data/README.md

@@ -1,18 +1,20 @@
-#ACH
+# ACH
+
+Note: I'm no longer actively maintaining this gem, and would be happy to turn it over to someone else. Let me know if you'd like to take over.
 
 [![Build Status](https://travis-ci.org/jm81/ach.svg?branch=master)](https://travis-ci.org/jm81/ach)
 
 ach is a Ruby helper for builder ACH files. In particular, it helps with field
 order and alignment, and adds padding lines to end of file.
 
-**This library has only been used in one production application and for very
+**This library has only been used in two production applications and for very
 limited purposes. Please test thoroughly before using in a production
 environment.**
 
 See [ACH::Builder](http://search.cpan.org/~tkeefer/ACH-Builder-0.03/lib/ACH/Builder.pm)
 for a similar Perl library
 
-##Example
+## Example
 
 You should consult a copy of the [ACH Rules](http://www.nacha.org) for details
 on individual fields. You can probably obtain a copy from your bank.
@@ -30,6 +32,11 @@ fh.immediate_destination = '000000000'
 fh.immediate_destination_name = 'BANK NAME'
 fh.immediate_origin = '000000000'
 fh.immediate_origin_name = 'BANK NAME'
+# Optional - This value is used in the File Creation Date/Time attributes - if excluded will default to Time.now
+# Note that you may wish to modify the time zone here if your environment has a different time zone than the banks
+# For example if your server is in UTC and the bank's is in US/Eastern, any files sent after 8pm Eastern/Midnight UTC
+#   would have a File Creation Date of the next day from the bank's perspective
+fh.transmission_datetime = Time.now
 
 # Batch
 batch = ACH::Batch.new
@@ -38,7 +45,7 @@ bh.company_name = 'Company Name'
 bh.company_identification = '123456789' # Use 10 characters if you're not using an EIN
 bh.standard_entry_class_code = 'PPD'
 bh.company_entry_description = 'DESCRIPTION'
-bh.company_descriptive_date = Date.today
+bh.company_descriptive_date = Date.today # Or string with 'SDHHMM' for same day ACH
 bh.effective_entry_date = ACH::NextFederalReserveEffectiveDate.new(Date.today).result
 bh.originating_dfi_identification = '00000000'
 ach.batches << batch
@@ -73,6 +80,6 @@ ach.batches.first.entries.first.addenda.first.payment_data
 
 **Note:** When adding an amount to your ach file, it needs to be in cents. So you'll want to multiply any dollar amounts by 100
 
-##Copyright
+## Copyright
 
 Copyright (c) 2008-2009 Jared E Morgan, released under the MIT license

data/lib/ach/ach_file.rb

@@ -24,7 +24,7 @@ module ACH
 
 
     # @param eol [String] Line ending, default to CRLF
-    def to_s eol = "\r\n"
+    def to_s eol = ACH.eol
       records = []
       records << @header
 
@@ -55,10 +55,10 @@ module ACH
         @control.entry_hash += batch.control.entry_hash
       end
 
-      records.collect { |r| r.to_ach }.join(eol) + eol
+      records.collect { |r| r.to_ach(eol: eol) }.join(eol) + eol
     end
 
-    def report
+    def report eol: ACH.eol
       to_s # To ensure correct records
       lines = []
 
@@ -74,7 +74,7 @@ module ACH
       lines << left_justify("Credit Total: ", 25) +
           sprintf("% 7d.%02d", @control.credit_total / 100, @control.credit_total % 100)
 
-      lines.join("\r\n")
+      lines.join(eol)
     end
 
     def parse_fixed data
@@ -105,6 +105,7 @@ module ACH
           batch = ACH::Batch.new
           bh = batch.header
           bh.company_name                   = line[4..19].strip
+          bh.company_discretionary_data     = line[20..39].strip
           bh.company_identification         = line[40..49].gsub(/\A1/, '')
 
           # Does not try to guess if company identification is an EIN
@@ -113,7 +114,7 @@ module ACH
           bh.full_company_identification    = line[40..49]
           bh.standard_entry_class_code      = line[50..52].strip
           bh.company_entry_description      = line[53..62].strip
-          bh.company_descriptive_date       = Date.parse(line[63..68]) rescue nil # this can be various formats
+          bh.company_descriptive_date       = parse_descriptive_date(line[63..68].strip)
           bh.effective_entry_date           = Date.parse(line[69..74])
           bh.originating_dfi_identification = line[79..86].strip
         when '6'
@@ -145,7 +146,8 @@ module ACH
         when '8'
           # skip
         when '9'
-          # skip
+          @control = Records::FileControl.new
+          @control.filler = line[55..93]
         else
           raise UnrecognizedTypeCode, "Didn't recognize type code #{type} for this line:\n#{line}"
         end
@@ -154,5 +156,19 @@ module ACH
       self.batches << batch unless batch.nil?
       to_s
     end
+
+    def parse_descriptive_date(date_string)
+      return if date_string.empty?
+
+      date_time = date_string.match(/^SD(\d{2})(\d{2})$/) do
+        same_day_hour, same_day_minute = _1.captures.map(&:to_f)
+
+        Date.today.to_datetime + (same_day_hour + same_day_minute/60) / 24
+      end
+
+      date_time || Data.parse(date_string)
+    rescue
+      date_string
+    end
   end
 end

data/lib/ach/batch.rb

@@ -58,9 +58,9 @@ module ACH
 
       [@header] + @entries + @addendas + [@control]
     end
-    
+
     private
-    
+
     def last_entry
       @last_entry ||= @entries.last
     end

data/lib/ach/records/entry_detail.rb

@@ -54,7 +54,7 @@ module ACH::Records
       return !self.addenda.empty?
     end
 
-    def to_ach
+    def to_ach eol: ACH.eol
       self.addenda_record_indicator = (self.addenda.empty? ? 0 : 1) if self.respond_to?(:addenda_record_indicator)
       self.number_of_addenda_records = self.addenda.length if self.respond_to?(:number_of_addenda_records)
 
@@ -62,7 +62,7 @@ module ACH::Records
 
       self.addenda.each {|a|
         a.entry_detail_sequence_number = self.trace_number
-        ach_string << "\r\n" + a.to_ach
+        ach_string << eol + a.to_ach
       }
       return ach_string
     end

data/lib/ach/records/file_control.rb

@@ -1,17 +1,18 @@
 module ACH::Records
   class FileControl < Record
     @fields = []
-    
+
     const_field :record_type, '9'
     # Many of the fields are calculated in ACHFile.to_ach
     field :batch_count, Integer, lambda { |f| sprintf('%06d', f)}
     field :block_count, Integer, lambda { |f| sprintf('%06d', f)}
     field :entry_count, Integer, lambda { |f| sprintf('%08d', f)}
     field :entry_hash, Integer, lambda { |f| sprintf('%010d', f % (10 ** 10))}
-    
+
     field :debit_total, Integer, lambda { |f| sprintf('%012d', f)}
     field :credit_total, Integer, lambda { |f| sprintf('%012d', f)}
-    const_field :reserved, (' ' * 39)
+
+    field :filler, String, lambda { |f| left_justify(f, 39)}, ' '
   end
 end
 

data/lib/ach/records/record.rb

@@ -13,7 +13,7 @@ module ACH
 
       attr_accessor :case_sensitive
 
-      def to_ach
+      def to_ach eol: nil
         to_ach = self.class.fields.collect { |f| send("#{f}_to_ach") }.join('')
         case_sensitive ? to_ach : to_ach.upcase
       end

data/lib/ach/string_formatting_helper.rb

@@ -3,7 +3,10 @@ module ACH
     # Passing in SD to the date signifies same-day to banks. This is used for the company_descriptive_date
     def self.stringify_with_same_day(f)
       return f.upcase if f.to_s.upcase.match(/^SD\d+$/)
-      f.strftime('%y%m%d')
+
+      Date.strptime(f, '%y%m%d')
+    rescue
+      f
     end
   end
-end
+end

data/lib/ach/version.rb

@@ -1,3 +1,3 @@
 module ACH
-  VERSION = '0.5.16'.freeze
+  VERSION = '0.6.1'.freeze
 end

data/lib/ach.rb

@@ -20,6 +20,12 @@ module ACH
     225, # ACH Debits Only
     280  # ACH Automated Accounting Advices
   ]
+
+  DEFAULT_EOL = "\r\n"
+
+  def self.eol
+    DEFAULT_EOL
+  end
 end
 
 require 'time'

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: ach
 version: !ruby/object:Gem::Version
-  version: 0.5.16
+  version: 0.6.1
 platform: ruby
 authors:
 - Jared Morgan
 - Josh Puetz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-10 00:00:00.000000000 Z
+date: 2023-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -110,7 +110,7 @@ files:
 homepage: https://github.com/jm81/ach
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -125,8 +125,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: Helper for building ACH files
 test_files: []