acfs 0.50.0 → 1.0.0.dev.1.b297

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA256:
-  metadata.gz: 5f6205aca10d63d37898eecce39e239605fc0a4165d17a9ad994ead94e0037dd
-  data.tar.gz: e1dac804253b61cabd8d5e9410784268c689771fedb9bdcad8c99a67e0b946ef
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    OTZhZGMyZGMzM2UzYjJmODU1MDU3NGU1MmVkYTQ5MTQxZDUwYTI5ZA==
+  data.tar.gz: !binary |-
+    NGZhODhiOTY5MTc5M2QxNDMxYjFmYjA3MjVmMTA4ZGM0OGZjZWJkYw==
 SHA512:
-  metadata.gz: 150fd36e55507f600437fe65dc3d853379799b6f5afc30c0aaa9644e36d4e025fa3ced557569f6af9e8cbbb8e484ede41281cefac7ceaecda3d6957647e5b76b
-  data.tar.gz: 206228583c974b3ef735d1cfb524938595856bd8741e481c80b331da1779839c4ab31073f34d615561d68f53955ea5f58c501c2d5208039522e5296233d002aa
+  metadata.gz: !binary |-
+    Y2JkMDFjOTE0NDhjOGJkNDY1ZjIwMjgwMDg1ZmY2ZDRmNzc5NTk2MDhlZDA0
+    MDU5OWJhY2I1MDUyNmQ0MjBjYWZmZjcwZDEwNTIwNWJlMmI2YjZjOWU1YTJk
+    ODU3YzQ3NjFkZjlkZDA3YTlhOWE1MmZlYjk4M2U3MTM3ZjBjZmI=
+  data.tar.gz: !binary |-
+    NjY3YWI3MGYzMGQxNTljZTNkYWQzMjYxMjcxYTlhNTcyODFmNDJhZjg5Yzk2
+    NjIxZmQyM2MwYTZkNTdmYWM1NTdiN2JkZjYwMzg5ZTYwMzIyODk3MzdiYzli
+    MzI0MDJjMDgzMDcwOWJjZTI2YWIyOGFhMWQ3ZTIxNTU3M2QyZWU=

data/CHANGELOG.md

@@ -1,85 +1,5 @@
 # Changelog
 
-## 1.2.0
-
-* Add Rails 5.2 compatibility
-
-## 1.1.1
-
-* `each_item`: Pass collection to provided block (#40)
-
-## 1.1.0
-
-* Add support for Rails 5.1
-
-## 1.0.1
-
-* Fix deprecation warnings when using ::Mime
-
-## 1.0.0
-
-* Switch to first non-development major as it's long time used in production.
-* Fix NewRelic RPM inference with middleware stack inherited from `ActionDispatch::MiddlewareStack`.
-
-## 0.48.0
-
-* Remove #attribute_types broke since f7e4109 (Sep 2013, v0.23)
-* Fix attribute inheritance on subclassing broken since commit 7cf1d11 (Apr 2014, v0.43)
-
-## 0.47.0
-
-* Change blank value handling of dict and list type (0a12ef1)
-
-## 0.46.0
-
-* Rework types system (#39)
-
-## 0.45.0
-
-* Fetching multiple records (`find(ary)`) is stable now, but untested (#38)
-* Middleware stack is build on ActionDispatch::MiddlewareStack now
-* Deprecate legacy middleware names (xyEncoder, xyDecoder)
-
-## 0.44.0
-
-* Add option to configure adapter creation and pass option to typhoeus adapter e.g.
-  limiting concurrency.
-
-## 0.43.2
-
-* add `total_count` for paginated collections
-
-## 0.43.1
-
-* Fix `:with` condition matching on stubs
-
-## 0.43.0
-
-* Remove `Acfs::Model` (inherit from `Acfs::Resource`)
-* Stub does only a partial match of `:with` attributes now
-* Allow blocks as stub `:return`s
-
-## 0.42.0
-
-* Add simple dict attribute type
-
-## 0.40.0
-
-* Change `Resource#persisted?` to return true if it is not new
-
-## 0.39.1
-
-* Fix automatic path parameter handling for #destroy
-
-## 0.39.0
-
-* Add new event acfs.operation.before_process
-
-## 0.38.0
-
-* Allow middlewares to abort request processing
-* Allow middlewares to receive the request operation object (via the request)
-
 ## 0.37.0
 
 * Add Acfs.on

data/README.md

@@ -1,11 +1,11 @@
 # Acfs - *API client for services*
 
-[![Gem Version](https://badge.fury.io/rb/acfs.svg)](http://badge.fury.io/rb/acfs)
-[![Build Status](http://img.shields.io/travis/jgraichen/acfs/master.svg)](https://travis-ci.org/jgraichen/acfs)
-[![Coverage Status](http://img.shields.io/coveralls/jgraichen/acfs/master.svg)](https://coveralls.io/r/jgraichen/acfs)
-[![Code Climate](http://img.shields.io/codeclimate/github/jgraichen/acfs.svg)](https://codeclimate.com/github/jgraichen/acfs)
-[![Dependency Status](http://img.shields.io/gemnasium/jgraichen/acfs.svg)](https://gemnasium.com/jgraichen/acfs)
-[![RubyDoc Documentation](http://img.shields.io/badge/rubydoc-here-blue.svg)](http://rubydoc.info/github/jgraichen/acfs/master/frames)
+[![Gem Version](https://badge.fury.io/rb/acfs.png)](http://badge.fury.io/rb/acfs)
+[![Build Status](https://travis-ci.org/jgraichen/acfs.png?branch=master)](https://travis-ci.org/jgraichen/acfs)
+[![Coverage Status](https://coveralls.io/repos/jgraichen/acfs/badge.png?branch=master)](https://coveralls.io/r/jgraichen/acfs)
+[![Code Climate](https://codeclimate.com/github/jgraichen/acfs.png)](https://codeclimate.com/github/jgraichen/acfs)
+[![Dependency Status](https://gemnasium.com/jgraichen/acfs.png)](https://gemnasium.com/jgraichen/acfs)
+[![RubyDoc Documentation](http://b.repl.ca/v1/rubydoc-here-blue.png)](http://rubydoc.info/github/jgraichen/acfs/master/frames)
 
 Acfs is a library to develop API client libraries for single services within a larger service oriented application.
 
@@ -250,8 +250,8 @@ it 'should find user number one' do
   expect(user.name).to be == 'John Smith'
   expect(user.age).to be == 32
 
-  expect(@stub).to be_called
-  expect(@stub).to_not be_called 5.times
+  expect(@stub).to has_called
+  expect(@stub).to_not have_called 5.times
 end
 
 it 'should not find user number two' do
@@ -313,6 +313,7 @@ Read [official guide][2] to see to to subscribe.
         * Reusing model definitions for generating responses?
         * Rails responders providing REST operations with integrated ETag,
           Modified Headers, conflict detection, ...
+    * Pagination? Filtering? (If service API provides such features.)
 * Documentation
 
 ## Contributing

data/acfs.gemspec

@@ -8,23 +8,23 @@ Gem::Specification.new do |spec|
   spec.version       = Acfs::VERSION
   spec.authors       = ['Jan Graichen']
   spec.email         = %w(jg@altimos.de)
-  spec.description   = 'API Client For Services'
-  spec.summary       = 'An abstract API base client for service oriented application.'
+  spec.description   = %q{API Client For Services}
+  spec.summary       = %q{An abstract API base client for service oriented application.}
   spec.homepage      = 'https://github.com/jgraichen/acfs'
   spec.license       = 'MIT'
 
   spec.files         = Dir['**/*'].grep(%r{^((bin|lib|test|spec|features)/|.*\.gemspec|.*LICENSE.*|.*README.*|.*CHANGELOG.*)})
-  spec.executables   = spec.files.grep(%r{^bin/}) {|f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = %w(lib)
 
-  spec.add_runtime_dependency 'activesupport', '>= 4.2'
-  spec.add_runtime_dependency 'activemodel', '>= 4.2'
-  spec.add_runtime_dependency 'actionpack', '>= 4.2'
+  spec.add_runtime_dependency 'activesupport', '>= 3.1'
+  spec.add_runtime_dependency 'activemodel', '>= 3.1'
+  spec.add_runtime_dependency 'actionpack', '>= 3.1'
   spec.add_runtime_dependency 'multi_json'
 
   # Bundle update w/o version resolves to 0.3.3 ...
-  spec.add_runtime_dependency 'typhoeus', '~> 1.0'
+  spec.add_runtime_dependency 'typhoeus', '>= 0.6.5'
 
   spec.add_runtime_dependency 'rack'
 

data/lib/acfs.rb

@@ -30,16 +30,13 @@ module Acfs
   module Middleware
     extend ActiveSupport::Autoload
     require 'acfs/middleware/base'
-    require 'acfs/middleware/serializer'
 
     autoload :Print
     autoload :Logger
-    autoload :JSON
-    autoload :JsonDecoder, 'acfs/middleware/json'
-    autoload :JsonEncoder, 'acfs/middleware/json'
-    autoload :MessagePack, 'acfs/middleware/msgpack'
-    autoload :MessagePackDecoder, 'acfs/middleware/msgpack'
-    autoload :MessagePackEncoder, 'acfs/middleware/msgpack'
+    autoload :JsonDecoder
+    autoload :MessagePackDecoder, 'acfs/middleware/msgpack_decoder'
+    autoload :JsonEncoder
+    autoload :MessagePackEncoder, 'acfs/middleware/msgpack_encoder'
   end
 
   module Adapter
@@ -47,3 +44,4 @@ module Acfs
     require 'acfs/adapter/typhoeus'
   end
 end
+

data/lib/acfs/adapter/base.rb

@@ -1,8 +1,10 @@
 module Acfs::Adapter
+
   # Base adapter handling operation queuing
   # and processing.
   #
   class Base
+
     # Start processing queued requests.
     #
     def start

data/lib/acfs/adapter/typhoeus.rb

@@ -2,12 +2,10 @@ require 'typhoeus'
 
 module Acfs
   module Adapter
+
     # Adapter for Typhoeus.
     #
     class Typhoeus < Base
-      def initialize(**kwargs)
-        @options = kwargs
-      end
 
       def start
         hydra.run
@@ -16,7 +14,9 @@ module Acfs
         raise
       end
 
-      delegate :abort, to: :hydra
+      def abort
+        hydra.abort
+      end
 
       def run(request)
         convert_request(request).run
@@ -26,21 +26,17 @@ module Acfs
         hydra.queue convert_request request
       end
 
-      protected
-
+    protected
       def hydra
-        @hydra ||= ::Typhoeus::Hydra.new(**@options)
+        @hydra ||= ::Typhoeus::Hydra.new
       end
 
       def convert_request(req)
         request = ::Typhoeus::Request.new req.url,
-          method: req.method,
-          params: req.params,
-          headers: req.headers.merge(
-            'Expect'            => '',
-            'Transfer-Encoding' => ''
-          ),
-          body: req.body
+                                          method: req.method,
+                                          params: req.params,
+                                          headers: req.headers,
+                                          body: req.body
 
         request.on_complete do |response|
           req.complete! convert_response(req, response)
@@ -51,9 +47,9 @@ module Acfs
 
       def convert_response(request, response)
         Acfs::Response.new request,
-          status: response.code,
-          headers: response.headers,
-          body: response.body
+                           status: response.code,
+                           headers: response.headers,
+                           body: response.body
       end
     end
   end

data/lib/acfs/collections/paginatable.rb

@@ -1,14 +1,15 @@
 module Acfs::Collections
+
   #
   module Paginatable
     extend ActiveSupport::Concern
 
     included do
-      def self.operation(_action, opts = {}, &_block)
+      def self.operation(action, opts = {}, &block)
         opts[:url]
       end
 
-      attr_reader :total_pages, :current_page, :total_count
+      attr_reader :total_pages, :current_page
     end
 
     def process_response(response)
@@ -33,9 +34,12 @@ module Acfs::Collections
     end
 
     def page(rel, &block)
-      return unless relations[rel]
-
-      @resource_class.all nil, url: relations[rel], &block
+      if relations[rel]
+        @resource_class.all nil, url: relations[rel], &block
+      else
+        # raise ArgumentError.new "No relative page `#{rel}'."
+        nil
+      end
     end
 
     private
@@ -49,17 +53,13 @@ module Acfs::Collections
         @total_pages = Integer(headers['X-Total-Pages'])
       end
 
-      if headers['X-Total-Count']
-        @total_count = Integer(headers['X-Total-Count'])
-      end
-
       setup_links headers['Link'] if headers['Link']
     end
 
     def setup_links(links)
       links.split(/,\s+/).each do |link|
         if link =~ /^\s*<([^>]+)>.*\s+rel="([\w_-]+)".*$/
-          relations[Regexp.last_match[2]] = Regexp.last_match[1]
+          relations[$2] = $1
         end
       end
     end

data/lib/acfs/configuration.rb

@@ -2,11 +2,11 @@ require 'uri'
 require 'yaml'
 
 module Acfs
+
   # Acfs configuration is used to locate services and get their base URLs.
   #
   class Configuration
     attr_reader :locations
-    attr_accessor :adapter
 
     # @api private
     def initialize
@@ -28,7 +28,7 @@ module Acfs
       if block.arity > 0
         block.call self
       else
-        instance_eval(&block)
+        instance_eval &block
       end
     end
 
@@ -64,10 +64,10 @@ module Acfs
     # @return [undefined]
     #
     def load(filename)
-      config = YAML.load File.read filename
+      config = YAML::load File.read filename
       env    = ENV['RACK_ENV'] || ENV['RAILS_ENV'] || 'development'
 
-      config = config[env] if config.key? env
+      config = config[env] if config.has_key? env
       config.each do |key, value|
         case key
           when 'services' then load_services value
@@ -88,6 +88,7 @@ module Acfs
     end
 
     class << self
+
       # @api private
       #
       # Return current configuration object.

data/lib/acfs/errors.rb

@@ -1,4 +1,5 @@
 module Acfs
+
   # Acfs base error.
   #
   class Error < StandardError
@@ -22,20 +23,20 @@ module Acfs
         message << ": #{response.code}"
         if response.data
           message << "\n  with content:\n    "
-          message << response.data.map {|k, v| "#{k.inspect}: #{v.inspect}" }.join("\n    ")
+          message << response.data.map{|k,v| "#{k.inspect}: #{v.inspect}"}.join("\n    ")
         end
         if response.headers.any?
           message << "\n  with headers:\n    "
-          message << response.headers.map {|k, v| "#{k}: #{v}" }.join("\n    ")
+          message << response.headers.map{|k,v| "#{k}: #{v}"}.join("\n    ")
         end
         message << "\nbased on request: #{response.request.method.upcase} #{response.request.url} #{response.request.format}"
         if response.request.data
           message << "\n  with content:\n    "
-          message << response.request.data.map {|k, v| "#{k.inspect}: #{v.inspect}" }.join("\n    ")
+          message << response.request.data.map{|k,v| "#{k.inspect}: #{v.inspect}"}.join("\n    ")
         end
         if response.request.headers.any?
           message << "\n  with headers:\n    "
-          message << response.request.headers.map {|k, v| "#{k}: #{v}" }.join("\n    ")
+          message << response.request.headers.map{|k,v| "#{k}: #{v}"}.join("\n    ")
         end
       end
       super opts, message
@@ -46,14 +47,12 @@ module Acfs
     attr_reader :stubs, :operation
 
     def initialize(opts = {})
-      require 'pp'
-
       @stubs     = opts.delete :stubs
       @operation = opts.delete :operation
 
-      super opts, "Ambiguous stubs for #{operation.action} on #{operation.resource}.\n" +
-        stubs.map {|s| "  #{s.opts.pretty_inspect}" }.join
+      super opts, 'Ambiguous stubs.'
     end
+
   end
 
   # Resource not found error raised on a 404 response
@@ -68,7 +67,7 @@ module Acfs
     def initialize(opts = {})
       @errors   = opts.delete :errors
       @resource = opts.delete :resource
-      opts[:message] ||= @errors.map {|k, v| "#{k}: #{v.join ', '}" }.join ', ' if @errors.is_a? Hash
+      opts[:message] ||= @errors.map{ |k,v| "#{k}: #{v.join ', '}" }.join ', ' if @errors.is_a? Hash
       opts[:message] ||= @errors.join ', ' if @errors.is_a? Array
       super
     end
@@ -100,7 +99,7 @@ module Acfs
     def initialize(opts = {})
       @base_class    = opts.delete :base_class
       @type_name     = opts.delete :type_name
-      opts[:message] = "Received resource type `#{type_name}` is no subclass of #{base_class}"
+      opts[:message] = "Recieved ressource type `#{type_name}` is no subclass of #{base_class}"
       super
     end
   end

data/lib/acfs/global.rb

@@ -1,22 +1,14 @@
 module Acfs
-  #
+
   # Global Acfs module methods.
   #
   module Global
-    #
+
     # @api private
     # @return [Runner]
     #
     def runner
-      Thread.current[:acfs_runner] ||= begin
-        adapter = Configuration.current.adapter
-
-        if adapter
-          Runner.new adapter.call
-        else
-          Runner.new Adapter::Typhoeus.new
-        end
-      end
+      @runner ||= Runner.new Adapter::Typhoeus.new
     end
 
     # @api public
@@ -67,10 +59,9 @@ module Acfs
     #   Acfs.add_callback(user, &callback_two)
     #
     def add_callback(resource, &block)
-      unless resource.respond_to?(:__callbacks__)
-        raise ArgumentError.new 'Given resource is not an Acfs resource ' \
-          "delegator but a: #{resource.class.name}"
-      end
+      raise ArgumentError.new "Given resource is not an Acfs resource but "\
+                              "a: #{resource.class.name}" \
+                              unless resource.respond_to?(:__callbacks__)
       return false if block.nil?
 
       if resource.loaded?
@@ -82,7 +73,7 @@ module Acfs
 
     def on(*resources)
       resources.each do |resource|
-        add_callback resource do |_|
+        add_callback resource do |ret|
           yield(*resources) unless resources.any? {|res| !res.loaded? }
         end
       end