acfs 0.50.0 → 1.0.0.dev.1.b297

data/spec/acfs/collection_spec.rb

@@ -11,59 +11,47 @@ describe Acfs::Collection do
 
     context 'without explicit page parameter' do
       before do
-        stub_request(:get, 'http://users.example.org/users')
-          .to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
-            headers: {
-              'X-Total-Pages' => '2',
-              'X-Total-Count' => '10'
-            })
+        stub_request(:get, 'http://users.example.org/users').
+            to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
+                               headers: {'X-Total-Pages' => '2'})
       end
 
       its(:total_pages) { should eq 2 }
       its(:current_page) { should eq 1 }
-      its(:total_count) { should eq 10 }
     end
 
     context 'with page parameter' do
       let(:params) { {page: 2} }
       before do
-        stub_request(:get, 'http://users.example.org/users?page=2')
-          .to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
-            headers: {
-              'X-Total-Pages' => '2',
-              'X-Total-Count' => '10'
-            })
+        stub_request(:get, 'http://users.example.org/users?page=2').
+            to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
+                               headers: {'X-Total-Pages' => '2'})
       end
 
       its(:total_pages) { should eq 2 }
       its(:current_page) { should eq 2 }
-      its(:total_count) { should eq 10 }
     end
 
     context 'with non-numerical page parameter' do
       let(:params) { {page: 'e546f5'} }
       before do
-        stub_request(:get, 'http://users.example.org/users?page=e546f5')
-          .to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
-            headers: {
-              'X-Total-Pages' => '2',
-              'X-Total-Count' => '10'
-            })
+        stub_request(:get, 'http://users.example.org/users?page=e546f5').
+            to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
+                               headers: {'X-Total-Pages' => '2'})
       end
 
       its(:total_pages) { should eq 2 }
       its(:current_page) { should eq 'e546f5' }
-      its(:total_count) { should eq 10 }
     end
 
     describe '#next_page' do
       before do
-        stub_request(:get, 'http://users.example.org/users')
-          .to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
-            headers: {
-              'X-Total-Pages' => '2',
-              'Link'          => '<http://users.example.org/users?page=2>; rel="next"'
-            })
+        stub_request(:get, 'http://users.example.org/users').
+            to_return response([{id: 1, name: 'Anon', age: 12, born_at: 'Berlin'}],
+                               headers: {
+                                   'X-Total-Pages' => '2',
+                                   'Link'          => '<http://users.example.org/users?page=2>; rel="next"'
+                               })
       end
       let!(:req) do
         stub_request(:get, 'http://users.example.org/users?page=2').to_return response([])
@@ -82,12 +70,12 @@ describe Acfs::Collection do
 
     describe '#prev_page' do
       before do
-        stub_request(:get, 'http://users.example.org/users?page=2')
-          .to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
-            headers: {
-              'X-Total-Pages' => '2',
-              'Link'          => '<http://users.example.org/users>; rel="prev"'
-            })
+        stub_request(:get, 'http://users.example.org/users?page=2').
+            to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
+                               headers: {
+                                   'X-Total-Pages' => '2',
+                                   'Link'          => '<http://users.example.org/users>; rel="prev"'
+                               })
       end
       let!(:req) do
         stub_request(:get, 'http://users.example.org/users').to_return response([])
@@ -106,12 +94,12 @@ describe Acfs::Collection do
 
     describe '#first_page' do
       before do
-        stub_request(:get, 'http://users.example.org/users?page=2')
-          .to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
-            headers: {
-              'X-Total-Pages' => '2',
-              'Link'          => '<http://users.example.org/users>; rel="first"'
-            })
+        stub_request(:get, 'http://users.example.org/users?page=2').
+            to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
+                               headers: {
+                                   'X-Total-Pages' => '2',
+                                   'Link'          => '<http://users.example.org/users>; rel="first"'
+                               })
       end
       let!(:req) do
         stub_request(:get, 'http://users.example.org/users').to_return response([])
@@ -130,12 +118,12 @@ describe Acfs::Collection do
 
     describe '#last_page' do
       before do
-        stub_request(:get, 'http://users.example.org/users?page=2')
-          .to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
-            headers: {
-              'X-Total-Pages' => '2',
-              'Link'          => '<http://users.example.org/users?page=12>; rel="last"'
-            })
+        stub_request(:get, 'http://users.example.org/users?page=2').
+            to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
+                               headers: {
+                                   'X-Total-Pages' => '2',
+                                   'Link'          => '<http://users.example.org/users?page=12>; rel="last"'
+                               })
       end
       let!(:req) do
         stub_request(:get, 'http://users.example.org/users?page=12').to_return response([])

data/spec/acfs/configuration_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe Acfs::Configuration do
+
   let(:cfg) { Acfs::Configuration.new }
   before { @configuration = Acfs::Configuration.current.dup }
   after { Acfs::Configuration.set @configuration }
@@ -39,13 +40,4 @@ describe Acfs::Configuration do
       end
     end
   end
-
-  describe '#adapter' do
-    let(:object) { Object.new }
-
-    it 'should be a accessor' do
-      cfg.adapter = object
-      expect(cfg.adapter).to eq object
-    end
-  end
 end

data/spec/acfs/global_spec.rb

@@ -14,11 +14,11 @@ describe ::Acfs::Global do
   let(:adapter) { ::NullAdapter.new }
   let(:runner) { double 'runner' }
   let(:collector) { NotificationCollector.new }
-  let(:acfs) { Object.new.tap {|o| o.extend ::Acfs::Global } }
+  let(:acfs) { Object.new.tap { |o| o.extend ::Acfs::Global } }
 
   describe 'instrumentation' do
     before do
-      # allow(runner).to receive(:start)
+      #allow(runner).to receive(:start)
       allow(acfs).to receive(:runner).and_return runner
     end
 
@@ -48,7 +48,7 @@ describe ::Acfs::Global do
       stub_request(:get, %r{http://users.example.org/users/\d+}).to_return(
         status: 200,
         body: '{}',
-        headers: {'Content-Type' => 'application/json'})
+        headers: { 'Content-Type' => 'application/json' })
     end
 
     it 'should invoke when both resources' do
@@ -72,22 +72,4 @@ describe ::Acfs::Global do
       Acfs.run
     end
   end
-
-  describe '#runner' do
-    it 'returns per-thread runner' do
-      runner1 = Thread.new { acfs.runner } .value
-      runner2 = Thread.new { acfs.runner } .value
-
-      expect(runner1).to_not equal runner2
-    end
-
-    it 'uses configurated adapter' do
-      adapter = double :adapter
-      expect(Acfs::Configuration.current).to receive(:adapter).and_return(-> { adapter })
-
-      runner = Thread.new { acfs.runner }.value
-
-      expect(runner.adapter).to equal adapter
-    end
-  end
 end

data/spec/acfs/middleware/json_decoder_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe Acfs::Middleware::JsonDecoder do
+  let(:data)     { [{id: 1, name: "Anon"},{id: 2, name:"John", friends: [ 1 ]}] }
+  let(:body)     { data.to_param }
+  let(:headers)  { {} }
+  let(:request)  { Acfs::Request.new "fubar" }
+  let(:response) { Acfs::Response.new request, status: 200, headers: headers, body: body }
+  let(:decoder)  { Acfs::Middleware::JsonDecoder.new lambda { |req| req } }
+
+  before do
+    decoder.call request
+  end
+
+  context 'with JSON response' do
+    let(:headers) { { 'Content-Type' => 'application/json; charset=utf-8' } }
+    let(:body)    { data.to_json }
+
+    it 'should decode body data' do
+      request.complete! response
+
+      expect(response.data).to be == data.map(&:stringify_keys)
+    end
+  end
+
+  context 'with invalid JSON response' do
+    let(:headers) { { 'Content-Type' => 'application/json' } }
+    let(:body)    { data.to_json[4..-4] }
+
+    it 'should raise an error' do
+      expect { request.complete! response }.to raise_error(MultiJson::LoadError)
+    end
+  end
+
+  context 'without JSON response' do
+    let(:headers) { { 'Content-Type' => 'application/text' } }
+    let(:body)    { data.to_json }
+
+    it 'should not decode non-JSON encoded responses' do
+      request.complete! response
+
+      expect(response.data).to be_nil
+    end
+  end
+end

data/spec/acfs/middleware/msgpack_decoder_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Acfs::Middleware::MessagePackDecoder do
+  let(:data)     { [{id: 1, name: "Anon"},{id: 2, name:"John", friends: [ 1 ]}] }
+  let(:body)     { data.to_param }
+  let(:headers)  { {} }
+  let(:request)  { Acfs::Request.new "fubar" }
+  let(:response) { Acfs::Response.new request, status: 200, headers: headers, body: body }
+  let(:decoder)  { Acfs::Middleware::MessagePackDecoder.new lambda { |req| req } }
+
+  before do
+    decoder.call request
+  end
+
+  context 'with Message Pack response' do
+    let(:headers) { { 'Content-Type' => 'application/x-msgpack' } }
+    let(:body)    { MessagePack.pack data }
+
+    it 'should decode body data' do
+      request.complete! response
+
+      expect(response.data).to be == data.map(&:stringify_keys)
+    end
+  end
+
+  context 'without Message Pack response' do
+    let(:headers) { { 'Content-Type' => 'application/text' } }
+    let(:body)    { data.to_json }
+
+    it 'should not decode non-MessagePack encoded responses' do
+      request.complete! response
+
+      expect(response.data).to be_nil
+    end
+  end
+end

data/spec/acfs/request/callbacks_spec.rb

@@ -1,20 +1,20 @@
 require 'spec_helper'
 
 describe Acfs::Request::Callbacks do
-  let(:callback) { ->(_res) {} }
+  let(:callback) { lambda { |res| } }
   let(:request)  { Acfs::Request.new('fubar') }
 
   describe '#on_complete' do
     it 'should store a given callback' do
-      request.on_complete(&callback)
+      request.on_complete &callback
 
       expect(request.callbacks).to have(1).item
       expect(request.callbacks[0]).to be == callback
     end
 
     it 'should store multiple callback' do
-      request.on_complete {|_res| 'abc' }
-      request.on_complete(&callback)
+      request.on_complete { |res| "abc" }
+      request.on_complete &callback
 
       expect(request.callbacks).to have(2).item
       expect(request.callbacks[0]).to be == callback
@@ -27,16 +27,16 @@ describe Acfs::Request::Callbacks do
     it 'should trigger registered callbacks with given response' do
       expect(callback).to receive(:call).with(response, kind_of(Proc))
 
-      request.on_complete(&callback)
+      request.on_complete &callback
       request.complete! response
     end
 
     it 'should trigger multiple callback in reverted insertion order' do
       check = []
 
-      request.on_complete {|res, nxt| check << 1; nxt.call res }
-      request.on_complete {|res, nxt| check << 2; nxt.call res }
-      request.on_complete {|res, nxt| check << 3; nxt.call res }
+      request.on_complete { |res, nxt| check << 1; nxt.call res }
+      request.on_complete { |res, nxt| check << 2; nxt.call res }
+      request.on_complete { |res, nxt| check << 3; nxt.call res }
 
       request.complete! response
 

data/spec/acfs/request_spec.rb

@@ -15,7 +15,7 @@ describe Acfs::Request do
     end
 
     context 'with parameters' do
-      let(:params) { {id: 10} }
+      let(:params) { { id: 10 }}
 
       it 'should return URL without query' do
         expect(request.url).to be == "#{url}"
@@ -24,7 +24,7 @@ describe Acfs::Request do
   end
 
   describe '#headers' do
-    let(:headers) { {'Accept' => 'application/json'} }
+    let(:headers) { { 'Accept' => 'application/json' } }
 
     it 'should return request headers' do
       expect(request.headers).to be == headers
@@ -46,7 +46,7 @@ describe Acfs::Request do
   end
 
   describe '#params' do
-    let(:params) { {id: 10} }
+    let(:params) { { id: 10 }}
 
     it 'should return request headers' do
       expect(request.params).to be == params
@@ -54,7 +54,7 @@ describe Acfs::Request do
   end
 
   describe '#data' do
-    let(:data) { {id: 10, name: 'Anon'} }
+    let(:data) { { id: 10, name: 'Anon' } }
 
     it 'should return request data' do
       expect(request.data).to be == data
@@ -63,7 +63,7 @@ describe Acfs::Request do
 
   describe '#data' do
     context 'with data' do
-      let(:data) { {id: 10, name: 'Anon'} }
+      let(:data) { { id: 10, name: 'Anon' } }
 
       it { expect(request).to be_data }
     end

data/spec/acfs/resource/attributes/boolean_spec.rb

@@ -3,54 +3,23 @@ require 'spec_helper'
 describe Acfs::Resource::Attributes::Boolean do
   subject { Acfs::Resource::Attributes::Boolean.new }
 
-  describe '#cast' do
-    it 'casts nil' do
-      expect(subject.cast(nil)).to eq nil
-    end
-
-    it 'casts empty string to false' do
-      expect(subject.cast('')).to eq nil
-    end
-
-    it 'casts blank string to false' do
-      expect(subject.cast("  \t")).to eq nil
-    end
-
-    it 'preserves boolean values' do
+  describe 'cast' do
+    it 'should preserve boolean values' do
       expect(subject.cast(false)).to eq false
       expect(subject.cast(true)).to eq true
     end
 
-    it 'casts falsy values to false' do
-      expect(subject.cast(false)).to eq false
-      expect(subject.cast(0)).to eq false
-      expect(subject.cast('0')).to eq false
-      expect(subject.cast('no')).to eq false
-      expect(subject.cast('NO')).to eq false
-      expect(subject.cast('off')).to eq false
-      expect(subject.cast('OFF')).to eq false
-      expect(subject.cast('false')).to eq false
-      expect(subject.cast('FALSE')).to eq false
-      expect(subject.cast('f')).to eq false
-      expect(subject.cast('F')).to eq false
-    end
-
-    it 'casts any other value to true' do
-      expect(subject.cast(true)).to eq true
-      expect(subject.cast(1)).to eq true
-      expect(subject.cast('1')).to eq true
+    it 'should cast TRUE_VALUES to true' do
       expect(subject.cast('yes')).to eq true
-      expect(subject.cast('YES')).to eq true
       expect(subject.cast('on')).to eq true
-      expect(subject.cast('ON')).to eq true
       expect(subject.cast('true')).to eq true
-      expect(subject.cast('TRUE')).to eq true
-      expect(subject.cast('t')).to eq true
-      expect(subject.cast('T')).to eq true
+      expect(subject.cast('1')).to eq true
+    end
 
-      expect(subject.cast(2)).to eq true
-      expect(subject.cast('wrong')).to eq true
-      expect(subject.cast('random')).to eq true
+    it 'should cast any other value to false' do
+      expect(subject.cast('')).to eq false
+      expect(subject.cast('wrong')).to eq false
+      expect(subject.cast('random')).to eq false
     end
   end
 end

data/spec/acfs/resource/attributes/date_time_spec.rb

@@ -1,49 +1,55 @@
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::DateTime do
-  let(:type) { Acfs::Resource::Attributes::DateTime.new }
+  let(:model) { Class.new Acfs::Resource }
+  let(:params) { {} }
+  subject { Acfs::Resource::Attributes::DateTime.new params }
 
-  describe '#cast' do
-    subject { -> { type.cast value } }
-
-    context 'with nil' do
-      let(:value) { nil }
-      it { expect(subject.call).to eq nil }
+  describe 'cast' do
+    it 'should return same object, if obj is already of DateTime class' do
+      date_time = DateTime.now
+      retval = subject.cast(date_time)
+      expect(retval).to be == date_time
     end
 
-    context 'with empty string' do
-      let(:value) { '' }
-      it { expect(subject.call).to eq nil }
+    it 'should return parsed object, if obj is of Time class' do
+      time = Time.now
+      retval = subject.cast(time)
+      expect(retval).to be == DateTime.iso8601(time.iso8601)
     end
 
-    context 'with blank string' do
-      let(:value) { "  \t" }
-      it { expect(subject.call).to eq nil }
+    it 'should return parsed object, if obj is of Date class' do
+      date = Date.today
+      retval = subject.cast(date)
+      expect(retval).to be == DateTime.iso8601(date.iso8601)
     end
 
-    context 'with DateTime' do
-      let(:value) { DateTime.now }
-      it { expect(subject.call).to eq value }
+    it 'should return parsed object, if obj is of String class in ISO-8601 format' do
+      date_time_string = DateTime.now.iso8601
+      retval = subject.cast(date_time_string)
+      expect(retval).to be == DateTime.iso8601(date_time_string)
     end
 
-    context 'with Time' do
-      let(:value) { Time.now }
-      it { expect(subject.call).to eq value.to_datetime }
+    it 'should raise an error if obj is of String class not in valid ISO-8601 format' do
+      malformed_string = 'qwe123'
+      expect {
+        subject.cast(malformed_string)
+      }.to raise_error ArgumentError
     end
 
-    context 'with Date' do
-      let(:value) { Date.today }
-      it { expect(subject.call).to eq value.to_datetime }
+    it 'should raise an error if obj is of wrong class (Fixnum)' do
+      fixnum = 12
+      expect {
+        subject.cast(fixnum)
+      }.to raise_error TypeError
     end
 
-    context 'with ISO8601' do
-      let(:value) { DateTime.now.iso8601 }
-      it { expect(subject.call.iso8601).to eq value }
-    end
+    context 'with allow_nil option' do
+      let(:params) { {allow_nil: true} }
 
-    context 'with invalid string' do
-      let(:value) { 'qwe123' }
-      it { is_expected.to raise_error ArgumentError }
+      it 'should accept empty string as nil' do
+        expect(subject.cast('')).to eq nil
+      end
     end
   end
 end