acfs 0.39.1 → 0.40.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6329e35c7cb801186fdcda65f956efcb3316c064
-  data.tar.gz: c07744dd6be8d4cce2cb70b3cdccce1e967c9bcb
+  metadata.gz: e728ae7cf62def4e1df96d8c0c5444d7744d9118
+  data.tar.gz: e1ea041ebf16e56151bffc3126bee0bf5ac7bff2
 SHA512:
-  metadata.gz: bdba68bc9e317021251f4c593d7c2919ba0f722b9246d6931d585d664116708c3fb1d3ae932fc5fa2b1a7fab50eeb4a3d009a056ca18d469ff2f460f05852ceb
-  data.tar.gz: 1eb26e66f93c43db47ece59f17e31d357c61d37e3b16d4a64bfdd230b42ce80939b070bee7c87d6078c21499f5c99435f324286c0a8f98c4aeaee6c354371fad
+  metadata.gz: 34bc346e59bdca107b308f5b6c06b7252694971d4a9734dd01127e49d93298cfb606032a8c0198d983d83af096a7928d7b052084cade4b03354015158a5a21df
+  data.tar.gz: 56b3426386526dba23875d3161cebcec98fbef38f2052459062e43e21553175cf65d6be7f4119ab398744dfeaf4ed14a482fb42d9f056dc78d5584c1ede361d3

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.40.0
+
+* Change `Resource#persisted?` to return true if it is not new
+
 ## 0.39.1
 
 * Fix automatic path parameter handling for #destroy

data/lib/acfs/global.rb

@@ -1,14 +1,14 @@
 module Acfs
-
+  #
   # Global Acfs module methods.
   #
   module Global
-
+    #
     # @api private
     # @return [Runner]
     #
     def runner
-      @runner ||= Runner.new Adapter::Typhoeus.new
+      Thread.current[:acfs_runner] ||= Runner.new Adapter::Typhoeus.new
     end
 
     # @api public
@@ -32,7 +32,7 @@ module Acfs
     # @see Configuration#configure
     #
     def configure(&block)
-      Configuration.current.configure &block
+      Configuration.current.configure(&block)
     end
 
     # @api public
@@ -41,7 +41,7 @@ module Acfs
     #
     def reset
       ::ActiveSupport::Notifications.instrument 'acfs.reset' do
-        self.runner.clear
+        runner.clear
         Acfs::Stub.clear
       end
     end
@@ -51,15 +51,18 @@ module Acfs
     # Add an additional callback hook to not loaded resource.
     # If given resource already loaded callback will be invoked immediately.
     #
-    # This method will be replaced by explicit callback handling when query methods
-    # return explicit future objects.
+    # This method will be replaced by explicit callback
+    # handling when query methods return explicit future objects.
     #
     # @example
     #   user = MyUser.find 1, &callback_one
     #   Acfs.add_callback(user, &callback_two)
     #
     def add_callback(resource, &block)
-      raise ArgumentError.new "Given resource is not an Acfs resource but a: #{resource.class.name}" unless resource.respond_to?(:__callbacks__)
+      unless resource.respond_to?(:__callbacks__)
+        raise ArgumentError.new 'Given resource is not an Acfs resource ' \
+          "delegator but a: #{resource.class.name}"
+      end
       return false if block.nil?
 
       if resource.loaded?
@@ -71,8 +74,8 @@ module Acfs
 
     def on(*resources)
       resources.each do |resource|
-        add_callback resource do |ret|
-          yield(*resources) unless resources.any? { |res| !res.loaded? }
+        add_callback resource do |_|
+          yield(*resources) unless resources.any?{|res| !res.loaded? }
         end
       end
     end

data/lib/acfs/model/persistence.rb

@@ -9,8 +9,7 @@ module Acfs
       # @api public
       #
       # Check if the model is persisted. A model is persisted if
-      # it is saved after beeing created or when it was not changed
-      # since it was loaded.
+      # it is saved after being created
       #
       # @example Newly created resource:
       #   user = User.new name: "John"
@@ -22,14 +21,14 @@ module Acfs
       #   user2 = User.find 5
       #   user2.persisted? # => true
       #   user2.name = 'Amy'
-      #   user2.persisted? # => false
+      #   user2.persisted? # => true
       #   user2.save
       #   user2.persisted? # => true
       #
-      # @return [Boolean] True if resource has no changes and is not newly created, false otherwise.
+      # @return [Boolean] True if resource has been saved
       #
       def persisted?
-        !new? && !changed?
+        !new?
       end
 
       # @api public

data/lib/acfs/version.rb

@@ -1,8 +1,8 @@
 module Acfs
   module VERSION
     MAJOR = 0
-    MINOR = 39
-    PATCH = 1
+    MINOR = 40
+    PATCH = 0
     STAGE = nil
 
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.')

data/spec/acfs/model/persistance_spec.rb

@@ -122,7 +122,7 @@ describe Acfs::Model::Persistence do
       let(:model) { model_class.find 1 }
       before { model; Acfs.run; model.name = 'dhh' }
 
-      it { expect(model).to_not be_persisted }
+      it { expect(model).to be_persisted }
       it { expect(model).to_not be_new }
     end
 

data/spec/acfs_spec.rb

@@ -24,7 +24,7 @@ describe 'Acfs' do
     @user.name = 'Johnny'
 
     expect(@user).to be_changed
-    expect(@user).to_not be_persisted
+    expect(@user).to be_persisted
 
     @user.save
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acfs
 version: !ruby/object:Gem::Version
-  version: 0.39.1
+  version: 0.40.0
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-13 00:00:00.000000000 Z
+date: 2014-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport