acfs 0.39.1 → 0.40.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 6329e35c7cb801186fdcda65f956efcb3316c064
4
- data.tar.gz: c07744dd6be8d4cce2cb70b3cdccce1e967c9bcb
3
+ metadata.gz: e728ae7cf62def4e1df96d8c0c5444d7744d9118
4
+ data.tar.gz: e1ea041ebf16e56151bffc3126bee0bf5ac7bff2
5
5
  SHA512:
6
- metadata.gz: bdba68bc9e317021251f4c593d7c2919ba0f722b9246d6931d585d664116708c3fb1d3ae932fc5fa2b1a7fab50eeb4a3d009a056ca18d469ff2f460f05852ceb
7
- data.tar.gz: 1eb26e66f93c43db47ece59f17e31d357c61d37e3b16d4a64bfdd230b42ce80939b070bee7c87d6078c21499f5c99435f324286c0a8f98c4aeaee6c354371fad
6
+ metadata.gz: 34bc346e59bdca107b308f5b6c06b7252694971d4a9734dd01127e49d93298cfb606032a8c0198d983d83af096a7928d7b052084cade4b03354015158a5a21df
7
+ data.tar.gz: 56b3426386526dba23875d3161cebcec98fbef38f2052459062e43e21553175cf65d6be7f4119ab398744dfeaf4ed14a482fb42d9f056dc78d5584c1ede361d3
@@ -1,5 +1,9 @@
1
1
  # Changelog
2
2
 
3
+ ## 0.40.0
4
+
5
+ * Change `Resource#persisted?` to return true if it is not new
6
+
3
7
  ## 0.39.1
4
8
 
5
9
  * Fix automatic path parameter handling for #destroy
@@ -1,14 +1,14 @@
1
1
  module Acfs
2
-
2
+ #
3
3
  # Global Acfs module methods.
4
4
  #
5
5
  module Global
6
-
6
+ #
7
7
  # @api private
8
8
  # @return [Runner]
9
9
  #
10
10
  def runner
11
- @runner ||= Runner.new Adapter::Typhoeus.new
11
+ Thread.current[:acfs_runner] ||= Runner.new Adapter::Typhoeus.new
12
12
  end
13
13
 
14
14
  # @api public
@@ -32,7 +32,7 @@ module Acfs
32
32
  # @see Configuration#configure
33
33
  #
34
34
  def configure(&block)
35
- Configuration.current.configure &block
35
+ Configuration.current.configure(&block)
36
36
  end
37
37
 
38
38
  # @api public
@@ -41,7 +41,7 @@ module Acfs
41
41
  #
42
42
  def reset
43
43
  ::ActiveSupport::Notifications.instrument 'acfs.reset' do
44
- self.runner.clear
44
+ runner.clear
45
45
  Acfs::Stub.clear
46
46
  end
47
47
  end
@@ -51,15 +51,18 @@ module Acfs
51
51
  # Add an additional callback hook to not loaded resource.
52
52
  # If given resource already loaded callback will be invoked immediately.
53
53
  #
54
- # This method will be replaced by explicit callback handling when query methods
55
- # return explicit future objects.
54
+ # This method will be replaced by explicit callback
55
+ # handling when query methods return explicit future objects.
56
56
  #
57
57
  # @example
58
58
  # user = MyUser.find 1, &callback_one
59
59
  # Acfs.add_callback(user, &callback_two)
60
60
  #
61
61
  def add_callback(resource, &block)
62
- raise ArgumentError.new "Given resource is not an Acfs resource but a: #{resource.class.name}" unless resource.respond_to?(:__callbacks__)
62
+ unless resource.respond_to?(:__callbacks__)
63
+ raise ArgumentError.new 'Given resource is not an Acfs resource ' \
64
+ "delegator but a: #{resource.class.name}"
65
+ end
63
66
  return false if block.nil?
64
67
 
65
68
  if resource.loaded?
@@ -71,8 +74,8 @@ module Acfs
71
74
 
72
75
  def on(*resources)
73
76
  resources.each do |resource|
74
- add_callback resource do |ret|
75
- yield(*resources) unless resources.any? { |res| !res.loaded? }
77
+ add_callback resource do |_|
78
+ yield(*resources) unless resources.any?{|res| !res.loaded? }
76
79
  end
77
80
  end
78
81
  end
@@ -9,8 +9,7 @@ module Acfs
9
9
  # @api public
10
10
  #
11
11
  # Check if the model is persisted. A model is persisted if
12
- # it is saved after beeing created or when it was not changed
13
- # since it was loaded.
12
+ # it is saved after being created
14
13
  #
15
14
  # @example Newly created resource:
16
15
  # user = User.new name: "John"
@@ -22,14 +21,14 @@ module Acfs
22
21
  # user2 = User.find 5
23
22
  # user2.persisted? # => true
24
23
  # user2.name = 'Amy'
25
- # user2.persisted? # => false
24
+ # user2.persisted? # => true
26
25
  # user2.save
27
26
  # user2.persisted? # => true
28
27
  #
29
- # @return [Boolean] True if resource has no changes and is not newly created, false otherwise.
28
+ # @return [Boolean] True if resource has been saved
30
29
  #
31
30
  def persisted?
32
- !new? && !changed?
31
+ !new?
33
32
  end
34
33
 
35
34
  # @api public
@@ -1,8 +1,8 @@
1
1
  module Acfs
2
2
  module VERSION
3
3
  MAJOR = 0
4
- MINOR = 39
5
- PATCH = 1
4
+ MINOR = 40
5
+ PATCH = 0
6
6
  STAGE = nil
7
7
 
8
8
  STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.')
@@ -122,7 +122,7 @@ describe Acfs::Model::Persistence do
122
122
  let(:model) { model_class.find 1 }
123
123
  before { model; Acfs.run; model.name = 'dhh' }
124
124
 
125
- it { expect(model).to_not be_persisted }
125
+ it { expect(model).to be_persisted }
126
126
  it { expect(model).to_not be_new }
127
127
  end
128
128
 
@@ -24,7 +24,7 @@ describe 'Acfs' do
24
24
  @user.name = 'Johnny'
25
25
 
26
26
  expect(@user).to be_changed
27
- expect(@user).to_not be_persisted
27
+ expect(@user).to be_persisted
28
28
 
29
29
  @user.save
30
30
 
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: acfs
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.39.1
4
+ version: 0.40.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Jan Graichen
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2014-05-13 00:00:00.000000000 Z
11
+ date: 2014-06-02 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activesupport