acfs 1.7.0 → 2.0.0

data/spec/acfs/resource/attributes/integer_spec.rb

@@ -6,36 +6,36 @@ describe Acfs::Resource::Attributes::Integer do
   let(:type) { Acfs::Resource::Attributes::Integer.new }
 
   describe '#cast' do
-    subject(:cast) { -> { type.cast value } }
+    subject(:cast) { type.cast value }
 
     context 'with nil' do
       let(:value) { nil }
 
-      it { expect(cast.call).to eq nil }
+      it { expect(cast).to be_nil }
     end
 
     context 'with empty string' do
       let(:value) { '' }
 
-      it { expect(cast.call).to eq 0 }
+      it { expect(cast).to eq 0 }
     end
 
     context 'with blank string' do
       let(:value) { "  \t" }
 
-      it { expect(cast.call).to eq 0 }
+      it { expect(cast).to eq 0 }
     end
 
     context 'with string' do
       let(:value) { '123' }
 
-      it { expect(cast.call).to eq 123 }
+      it { expect(cast).to eq 123 }
     end
 
     context 'with invalid string' do
       let(:value) { '123a' }
 
-      it { is_expected.to raise_error ArgumentError }
+      it { expect { cast }.to raise_error ArgumentError }
     end
   end
 end

data/spec/acfs/resource/attributes/list_spec.rb

@@ -11,7 +11,7 @@ describe Acfs::Resource::Attributes::List do
     context 'with nil' do
       let(:value) { nil }
 
-      it { expect(cast.call).to eq nil }
+      it { expect(cast.call).to be_nil }
     end
 
     context 'with blank string (I)' do

data/spec/acfs/resource/attributes/uuid_spec.rb

@@ -6,43 +6,43 @@ describe Acfs::Resource::Attributes::UUID do
   let(:type) { Acfs::Resource::Attributes::UUID.new }
 
   describe '#cast' do
-    subject(:cast) { -> { type.cast(value) } }
+    subject(:cast) { type.cast(value) }
 
     context 'with nil' do
       let(:value) { nil }
 
-      it { expect(cast.call).to eq nil }
+      it { expect(cast).to be_nil }
     end
 
     context 'with empty string' do
       let(:value) { '' }
 
-      it { expect(cast.call).to eq nil }
+      it { expect(cast).to be_nil }
     end
 
     context 'with blank string' do
       let(:value) { "  \t" }
 
-      it { expect(cast.call).to eq nil }
+      it { expect(cast).to be_nil }
     end
 
     context 'with string UUID' do
       let(:value) { '450b7a40-94ad-11e3-baa8-0800200c9a66' }
 
-      it { expect(cast.call).to be_a String }
-      it { expect(cast.call).to eq value }
+      it { expect(cast).to be_a String }
+      it { expect(cast).to eq value }
     end
 
     context 'with invalid string' do
       let(:value) { 'invalid string' }
 
-      it { is_expected.to raise_error TypeError, /invalid UUID/i }
+      it { expect { cast }.to raise_error TypeError, /invalid UUID/i }
     end
 
     context 'with invalid UUID' do
       let(:value) { 'xxxxxxxx-yyyy-11e3-baa8-0800200c9a66' }
 
-      it { is_expected.to raise_error TypeError, /invalid UUID/i }
+      it { expect { cast }.to raise_error TypeError, /invalid UUID/i }
     end
   end
 end

data/spec/acfs/resource/attributes_spec.rb

@@ -41,7 +41,7 @@ describe Acfs::Resource::Attributes do
   end
 
   describe '#write_attributes' do
-    subject(:action) { -> { m.write_attributes(params, **opts) } }
+    subject(:action) { m.write_attributes(params, **opts) }
 
     before do
       model.attribute :name, :string, default: 'John'
@@ -56,7 +56,7 @@ describe Acfs::Resource::Attributes do
     let(:m) { model.new }
 
     it 'updates attributes' do
-      expect(action).to change(m, :attributes)
+      expect { action }.to change(m, :attributes)
         .from(name: 'The Great John', age: 25)
         .to(name: 'The Great James', age: 25)
     end
@@ -64,17 +64,17 @@ describe Acfs::Resource::Attributes do
     context 'without non-hash params' do
       let(:params) { 'James' }
 
-      it { expect(action).not_to change(m, :attributes) }
-      it { expect(action.call).to eq false }
+      it { expect { action }.not_to change(m, :attributes) }
+      it { expect(action).to be false }
     end
 
     context 'with unknown attributes' do
       let(:params) { {name: 'James', born_at: 'today'} }
 
-      it { expect(action).not_to raise_error }
+      it { expect { action }.not_to raise_error }
 
       it 'updates known attributes and store unknown' do
-        expect(action).to change(m, :attributes)
+        expect { action }.to change(m, :attributes)
           .from(name: 'The Great John', age: 25)
           .to(name: 'The Great James', age: 25, born_at: 'today')
       end
@@ -82,11 +82,11 @@ describe Acfs::Resource::Attributes do
       context 'with unknown: :raise option' do
         let(:opts) { {unknown: :raise} }
 
-        it { expect(action).to raise_error(ArgumentError, /unknown attribute/i) }
+        it { expect { action }.to raise_error(ArgumentError, /unknown attribute/i) }
 
         it do
           expect do
-            action.call
+            action
           rescue StandardError
             true
           end.not_to change(m, :attributes)

data/spec/acfs/resource/dirty_spec.rb

@@ -13,7 +13,7 @@ describe Acfs::Resource::Dirty do
   end
 
   it 'includes ActiveModel::Dirty' do
-    model.is_a? ActiveModel::Dirty
+    expect(model).to be_a ActiveModel::Dirty
   end
 
   describe '#changed?' do

data/spec/acfs/resource/persistence_spec.rb

@@ -275,7 +275,7 @@ describe Acfs::Resource::Persistence do
         rescue StandardError
           nil
         end
-        expect(model.errors.to_hash).to be == {name: %w[required]}
+        expect(model.errors.to_hash).to eq({name: %w[required]})
       end
     end
   end
@@ -286,8 +286,8 @@ describe Acfs::Resource::Persistence do
 
       it 'creates new resource' do
         model = model_class.create! data
-        expect(model.name).to be == 'Idefix'
-        expect(model.age).to be == 12
+        expect(model.name).to eq 'Idefix'
+        expect(model.age).to eq 12
       end
 
       it 'is persisted' do
@@ -301,8 +301,8 @@ describe Acfs::Resource::Persistence do
 
       it 'raises an error' do
         expect { model_class.create! data }.to \
-          raise_error(::Acfs::InvalidResource) do |error|
-            expect(error.errors).to be == {'name' => %w[required]}
+          raise_error(Acfs::InvalidResource) do |error|
+            expect(error.errors).to eq({'name' => %w[required]})
           end
       end
     end
@@ -315,8 +315,8 @@ describe Acfs::Resource::Persistence do
       let(:data) { {name: 'Idefix', age: 12} }
 
       it 'creates new resource' do
-        expect(model.name).to be == 'Idefix'
-        expect(model.age).to be == 12
+        expect(model.name).to eq 'Idefix'
+        expect(model.age).to eq 12
       end
 
       it 'is persisted' do

data/spec/acfs/resource/query_methods_spec.rb

@@ -333,7 +333,7 @@ describe Acfs::Resource::QueryMethods do
       let(:model) { Single }
 
       it '.find_by should not be defined' do
-        expect { model.find_by }.to raise_error ::Acfs::UnsupportedOperation
+        expect { model.find_by }.to raise_error Acfs::UnsupportedOperation
       end
     end
   end

data/spec/acfs/runner_spec.rb

@@ -30,26 +30,26 @@ class NotificationCollector
   end
 end
 
-describe ::Acfs::Runner do
-  let(:adapter) { ::NullAdapter.new }
-  let(:runner) { ::Acfs::Runner.new adapter }
+describe Acfs::Runner do
+  let(:adapter) { NullAdapter.new }
+  let(:runner) { Acfs::Runner.new adapter }
   let(:collector) { NotificationCollector.new }
   let(:collector2) { NotificationCollector.new }
 
   after do
-    ::ActiveSupport::Notifications.notifier = \
-      ::ActiveSupport::Notifications::Fanout.new
+    ActiveSupport::Notifications.notifier =
+      ActiveSupport::Notifications::Fanout.new
   end
 
   describe '#instrumentation' do
     before do
-      ::ActiveSupport::Notifications.subscribe(/^acfs\.runner/, collector)
-      ::ActiveSupport::Notifications.subscribe(/^acfs\.operation/, collector2)
+      ActiveSupport::Notifications.subscribe(/^acfs\.runner/, collector)
+      ActiveSupport::Notifications.subscribe(/^acfs\.operation/, collector2)
     end
 
     describe '#process' do
       it 'triggers event' do
-        runner.process ::Acfs::Operation.new MyUser, :read, params: {id: 0}
+        runner.process Acfs::Operation.new MyUser, :read, params: {id: 0}
         expect(collector.events).to have(1).items
         expect(collector2.events).to have(1).items
       end
@@ -57,7 +57,7 @@ describe ::Acfs::Runner do
 
     describe '#run' do
       it 'triggers event' do
-        runner.run ::Acfs::Operation.new MyUser, :read, params: {id: 0}
+        runner.run Acfs::Operation.new MyUser, :read, params: {id: 0}
         expect(collector.events).to have(1).items
         expect(collector2.events).to have(0).items
       end
@@ -65,7 +65,7 @@ describe ::Acfs::Runner do
 
     describe '#enqueue' do
       it 'triggers event' do
-        runner.enqueue ::Acfs::Operation.new MyUser, :read, params: {id: 0}
+        runner.enqueue Acfs::Operation.new MyUser, :read, params: {id: 0}
         expect(collector.events).to have(1).items
         expect(collector2.events).to have(0).items
       end
@@ -79,7 +79,7 @@ describe ::Acfs::Runner do
 
     it 'does not do requests when a middleware aborted' do
       expect(adapter).not_to receive :run
-      runner.run ::Acfs::Operation.new MyUser, :read, params: {id: 0}
+      runner.run Acfs::Operation.new MyUser, :read, params: {id: 0}
     end
   end
 
@@ -90,7 +90,7 @@ describe ::Acfs::Runner do
 
     it 'does not do requests when a middleware aborted' do
       expect(adapter).not_to receive(:queue)
-      runner.enqueue ::Acfs::Operation.new MyUser, :read, params: {id: 0}
+      runner.enqueue Acfs::Operation.new MyUser, :read, params: {id: 0}
       runner.start
     end
   end

data/spec/acfs/stub_spec.rb

@@ -126,7 +126,7 @@ describe Acfs::Stub do
       it 'allows to raise error' do
         expect do
           Session.create! ident: 'john@exmaple.org', password: 'wrong'
-        end.to raise_error(::Acfs::InvalidResource)
+        end.to raise_error(Acfs::InvalidResource)
       end
     end
 
@@ -204,7 +204,7 @@ describe Acfs::Stub do
       let!(:update_stub) do
         Acfs::Stub.resource MyUser, :update,
           with: {id: 1, name: 'Jane Smith'},
-          return: ->(op) { op.data.map {|k, v| [k, v.to_s.upcase] }.to_h }
+          return: ->(op) { op.data.to_h {|k, v| [k, v.to_s.upcase] } }
       end
 
       it 'allows stub resource update' do
@@ -226,7 +226,7 @@ describe Acfs::Stub do
 
         expect do
           user.save!
-        end.to raise_error(::Acfs::InvalidResource)
+        end.to raise_error(Acfs::InvalidResource)
       end
 
       it 'matches partial :with' do
@@ -283,9 +283,8 @@ describe Acfs::Stub do
 
     context 'with a match in params' do
       let(:op) do
-        instance_double('Acfs::Operation').tap do |op|
-          allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
-          allow(op).to receive(:data).and_return({})
+        instance_double(Acfs::Operation).tap do |op|
+          allow(op).to receive_messages(full_params: {id: 1337, blub: 'abc'}, data: {})
         end
       end
 
@@ -296,9 +295,8 @@ describe Acfs::Stub do
 
     context 'with a match in data' do
       let(:op) do
-        instance_double('Acfs::Operation').tap do |op|
-          allow(op).to receive(:full_params).and_return({})
-          allow(op).to receive(:data).and_return(id: 1337, blub: 'abc')
+        instance_double(Acfs::Operation).tap do |op|
+          allow(op).to receive_messages(full_params: {}, data: {id: 1337, blub: 'abc'})
         end
       end
 
@@ -309,9 +307,8 @@ describe Acfs::Stub do
 
     context 'with no match in params nor data' do
       let(:op) do
-        instance_double('Acfs::Operation').tap do |op|
-          allow(op).to receive(:full_params).and_return(id: 1337)
-          allow(op).to receive(:data).and_return({})
+        instance_double(Acfs::Operation).tap do |op|
+          allow(op).to receive_messages(full_params: {id: 1337}, data: {})
         end
       end
 
@@ -322,9 +319,8 @@ describe Acfs::Stub do
 
     context 'with a wrong match' do
       let(:op) do
-        instance_double('Acfs::Operation').tap do |op|
-          allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
-          allow(op).to receive(:data).and_return({})
+        instance_double(Acfs::Operation).tap do |op|
+          allow(op).to receive_messages(full_params: {id: 1337, blub: 'abc'}, data: {})
         end
       end
 
@@ -335,9 +331,8 @@ describe Acfs::Stub do
 
     context 'with a missing match' do
       let(:op) do
-        instance_double('Acfs::Operation').tap do |op|
-          allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
-          allow(op).to receive(:data).and_return({})
+        instance_double(Acfs::Operation).tap do |op|
+          allow(op).to receive_messages(full_params: {id: 1337, blub: 'abc'}, data: {})
         end
       end
 

data/spec/acfs_spec.rb

@@ -77,12 +77,12 @@ describe 'Acfs' do
       stub = stub_request(:post, 'http://users.example.org/singles').to_return response(score: 250, user_id: 5)
 
       single = Single.new user_id: 5, score: 250
-      expect(single.new?).to eq true
+      expect(single.new?).to be true
 
       single.save
       expect(stub).to have_been_requested
 
-      expect(single.new?).to eq false
+      expect(single.new?).to be false
       expect(single.user_id).to eq 5
       expect(single.score).to eq 250
     end
@@ -126,7 +126,7 @@ describe 'Acfs' do
       single = Single.find user_id: 5
       Acfs.run
 
-      expect(single.new?).to eq false
+      expect(single.new?).to be false
 
       single.delete
 
@@ -134,7 +134,7 @@ describe 'Acfs' do
     end
 
     it 'raises error when calling .all' do
-      expect { Single.all }.to raise_error ::Acfs::UnsupportedOperation
+      expect { Single.all }.to raise_error Acfs::UnsupportedOperation
     end
   end
 

data/spec/spec_helper.rb

@@ -4,21 +4,23 @@ require 'rspec'
 require 'webmock/rspec'
 
 require 'simplecov'
+require 'simplecov-cobertura'
+
 SimpleCov.start do
   add_filter 'spec'
 end
 
-if ENV['CI']
-  require 'codecov'
-  SimpleCov.formatter = SimpleCov::Formatter::Codecov
-end
+SimpleCov.formatters = [
+  SimpleCov::Formatter::HTMLFormatter,
+  SimpleCov::Formatter::CoberturaFormatter,
+]
 
 require 'bundler'
 Bundler.require(:default, :test)
 
 require 'acfs'
 
-Dir[File.expand_path('spec/support/**/*.rb')].sort.each {|f| require f }
+Dir[File.expand_path('spec/support/**/*.rb')].each {|f| require f }
 
 RSpec.configure do |config|
   # ## Mock Framework
@@ -35,6 +37,8 @@ RSpec.configure do |config|
   #     --seed 1234
   config.order = 'random'
 
+  config.raise_errors_for_deprecations!
+
   config.before do
     Acfs.runner.clear
     Acfs::Stub.clear

data/spec/support/hash.rb

@@ -3,7 +3,7 @@
 class ActiveSupport::HashWithIndifferentAccess
   def ==(other)
     if other.respond_to? :with_indifferent_access
-      super other.with_indifferent_access
+      super(other.with_indifferent_access)
     else
       super
     end

data/vendor/bundle/ruby/3.4.0/bundler/gems/rubocop-config-67802c9d1826/LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2020 Jan Graichen
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/vendor/bundle/ruby/3.4.0/bundler/gems/rubocop-config-67802c9d1826/README.md

@@ -0,0 +1,23 @@
+# Shared Rubocop Configuration
+
+Shared rubocop configuration and defaults for my libraries and projects.
+
+## Usage
+
+```ruby
+# Gemfile
+
+gem 'rubocop-config', github: 'jgraichen/rubocop-config', ref: 'v11', require: false
+```
+
+```yaml
+# .rubocop.yml
+
+inherit_gem:
+  rubocop-config: default.yml
+
+AllCops:
+  TargetRubyVersion: 2.7
+  SuggestExtensions: False
+  NewCops: enable
+```

data/vendor/bundle/ruby/3.4.0/bundler/gems/rubocop-config-67802c9d1826/rubocop-config.gemspec

@@ -0,0 +1,31 @@
+# -*- encoding: utf-8 -*-
+# stub: rubocop-config 13.0.0 ruby lib
+
+Gem::Specification.new do |s|
+  s.name = "rubocop-config".freeze
+  s.version = "13.0.0".freeze
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.metadata = { "allowed_push_host" => ".", "rubygems_mfa_required" => "true" } if s.respond_to? :metadata=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Jan Graichen".freeze]
+  s.date = "2025-01-17"
+  s.email = ["jgraichen@altimos.de".freeze]
+  s.files = ["LICENSE".freeze, "README.md".freeze, "default.yml".freeze]
+  s.homepage = "https://github.com/jgraichen/rubocop-config".freeze
+  s.licenses = ["MIT".freeze]
+  s.required_ruby_version = Gem::Requirement.new(">= 2.7.0".freeze)
+  s.rubygems_version = "3.6.2".freeze
+  s.summary = "Shared rubocop config".freeze
+
+  s.installed_by_version = "3.6.2".freeze
+
+  s.specification_version = 4
+
+  s.add_runtime_dependency(%q<rubocop>.freeze, ["~> 1.70.0".freeze])
+  s.add_runtime_dependency(%q<rubocop-capybara>.freeze, ["~> 2.21.0".freeze])
+  s.add_runtime_dependency(%q<rubocop-factory_bot>.freeze, ["~> 2.26.1".freeze])
+  s.add_runtime_dependency(%q<rubocop-performance>.freeze, ["~> 1.23.0".freeze])
+  s.add_runtime_dependency(%q<rubocop-rspec>.freeze, ["~> 3.3.0".freeze])
+  s.add_runtime_dependency(%q<rubocop-rspec_rails>.freeze, ["~> 2.30.0".freeze])
+end