acfs 0.43.0 → 0.43.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f1766a2689f9c913392aa1043fe386ecef50182
-  data.tar.gz: de21e2406b4178106c085594630a24fe6a591f99
+  metadata.gz: b273e1b3c19b7b27fdbea33867f442ec33ada319
+  data.tar.gz: cd853ac93c6276d23cae140d860bf563ba62159b
 SHA512:
-  metadata.gz: fb2415918968e9bc642a3d4762acbfa3a4fb9222beb16b4f1eafe138a2aeb9e53dedcd7789b14908aff2428eb6948a800f3ebe59e138fef3e5aed03d089b775f
-  data.tar.gz: 57ac583c1f24ff0f1c12e9d4041496e96476675c8be3d60ace5d98c1f0cec270d6419d9edf7eff533c5e218db689368a4ee92ac58172370c8f12a27b9b754c5b
+  metadata.gz: a73b486b0685757f0f5495f9cd358978a6702f78805c5ceeb354aa3e7da086bdae2b4fe0f11a664cb8c1ed753aeb50b7a9bfe4f2cac47b14241f33f883d31ba2
+  data.tar.gz: 088703ae6692aab3666106c6bd3afcdda44fa37676e4351842e32a1b1777a29fff31daf1b2f0c05c03fe0a6d85d12058aedd87a17710530a28c30b117231c8b6

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.43.1
+
+* Fix `:with` condition matching on stubs
+
 ## 0.43.0
 
 * Remove `Acfs::Model` (inherit from `Acfs::Resource`)

data/lib/acfs/stub.rb

@@ -32,8 +32,8 @@ module Acfs
           return true if with.reject {|_, v| v.nil? } == data.reject {|_, v| v.nil? }
           false
         when :inclusion
-          !with.each_pair.any? do |k, v|
-            (params.key?(k) && params[k] != v) || (data.key?(k) && data[k] != v)
+          with.each_pair.all? do |k, v|
+            (params.key?(k) && params[k] == v) || (data.key?(k) && data[k] == v)
           end
       end
     end

data/lib/acfs/version.rb

@@ -2,7 +2,7 @@ module Acfs
   module VERSION
     MAJOR = 0
     MINOR = 43
-    PATCH = 0
+    PATCH = 1
     STAGE = nil
 
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.')

data/spec/acfs/stub_spec.rb

@@ -265,4 +265,73 @@ describe Acfs::Stub do
       end
     end
   end
+
+  describe 'accept?' do
+    subject { stub.accept?(op) }
+
+    context 'with a match in params' do
+      let(:op) do
+        double('operation').tap do |op|
+          allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
+          allow(op).to receive(:data).and_return({})
+        end
+      end
+
+      let(:stub) { Acfs::Stub.resource MyUser, :read, with: {id: 1337} }
+
+      it { is_expected.to be true }
+    end
+
+    context 'with a match in data' do
+      let(:op) do
+        double('operation').tap do |op|
+          allow(op).to receive(:full_params).and_return({})
+          allow(op).to receive(:data).and_return(id: 1337, blub: 'abc')
+        end
+      end
+
+      let(:stub) { Acfs::Stub.resource MyUser, :read, with: {id: 1337} }
+
+      it { is_expected.to be true }
+    end
+
+    context 'with no match in params nor data' do
+      let(:op) do
+        double('operation').tap do |op|
+          allow(op).to receive(:full_params).and_return(id: 1337)
+          allow(op).to receive(:data).and_return({})
+        end
+      end
+
+      let(:stub) { Acfs::Stub.resource MyUser, :read, with: {abc: '123'} }
+
+      it { is_expected.to be false }
+    end
+
+    context 'with a wrong match' do
+      let(:op) do
+        double('operation').tap do |op|
+          allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
+          allow(op).to receive(:data).and_return({})
+        end
+      end
+
+      let(:stub) { Acfs::Stub.resource MyUser, :read, with: {id: 1337, blub: '123'} }
+
+      it { is_expected.to be false }
+    end
+
+    context 'with a missing match' do
+      let(:op) do
+        double('operation').tap do |op|
+          allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
+          allow(op).to receive(:data).and_return({})
+        end
+      end
+
+      let(:stub) { Acfs::Stub.resource MyUser, :read, with: {id: 1337, answer: 42} }
+
+      it { is_expected.to be false }
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acfs
 version: !ruby/object:Gem::Version
-  version: 0.43.0
+  version: 0.43.1
 platform: ruby
 authors:
 - Jan Graichen