acfs 0.23.1 → 0.23.2.b199

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 86289d5859ba20599d5eb05d95bcbb71e6e7926b
-  data.tar.gz: daa9e0ca7cba3c8f118b5a5530cd31a6c448bc46
-SHA512:
-  metadata.gz: 5e95b2353c13accec3a77b1d479d104df74e8b055bc146b852dd8c2e0a0bc7707eb6ca268e6ef1c6a3816da1a24047ef1e1207ff5af324df74b8e3deb32ff814
-  data.tar.gz: 6daa523f2762ab2fe320da616263ddc9ed286815720f461efff5a5f44558258cda2c95e96a50bd51a7d6344c604a68347d015142bc6d4f25c6709caefd598a3c
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    MjA0OGFmMDhhMGZhMDY5Zjc0YmEzNzNhMDg5MDA2MThjOGUzZTg5ZA==
+  data.tar.gz: !binary |-
+    OWNhYzY2MzM1YjQ1YmVkNzY0ODg5OTcyZjA5NTdjYjBkZTY0YjZmYw==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    NjU4ZTllOWQ4MmE4ZDM2YjA2YTFhMjA3NGM5ZmY1ZGM4NDY1NTBjNTFhMTcx
+    ZGI3YTNhMmM2OTc3NDYwOTEwZjI4YzNkMjEwMWY1NDc1NjdkYmYyNjJjZTU1
+    ZDgzNmRjOWU1NTkyZGM0M2YyOWRkZDY2YTQwNDUzY2M1ZDAzNzk=
+  data.tar.gz: !binary |-
+    NWExMGY4MjIzZGMyNzQyMjk4ZmM4NzkxOGJlZGY4MWIzZDE5NzE0YTQ4YWVh
+    NThjN2JkMTA4MTdhNmFmZGM5ZWJmYzJkMTljZTg4ZmNkOGFjNGFmMTUxZWEx
+    MDI1YzZiMjIxYWE4YjUxMTE2NGM0MjJmNjY2NjY0NzAyZGJhOWY=

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 0.23.2
+
+* Fix regression in delegator usage by #find due to resource type inheritance.
+
+## 0.23.1
+
+* Fix error class name typo
+
+## 0.23.0
+
+* Add Resource Type Inheritance
+
 ## 0.22.2
 
 * Preserve errors received from service on revalidation (2f1fc178)

data/lib/acfs/model/query_methods.rb

@@ -86,9 +86,14 @@ module Acfs::Model
       end
       alias :where :all
 
+      # TODO: Replace delegator with promise or future for the long run.
+      class ResourceDelegator < SimpleDelegator
+        delegate :class, :is_a?, :kind_of?, to: :__getobj__
+      end
+
       private
       def find_single(id, opts, &block)
-        model = SimpleDelegator.new self.new
+        model = ResourceDelegator.new self.new
 
         opts[:params] ||= {}
         opts[:params].merge!({ id: id })

data/lib/acfs/version.rb

@@ -2,7 +2,7 @@ module Acfs
   module VERSION
     MAJOR = 0
     MINOR = 23
-    PATCH = 1
+    PATCH = 2
     STAGE = nil
 
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.')

data/spec/acfs/model/query_methods_spec.rb

@@ -8,6 +8,7 @@ describe Acfs::Model::QueryMethods do
       context 'with successful response' do
         before do
           stub_request(:get, 'http://users.example.org/users/1').to_return response({ id: 1, name: 'Anon', age: 12 })
+          stub_request(:get, 'http://users.example.org/users/2').to_return response({ id: 2, type: 'Customer', name: 'Clare Customer', age: 24 })
         end
 
         it 'should load a single remote resource' do
@@ -20,13 +21,28 @@ describe Acfs::Model::QueryMethods do
         it 'should invoke callback after model is loaded' do
           proc = Proc.new { }
           proc.should_receive(:call) do |user|
-            expect(user.__getobj__).to equal @user.__getobj__
+            expect(user).to equal @user
             expect(user).to be_loaded
           end
 
           @user = model.find 1, &proc
           Acfs.run
         end
+
+        context 'with resource type inheritance' do
+          let!(:user) { MyUser.find 2 }
+          subject { user }
+          before { Acfs.run }
+
+          it 'should respect resource type inheritance' do
+            expect(subject).to be_a Customer
+          end
+
+          it 'should implement ActiveModel class interface' do
+            expect(subject.class).to be_a ActiveModel::Naming
+            expect(subject.class).to be_a ActiveModel::Translation
+          end
+        end
       end
 
       context 'with 404 response' do
@@ -62,6 +78,8 @@ describe Acfs::Model::QueryMethods do
       before do
         stub_request(:get, 'http://users.example.org/users/1').to_return response({ id: 1, name: 'Anon', age: 12 })
         stub_request(:get, 'http://users.example.org/users/2').to_return response({ id: 2, name: 'Johnny', age: 42 })
+        stub_request(:get, 'http://users.example.org/users/3').to_return response({ id: 3, type: 'Customer', name: 'Anon', age: 12 })
+        stub_request(:get, 'http://users.example.org/users/4').to_return response({ id: 4, name: 'Johnny', age: 42 })
       end
 
       context 'with successful response' do
@@ -85,6 +103,14 @@ describe Acfs::Model::QueryMethods do
           @users = model.find 1, 2, &proc
           Acfs.run
         end
+
+        it 'should respect resource type inheritance' do
+          customers = MyUser.find 3, 4
+          Acfs.run
+
+          expect(customers[0]).to be_a Customer
+          expect(customers[1]).to be_a MyUser
+        end
       end
 
       context 'with one 404 response' do

data/spec/support/service.rb

@@ -25,7 +25,7 @@ class MyUser < Acfs::Resource
   attribute :age, :integer
 end
 
-class MyUserInherited < MyUser
+class Customer < MyUser
 
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acfs
 version: !ruby/object:Gem::Version
-  version: 0.23.1
+  version: 0.23.2.b199
 platform: ruby
 authors:
 - Jan Graichen
@@ -14,84 +14,84 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -212,14 +212,14 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.0.3
@@ -253,4 +253,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/response.rb
 - spec/support/service.rb
-has_rdoc: