ace-task 0.39.2 → 0.39.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 425d8beebe8b18f6d816767d85d9f1b0a29c68a470b8c6cf4590629b2028bddd
-  data.tar.gz: a28fc844b081cc3f9b969e2ab15a674df2dca08bb30fc48cd90b1741d3024663
+  metadata.gz: bf3a2b4bdbf7c413363c5f9b81a0f0b4161e6b50e58cce724adcb67ba03fc1c2
+  data.tar.gz: b08a3d0f30ad8dfb455c6232bde690e632a9028a603ac37fa289a4768c2f0312
 SHA512:
-  metadata.gz: c2be6996b2753ec7ff709cba139a8533e2b746186e7ba3c29b26e51d9361d163e99a022bc5c05a39db372e71ee5a843c64f4f06fbe5b66298e7488b922da27d5
-  data.tar.gz: b976035a868e0d4d433b956d41520d5b7a2670aff609754bd975797a6bc6a0417ca1e3fe364d429c65dfe9edfc8c4e9609ad20accfb0db4f2743c8b26ec304a5
+  metadata.gz: ea63fb03267e6eb84875128ff0ec56becc9fbc0a650a40344cf9a1b11090a61791eed9c97a203ce8a231b132534d442d0238d93cac07162ecd96f522cdd930be
+  data.tar.gz: 2be684d6224ec2a57dc9cc4f84eafdee43c14e1b044116e470f12b51dd1cab952267ff9b4a05d96f6e2df5eb4ef1b10d0bd52e32a31e53275a8cdca7e43b0626

data/CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.39.3] - 2026-10-12
+
+### Fixed
+
+- Route `ace-task create --in FOLDER` through the task manager's relocation API
+  and remove the newly created task artifacts when destination placement fails.
+
 ## [0.39.2] - 2026-10-06
 
 ### Fixed

data/lib/ace/task/cli/commands/create.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "ace/support/cli"
+require "fileutils"
 
 module Ace
   module Task
@@ -10,6 +11,9 @@ module Ace
         class Create < Ace::Support::Cli::Command
           include Ace::Support::Cli::Base
 
+          # "next" is a move-to-root alias and is validated separately.
+          BUILT_IN_DESTINATIONS = %w[maybe anytime archive].freeze
+
           desc <<~DESC.strip
             Create a new task
 
@@ -38,7 +42,8 @@ module Ace
           option :server, type: :string, desc: "Named forge server"
           option :"default-server", type: :boolean, desc: "Use the configured default forge server"
           option :"child-of", type: :string, desc: "Parent task reference (creates subtask)"
-          option :in, type: :string, aliases: %w[-i], desc: "Target folder (e.g. next, maybe)"
+          option :in, type: :string, aliases: %w[-i],
+            desc: "Top-level target (next, maybe, anytime, archive, or existing custom folder)"
           option :"dry-run", type: :boolean, aliases: %w[-n], desc: "Preview without writing"
 
           option :git_commit, type: :boolean, aliases: %w[--gc], desc: "Auto-commit changes"
@@ -72,6 +77,10 @@ module Ace
               end
             end
 
+            manager = Ace::Task::Organisms::TaskManager.new
+            validate_destination!(manager, in_folder) if in_folder && !child_of
+            placement_directories_before = directories_under(manager.root_dir) if in_folder && !child_of
+
             if dry_run
               puts "Would create task:"
               puts "  Title:    #{title}"
@@ -85,8 +94,6 @@ module Ace
               return
             end
 
-            manager = Ace::Task::Organisms::TaskManager.new
-
             task = begin
               if child_of
                 manager.create_subtask(
@@ -119,7 +126,7 @@ module Ace
 
             # Move to folder if specified
             if in_folder && !child_of
-              task = manager.move(task.id, to: in_folder)
+              task = place_created_task(manager, task, in_folder, placement_directories_before)
             end
 
             puts "Created task #{task.id}"
@@ -140,6 +147,117 @@ module Ace
 
           private
 
+          def validate_destination!(manager, target_folder)
+            detector = Ace::Support::Items::Atoms::SpecialFolderDetector
+            return if detector.move_to_root?(target_folder)
+
+            if detector.virtual_filter?(target_folder)
+              raise Ace::Support::Cli::Error,
+                "Destination '#{target_folder}' is a virtual list filter, not a physical folder."
+            end
+
+            normalized = detector.normalize(target_folder)
+            configured_path = File.join(manager.root_dir, normalized)
+            normalized_built_ins = BUILT_IN_DESTINATIONS.map { |name| detector.normalize(name) }
+            valid = !target_folder.strip.empty? &&
+              !normalized.include?(File::SEPARATOR) &&
+              !normalized.include?("..") &&
+              (normalized_built_ins.include?(normalized) || Dir.exist?(configured_path)) &&
+              destination_within_root?(manager.root_dir, configured_path)
+            return if valid
+
+            choices = (["next"] + BUILT_IN_DESTINATIONS).join(", ")
+            raise Ace::Support::Cli::Error,
+              "Destination '#{target_folder}' does not exist. " \
+                "Use #{choices}, or an existing custom task folder."
+          end
+
+          def destination_within_root?(root, destination)
+            return true unless File.exist?(destination)
+
+            root_path = File.realpath(root)
+            destination_path = File.realpath(destination)
+            destination_path.start_with?(root_path + File::SEPARATOR)
+          rescue Errno::ENOENT, Errno::EACCES
+            false
+          end
+
+          def place_created_task(manager, task, target_folder, directories_before)
+            placed_task = manager.update(task.id, move_to: target_folder)
+            expected_folder = if Ace::Support::Items::Atoms::SpecialFolderDetector.move_to_root?(target_folder)
+              nil
+            else
+              Ace::Support::Items::Atoms::SpecialFolderDetector.normalize(target_folder)
+            end
+
+            unless placed_task && placed_task.special_folder == expected_folder
+              actual_folder = if placed_task
+                placed_task.special_folder || "root"
+              else
+                "no task returned"
+              end
+              # This internal signal is wrapped below with rollback and an actionable CLI error.
+              raise "placement returned #{actual_folder.inspect}, expected #{expected_folder || "root"}"
+            end
+
+            placed_task
+          rescue Ace::Git::Error
+            # update retains linked tasks after post-placement sync failures as
+            # recovery records; those are not destination-placement failures.
+            raise
+          rescue StandardError => e
+            begin
+              remove_created_task_artifacts(manager, task)
+              remove_empty_directories_created_since(manager.root_dir, directories_before)
+            rescue StandardError => cleanup_error
+              raise Ace::Support::Cli::Error,
+                "Failed to create task in '#{target_folder}': #{e.message}. " \
+                  "Cleanup also failed: #{cleanup_error.message}"
+            end
+            raise Ace::Support::Cli::Error,
+              "Failed to create task in '#{target_folder}': #{e.message}. " \
+                "No task was created; fix the destination and retry."
+          end
+
+          def remove_created_task_artifacts(manager, task)
+            root = File.expand_path(manager.root_dir)
+            candidates = [task.path]
+            candidates.concat(
+              Dir.glob(File.join(root, "**", "#{task.id}-*")).select { |path| File.directory?(path) }
+            )
+
+            candidates.uniq.each do |path|
+              expanded = File.expand_path(path)
+              next unless expanded.start_with?(root + File::SEPARATOR)
+
+              FileUtils.rm_rf(expanded)
+            end
+
+            remaining = Dir.glob(File.join(root, "**", "#{task.id}-*")).select { |path| File.exist?(path) }
+            return if remaining.empty?
+
+            raise Ace::Support::Cli::Error,
+              "Failed to remove partial task artifacts after placement failure: #{remaining.join(", ")}"
+          end
+
+          def directories_under(root)
+            return [] unless Dir.exist?(root)
+
+            [File.expand_path(root)] + Dir.glob(File.join(root, "**", "*"))
+              .select { |path| File.directory?(path) }
+              .map { |path| File.expand_path(path) }
+          end
+
+          def remove_empty_directories_created_since(root, directories_before)
+            # Only directories created during this short command transaction
+            # are candidates, and non-empty concurrent directories are retained.
+            (directories_under(root) - directories_before).sort_by(&:length).reverse_each do |path|
+              Dir.rmdir(path)
+            rescue Errno::ENOENT, Errno::ENOTEMPTY
+              next
+            end
+          end
+
           def resolve_title(positional_title, flag_title)
             positional_present = present_string?(positional_title)
             flag_present = present_string?(flag_title)

data/lib/ace/task/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Task
-    VERSION = "0.39.2"
+    VERSION = "0.39.3"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-task
 version: !ruby/object:Gem::Version
-  version: 0.39.2
+  version: 0.39.3
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-10-08 00:00:00.000000000 Z
+date: 2026-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-support-core