ace-task 0.39.1 → 0.39.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f78511a98128a2afd0cfd4d2120939912d8bc3ccc8865b3c40a032cff50fa6fd
-  data.tar.gz: ca39e7634c9e5276e546f4bb333b7920babfcc00f3e62675755f128b4c0f92e2
+  metadata.gz: 425d8beebe8b18f6d816767d85d9f1b0a29c68a470b8c6cf4590629b2028bddd
+  data.tar.gz: a28fc844b081cc3f9b969e2ab15a674df2dca08bb30fc48cd90b1741d3024663
 SHA512:
-  metadata.gz: 69e57555803c7a2a9196559675bc1cf532955286e3704643bf1420c7484a525f41d9a1c7435e20349983ec70bcf0116d82bbd8fbfa49455cabf3fa57c86ea194
-  data.tar.gz: d6a7abcf1878a0799d0c34f195069f61b8ac20700700e0c82e83fa8cafe1beddde4141d3d374815f7bcb4b1ee01bac8453f7ddae66791c38e607cb7b01bef7bd
+  metadata.gz: c2be6996b2753ec7ff709cba139a8533e2b746186e7ba3c29b26e51d9361d163e99a022bc5c05a39db372e71ee5a843c64f4f06fbe5b66298e7488b922da27d5
+  data.tar.gz: b976035a868e0d4d433b956d41520d5b7a2670aff609754bd975797a6bc6a0417ca1e3fe364d429c65dfe9edfc8c4e9609ad20accfb0db4f2743c8b26ec304a5

data/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.39.2] - 2026-10-06
+
+### Fixed
+
+- Keep unresolved descendants from completing or archiving task families, return children correctly after legitimate archival, and prevent doctor from inferring completion from archive location.
+
 ## [0.39.1] - 2026-10-04
 
 ### Fixed

data/handbook/workflow-instructions/task/work.wf.md

@@ -74,6 +74,13 @@ Work through the plan checklist, step by step:
 - If a test fails: fix it before moving to the next step
 - If a test failure is undiagnosable after one attempt: stop and report
 
+**Diagnostic reruns and contract corrections:**
+- Before rerunning a failure, state the hypothesis and the observation that will distinguish it. Verify the runner's actual selected tests/count, effective configuration path and seed from its report or a narrow configuration probe; command arguments alone are not proof that options reached the child.
+- Resolve configuration against the runner's actual working directory. If it changes directories, use a verified absolute path. A reproduction with a different seed or zero selected tests does not satisfy the intended check.
+- Add bounded diagnostics at the failing boundary before repeating an opaque failure. Preserve earlier failures and distinguish product fixes, fixture corrections and diagnostic-only changes; do not rerun merely to obtain green output or silently increase deadlines.
+- Poll an owned live test handle to its terminal result. Quiet output is not a reason to start a duplicate run. After a meaningful fix or new hypothesis, rerun only the affected checks, then broaden when integration risk requires it.
+- When a contract changes, revise its current authoritative spec and consumer obligations together. Keep superseded decisions in history rather than leaving competing current addenda. A partial source commit cannot close an unverified acceptance criterion.
+
 **Task lifecycle:**
 - `draft` status: warn the user that the spec hasn't been reviewed, then continue only with explicit confirmation. In unattended/fork contexts where interactive confirmation is not possible, proceed after marking in-progress -- the assignment creation layer is responsible for blocking draft tasks before they reach this point.
 - Mark in-progress before first change, done after last verification

data/lib/ace/task/molecules/task_doctor_fixer.rb

@@ -8,6 +8,7 @@ require_relative "../atoms/task_id_formatter"
 require_relative "../atoms/task_validation_rules"
 require_relative "../atoms/task_frontmatter_defaults"
 require_relative "task_scanner"
+require_relative "task_family_completion"
 
 module Ace
   module Task
@@ -218,7 +219,9 @@ module Ace
         end
 
         def fix_archive_status(file_path)
-          update_frontmatter_field(file_path, "status", "done", "Updated status to 'done' (in _archive/)")
+          log_fix(file_path, "Skipped status repair: archive location does not prove task completion")
+          @skipped_count += 1
+          false
         end
 
         def fix_maybe_terminal(file_path)
@@ -456,6 +459,16 @@ module Ace
             description = "Moved parent task to _archive/ (all subtasks terminal)"
           end
 
+          source_spec = find_primary_spec(source_dir)
+          source_frontmatter, = Ace::Support::Items::Atoms::FrontmatterParser.parse(File.read(source_spec))
+          unless TaskFamilyCompletion.new(@root_dir).descendants_terminal?(
+            source_dir, id: source_frontmatter["id"]
+          )
+            log_fix(source_dir, "Skipped archive move: descendants are not all terminal")
+            @skipped_count += 1
+            return false
+          end
+
           if @dry_run
             log_fix(source_dir, "Would #{description.downcase}")
             @fixed_count += 1
@@ -493,16 +506,7 @@ module Ace
         end
 
         def all_siblings_terminal?(parent_dir, parent_id)
-          scanner = TaskScanner.new(@root_dir)
-          subtasks = scanner.scan_subtasks(parent_dir, parent_id: parent_id)
-          return false if subtasks.empty?
-
-          subtasks.all? do |scan_result|
-            content = File.read(scan_result.file_path)
-            frontmatter, _body = Ace::Support::Items::Atoms::FrontmatterParser.parse(content)
-            status = frontmatter.is_a?(Hash) ? frontmatter["status"] : nil
-            Atoms::TaskValidationRules.terminal_status?(status.to_s.downcase)
-          end
+          TaskFamilyCompletion.new(@root_dir).complete?(parent_dir, id: parent_id)
         end
       end
     end

data/lib/ace/task/molecules/task_family_completion.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require_relative "task_scanner"
+require_relative "../atoms/task_validation_rules"
+
+module Ace
+  module Task
+    module Molecules
+      # Task-aware traversal excludes evidence folders and the parent's own status.
+      class TaskFamilyCompletion
+        def initialize(root_dir)
+          @scanner = TaskScanner.new(root_dir)
+        end
+
+        def descendants_terminal?(path, id:)
+          @scanner.scan_subtasks(path, parent_id: id).all? do |child|
+            content = File.read(child.file_path)
+            frontmatter, = Ace::Support::Items::Atoms::FrontmatterParser.parse(content)
+            Atoms::TaskValidationRules.terminal_status?(frontmatter["status"].to_s.downcase) &&
+              descendants_terminal?(child.dir_path, id: child.id)
+          end
+        end
+
+        def complete?(path, id:)
+          @scanner.scan_subtasks(path, parent_id: id).any? && descendants_terminal?(path, id: id)
+        end
+      end
+    end
+  end
+end

data/lib/ace/task/organisms/task_manager.rb

@@ -9,6 +9,7 @@ require_relative "../molecules/task_resolver"
 require_relative "../molecules/task_loader"
 require_relative "../molecules/task_creator"
 require_relative "../molecules/subtask_creator"
+require_relative "../molecules/task_family_completion"
 require_relative "../molecules/task_reparenter"
 require_relative "../molecules/issue_link"
 require_relative "../atoms/task_validation_rules"
@@ -190,6 +191,13 @@ module Ace
             special_folder: scan_result.special_folder)
           return nil unless task
 
+          if Ace::Support::Items::Atoms::SpecialFolderDetector.normalize(move_to) == "_archive" &&
+              !task.subtask? && !family_completion.descendants_terminal?(task.path, id: task.id)
+            @last_update_note = "Task #{task.id} was not archived because descendants are not all terminal; " \
+              "resolve blocked or unfinished subtasks before archiving. No requested fields were changed."
+            return task
+          end
+
           # Apply field updates if any
           has_field_updates = [set, add, remove].any? { |h| h && !h.empty? }
           reject_issue_metadata_update!(set, add, remove)
@@ -258,11 +266,11 @@ module Ace
           # Auto-archive hook: if a subtask status was set to terminal,
           # check if all siblings are terminal and auto-move parent to archive
           if set && set.key?("status")
-            check_auto_archive(task, set["status"], loader)
+            check_auto_archive(task, set["status"])
           end
 
           # Reload and return updated task
-          updated_task = loader.load(current_path, id: current_id, special_folder: current_special)
+          updated_task = show(current_id)
           if sync_needed_after_update?(task, updated_task, set: set, add: add, remove: remove, move_to: move_to)
             sync_failed_definitively = false
             with_issue_identity_lock(linked_issue(updated_task) || {}) do
@@ -847,25 +855,23 @@ module Ace
 
         # Auto-archive: if a subtask reaches terminal status and all siblings
         # in the parent directory are also terminal, move the parent to archive.
-        def check_auto_archive(task, new_status, loader)
-          terminal = Ace::Support::Items::Atoms::FolderCompletionDetector::TERMINAL_STATUSES
-          return unless terminal.include?(new_status.to_s.downcase)
+        def check_auto_archive(task, new_status)
+          return unless Atoms::TaskValidationRules.terminal_status?(new_status.to_s.downcase)
+          return unless task.subtask?
 
-          # Only applies to subtasks (task dir is nested inside a parent dir)
-          parent_dir = File.dirname(task.path)
-          return if File.expand_path(parent_dir) == File.expand_path(@root_dir)
+          current = show(task.id)
+          return unless current && current.special_folder != "_archive"
 
-          # Check if all specs in the parent dir (recursive for subtask subdirs) are terminal
-          return unless Ace::Support::Items::Atoms::FolderCompletionDetector.all_terminal?(
-            parent_dir, recursive: true
-          )
-
-          parent = load_parent_from_directory(parent_dir, loader)
-          return unless parent
+          parent = show(current.parent_id)
+          return unless parent && family_completion.complete?(parent.path, id: parent.id)
 
           archive_parent_via_update(parent)
         end
 
+        def family_completion
+          Molecules::TaskFamilyCompletion.new(@root_dir)
+        end
+
         def parse_archive_date(task)
           raw = task.metadata["completed_at"] || task.metadata["created_at"]
           return nil unless raw
@@ -897,10 +903,7 @@ module Ace
             }
           end
 
-          parent_with_subtasks = loader.load(parent.path, id: parent.id, special_folder: parent.special_folder)
-          subtasks = parent_with_subtasks&.subtasks || []
-          all_terminal = subtasks.any? &&
-            subtasks.all? { |st| Atoms::TaskValidationRules.terminal_status?(st.status.to_s.downcase) }
+          all_terminal = family_completion.complete?(parent.path, id: parent.id)
 
           unless all_terminal
             @last_update_note = "Subtask #{task.id} was not archived because sibling subtasks are not all terminal."
@@ -941,16 +944,6 @@ module Ace
           archived_parent
         end
 
-        def load_parent_from_directory(parent_dir, loader)
-          parent_id = File.basename(parent_dir).split("-", 2).first
-          return nil unless parent_id
-
-          parent_special = Ace::Support::Items::Atoms::SpecialFolderDetector.detect_in_path(
-            parent_dir, root: @root_dir
-          )
-          loader.load(parent_dir, id: parent_id, special_folder: parent_special)
-        end
-
         # Value accessor for FilterApplier
         def task_value_accessor(item, key)
           case key

data/lib/ace/task/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Task
-    VERSION = "0.39.1"
+    VERSION = "0.39.2"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-task
 version: !ruby/object:Gem::Version
-  version: 0.39.1
+  version: 0.39.2
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-10-03 00:00:00.000000000 Z
+date: 2026-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-support-core
@@ -204,6 +204,7 @@ files:
 - lib/ace/task/molecules/task_display_formatter.rb
 - lib/ace/task/molecules/task_doctor_fixer.rb
 - lib/ace/task/molecules/task_doctor_reporter.rb
+- lib/ace/task/molecules/task_family_completion.rb
 - lib/ace/task/molecules/task_frontmatter_validator.rb
 - lib/ace/task/molecules/task_loader.rb
 - lib/ace/task/molecules/task_plan_cache.rb