ace-support-test-helpers 0.14.5 → 0.14.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f964e2cbd1eb428c260e5190ddaefbef7905d1ee86e894cbcab9a2d2b985b628
-  data.tar.gz: 6b8e0b1f8c3e0e88638d99b8d4abaea0a8378262bbae3c3784ae519d5859ecc2
+  metadata.gz: 95c5242cb44820418bda5f2d031055e5adab6a3fd8e2cacb88810622e7776ff2
+  data.tar.gz: 9a55229cf434d2a61122be1dcd9595eafbb4af1c87afc8d9c79b5f6fcace82da
 SHA512:
-  metadata.gz: 8da847ee96be275ce048c97e55d3a0c6c659c2bf73ac472fbf4001fd3ca6eabc907658a2d2c333843f65dc059bb69b87cdec2ed1afa4965a8608ba4ccad5e174
-  data.tar.gz: 6f5b8c776f80d9a799e06c64cc0238cefc346fec2f98715e92767369f56e2222a24dc84c4ff1070dc210ba54b09f3244f751de978ef695b4839604a4ca3a276b
+  metadata.gz: 2c189fbce23a0c3544780011c88d73d81f269232b2062f6c025d920883cb6872404c8d25f523ed60016741a700c2d5499c2faf977971ab84c716282f60b48fc2
+  data.tar.gz: e4e67a4240c9a183f72191f14273ad88457dd99951c593484bf9e1d62633209dc45bd5238296c8c2b82e89e50ea420070fedc0a66771eeefb0d3644c044c53a3

data/CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.14.6] - 2026-09-28
+
 ## [0.14.5] - 2026-09-24
 
 ### Fixed

data/lib/ace/test_support/pull_request_lifecycle_contract.rb

@@ -0,0 +1,150 @@
+# frozen_string_literal: true
+
+module Ace
+  module TestSupport
+    # Shared PR-lifecycle contract parity suite.
+    #
+    # Provider packages include this module and supply scripted runners per
+    # symbolic scenario, proving identical normalized receipts, exact-identity
+    # matching, expected-head enforcement, idempotent create, unknown-outcome
+    # classification, and capability classification across every provider —
+    # with no network and no provider CLI.
+    #
+    # Host test class contract:
+    # - #build_provider(runner) -> Ace::Git::Providers::Base on the runner
+    # - #lifecycle_runner(scenario) -> scripted runner for the scenario
+    # - #ready_supported? [Boolean] provider can mark drafts ready
+    # - #merge_supported? [Boolean] provider enforces head atomically
+    module PullRequestLifecycleContract
+      SERVER_URL = "https://forge.example.com/owner/repo"
+      HEAD_SHA = "fc14c43d3660ac6c133959a6dec29603413f0e8a"
+      OTHER_SHA = "0123456789abcdef0123456789abcdef01234567"
+
+      IDENTITY = {
+        head_repository_url: SERVER_URL,
+        head_ref: "feature/x",
+        base_repository_url: SERVER_URL,
+        base_ref: "main"
+      }.freeze
+
+      # Create kwargs: the base repository is always the resolved server.
+      CREATE_IDENTITY = IDENTITY.except(:base_repository_url).freeze
+
+      def test_lifecycle_find_matches_exact_identity_with_provenance
+        prs = build_provider(lifecycle_runner(:find_single)).find_open_pull_requests(**IDENTITY)
+        assert_equal [25], prs.map(&:number)
+        pr = prs.first
+        assert_equal HEAD_SHA, pr.head_sha
+        assert_equal "feature/x", pr.head_ref
+        assert_equal "main", pr.base_ref
+        assert_equal SERVER_URL, pr.head_repository_url
+        assert_equal SERVER_URL, pr.base_repository_url
+      end
+
+      def test_lifecycle_create_proves_head_and_reports_created
+        provider = build_provider(lifecycle_runner(:create_new))
+        receipt = provider.create_pull_request(
+          **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+        )
+        assert_instance_of Ace::Git::ProviderMutationReceipt, receipt
+        assert_equal :create, receipt.operation
+        assert_equal :created, receipt.idempotency
+        assert_equal HEAD_SHA, receipt.pull_request.head_sha
+        assert_equal SERVER_URL, receipt.pull_request.base_repository_url
+        assert_equal HEAD_SHA, receipt.to_h.dig(:pull_request, :head_sha)
+      end
+
+      def test_lifecycle_create_reconciles_to_exact_open_match
+        receipt = build_provider(lifecycle_runner(:create_existing)).create_pull_request(
+          **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+        )
+        assert_equal :existing, receipt.idempotency
+        assert_equal 25, receipt.pull_request.number
+      end
+
+      def test_lifecycle_create_rejects_stale_expected_head_without_mutation
+        provider = build_provider(lifecycle_runner(:create_existing))
+        error = assert_raises(Ace::Git::ProviderExpectedHeadConflictError) do
+          provider.create_pull_request(
+            **CREATE_IDENTITY, expected_head: OTHER_SHA, title: "Ship it"
+          )
+        end
+        assert_match(/head changed|does not match/i, error.message)
+      end
+
+      def test_lifecycle_create_conflicts_on_multiple_exact_matches
+        provider = build_provider(lifecycle_runner(:find_multi))
+        error = assert_raises(Ace::Git::ProviderConflictingMatchesError) do
+          provider.create_pull_request(
+            **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+          )
+        end
+        assert_match(/match/i, error.message)
+      end
+
+      def test_lifecycle_create_reports_unknown_outcome_with_reconciliation_identity
+        provider = build_provider(lifecycle_runner(:create_unknown))
+        error = assert_raises(Ace::Git::ProviderUnknownOutcomeError) do
+          provider.create_pull_request(
+            **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+          )
+        end
+        assert_match(/reconcile by exact identity/i, error.message)
+        assert_match(%r{owner/repo}, error.message)
+      end
+
+      def test_lifecycle_update_enforces_expected_head
+        provider = build_provider(lifecycle_runner(:update_stale))
+        error = assert_raises(Ace::Git::ProviderExpectedHeadConflictError) do
+          provider.update_pull_request(number: 25, expected_head: OTHER_SHA, title: "New title")
+        end
+        assert_match(/head changed/i, error.message)
+
+        receipt = build_provider(lifecycle_runner(:update_ok))
+          .update_pull_request(number: 25, expected_head: HEAD_SHA, title: "New title")
+        assert_equal :update, receipt.operation
+        assert_equal HEAD_SHA, receipt.pull_request.head_sha
+      end
+
+      def test_lifecycle_ready_classifies_capability
+        provider = build_provider(lifecycle_runner(ready_supported? ? :ready_ok : :ready_unsupported))
+        if ready_supported?
+          receipt = provider.ready_pull_request(number: 25, expected_head: HEAD_SHA)
+          assert_equal :ready, receipt.operation
+        else
+          error = assert_raises(Ace::Git::ProviderUnsupportedCapabilityError) do
+            provider.ready_pull_request(number: 25, expected_head: HEAD_SHA)
+          end
+          assert_match(/ready|capab|support/i, error.message)
+        end
+      end
+
+      def test_lifecycle_merge_enforces_expected_head_atomically
+        provider = build_provider(lifecycle_runner(merge_supported? ? :merge_ok : :merge_unsupported))
+        if merge_supported?
+          receipt = provider.merge_pull_request(number: 25, expected_head: HEAD_SHA, method: :squash)
+          assert_equal :merge, receipt.operation
+          assert_equal HEAD_SHA, receipt.pull_request.head_sha
+
+          error = assert_raises(Ace::Git::ProviderExpectedHeadConflictError) do
+            build_provider(lifecycle_runner(:merge_stale))
+              .merge_pull_request(number: 25, expected_head: OTHER_SHA, method: :squash)
+          end
+          assert_match(/head|match/i, error.message)
+        else
+          error = assert_raises(Ace::Git::ProviderUnsupportedCapabilityError) do
+            provider.merge_pull_request(number: 25, expected_head: HEAD_SHA, method: :squash)
+          end
+          assert_match(/atomic|expected[- ]head|capab|support/i, error.message)
+        end
+      end
+
+      def test_lifecycle_merge_rejects_unknown_methods
+        provider = build_provider(lifecycle_runner(:find_single))
+        assert_raises(ArgumentError) do
+          provider.merge_pull_request(number: 25, expected_head: HEAD_SHA, method: :fast_forward)
+        end
+      end
+    end
+  end
+end

data/lib/ace/test_support/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module TestSupport
-    VERSION = "0.14.5"
+    VERSION = "0.14.6"
   end
 end

data/lib/ace/test_support.rb

@@ -22,6 +22,7 @@ require_relative "test_support/fixtures/http_mocks"  # Shared HTTP mocks for LLM
 require_relative "test_support/fixtures/prompt_helpers"  # Shared prompt stubbing helpers
 require_relative "test_support/fixtures/test_runner_mocks"  # Shared test runner mocks
 require_relative "test_support/provider_contract"  # Provider contract parity suite for forge provider gems
+require_relative "test_support/pull_request_lifecycle_contract"  # PR lifecycle contract parity suite
 
 # Configure Minitest reporters by default
 Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-support-test-helpers
 version: !ruby/object:Gem::Version
-  version: 0.14.5
+  version: 0.14.6
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-09-24 00:00:00.000000000 Z
+date: 2026-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -63,6 +63,7 @@ files:
 - lib/ace/test_support/fixtures/test_runner_mocks.rb
 - lib/ace/test_support/performance_helpers.rb
 - lib/ace/test_support/provider_contract.rb
+- lib/ace/test_support/pull_request_lifecycle_contract.rb
 - lib/ace/test_support/sandbox_package_copy.rb
 - lib/ace/test_support/subprocess_runner.rb
 - lib/ace/test_support/test_environment.rb