ace-support-test-helpers 0.14.4 → 0.14.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a629650c00f11a385af2702b706fad2a502e89d740000dfafa1fe465c0f63ffa
-  data.tar.gz: 4ffe9e7d64e66814e667431cde88f42ebfbc8ac449c3c7832f3083745ab19f46
+  metadata.gz: 95c5242cb44820418bda5f2d031055e5adab6a3fd8e2cacb88810622e7776ff2
+  data.tar.gz: 9a55229cf434d2a61122be1dcd9595eafbb4af1c87afc8d9c79b5f6fcace82da
 SHA512:
-  metadata.gz: ccf9bd44e4ba8dc9be6ea21df13afa27bd80baec31f295e61d4346cb670bd2e4905318e7c9b2fea092ca810e1b59a3f47080587efb6b25e1f4ac282e20b47701
-  data.tar.gz: e3448213c72aaacd1fa25aad4e061a9e4f22c0a0de0e8a0848da110f15af0a30e72f7f49408d419bd22413f27a3dd56d2971408aebc2ffb05979887fdd74e1ee
+  metadata.gz: 2c189fbce23a0c3544780011c88d73d81f269232b2062f6c025d920883cb6872404c8d25f523ed60016741a700c2d5499c2faf977971ab84c716282f60b48fc2
+  data.tar.gz: e4e67a4240c9a183f72191f14273ad88457dd99951c593484bf9e1d62633209dc45bd5238296c8c2b82e89e50ea420070fedc0a66771eeefb0d3644c044c53a3

data/CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.14.6] - 2026-09-28
+
+## [0.14.5] - 2026-09-24
+
+### Fixed
+
+- Accept bundle loader options in shared test mocks.
 
 ## [0.14.4] - 2026-09-02
 

data/lib/ace/test_support/fixtures/bundle_mocks.rb

@@ -152,7 +152,7 @@ module Ace
 
           original_method_holder[:load_file] = Ace::Bundle.method(:load_file) if Ace::Bundle.respond_to?(:load_file)
 
-          Ace::Bundle.define_singleton_method(:load_file) do |path|
+          Ace::Bundle.define_singleton_method(:load_file) do |path, _options = {}|
             BundleMocks.mock_load_file_result(path)
           end
 

data/lib/ace/test_support/provider_contract.rb

@@ -0,0 +1,173 @@
+# frozen_string_literal: true
+
+module Ace
+  module TestSupport
+    # Shared provider-contract parity suite.
+    #
+    # Provider packages (ace-git-github, ace-git-forgejo) include this module
+    # in a test class backed by a scripted fake command runner and assert that
+    # their implementation produces identical normalized evidence and the
+    # exact classified failure taxonomy. Identical assertions run against every
+    # provider, which proves contract parity without any network or CLI.
+    #
+    # Host test class contract:
+    # - #build_provider(runner) -> Ace::Git::Providers::Base wired to the runner
+    # - #ok_runner               -> successful scripted runner
+    # - #version_fail_runner     -> provider CLI presence probe fails
+    # - #auth_fail_runner        -> provider CLI auth probe fails
+    # - #not_found_runner        -> object lookup command fails as "not found"
+    # - #malformed_runner        -> object lookup returns unparseable output
+    # - #unreachable_runner      -> object lookup fails as unreachable/timeout
+    #
+    # Runners are callables receiving kwargs (args:, timeout:, env:) and
+    # returning {stdout:, stderr:, exit_code:}.
+    module ProviderContract
+      # Essential normalized evidence: fields every provider must supply.
+      # Provider-optional fields (url, draft, merged_at) are asserted as
+      # present or left unchecked where a provider cannot supply them.
+      EXPECTED_PR = {
+        server_name: "forge-server",
+        number: 25,
+        title: "Ship the provider contract",
+        state: :merged,
+        head_ref: "lab/W675-ace",
+        base_ref: "main",
+        head_sha: "fc14c43d3660ac6c133959a6dec29603413f0e8a",
+        author: "lab-builder"
+      }.freeze
+
+      EXPECTED_BRANCH_PR = {
+        server_name: "forge-server",
+        number: 31,
+        title: "Wire status to providers",
+        state: :open,
+        head_ref: "lab/W676-ace",
+        base_ref: "main",
+        head_sha: "a1b2c3d4e5f60718293a4b5c6d7e8f9012345678",
+        author: "lab-builder"
+      }.freeze
+
+      EXPECTED_ISSUE = {
+        server_name: "forge-server",
+        number: 9,
+        title: "Broken diff on detached HEAD",
+        state: :open,
+        author: "lab-admin"
+      }.freeze
+
+      EXPECTED_CHECK = {server_name: "forge-server", name: "test-suite", state: :success, conclusion: :success}.freeze
+
+      EXPECTED_REPO = {
+        server_name: "forge-server",
+        full_name: "owner/repo",
+        url: "https://forge.example.com/owner/repo"
+      }.freeze
+
+      def test_contract_reports_available_and_authenticated
+        provider = build_provider(ok_runner)
+        assert_equal true, provider.available?
+        assert_equal true, provider.authenticated?
+        provider.check_available!
+        provider.check_authenticated!
+      end
+
+      def test_contract_pull_request_evidence_matches_normalized_shape
+        pr = build_provider(ok_runner).pull_request(number: 25)
+        assert_instance_of Ace::Git::ProviderPullRequest, pr
+        assert_normalized_fields(EXPECTED_PR, pr)
+        refute_nil pr.url
+      end
+
+      def test_contract_pull_request_for_branch_evidence_matches_normalized_shape
+        pr = build_provider(ok_runner).pull_request_for_branch(branch: "lab/W676-ace")
+        assert_instance_of Ace::Git::ProviderPullRequest, pr
+        assert_normalized_fields(EXPECTED_BRANCH_PR, pr)
+      end
+
+      def test_contract_pull_request_for_branch_returns_nil_without_match
+        assert_nil build_provider(ok_runner).pull_request_for_branch(branch: "no-such-branch")
+      end
+
+      def test_contract_pull_request_diff_returns_raw_text
+        diff = build_provider(ok_runner).pull_request_diff(number: 25)
+        assert_instance_of String, diff
+        assert_includes diff, "diff --git"
+      end
+
+      def test_contract_recent_pull_requests_returns_normalized_list
+        prs = build_provider(ok_runner).recent_pull_requests(limit: 30)
+        assert_instance_of Array, prs
+        assert_equal 2, prs.length
+        assert prs.all? { |pr| pr.instance_of?(Ace::Git::ProviderPullRequest) }
+        # Newest first (descending PR number), identical across providers
+        assert_equal [31, 25], prs.map(&:number)
+      end
+
+      def test_contract_issue_evidence_matches_normalized_shape
+        issue = build_provider(ok_runner).issue(number: 9)
+        assert_instance_of Ace::Git::ProviderIssue, issue
+        assert_normalized_fields(EXPECTED_ISSUE, issue)
+        refute_nil issue.url
+      end
+
+      def test_contract_checks_return_normalized_list
+        checks = build_provider(ok_runner).checks(ref: "fc14c43d3660ac6c133959a6dec29603413f0e8a")
+        assert_instance_of Array, checks
+        assert_equal 1, checks.length
+        check = checks.first
+        assert_instance_of Ace::Git::ProviderCheck, check
+        assert_equal EXPECTED_CHECK[:server_name], check.server_name
+        assert_equal EXPECTED_CHECK[:name], check.name
+        assert_equal EXPECTED_CHECK[:state], check.state
+        assert_equal EXPECTED_CHECK[:conclusion], check.conclusion
+      end
+
+      def test_contract_repository_evidence_matches_normalized_shape
+        repo = build_provider(ok_runner).repository
+        assert_instance_of Ace::Git::ProviderRepository, repo
+        assert_equal EXPECTED_REPO[:server_name], repo.server_name
+        assert_equal EXPECTED_REPO[:full_name], repo.full_name
+        assert_equal EXPECTED_REPO[:url], repo.url
+      end
+
+      def test_contract_cli_missing_failure_is_classified
+        provider = build_provider(version_fail_runner)
+        error = assert_raises(Ace::Git::ProviderCliMissingError) { provider.check_available! }
+        assert_match(/cli/i, error.message)
+      end
+
+      def test_contract_authentication_failure_is_classified
+        provider = build_provider(auth_fail_runner)
+        error = assert_raises(Ace::Git::ProviderAuthenticationError) { provider.check_authenticated! }
+        assert_match(/auth/i, error.message)
+      end
+
+      def test_contract_object_not_found_failure_is_classified
+        provider = build_provider(not_found_runner)
+        error = assert_raises(Ace::Git::ProviderObjectNotFoundError) { provider.pull_request(number: 999) }
+        assert_match(/999/, error.message)
+      end
+
+      def test_contract_malformed_output_failure_is_classified
+        provider = build_provider(malformed_runner)
+        error = assert_raises(Ace::Git::ProviderMalformedOutputError) { provider.pull_request(number: 25) }
+        assert_match(/malformed|parse|unrecognized/i, error.message)
+      end
+
+      def test_contract_unreachable_failure_is_classified
+        provider = build_provider(unreachable_runner)
+        error = assert_raises(Ace::Git::ProviderUnreachableError) { provider.pull_request(number: 25) }
+        assert_match(/unreachable|timed out|failed/i, error.message)
+      end
+
+      private
+
+      def assert_normalized_fields(expected, evidence)
+        expected.each do |field, value|
+          assert_equal value, evidence.public_send(field),
+            "#{field} must be normalized identically across providers"
+        end
+      end
+    end
+  end
+end

data/lib/ace/test_support/pull_request_lifecycle_contract.rb

@@ -0,0 +1,150 @@
+# frozen_string_literal: true
+
+module Ace
+  module TestSupport
+    # Shared PR-lifecycle contract parity suite.
+    #
+    # Provider packages include this module and supply scripted runners per
+    # symbolic scenario, proving identical normalized receipts, exact-identity
+    # matching, expected-head enforcement, idempotent create, unknown-outcome
+    # classification, and capability classification across every provider —
+    # with no network and no provider CLI.
+    #
+    # Host test class contract:
+    # - #build_provider(runner) -> Ace::Git::Providers::Base on the runner
+    # - #lifecycle_runner(scenario) -> scripted runner for the scenario
+    # - #ready_supported? [Boolean] provider can mark drafts ready
+    # - #merge_supported? [Boolean] provider enforces head atomically
+    module PullRequestLifecycleContract
+      SERVER_URL = "https://forge.example.com/owner/repo"
+      HEAD_SHA = "fc14c43d3660ac6c133959a6dec29603413f0e8a"
+      OTHER_SHA = "0123456789abcdef0123456789abcdef01234567"
+
+      IDENTITY = {
+        head_repository_url: SERVER_URL,
+        head_ref: "feature/x",
+        base_repository_url: SERVER_URL,
+        base_ref: "main"
+      }.freeze
+
+      # Create kwargs: the base repository is always the resolved server.
+      CREATE_IDENTITY = IDENTITY.except(:base_repository_url).freeze
+
+      def test_lifecycle_find_matches_exact_identity_with_provenance
+        prs = build_provider(lifecycle_runner(:find_single)).find_open_pull_requests(**IDENTITY)
+        assert_equal [25], prs.map(&:number)
+        pr = prs.first
+        assert_equal HEAD_SHA, pr.head_sha
+        assert_equal "feature/x", pr.head_ref
+        assert_equal "main", pr.base_ref
+        assert_equal SERVER_URL, pr.head_repository_url
+        assert_equal SERVER_URL, pr.base_repository_url
+      end
+
+      def test_lifecycle_create_proves_head_and_reports_created
+        provider = build_provider(lifecycle_runner(:create_new))
+        receipt = provider.create_pull_request(
+          **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+        )
+        assert_instance_of Ace::Git::ProviderMutationReceipt, receipt
+        assert_equal :create, receipt.operation
+        assert_equal :created, receipt.idempotency
+        assert_equal HEAD_SHA, receipt.pull_request.head_sha
+        assert_equal SERVER_URL, receipt.pull_request.base_repository_url
+        assert_equal HEAD_SHA, receipt.to_h.dig(:pull_request, :head_sha)
+      end
+
+      def test_lifecycle_create_reconciles_to_exact_open_match
+        receipt = build_provider(lifecycle_runner(:create_existing)).create_pull_request(
+          **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+        )
+        assert_equal :existing, receipt.idempotency
+        assert_equal 25, receipt.pull_request.number
+      end
+
+      def test_lifecycle_create_rejects_stale_expected_head_without_mutation
+        provider = build_provider(lifecycle_runner(:create_existing))
+        error = assert_raises(Ace::Git::ProviderExpectedHeadConflictError) do
+          provider.create_pull_request(
+            **CREATE_IDENTITY, expected_head: OTHER_SHA, title: "Ship it"
+          )
+        end
+        assert_match(/head changed|does not match/i, error.message)
+      end
+
+      def test_lifecycle_create_conflicts_on_multiple_exact_matches
+        provider = build_provider(lifecycle_runner(:find_multi))
+        error = assert_raises(Ace::Git::ProviderConflictingMatchesError) do
+          provider.create_pull_request(
+            **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+          )
+        end
+        assert_match(/match/i, error.message)
+      end
+
+      def test_lifecycle_create_reports_unknown_outcome_with_reconciliation_identity
+        provider = build_provider(lifecycle_runner(:create_unknown))
+        error = assert_raises(Ace::Git::ProviderUnknownOutcomeError) do
+          provider.create_pull_request(
+            **CREATE_IDENTITY, expected_head: HEAD_SHA, title: "Ship it"
+          )
+        end
+        assert_match(/reconcile by exact identity/i, error.message)
+        assert_match(%r{owner/repo}, error.message)
+      end
+
+      def test_lifecycle_update_enforces_expected_head
+        provider = build_provider(lifecycle_runner(:update_stale))
+        error = assert_raises(Ace::Git::ProviderExpectedHeadConflictError) do
+          provider.update_pull_request(number: 25, expected_head: OTHER_SHA, title: "New title")
+        end
+        assert_match(/head changed/i, error.message)
+
+        receipt = build_provider(lifecycle_runner(:update_ok))
+          .update_pull_request(number: 25, expected_head: HEAD_SHA, title: "New title")
+        assert_equal :update, receipt.operation
+        assert_equal HEAD_SHA, receipt.pull_request.head_sha
+      end
+
+      def test_lifecycle_ready_classifies_capability
+        provider = build_provider(lifecycle_runner(ready_supported? ? :ready_ok : :ready_unsupported))
+        if ready_supported?
+          receipt = provider.ready_pull_request(number: 25, expected_head: HEAD_SHA)
+          assert_equal :ready, receipt.operation
+        else
+          error = assert_raises(Ace::Git::ProviderUnsupportedCapabilityError) do
+            provider.ready_pull_request(number: 25, expected_head: HEAD_SHA)
+          end
+          assert_match(/ready|capab|support/i, error.message)
+        end
+      end
+
+      def test_lifecycle_merge_enforces_expected_head_atomically
+        provider = build_provider(lifecycle_runner(merge_supported? ? :merge_ok : :merge_unsupported))
+        if merge_supported?
+          receipt = provider.merge_pull_request(number: 25, expected_head: HEAD_SHA, method: :squash)
+          assert_equal :merge, receipt.operation
+          assert_equal HEAD_SHA, receipt.pull_request.head_sha
+
+          error = assert_raises(Ace::Git::ProviderExpectedHeadConflictError) do
+            build_provider(lifecycle_runner(:merge_stale))
+              .merge_pull_request(number: 25, expected_head: OTHER_SHA, method: :squash)
+          end
+          assert_match(/head|match/i, error.message)
+        else
+          error = assert_raises(Ace::Git::ProviderUnsupportedCapabilityError) do
+            provider.merge_pull_request(number: 25, expected_head: HEAD_SHA, method: :squash)
+          end
+          assert_match(/atomic|expected[- ]head|capab|support/i, error.message)
+        end
+      end
+
+      def test_lifecycle_merge_rejects_unknown_methods
+        provider = build_provider(lifecycle_runner(:find_single))
+        assert_raises(ArgumentError) do
+          provider.merge_pull_request(number: 25, expected_head: HEAD_SHA, method: :fast_forward)
+        end
+      end
+    end
+  end
+end

data/lib/ace/test_support/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module TestSupport
-    VERSION = "0.14.4"
+    VERSION = "0.14.6"
   end
 end

data/lib/ace/test_support.rb

@@ -21,6 +21,8 @@ require_relative "test_support/fixtures/git_mocks"  # Shared git mocks
 require_relative "test_support/fixtures/http_mocks"  # Shared HTTP mocks for LLM testing
 require_relative "test_support/fixtures/prompt_helpers"  # Shared prompt stubbing helpers
 require_relative "test_support/fixtures/test_runner_mocks"  # Shared test runner mocks
+require_relative "test_support/provider_contract"  # Provider contract parity suite for forge provider gems
+require_relative "test_support/pull_request_lifecycle_contract"  # PR lifecycle contract parity suite
 
 # Configure Minitest reporters by default
 Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-support-test-helpers
 version: !ruby/object:Gem::Version
-  version: 0.14.4
+  version: 0.14.6
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-09-05 00:00:00.000000000 Z
+date: 2026-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -62,6 +62,8 @@ files:
 - lib/ace/test_support/fixtures/prompt_helpers.rb
 - lib/ace/test_support/fixtures/test_runner_mocks.rb
 - lib/ace/test_support/performance_helpers.rb
+- lib/ace/test_support/provider_contract.rb
+- lib/ace/test_support/pull_request_lifecycle_contract.rb
 - lib/ace/test_support/sandbox_package_copy.rb
 - lib/ace/test_support/subprocess_runner.rb
 - lib/ace/test_support/test_environment.rb