ace-support-test-helpers 0.14.3 → 0.14.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 30924ca77ecdc80a168d83e9352a79cddd32a4602692f7e4e86ad797f9871300
-  data.tar.gz: 4e21f0e8a9f87f06bb4c24db88c6395cd8f195164fa5031c43002dcda484cd75
+  metadata.gz: f964e2cbd1eb428c260e5190ddaefbef7905d1ee86e894cbcab9a2d2b985b628
+  data.tar.gz: 6b8e0b1f8c3e0e88638d99b8d4abaea0a8378262bbae3c3784ae519d5859ecc2
 SHA512:
-  metadata.gz: 19da23814d679f7fc0bf4f783fc1e9d23e0dc6a51174589e1f33187e40cbd024ce4329a51b205c5c157c1ad77930d07db52c3bb7e04c760006be5674be818360
-  data.tar.gz: e5fc6999bf0ba89276c34a9adaa0ecdaa797b8dfc0d5effe1d655075da8105f77f7b754d51bb772708abf0789be48745b5239b905933b8e2c84fe9eb800547f4
+  metadata.gz: 8da847ee96be275ce048c97e55d3a0c6c659c2bf73ac472fbf4001fd3ca6eabc907658a2d2c333843f65dc059bb69b87cdec2ed1afa4965a8608ba4ccad5e174
+  data.tar.gz: 6f5b8c776f80d9a799e06c64cc0238cefc346fec2f98715e92767369f56e2222a24dc84c4ff1070dc210ba54b09f3244f751de978ef695b4839604a4ca3a276b

data/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.14.5] - 2026-09-24
+
+### Fixed
+
+- Accept bundle loader options in shared test mocks.
+
+## [0.14.4] - 2026-09-02
+
+### Technical
+- Included in the coordinated all-package patch release preparation for ACE monorepo review.
 ## [0.14.3] - 2026-08-12
 
 ### Technical

data/lib/ace/test_support/fixtures/bundle_mocks.rb

@@ -152,7 +152,7 @@ module Ace
 
           original_method_holder[:load_file] = Ace::Bundle.method(:load_file) if Ace::Bundle.respond_to?(:load_file)
 
-          Ace::Bundle.define_singleton_method(:load_file) do |path|
+          Ace::Bundle.define_singleton_method(:load_file) do |path, _options = {}|
             BundleMocks.mock_load_file_result(path)
           end
 

data/lib/ace/test_support/provider_contract.rb

@@ -0,0 +1,173 @@
+# frozen_string_literal: true
+
+module Ace
+  module TestSupport
+    # Shared provider-contract parity suite.
+    #
+    # Provider packages (ace-git-github, ace-git-forgejo) include this module
+    # in a test class backed by a scripted fake command runner and assert that
+    # their implementation produces identical normalized evidence and the
+    # exact classified failure taxonomy. Identical assertions run against every
+    # provider, which proves contract parity without any network or CLI.
+    #
+    # Host test class contract:
+    # - #build_provider(runner) -> Ace::Git::Providers::Base wired to the runner
+    # - #ok_runner               -> successful scripted runner
+    # - #version_fail_runner     -> provider CLI presence probe fails
+    # - #auth_fail_runner        -> provider CLI auth probe fails
+    # - #not_found_runner        -> object lookup command fails as "not found"
+    # - #malformed_runner        -> object lookup returns unparseable output
+    # - #unreachable_runner      -> object lookup fails as unreachable/timeout
+    #
+    # Runners are callables receiving kwargs (args:, timeout:, env:) and
+    # returning {stdout:, stderr:, exit_code:}.
+    module ProviderContract
+      # Essential normalized evidence: fields every provider must supply.
+      # Provider-optional fields (url, draft, merged_at) are asserted as
+      # present or left unchecked where a provider cannot supply them.
+      EXPECTED_PR = {
+        server_name: "forge-server",
+        number: 25,
+        title: "Ship the provider contract",
+        state: :merged,
+        head_ref: "lab/W675-ace",
+        base_ref: "main",
+        head_sha: "fc14c43d3660ac6c133959a6dec29603413f0e8a",
+        author: "lab-builder"
+      }.freeze
+
+      EXPECTED_BRANCH_PR = {
+        server_name: "forge-server",
+        number: 31,
+        title: "Wire status to providers",
+        state: :open,
+        head_ref: "lab/W676-ace",
+        base_ref: "main",
+        head_sha: "a1b2c3d4e5f60718293a4b5c6d7e8f9012345678",
+        author: "lab-builder"
+      }.freeze
+
+      EXPECTED_ISSUE = {
+        server_name: "forge-server",
+        number: 9,
+        title: "Broken diff on detached HEAD",
+        state: :open,
+        author: "lab-admin"
+      }.freeze
+
+      EXPECTED_CHECK = {server_name: "forge-server", name: "test-suite", state: :success, conclusion: :success}.freeze
+
+      EXPECTED_REPO = {
+        server_name: "forge-server",
+        full_name: "owner/repo",
+        url: "https://forge.example.com/owner/repo"
+      }.freeze
+
+      def test_contract_reports_available_and_authenticated
+        provider = build_provider(ok_runner)
+        assert_equal true, provider.available?
+        assert_equal true, provider.authenticated?
+        provider.check_available!
+        provider.check_authenticated!
+      end
+
+      def test_contract_pull_request_evidence_matches_normalized_shape
+        pr = build_provider(ok_runner).pull_request(number: 25)
+        assert_instance_of Ace::Git::ProviderPullRequest, pr
+        assert_normalized_fields(EXPECTED_PR, pr)
+        refute_nil pr.url
+      end
+
+      def test_contract_pull_request_for_branch_evidence_matches_normalized_shape
+        pr = build_provider(ok_runner).pull_request_for_branch(branch: "lab/W676-ace")
+        assert_instance_of Ace::Git::ProviderPullRequest, pr
+        assert_normalized_fields(EXPECTED_BRANCH_PR, pr)
+      end
+
+      def test_contract_pull_request_for_branch_returns_nil_without_match
+        assert_nil build_provider(ok_runner).pull_request_for_branch(branch: "no-such-branch")
+      end
+
+      def test_contract_pull_request_diff_returns_raw_text
+        diff = build_provider(ok_runner).pull_request_diff(number: 25)
+        assert_instance_of String, diff
+        assert_includes diff, "diff --git"
+      end
+
+      def test_contract_recent_pull_requests_returns_normalized_list
+        prs = build_provider(ok_runner).recent_pull_requests(limit: 30)
+        assert_instance_of Array, prs
+        assert_equal 2, prs.length
+        assert prs.all? { |pr| pr.instance_of?(Ace::Git::ProviderPullRequest) }
+        # Newest first (descending PR number), identical across providers
+        assert_equal [31, 25], prs.map(&:number)
+      end
+
+      def test_contract_issue_evidence_matches_normalized_shape
+        issue = build_provider(ok_runner).issue(number: 9)
+        assert_instance_of Ace::Git::ProviderIssue, issue
+        assert_normalized_fields(EXPECTED_ISSUE, issue)
+        refute_nil issue.url
+      end
+
+      def test_contract_checks_return_normalized_list
+        checks = build_provider(ok_runner).checks(ref: "fc14c43d3660ac6c133959a6dec29603413f0e8a")
+        assert_instance_of Array, checks
+        assert_equal 1, checks.length
+        check = checks.first
+        assert_instance_of Ace::Git::ProviderCheck, check
+        assert_equal EXPECTED_CHECK[:server_name], check.server_name
+        assert_equal EXPECTED_CHECK[:name], check.name
+        assert_equal EXPECTED_CHECK[:state], check.state
+        assert_equal EXPECTED_CHECK[:conclusion], check.conclusion
+      end
+
+      def test_contract_repository_evidence_matches_normalized_shape
+        repo = build_provider(ok_runner).repository
+        assert_instance_of Ace::Git::ProviderRepository, repo
+        assert_equal EXPECTED_REPO[:server_name], repo.server_name
+        assert_equal EXPECTED_REPO[:full_name], repo.full_name
+        assert_equal EXPECTED_REPO[:url], repo.url
+      end
+
+      def test_contract_cli_missing_failure_is_classified
+        provider = build_provider(version_fail_runner)
+        error = assert_raises(Ace::Git::ProviderCliMissingError) { provider.check_available! }
+        assert_match(/cli/i, error.message)
+      end
+
+      def test_contract_authentication_failure_is_classified
+        provider = build_provider(auth_fail_runner)
+        error = assert_raises(Ace::Git::ProviderAuthenticationError) { provider.check_authenticated! }
+        assert_match(/auth/i, error.message)
+      end
+
+      def test_contract_object_not_found_failure_is_classified
+        provider = build_provider(not_found_runner)
+        error = assert_raises(Ace::Git::ProviderObjectNotFoundError) { provider.pull_request(number: 999) }
+        assert_match(/999/, error.message)
+      end
+
+      def test_contract_malformed_output_failure_is_classified
+        provider = build_provider(malformed_runner)
+        error = assert_raises(Ace::Git::ProviderMalformedOutputError) { provider.pull_request(number: 25) }
+        assert_match(/malformed|parse|unrecognized/i, error.message)
+      end
+
+      def test_contract_unreachable_failure_is_classified
+        provider = build_provider(unreachable_runner)
+        error = assert_raises(Ace::Git::ProviderUnreachableError) { provider.pull_request(number: 25) }
+        assert_match(/unreachable|timed out|failed/i, error.message)
+      end
+
+      private
+
+      def assert_normalized_fields(expected, evidence)
+        expected.each do |field, value|
+          assert_equal value, evidence.public_send(field),
+            "#{field} must be normalized identically across providers"
+        end
+      end
+    end
+  end
+end

data/lib/ace/test_support/test_helper.rb

@@ -38,6 +38,35 @@ module Ace
         end
       end
 
+      # Returns true when mode-0000/DAC permission bits are enforced against
+      # the current process. Root and processes with CAP_DAC_OVERRIDE bypass
+      # these checks, so chmod-based permission tests must be skipped there.
+      def permission_denial_enforced?
+        return false if Gem.win_platform?
+
+        Tempfile.create("ace_perm_probe") do |probe|
+          probe.write("probe")
+          probe.flush
+          begin
+            File.chmod(0o000, probe.path)
+          rescue NotImplementedError, SystemCallError
+            return false
+          end
+          begin
+            File.read(probe.path)
+            false
+          rescue SystemCallError
+            true
+          ensure
+            begin
+              File.chmod(0o600, probe.path)
+            rescue StandardError
+              nil
+            end
+          end
+        end
+      end
+
       def create_config_file(path, content)
         FileUtils.mkdir_p(File.dirname(path))
         File.write(path, content)

data/lib/ace/test_support/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module TestSupport
-    VERSION = "0.14.3"
+    VERSION = "0.14.5"
   end
 end

data/lib/ace/test_support.rb

@@ -21,6 +21,7 @@ require_relative "test_support/fixtures/git_mocks"  # Shared git mocks
 require_relative "test_support/fixtures/http_mocks"  # Shared HTTP mocks for LLM testing
 require_relative "test_support/fixtures/prompt_helpers"  # Shared prompt stubbing helpers
 require_relative "test_support/fixtures/test_runner_mocks"  # Shared test runner mocks
+require_relative "test_support/provider_contract"  # Provider contract parity suite for forge provider gems
 
 # Configure Minitest reporters by default
 Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-support-test-helpers
 version: !ruby/object:Gem::Version
-  version: 0.14.3
+  version: 0.14.5
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-08-12 00:00:00.000000000 Z
+date: 2026-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -62,6 +62,7 @@ files:
 - lib/ace/test_support/fixtures/prompt_helpers.rb
 - lib/ace/test_support/fixtures/test_runner_mocks.rb
 - lib/ace/test_support/performance_helpers.rb
+- lib/ace/test_support/provider_contract.rb
 - lib/ace/test_support/sandbox_package_copy.rb
 - lib/ace/test_support/subprocess_runner.rb
 - lib/ace/test_support/test_environment.rb