ace-review 0.62.1 → 0.62.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +7 -0
- data/docs/usage.md +10 -0
- data/handbook/workflow-instructions/review/pr.wf.md +27 -0
- data/lib/ace/review/version.rb +1 -1
- metadata +8 -8
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 0d5ed9b815de2be3f42f06d250cd67c0b9016b45af7a22a577e22627c3ecbd58
|
|
4
|
+
data.tar.gz: b1da6f44694b73e8cc155d1f71c9b7100a7f7cf794e955ae6ee8d4ba3504fd06
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 5f47911975e20b99a4f56dfe274db15f2f9fb1b237bb5cdd245d00d7d72653c07f586bde7c4957dad4f04c1c544a2969eeabf639c5ee5c0ea8cc0f7863b21819
|
|
7
|
+
data.tar.gz: 335d6fa500b2818b297477b08db95b1b4c5afbbe1d1c214fbe8236612b7dbd2a1f43ab43cc43a0d1f9fc08b7f3f7c7fdac2c3d8d5d08e32a786acb5927e0367b
|
data/CHANGELOG.md
CHANGED
|
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|
|
7
7
|
|
|
8
8
|
## [Unreleased]
|
|
9
9
|
|
|
10
|
+
## [0.62.2] - 2026-10-23
|
|
11
|
+
|
|
12
|
+
### Added
|
|
13
|
+
|
|
14
|
+
- Formal reviewer-owned, exact-head provider approval and read-only approval verification through the forge-neutral review flow; comments do not substitute for approval.
|
|
15
|
+
|
|
16
|
+
|
|
10
17
|
|
|
11
18
|
## [0.62.1] - 2026-10-20
|
|
12
19
|
|
data/docs/usage.md
CHANGED
|
@@ -212,3 +212,13 @@ ace-review-feedback skip abc123 --reason "Design: intentional choice"
|
|
|
212
212
|
ace-review --help
|
|
213
213
|
ace-review-feedback --help
|
|
214
214
|
```
|
|
215
|
+
|
|
216
|
+
|
|
217
|
+
Formal approval is a separate reviewer-owned operation after an accepted
|
|
218
|
+
independent review and required executed checks: `ace-git pr approve PR
|
|
219
|
+
--expected-head SHA --body-file REVIEW_REPORT --correlation REVIEW_ID --server
|
|
220
|
+
SERVER --format json`. `--post-comment` still posts only a comment. Keep the
|
|
221
|
+
verified approval receipt with the existing review artifacts; integrators read
|
|
222
|
+
current evidence through `ace-git pr approval`, without publishing approval on
|
|
223
|
+
the reviewer's behalf. Missing rights/capability or unknown outcomes block the
|
|
224
|
+
integration handoff and require reconciliation through the configured account.
|
|
@@ -63,3 +63,30 @@ records each finished round with the deterministic 3/2/10 counter tooling
|
|
|
63
63
|
That role workflow is the authority for role handoff and round-limit
|
|
64
64
|
enforcement; this document stays the authority for running the review rounds
|
|
65
65
|
themselves. Do not duplicate or re-implement the counters here.
|
|
66
|
+
|
|
67
|
+
|
|
68
|
+
## Formal provider approval (reviewer-owned)
|
|
69
|
+
|
|
70
|
+
After the accepted independent review and executed tests cover the current full
|
|
71
|
+
head, a commissioned reviewer publishes the accepted report using
|
|
72
|
+
`ace-git pr approve PR --expected-head SHA --body-file REVIEW_REPORT
|
|
73
|
+
--correlation REVIEW_ID --server SERVER --format json` (or the retained
|
|
74
|
+
`--default-server`). Preserve the returned effective approval receipt in the
|
|
75
|
+
existing review/task/assignment artifacts. `--post-comment`, a description edit
|
|
76
|
+
and `ace-git pr ready` remain separate operations and cannot substitute for a
|
|
77
|
+
formal approval. Own-PR approval is refused; role instructions never grant
|
|
78
|
+
provider credentials. Missing rights/capability and uncertain publication block
|
|
79
|
+
a successful integration handoff. Reconcile the same target-scoped correlation
|
|
80
|
+
after a lost response; do not blindly repeat a mutation or switch identities.
|
|
81
|
+
The integrator consumes current evidence through read-only `ace-git pr approval`
|
|
82
|
+
and the existing integration gate; it never publishes approval in place of the
|
|
83
|
+
independent reviewer. Review-round and authorization rules above still apply.
|
|
84
|
+
|
|
85
|
+
|
|
86
|
+
Deployment must provide a dedicated automation reviewer identity and one writer
|
|
87
|
+
per actor/repository/PR before formal publication. Missing evidence of that
|
|
88
|
+
mapping/ownership blocks live use; a role name grants no account permission.
|
|
89
|
+
Do not share that identity with manual clients or another host writer. Preserve
|
|
90
|
+
and report unrelated pending reviews/comments instead of publishing over them.
|
|
91
|
+
Resume only when the provider's path preserves the accepted commit/content;
|
|
92
|
+
unsafe or unsupported pending recovery remains blocked with retained evidence.
|
data/lib/ace/review/version.rb
CHANGED
metadata
CHANGED
|
@@ -1,13 +1,13 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: ace-review
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 0.62.
|
|
4
|
+
version: 0.62.2
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Michal Czyz
|
|
8
8
|
bindir: exe
|
|
9
9
|
cert_chain: []
|
|
10
|
-
date: 2026-10-
|
|
10
|
+
date: 2026-10-23 00:00:00.000000000 Z
|
|
11
11
|
dependencies:
|
|
12
12
|
- !ruby/object:Gem::Dependency
|
|
13
13
|
name: json
|
|
@@ -133,42 +133,42 @@ dependencies:
|
|
|
133
133
|
requirements:
|
|
134
134
|
- - "~>"
|
|
135
135
|
- !ruby/object:Gem::Version
|
|
136
|
-
version: '0.
|
|
136
|
+
version: '0.31'
|
|
137
137
|
type: :runtime
|
|
138
138
|
prerelease: false
|
|
139
139
|
version_requirements: !ruby/object:Gem::Requirement
|
|
140
140
|
requirements:
|
|
141
141
|
- - "~>"
|
|
142
142
|
- !ruby/object:Gem::Version
|
|
143
|
-
version: '0.
|
|
143
|
+
version: '0.31'
|
|
144
144
|
- !ruby/object:Gem::Dependency
|
|
145
145
|
name: ace-git-github
|
|
146
146
|
requirement: !ruby/object:Gem::Requirement
|
|
147
147
|
requirements:
|
|
148
148
|
- - "~>"
|
|
149
149
|
- !ruby/object:Gem::Version
|
|
150
|
-
version: '0.
|
|
150
|
+
version: '0.5'
|
|
151
151
|
type: :runtime
|
|
152
152
|
prerelease: false
|
|
153
153
|
version_requirements: !ruby/object:Gem::Requirement
|
|
154
154
|
requirements:
|
|
155
155
|
- - "~>"
|
|
156
156
|
- !ruby/object:Gem::Version
|
|
157
|
-
version: '0.
|
|
157
|
+
version: '0.5'
|
|
158
158
|
- !ruby/object:Gem::Dependency
|
|
159
159
|
name: ace-git-forgejo
|
|
160
160
|
requirement: !ruby/object:Gem::Requirement
|
|
161
161
|
requirements:
|
|
162
162
|
- - "~>"
|
|
163
163
|
- !ruby/object:Gem::Version
|
|
164
|
-
version: '0.
|
|
164
|
+
version: '0.8'
|
|
165
165
|
type: :runtime
|
|
166
166
|
prerelease: false
|
|
167
167
|
version_requirements: !ruby/object:Gem::Requirement
|
|
168
168
|
requirements:
|
|
169
169
|
- - "~>"
|
|
170
170
|
- !ruby/object:Gem::Version
|
|
171
|
-
version: '0.
|
|
171
|
+
version: '0.8'
|
|
172
172
|
- !ruby/object:Gem::Dependency
|
|
173
173
|
name: ace-support-nav
|
|
174
174
|
requirement: !ruby/object:Gem::Requirement
|