ace-review 0.57.0 → 0.57.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad21edc3f01275162f0b17aaa9033413abdca90a54a89b7240305b350087ac1a
-  data.tar.gz: 8a516e358225b6351f05b631f0866bb51c23c7cbfdf69dfd6c19e59a764c7d29
+  metadata.gz: 865eb269684936c32eb5d91b002f98419e71b1c89155715bc486382bfa4549f3
+  data.tar.gz: 0a4bbea96d948953da5fd157c10ae83c5d6b548888663975342ae11823784195
 SHA512:
-  metadata.gz: a22b32abda5cdfdef0c9c01a0cdeb9668aa60a98884ba93c48ea96d3c1f8ec1455fe08cbff16944afc661f2d4760a1aa644ea944b874e53ef6b5c033636d28d4
-  data.tar.gz: 3e65df04186e2748b7ab716555157ecb2c5e4153cb78928a8a15823717ee750f5bb346c9328f8f401f09f7570c02cf81cdade75f08159bc2aaee0afd427019c4
+  metadata.gz: 70a1f4d8f88fb5d9971e961fc0918b5c0477e87a52447b877814b429775b3196c648f2d99f24b216453d30e685ea29da97cb62b93809743a8f26f484402ec622
+  data.tar.gz: 39a724d6327716608165c95de3955ae77528fd19baaf107cf035e7cdef2e99697647cc247797f9e72c8639a6535e962791fa12f70fe878a582c181e87e746b43

data/CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.57.1] - 2026-10-02
+
+### Fixed
+
+- A failed or incomplete provider entry no longer invalidates a campaign session's completed reviewer executions; one completed reviewer per needed scope still completes the round.
+
+
 ## [0.57.0] - 2026-10-01
 
 ### Fixed

data/lib/ace/review/molecules/campaign_evidence.rb

@@ -18,6 +18,16 @@ module Ace
       class CampaignEvidence
         Contract = Atoms::CampaignContract
 
+        # One completion predicate for provider executions, shared with the
+        # extraction-inventory writer so session metadata and campaign
+        # evidence can never disagree about which reports were reviewed.
+        def self.completed_entry?(entry)
+          execution = entry["execution"] || {}
+          entry["status"] == "success" && execution["status"].to_s == "succeeded" &&
+            !execution["provider"].to_s.empty? && !execution["model"].to_s.empty? &&
+            !entry["completed_at"].to_s.empty?
+        end
+
         def initialize(repo_root:, check_evidence: nil, review_evidence: nil, approval_evidence: nil)
           @repo_root = File.realpath(repo_root)
           authority = CampaignExecutionEvidence.new(repo_root: @repo_root)
@@ -57,9 +67,9 @@ module Ace
           metadata = json_keys(YAML.safe_load_file(metadata_path, permitted_classes: [Time, Date, Symbol]))
           Contract.object!(metadata, "session metadata")
           expected = {"campaign_id" => record["id"], "contract_identity" => record["contract_identity"],
-            "subject" => record["subject"], "round_id" => binding["round_id"], "scope" => scope,
-            "head" => binding["head"], "base" => binding["base"],
-            "scope_identity" => binding["scope_identity"][scope]}
+                      "subject" => record["subject"], "round_id" => binding["round_id"], "scope" => scope,
+                      "head" => binding["head"], "base" => binding["base"],
+                      "scope_identity" => binding["scope_identity"][scope]}
           unless metadata["campaign_binding"] == expected && metadata["preset"] == expected["scope_identity"]["preset"]
             raise Contract::Invalid, "session campaign/contract/scope/head/base identity mismatch"
           end
@@ -83,12 +93,7 @@ module Ace
           reports = []
           entries.each do |entry|
             Contract.object!(entry, "model execution")
-            execution = entry["execution"] || {}
-            complete = entry["status"] == "success" && execution["status"] == "succeeded" &&
-              !execution["provider"].to_s.empty? && !execution["model"].to_s.empty? &&
-              !entry["completed_at"].to_s.empty?
-            completed &&= complete
-            next unless complete
+            next unless self.class.completed_entry?(entry)
             path = entry["output_file"].to_s
             raise Contract::Invalid, "completed execution has no report" if path.empty?
             path = File.expand_path(path, dir)
@@ -99,7 +104,7 @@ module Ace
             resolved, report_ref = artifact("path" => path, "sha256" => entry["report_sha256"])
             raise Contract::Invalid, "empty reviewer report" if File.read(resolved).strip.empty?
             refs << report_ref
-            reports << {"artifact" => report_ref, "execution" => execution}
+            reports << {"artifact" => report_ref, "execution" => entry["execution"] || {}}
             prompts = entry["prompt_sha256"]
             Contract.object!(prompts, "execution prompt checksums")
             %w[system user].each do |name|
@@ -117,6 +122,10 @@ module Ace
               raise Contract::Invalid, "feedback extraction inventory or reviewed reports changed"
             end
           end
+          # One completed reviewer per needed scope suffices: a failed or
+          # incomplete provider entry does not count as a reviewer, but it
+          # does not invalidate the model executions that did complete.
+          completed &&= reports.any?
           completed &&= extracted
           proof = completed ? @review_evidence.call(input.fetch("receipt"), head: binding["head"], artifacts: refs) : nil
           {"receipt" => input["receipt"], "execution_proof" => proof, "path" => dir.delete_prefix(@repo_root + File::SEPARATOR), "scope" => scope,

data/lib/ace/review/organisms/review_manager.rb

@@ -417,7 +417,8 @@ module Ace
                       pr_metadata: metadata, delta: delta,
                       diff_manifest: manifest.merge(scoped[:manifest]).merge(
                         exempt_files: classification[:exempt],
-                        exempt_patterns: Array(config[:exempt_paths]))}
+                        exempt_patterns: Array(config[:exempt_paths])
+                      )}
             end
 
             scoped = apply_exempt_paths(scoped, config)
@@ -497,10 +498,10 @@ module Ace
           lines << ""
           lines << "# No-op review round"
           lines << ""
-          if content[:noop_reason] == :empty_delta && delta
-            lines << "Scope: delta since `#{delta[:reference_head]}` — the delta is empty; there is no change to review."
+          lines << if content[:noop_reason] == :empty_delta && delta
+            "Scope: delta since `#{delta[:reference_head]}` — the delta is empty; there is no change to review."
           else
-            lines << "Scope: #{content[:noop_scope] || "no-op"}."
+            "Scope: #{content[:noop_scope] || "no-op"}."
           end
           lines << ""
           lines << "Verdict: no new findings. This round is clean only if no carried-forward Critical/High finding remains unresolved."
@@ -1636,7 +1637,17 @@ module Ace
         # completes; an absent directory cannot attest a zero-findings review.
         def save_campaign_feedback_metadata(session_dir, result)
           path = File.join(session_dir, "metadata.yml")
-          metadata = YAML.safe_load_file(path, permitted_classes: [Time, Date, Symbol])
+          # Session metadata is symbol-keyed YAML; normalize before any key
+          # reads so the completed-execution rule and the binding check see
+          # string keys, matching the campaign evidence reader.
+          normalize = lambda do |value|
+            case value
+            when Hash then value.to_h { |k, v| [k.to_s, normalize.call(v)] }
+            when Array then value.map { |v| normalize.call(v) }
+            else value
+            end
+          end
+          metadata = normalize.call(YAML.safe_load_file(path, permitted_classes: [Time, Date, Symbol]))
           return unless metadata["campaign_binding"]
           extraction = {"status" => result ? "failed" : "skipped"}
           if result && result[:success]
@@ -1649,9 +1660,13 @@ module Ace
             unless result[:items_count] == ids.size && ids.uniq.size == ids.size
               raise Errors::BundleProcessingError, "feedback extraction inventory is incomplete"
             end
-            entries = metadata["models"] || [YAML.safe_load_file(File.join(session_dir, "llm_metadata.yml"),
-              permitted_classes: [Time, Date, Symbol])]
-            digests = entries.map { |entry| entry["report_sha256"] }.compact
+            entries = metadata["models"] || [normalize.call(YAML.safe_load_file(
+              File.join(session_dir, "llm_metadata.yml"), permitted_classes: [Time, Date, Symbol]
+            ))]
+            # Same completed rule as the campaign evidence reader: a failed
+            # provider that left partial output is not a reviewed report.
+            digests = entries.select { |entry| Molecules::CampaignEvidence.completed_entry?(entry) }
+              .map { |entry| entry["report_sha256"] }.compact
             extraction = {"status" => "succeeded", "finding_ids" => ids, "report_sha256" => digests}
           end
           metadata["feedback_extraction"] = extraction

data/lib/ace/review/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Review
-    VERSION = "0.57.0"
+    VERSION = "0.57.1"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-review
 version: !ruby/object:Gem::Version
-  version: 0.57.0
+  version: 0.57.1
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-10-01 00:00:00.000000000 Z
+date: 2026-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-support-cli