ace-review 0.51.4 → 0.53.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78773489249dbc3812986dcc10b14bbccb643dfcd81bf500aa875cb274a827f3
-  data.tar.gz: ff822482b7b712b9c59c8911bc878a2396753c2d513197946d7596c4ec7c5fbd
+  metadata.gz: c50e105e74afc8802976a5c869debdd9514996f8c5c48c1ff0cc2266f1a2622f
+  data.tar.gz: 18512f481aa7315c446b7bfb93d7844dde492f1369b3a33cc34c3edb590bb1d0
 SHA512:
-  metadata.gz: a7e99e1cb1ba51db67b9b0f95649c80dedc99272ffb5989d36207723e656921d0cacf2eef7ee2041550757f821c5f0ecb873e6f25582dddb3f81ce3d20e42d1f
-  data.tar.gz: d5005fcd3e9e6af2f99eb3a8c6fd86d1e1a4099a5f4e9666946980b56d5c7ece97940b9314fb0e9d54c941ff469ec241c0db396fdd71cb9be382d78fd38e2d81
+  metadata.gz: 1869bc1bcbe622b59b88189ccbaf09192b183b44aac2a10d926b38befbb58f6e01a54601c218234d0e681532d590a4bf2d531d3ca5f027dda17957f19a046270
+  data.tar.gz: 68f5a18ae201735fb0577235d1a9bc53e703ea2e44c89e927b053e1048fa1bcfb2782facfed324a612b42cc8a07956fd96a99cc18599ebdd3538c86bcccb7105

data/.ace-defaults/review/config.yml

@@ -4,7 +4,7 @@
 # Configuration Options:
 # ---------------------
 # preset          - Default preset when --preset not specified (default: "code-valid")
-# model           - Default LLM model for reviews (default: "codex:codex@ro")
+# model           - Default LLM model for reviews (default: "role:review-default")
 # output_format   - Output format for reviews (default: "markdown")
 # context         - Default context preset (default: "project")
 # max_concurrent_models - Max parallel LLM queries for multi-model execution (default: 3)
@@ -32,7 +32,7 @@ project_docs:
 # Default settings applied to all reviews unless overridden
 defaults:
   preset: "code-valid"  # Default preset when --preset not specified
-  model: "codex:codex@ro"
+  model: "role:review-default"
   output_format: "markdown"
   bundle: "project"
   max_concurrent_models: 3  # Max parallel LLM queries for multi-model execution
@@ -71,9 +71,8 @@ defaults:
 # Feedback items are extracted from review reports for tracking and verification
 feedback:
   enabled: true                           # Enable feedback extraction (default: true)
-  synthesis_model: gemini:flash-latest@ro  # Model for synthesizing feedback items
-  fallback_models:                        # Fallback models if primary synthesis fails
-    - claude:sonnet
+  synthesis_model: role:review-synthesizer  # Model for synthesizing feedback items
+  # fallback_models not needed — role:review-synthesizer has built-in multi-provider fallback
 
 # Review presets - load from .ace/review/presets/*.yml
 # Individual preset files provide better organization and shareability

data/.ace-defaults/review/presets/code-fit.yml

@@ -60,5 +60,6 @@ instructions:
 bundle: "project"
 
 models:
-  - claude:opus@ro
-  - codex:gpt@ro
+  - role:review-claude
+  - role:review-codex
+  - role:review-gemini

data/.ace-defaults/review/presets/code-shine.yml

@@ -40,5 +40,5 @@ instructions:
 bundle: "project"
 
 models:
-  - claude:opus@ro
-  - codex:gpt@ro
+  - role:review-claude
+  - role:review-codex

data/.ace-defaults/review/presets/code-valid.yml

@@ -35,5 +35,6 @@ instructions:
 bundle: "project"
 
 models:
-  - claude:opus@ro
-  - codex:gpt@ro
+  - role:review-claude
+  - role:review-codex
+  - role:review-gemini

data/.ace-defaults/review/presets/docs.yml

@@ -30,7 +30,7 @@ instructions:
 bundle: "project"
 
 models:
-  - codex:codex@ro
+  - role:review-codex
 
 subject:
   bundle:

data/.ace-defaults/review/presets/spec.yml

@@ -25,7 +25,7 @@ instructions:
 bundle: "project"
 
 models:
-  - codex:codex@ro
+  - role:review-codex
 
 subject:
   bundle:

data/CHANGELOG.md

@@ -7,6 +7,85 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.53.5] - 2026-04-19
+
+### Technical
+- Stabilized retained multi-model and reviewers-format E2E fixtures by pinning them to installed direct review models instead of ambient mixed-provider availability.
+
+## [0.53.4] - 2026-04-16
+
+### Technical
+- Hardened retained multi-model and docs-path review E2E runners to persist `.stdout`, `.stderr`, and `.exit` artifacts consistently across success, timeout, and provider-constrained paths.
+
+## [0.53.3] - 2026-04-16
+
+### Fixed
+- Updated retained `TS-REVIEW-001` execution fixtures to use installed direct review models, require explicit diff subjects, and drive the single/multi-model flows through the public executable review path instead of stopping at session preparation.
+
+## [0.53.2] - 2026-04-16
+
+### Fixed
+- Switched retained `TS-REVIEW-001` multi-model fixtures from the missing `review-claude` role to installed review roles so the scenario validates real multi-provider review execution instead of local CLI availability drift.
+
+## [0.53.1] - 2026-04-16
+
+### Fixed
+- Updated docs-path onboarding E2E verification to accept bounded timeout evidence when help discovery and review session artifacts prove the documented path is discoverable.
+
+## [0.53.0] - 2026-04-15
+
+### Changed
+- Rewrote retained `TS-REVIEW-001` E2E goals to enforce public docs/help command-path guidance and added
+  `TC-003-docs-path-onboarding` coverage.
+- Tightened E2E verifier contracts so provider/model unavailability is treated as a failure path instead of a
+  PASS-equivalent outcome.
+
+### Technical
+- Updated scenario manifests and decision records to reflect three-goal execution (`X/3`) and the strict outcome
+  policy for onboarding-facing review workflows.
+
+## [0.52.1] - 2026-04-13
+
+### Changed
+- Completed the batch i05 migration follow-through for this package and aligned it with the restarted `fast` / `feat` / `e2e` verification model.
+
+### Technical
+- Included in the coordinated assignment-driven patch release for batch i05 package updates.
+
+
+## [0.52.0] - 2026-04-12
+
+### Changed
+- Migrated package tests to the restarted `fast` / `feat` / `e2e` contract:
+  - moved deterministic package tests from legacy top-level folders into `test/fast/`
+  - moved former `test/integration/` deterministic coverage into `test/feat/`
+  - rewrote `TS-REVIEW-001` to retain only high-value execution workflows and added an E2E decision record
+- Updated package docs to teach `ace-test ace-review`, `ace-test ace-review feat`, `ace-test ace-review all`, and `ace-test-e2e ace-review`.
+- Expanded `as-review-pr` canonical skill metadata so public `review-pr` assign-step discovery is skill-owned rather than catalog-owned.
+- Switched review GitHub CLI operations to use `Ace::Git::Molecules::GhCliExecutor` and removed the package-local `GhCliExecutor` implementation.
+
+### Fixed
+- Added `diff:RANGE -- path` subject parsing so reviews can scope git diffs to specific files or directories with git-style path filters.
+- Updated review GitHub workflows to correctly re-raise `Ace::Git` authentication/install errors after migrating to shared `GhCliExecutor`.
+
+## [0.51.10] - 2026-04-07
+
+### Changed
+- Switched review GitHub CLI integrations to shared `Ace::Git::Molecules::GhCliExecutor` to remove duplicate implementations and align error handling with other packages.
+
+### Fixed
+- Preserved review-path authentication and install error behavior after the executor migration.
+
+## [0.51.6] - 2026-03-31
+
+### Changed
+- Role-based review model, synthesis, and preset defaults.
+
+## [0.51.5] - 2026-03-29
+
+### Fixed
+- Bumped the `ace-bundle` runtime dependency constraint to `~> 0.41` to follow the new bundle minor release line.
+
 ## [0.51.4] - 2026-03-29
 
 ### Technical

data/README.md

@@ -38,5 +38,21 @@
 
 **Audit review history through session artifacts** - keep saved review sessions under `.ace-local/` for traceability, comparison, and handoff across contributors.
 
+## Testing
+
+Run package deterministic checks with:
+
+```bash
+ace-test ace-review
+ace-test ace-review feat
+ace-test ace-review all
+```
+
+Run retained workflow scenarios with:
+
+```bash
+ace-test-e2e ace-review
+```
+
 ---
 [Getting Started](docs/getting-started.md) | [Usage Guide](docs/usage.md) | [Handbook - Skills, Agents, Templates](docs/handbook.md) | Part of [ACE](https://github.com/cs3b/ace)

data/handbook/skills/as-review-pr/SKILL.md

@@ -22,10 +22,19 @@ integration:
     - pi
   providers: {}
 assign:
-  source: wfi://review/pr
   steps:
     - name: review-pr
       description: Review code changes for correctness, style, and best practices
+      prerequisites:
+        - name: create-pr
+          strength: required
+          reason: "Must have a PR to review"
+      produces: [review-feedback]
+      consumes: [pull-request]
+      when_to_skip:
+        - "No code changes since last review"
+        - "Changes are trivial (typo fix, config update)"
+      effort: medium
       tags: [review, quality]
       context:
         default: fork

data/handbook/workflow-instructions/review/run.wf.md

@@ -22,6 +22,7 @@ Review code using ace-review, verify feedback items, and create a plan for apply
 
   - `staged`, `working` - keywords (no prefix needed)
   - `diff:origin/main..HEAD` - git range (prefix required)
+  - `diff:origin/main...HEAD -- ace-test-runner-e2e` - git range filtered to paths
   - `pr:123` - PR diff (prefix required)
   - `files:lib/**/*.rb` - file pattern (prefix required)
   - `task:145` - task context (prefix required)
@@ -41,7 +42,7 @@ ace-review --preset $1 --auto-execute
 ace-review --subject "$2" --auto-execute
 
 # File pattern review (NOTE: files: prefix is REQUIRED)
-ace-review --preset spec --subject "files:.ace-taskflow/**/*.md" --auto-execute
+ace-review --preset spec --subject "files:.ace-task/**/*.md" --auto-execute
 
 # Multiple subjects merge automatically
 ace-review --subject pr:76 --subject files:CHANGELOG.md --auto-execute
@@ -259,4 +260,4 @@ The type prefix (`files:`, `pr:`, `diff:`, `task:`) is **required** for all subj
 - [ ] Feedback items verified (Critical/High priority)
 - [ ] False positives marked as invalid
 - [ ] Confirmed items implemented with commits
-- [ ] Items marked as resolved with commit references
+- [ ] Items marked as resolved with commit references

data/lib/ace/review/molecules/feedback_synthesizer.rb

@@ -26,6 +26,97 @@ module Ace
       #   result[:items]   #=> [FeedbackItem, ...] (with reviewers arrays)
       #
       class FeedbackSynthesizer
+        # Cached system prompt and prompt-path lookups to avoid repeated
+        # shell/file reads during test and command-heavy runs.
+        FALLBACK_SYSTEM_PROMPT = <<~PROMPT.freeze
+          Synthesize feedback from code review reports into unique findings.
+
+          For each unique issue found:
+          1. Track which reviewers identified it (by their model names)
+          2. Merge file references from all sources
+          3. Use the most comprehensive description
+          4. Mark consensus=true if 3+ reviewers agree
+
+          Return valid JSON with this schema:
+          {
+            "findings": [
+              {
+                "title": "Short title (max 60 chars)",
+                "files": ["path/file.rb:10-20"],
+                "reviewers": ["gemini-2.5-flash", "claude-3.5-sonnet"],
+                "consensus": false,
+                "priority": "high|medium|low|critical",
+                "finding": "Description of the issue",
+                "context": "Why this matters"
+              }
+            ]
+          }
+
+          IMPORTANT:
+          - When only one report: extract all findings as-is with that reviewer
+          - When multiple reports: deduplicate findings that describe the same issue
+          - When multiple reviewers find the same issue, list ALL of them in reviewers array
+          - Merge file arrays from all sources for each finding
+          - Return ONLY the JSON, no markdown code fences
+        PROMPT
+
+        class << self
+          def system_prompt(prompt_name)
+            system_prompt_cache_mutex.synchronize do
+              system_prompt_cache.fetch(prompt_name) do
+                prompt_path = resolve_prompt_path_cached(prompt_name)
+
+                if prompt_path && File.exist?(prompt_path)
+                  system_prompt_cache[prompt_name] = File.read(prompt_path)
+                else
+                  system_prompt_cache[prompt_name] = FALLBACK_SYSTEM_PROMPT
+                end
+              end
+            end
+          end
+
+          def resolve_prompt_path_cached(prompt_name)
+            prompt_path_cache[prompt_name] ||= begin
+              nav_result = begin
+                `ace-nav prompt://#{prompt_name} 2>/dev/null`.strip
+              rescue
+                ""
+              end
+
+              return nav_result unless nav_result.empty?
+
+              File.join(__dir__, "../../../../handbook/prompts", prompt_name)
+            end
+          end
+
+          def clear_prompt_cache!
+            system_prompt_cache_mutex.synchronize do
+              @system_prompt_cache = {}
+            end
+            prompt_path_cache_mutex.synchronize do
+              @prompt_path_cache = {}
+            end
+          end
+
+          private
+
+          def system_prompt_cache
+            @system_prompt_cache ||= {}
+          end
+
+          def prompt_path_cache
+            @prompt_path_cache ||= {}
+          end
+
+          def system_prompt_cache_mutex
+            @system_prompt_cache_mutex ||= Mutex.new
+          end
+
+          def prompt_path_cache_mutex
+            @prompt_path_cache_mutex ||= Mutex.new
+          end
+        end
+
         # Maximum combined report size before truncation (characters)
         MAX_COMBINED_SIZE = 200_000
 
@@ -138,51 +229,14 @@ module Ace
         #
         # @return [String] System prompt content
         def load_system_prompt
-          prompt_name = "synthesize-feedback.system.md"
-          prompt_path = resolve_prompt_path(prompt_name)
-
-          if File.exist?(prompt_path)
-            File.read(prompt_path)
-          else
-            fallback_synthesis_prompt
-          end
+          self.class.system_prompt("synthesize-feedback.system.md")
         end
 
         # Fallback synthesis prompt (used when prompt file not found)
         #
         # @return [String] Basic synthesis prompt
         def fallback_synthesis_prompt
-          <<~PROMPT
-            Synthesize feedback from code review reports into unique findings.
-
-            For each unique issue found:
-            1. Track which reviewers identified it (by their model names)
-            2. Merge file references from all sources
-            3. Use the most comprehensive description
-            4. Mark consensus=true if 3+ reviewers agree
-
-            Return valid JSON with this schema:
-            {
-              "findings": [
-                {
-                  "title": "Short title (max 60 chars)",
-                  "files": ["path/file.rb:10-20"],
-                  "reviewers": ["gemini-2.5-flash", "claude-3.5-sonnet"],
-                  "consensus": false,
-                  "priority": "high|medium|low|critical",
-                  "finding": "Description of the issue",
-                  "context": "Why this matters"
-                }
-              ]
-            }
-
-            IMPORTANT:
-            - When only one report: extract all findings as-is with that reviewer
-            - When multiple reports: deduplicate findings that describe the same issue
-            - When multiple reviewers find the same issue, list ALL of them in reviewers array
-            - Merge file arrays from all sources for each finding
-            - Return ONLY the JSON, no markdown code fences
-          PROMPT
+          FALLBACK_SYSTEM_PROMPT
         end
 
         # Build user prompt for report synthesis
@@ -522,16 +576,7 @@ module Ace
         # @param prompt_name [String] Prompt filename
         # @return [String] Resolved file path
         def resolve_prompt_path(prompt_name)
-          # Try ace-nav first if available
-          nav_result = begin
-            `ace-nav prompt://#{prompt_name} 2>/dev/null`.strip
-          rescue
-            ""
-          end
-          return nav_result unless nav_result.empty?
-
-          # Fallback to direct path
-          File.join(__dir__, "../../../../handbook/prompts", prompt_name)
+          self.class.resolve_prompt_path_cached(prompt_name)
         end
 
         # Get default synthesis model from config

data/lib/ace/review/molecules/gh_comment_poster.rb

@@ -53,7 +53,8 @@ module Ace
               error: "Failed to post comment: #{result[:stderr]}"
             }
           end
-        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError
+        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError,
+          Ace::Git::GhNotInstalledError, Ace::Git::GhAuthenticationError
           raise
         rescue => e
           {
@@ -68,7 +69,7 @@ module Ace
         # @return [Hash] Result with :success or :error
         def self.check_pr_state(gh_format)
           # Fetch PR metadata
-          result = Ace::Review::Molecules::GhCliExecutor.execute(
+          result = Ace::Git::Molecules::GhCliExecutor.execute(
             "pr",
             ["view", gh_format, "--json", "state,number"]
           )
@@ -169,7 +170,7 @@ module Ace
             file.flush
 
             # Post using gh pr comment
-            Ace::Review::Molecules::GhCliExecutor.execute(
+            Ace::Git::Molecules::GhCliExecutor.execute(
               "pr",
               ["comment", gh_format, "--body-file", file.path]
             )

data/lib/ace/review/molecules/gh_comment_resolver.rb

@@ -34,7 +34,7 @@ module Ace
           timeout = options[:timeout] || 30
 
           # Post comment using gh CLI
-          result = Ace::Review::Molecules::GhCliExecutor.execute(
+          result = Ace::Git::Molecules::GhCliExecutor.execute(
             "pr",
             ["comment", gh_format, "--body", body],
             timeout: timeout
@@ -54,7 +54,8 @@ module Ace
               error: "Failed to post reply: #{result[:stderr]}"
             }
           end
-        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError
+        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError,
+          Ace::Git::GhNotInstalledError, Ace::Git::GhAuthenticationError
           raise
         rescue => e
           {
@@ -91,7 +92,7 @@ module Ace
           mutation = build_resolve_thread_mutation(thread_id)
 
           # Execute via gh api graphql
-          result = Ace::Review::Molecules::GhCliExecutor.execute(
+          result = Ace::Git::Molecules::GhCliExecutor.execute(
             "api",
             ["graphql", "-f", "query=#{mutation}"],
             timeout: timeout
@@ -118,7 +119,8 @@ module Ace
               error: "Failed to resolve thread: #{result[:stderr]}"
             }
           end
-        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError
+        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError,
+          Ace::Git::GhNotInstalledError, Ace::Git::GhAuthenticationError
           raise
         rescue => e
           {

data/lib/ace/review/molecules/gh_pr_comment_fetcher.rb

@@ -82,7 +82,7 @@ module Ace
           fields = "comments,reviews,number,title,author"
 
           result = Ace::Review::Atoms::RetryWithBackoff.execute(options) do
-            Ace::Review::Molecules::GhCliExecutor.execute("pr", ["view", gh_format, "--json", fields], timeout: timeout)
+            Ace::Git::Molecules::GhCliExecutor.execute("pr", ["view", gh_format, "--json", fields], timeout: timeout)
           end
 
           if result[:success]
@@ -116,7 +116,8 @@ module Ace
             success: false,
             error: "Failed to parse PR comments: #{e.message}"
           }
-        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError
+        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError,
+          Ace::Git::GhNotInstalledError, Ace::Git::GhAuthenticationError
           raise
         rescue => e
           {
@@ -250,7 +251,7 @@ module Ace
 
           # Execute GraphQL query
           result = Ace::Review::Atoms::RetryWithBackoff.execute(options) do
-            Ace::Review::Molecules::GhCliExecutor.execute(
+            Ace::Git::Molecules::GhCliExecutor.execute(
               "api",
               [
                 "graphql",
@@ -382,7 +383,7 @@ module Ace
         # @return [String, nil] "owner/name" format or nil if not a GitHub repo
         def self.discover_repo_from_remote(options = {})
           timeout = options[:timeout] || 10
-          result = Ace::Review::Molecules::GhCliExecutor.execute(
+          result = Ace::Git::Molecules::GhCliExecutor.execute(
             "repo",
             ["view", "--json", "owner,name"],
             timeout: timeout

data/lib/ace/review/molecules/gh_pr_fetcher.rb

@@ -26,7 +26,7 @@ module Ace
 
           # Fetch diff with retry logic
           result = Ace::Review::Atoms::RetryWithBackoff.execute(options) do
-            Ace::Review::Molecules::GhCliExecutor.execute("pr", ["diff", gh_format], timeout: timeout)
+            Ace::Git::Molecules::GhCliExecutor.execute("pr", ["diff", gh_format], timeout: timeout)
           end
 
           if result[:success]
@@ -42,7 +42,8 @@ module Ace
         rescue Ace::Review::Errors::DiffTooLargeError
           # Fall back to local git diff when GitHub API rejects large diffs
           fetch_local_diff_fallback(pr_identifier, options)
-        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError
+        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError,
+          Ace::Git::GhNotInstalledError, Ace::Git::GhAuthenticationError
           # Re-raise authentication and installation errors
           raise
         rescue => e
@@ -70,7 +71,7 @@ module Ace
           fields = "number,state,isDraft,title,body,author,headRefName,baseRefName,url"
 
           result = Ace::Review::Atoms::RetryWithBackoff.execute(options) do
-            Ace::Review::Molecules::GhCliExecutor.execute("pr", ["view", gh_format, "--json", fields], timeout: timeout)
+            Ace::Git::Molecules::GhCliExecutor.execute("pr", ["view", gh_format, "--json", fields], timeout: timeout)
           end
 
           if result[:success]
@@ -89,7 +90,8 @@ module Ace
             success: false,
             error: "Failed to parse PR metadata: #{e.message}"
           }
-        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError
+        rescue Ace::Review::Errors::GhCliNotInstalledError, Ace::Review::Errors::GhAuthenticationError,
+          Ace::Git::GhNotInstalledError, Ace::Git::GhAuthenticationError
           raise
         rescue => e
           {

data/lib/ace/review/molecules/subject_extractor.rb

@@ -177,7 +177,7 @@ module Ace
         def parse_typed_subject(input)
           case input
           when /^diff:(.+)$/
-            {"bundle" => {"diffs" => [::Regexp.last_match(1)]}}
+            {"bundle" => parse_diff_subject(::Regexp.last_match(1))}
           when /^diff:$/
             raise ArgumentError, "Empty value for diff: subject. Usage: diff:RANGE (e.g., diff:HEAD~3...HEAD)"
           when /^pr:(.+)$/
@@ -224,6 +224,30 @@ module Ace
           end
         end
 
+        def parse_diff_subject(value)
+          subject_value = value.to_s.strip
+          raise ArgumentError, "Empty value for diff: subject. Usage: diff:RANGE (e.g., diff:HEAD~3...HEAD)" if subject_value.empty?
+
+          if (match = subject_value.match(/\A(.+?)\s+--(?:\s+(.*))?\z/))
+            diff_range = match[1].to_s.strip
+            path_string = match[2].to_s
+          else
+            diff_range = subject_value
+            path_string = nil
+          end
+
+          raise ArgumentError, "Empty value for diff: subject. Usage: diff:RANGE (e.g., diff:HEAD~3...HEAD)" if diff_range.empty?
+
+          config = {"diffs" => [diff_range]}
+          return config if path_string.nil?
+
+          paths = path_string.split(/[,\s]+/).map(&:strip).reject(&:empty?).uniq
+          raise ArgumentError, "No valid paths specified after -- for diff: subject" if paths.empty?
+
+          config["paths"] = paths
+          config
+        end
+
         # Default timeout for ace-task subprocess (in seconds)
         # Can be overridden via options for environments with slow I/O
         TASKFLOW_TIMEOUT = 10

data/lib/ace/review/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Review
-    VERSION = '0.51.4'
+    VERSION = '0.53.5'
   end
 end

data/lib/ace/review.rb

@@ -37,7 +37,6 @@ require_relative "review/molecules/preset_manager"
 require_relative "review/molecules/prompt_composer"
 require_relative "review/molecules/nav_prompt_resolver"
 require_relative "review/molecules/subject_extractor"
-require_relative "review/molecules/gh_cli_executor"
 require_relative "review/molecules/gh_pr_fetcher"
 require_relative "review/molecules/gh_pr_comment_fetcher"
 require_relative "review/molecules/gh_comment_poster"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-review
 version: !ruby/object:Gem::Version
-  version: 0.51.4
+  version: 0.53.5
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-03-29 00:00:00.000000000 Z
+date: 2026-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-support-cli
@@ -71,14 +71,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.40'
+        version: '0.41'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.40'
+        version: '0.41'
 - !ruby/object:Gem::Dependency
   name: ace-git
   requirement: !ruby/object:Gem::Requirement
@@ -300,7 +300,6 @@ files:
 - lib/ace/review/molecules/feedback_file_reader.rb
 - lib/ace/review/molecules/feedback_file_writer.rb
 - lib/ace/review/molecules/feedback_synthesizer.rb
-- lib/ace/review/molecules/gh_cli_executor.rb
 - lib/ace/review/molecules/gh_comment_poster.rb
 - lib/ace/review/molecules/gh_comment_resolver.rb
 - lib/ace/review/molecules/gh_pr_comment_fetcher.rb

data/lib/ace/review/molecules/gh_cli_executor.rb

@@ -1,124 +0,0 @@
-# frozen_string_literal: true
-
-require "open3"
-require "timeout"
-
-module Ace
-  module Review
-    module Molecules
-      # Safely execute gh CLI commands with error handling
-      class GhCliExecutor
-        # Default timeout for gh CLI operations
-        DEFAULT_GH_TIMEOUT = 30
-
-        # Execute a gh CLI command
-        #
-        # @param subcommand [String] The gh subcommand (e.g., "pr", "api")
-        # @param args [Array<String>] Arguments to pass to the subcommand
-        # @param options [Hash] Additional options
-        # @option options [Integer] :timeout Timeout in seconds (default: from config or 30)
-        # @return [Hash] Result with :success, :stdout, :stderr, :exit_code
-        def self.execute(subcommand, args = [], options = {})
-          check_installed
-
-          timeout_seconds = options[:timeout] ||
-            Ace::Review.get("defaults", "gh_timeout") ||
-            DEFAULT_GH_TIMEOUT
-          command = ["gh", subcommand] + args
-
-          run_command(command, timeout_seconds)
-        rescue Timeout::Error
-          raise Ace::Review::Errors::GhNetworkError, "gh command timed out after #{timeout_seconds} seconds"
-        end
-
-        # Check if gh CLI is installed
-        #
-        # @return [Boolean] true if installed
-        # @raise [GhCliNotInstalledError] if not installed
-        def self.check_installed
-          result = execute_simple("--version")
-          result[:success]
-        rescue Ace::Review::Errors::GhCliNotInstalledError
-          raise
-        end
-
-        # Check if user is authenticated with GitHub
-        #
-        # @return [Hash] Auth status with :authenticated, :username
-        # @raise [GhAuthenticationError] if not authenticated
-        def self.check_authenticated
-          result = execute_simple("auth", ["status"])
-
-          if result[:success]
-            # Extract username from stderr (gh auth status outputs to stderr)
-            username = extract_username(result[:stderr])
-            {
-              authenticated: true,
-              username: username
-            }
-          else
-            raise Ace::Review::Errors::GhAuthenticationError
-          end
-        end
-
-        # Default timeout for simple operations
-        DEFAULT_SIMPLE_TIMEOUT = 10
-
-        # Execute a simple gh command without error checking
-        # Used internally to avoid infinite recursion in check_installed
-        #
-        # @param command [String] The gh subcommand
-        # @param args [Array<String>] Arguments
-        # @param timeout_seconds [Integer] Timeout in seconds (default: from config or 10)
-        # @return [Hash] Result hash
-        def self.execute_simple(command, args = [], timeout_seconds = nil)
-          timeout_seconds ||= Ace::Review.get("defaults", "gh_simple_timeout") || DEFAULT_SIMPLE_TIMEOUT
-          cmd = ["gh", command] + args
-          run_command(cmd, timeout_seconds)
-        rescue Timeout::Error
-          {
-            success: false,
-            stdout: "",
-            stderr: "Command timed out",
-            exit_code: 1
-          }
-        end
-
-        # Extract username from gh auth status output
-        #
-        # @param output [String] Output from gh auth status
-        # @return [String, nil] Username if found
-        def self.extract_username(output)
-          # gh auth status output format: "✓ Logged in to github.com as username ..."
-          match = output.match(/Logged in to .+ as (\S+)/)
-          match ? match[1] : nil
-        end
-
-        # Execute a command with timeout and error handling
-        # Private helper to reduce duplication between execute and execute_simple
-        #
-        # @param command [Array<String>] Full command array including "gh"
-        # @param timeout_seconds [Integer] Timeout in seconds
-        # @return [Hash] Result with :success, :stdout, :stderr, :exit_code
-        # @raise [GhCliNotInstalledError] if gh is not installed
-        # @raise [Timeout::Error] if command times out (caller should handle)
-        def self.run_command(command, timeout_seconds)
-          stdout_str, stderr_str, status = Timeout.timeout(timeout_seconds) do
-            Open3.capture3(*command)
-          end
-
-          {
-            success: status.success?,
-            stdout: stdout_str,
-            stderr: stderr_str,
-            exit_code: status.exitstatus
-          }
-        rescue Errno::ENOENT
-          raise Ace::Review::Errors::GhCliNotInstalledError
-        end
-
-        private_class_method :execute_simple, :extract_username, :run_command
-      end
-    end
-  end
-end