ace-idea 0.18.5 → 0.21.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bf7ef23ac4a38f4d26294f5fb596febbb00a78b4279043a2909a47e510bb5387
-  data.tar.gz: 6f533a3b40614a87f532c0a14bf0060a577c825409b00b90aa4fd26b71644cb8
+  metadata.gz: '0669d1f1ea0f1d9e894bf29551ae7575a81983bffe85fb0de6225edca8a3b6de'
+  data.tar.gz: 2cfa1bd44ac20a02f462d35f8bafd27374bb4533a2719e0192a783707437fcaa
 SHA512:
-  metadata.gz: ffc4926286559c5df48894692633cb977c72228c893595213ceb4dcff52a1c3788b78f5d58c2509449b054c540f5937b2723fcffb9fa5586ca95544108536114
-  data.tar.gz: 0f3927c864fb1a43ab51f5930b883daaa943168e67917ba836329352c613dc24570805a308543945f52887f3d39af90c930cd3ab9e06b8dbcd3c781b8b900776
+  metadata.gz: ebdfaaf5c40128b9cc02c0aad4afee4428fca994bf5c859ca0d61ecfeb9c81921e8450cab9ff9b6a91f326c509b9ccc44922d247c7e5298c6d36bd5bacd73342
+  data.tar.gz: 1e448f583770a87ee3169173bf23b9dbffdfd27541e66fcbb35b1a0d61bdb5f5340e423f1ab2fbf06f9a886e4c4e9d93b52ca0dd91477ba31955df828cabd92e

data/CHANGELOG.md

@@ -7,6 +7,91 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.21.3] - 2026-04-20
+
+### Fixed
+- Updated stale idea workflow and root quick-start docs so `next` is consistently documented as the root-scope queue alias rather than a physical `_next` folder.
+
+### Technical
+- Tightened `TS-IDEA-001` move-to-next E2E contracts so Goal 3 requires raw update/list artifacts and verifies the `next` transition before the later archive step mutates final state.
+
+## [0.21.2] - 2026-04-18
+
+### Fixed
+- Pinned `TS-IDEA-001` to a sandbox-local `.ace-ideas` root so archive-listing lifecycle coverage no longer depends on ambient project-root discovery.
+
+### Technical
+- Added a CLI regression proving `ace-idea list --in archive` surfaces an idea immediately after `update --move-to archive`.
+
+## [0.21.1] - 2026-04-16
+
+### Fixed
+- Updated `TS-IDEA-001` sandbox setup to source `mise.toml` from `${ACE_E2E_SOURCE_ROOT:-$PROJECT_ROOT_PATH}`, keeping idea lifecycle runs compatible with read-only source-root mounts.
+
+## [0.21.0] - 2026-04-14
+
+### Changed
+- Reworked `TS-IDEA-001` lifecycle runner instructions around public command-output ID flow (`create` output to `update`/archive transitions) instead of hidden frontmatter ID recipes.
+
+### Technical
+- Reduced duplicated list assertions across lifecycle scenario goals and added lightweight scenario freshness metadata (`last-verified` + freshness policy) for E2E maintenance.
+
+## [0.20.2] - 2026-04-13
+
+### Fixed
+- Made create-time collision retries deterministic by reusing one precomputed payload across retries so clipboard capture and LLM enhancement are not rerun with divergent inputs.
+
+### Technical
+- Added manager-level regression coverage to enforce payload reuse semantics across collision retries.
+
+## [0.20.1] - 2026-04-13
+
+### Fixed
+- Added atomic idea-ID reservation during create so concurrent creates fail fast with retryable collision semantics instead of racing through non-atomic prechecks.
+
+### Technical
+- Narrowed idea ID-existence scans to ID-prefixed glob matches and added regression coverage for reservation-lock collision handling.
+
+## [0.20.0] - 2026-04-13
+
+### Fixed
+- Added duplicate persisted idea-ID detection to doctor health checks and made frontmatter-only doctor validation fail when duplicates are present.
+- Added bounded retry handling for `ace-idea create` ID collisions, including retry-exhaustion failures and enforcement that same-ID/different-slug creates are not treated as success.
+
+### Technical
+- Added regression coverage for duplicate-ID doctor failures, create-time retry semantics, and orphan-artifact cleanup guarantees.
+
+## [0.19.3] - 2026-04-13
+
+### Fixed
+- Added bounded retry handling for `ace-idea create` ID collisions so success is emitted only after a unique persisted idea ID exists.
+- Enforced create-time collision semantics where "same ID, different folder slug" is no longer treated as successful creation.
+- Added clear retry-exhaustion failure messaging for create-time ID collisions.
+
+### Technical
+- Updated molecule, command, and feature regression coverage to validate ID-retry semantics and no-orphan cleanup behavior.
+
+## [0.19.2] - 2026-04-13
+
+### Fixed
+- Report duplicate persisted idea IDs as explicit doctor health-check errors with file-path context.
+- Include duplicate ID detection in `ace-idea doctor --check frontmatter` and fail health status when duplicates are present.
+
+### Technical
+- Added organism and CLI regression coverage for duplicate ID failures and frontmatter-only doctor checks.
+
+## [0.19.1] - 2026-04-13
+
+### Changed
+- Completed the batch i05 migration follow-through for this package and aligned it with the restarted `fast` / `feat` / `e2e` verification model.
+
+### Technical
+- Included in the coordinated assignment-driven patch release for batch i05 package updates.
+
+
+### Changed
+- Migrated deterministic package coverage to `test/fast` and `test/feat`, retained lifecycle workflow coverage in `test/e2e`, and updated E2E scenario metadata to the restarted `fast`/`feat`/`e2e` contract.
+
 ## [0.18.5] - 2026-03-31
 
 ### Changed

data/docs/usage.md

@@ -3,8 +3,8 @@ doc-type: user
 title: ace-idea CLI Usage Reference
 purpose: Command reference for ace-idea
 ace-docs:
-  last-updated: 2026-03-22
-  last-checked: 2026-03-22
+  last-updated: '2026-04-13'
+  last-checked: '2026-04-13'
 ---
 
 # ace-idea CLI Usage Reference
@@ -92,6 +92,11 @@ ace-idea status --up-next-limit 5
 
 Create a new idea from direct text or clipboard input.
 
+If the generated idea ID collides with an existing persisted idea, `ace-idea create`
+automatically retries with a new ID. If retries are exhausted, the command fails
+without leaving behind a partial idea artifact. A same-ID create under a different
+folder slug is treated as a collision, not a successful create.
+
 **Syntax:**
 
 ```bash
@@ -210,6 +215,9 @@ ace-idea update q7w --move-to archive
 
 Run health checks across the idea store.
 
+Duplicate persisted idea IDs are reported as errors. `ace-idea doctor --check frontmatter`
+also fails when duplicate IDs are present in idea frontmatter.
+
 **Syntax:**
 
 ```bash
@@ -317,4 +325,4 @@ ID if needed.
 
 **Symptom:** The configured ideas root does not exist yet.
 
-**Solution:** Create an idea first or set `idea.root_dir` in config before running `doctor`.
+**Solution:** Create an idea first or set `idea.root_dir` in config before running `doctor`.

data/handbook/workflow-instructions/idea/capture.wf.md

@@ -178,8 +178,8 @@ ace-idea update q7w --move-to archive
 * **Note**: Clipboard functionality requires `ace-support-mac-clipboard` gem
 
 **"Invalid target folder" Error:**
-* **Cause**: `--move-to` was given a virtual filter (e.g., `next`) instead of a physical folder
-* **Solution**: Use a physical folder: `maybe`, `anytime`, `archive`, or any custom name. Note: `next` is a virtual filter for listing, not a physical folder — omit `--move-to` to place ideas in root
+* **Cause**: `--move-to` was given an unsupported or invalid folder value
+* **Solution**: Use a physical folder such as `maybe`, `anytime`, `archive`, or any custom name. Use `--move-to next` or `--move-to root` to place ideas in the root-scope next queue.
 
 **LLM Enhancement Failures:**
 * **Cause**: API issues, model unavailability, or `--no-llm-enhance` flag

data/handbook/workflow-instructions/idea/prioritize.wf.md

@@ -94,7 +94,7 @@ Systematically organize, prioritize, and align queued ideas with current project
      ```
 
    **How it works:**
-   * Updates move idea files between folders (`_next`, `_maybe`, `_anytime`)
+   * Updates move idea files between physical folders (`_maybe`, `_anytime`) or back to the root-scope `next` queue
    * Ideas are listed per folder when using `ace-idea list --in <folder>`
    * The same command can also update metadata such as `status` when needed
 

data/lib/ace/idea/cli/commands/create.rb

@@ -71,14 +71,18 @@ module Ace
             end
 
             manager = Ace::Idea::Organisms::IdeaManager.new
-            idea = manager.create(
-              content,
-              title: title,
-              tags: tags,
-              move_to: move_to,
-              clipboard: clipboard || false,
-              llm_enhance: llm_enhance || false
-            )
+            idea = begin
+              manager.create(
+                content,
+                title: title,
+                tags: tags,
+                move_to: move_to,
+                clipboard: clipboard || false,
+                llm_enhance: llm_enhance || false
+              )
+            rescue Ace::Idea::Organisms::IdeaManager::CreateRetriesExhaustedError => e
+              raise Ace::Support::Cli::Error, e.message
+            end
 
             folder_info = idea.special_folder ? " (#{idea.special_folder})" : ""
             puts "Idea created: #{idea.id} #{idea.title}#{folder_info}"

data/lib/ace/idea/molecules/idea_clipboard_reader.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-# Clipboard reader adapted from ace-taskflow's ClipboardReader.
-# Kept independent (no ace-taskflow dependency) as per task spec:
-# "Shared utilities from ace-taskflow are duplicated rather than centralized."
+# Clipboard reader adapted from ace-task's ClipboardReader.
+# Kept independent (no ace-task dependency) as per task spec:
+# "Shared utilities from ace-task are duplicated rather than centralized."
 
 begin
   require "clipboard"

data/lib/ace/idea/molecules/idea_creator.rb

@@ -16,6 +16,8 @@ module Ace
       # Creates new ideas with b36ts IDs, folder/file creation.
       # Supports --clipboard, --llm-enhance, and --move-to options.
       class IdeaCreator
+        class IdCollisionError < StandardError; end
+
         # @param root_dir [String] Root directory for ideas
         # @param config [Hash] Configuration hash
         def initialize(root_dir:, config: {})
@@ -33,66 +35,102 @@ module Ace
         # @param time [Time] Creation time (default: now)
         # @return [Idea] Created idea object
         def create(content = nil, title: nil, tags: [], move_to: nil,
-          clipboard: false, llm_enhance: false, time: Time.now.utc)
-          # Step 1: Gather content
+          clipboard: false, llm_enhance: false, time: Time.now.utc, prepared_payload: nil)
+          payload = prepared_payload || prepare_create_payload(content, clipboard: clipboard, llm_enhance: llm_enhance)
+          enhanced_body = payload.fetch(:enhanced_body)
+          attachments_to_save = payload.fetch(:attachments_to_save)
+
+          # Step 3: Generate ID and slugs
+          id = Atoms::IdeaIdFormatter.generate(time)
+          with_id_reservation(id) do
+            raise IdCollisionError, "Idea ID collision detected for #{id}" if idea_id_exists?(id)
+
+            slug_title = title || extract_title(enhanced_body)
+            folder_slug = generate_folder_slug(slug_title)
+            file_slug = generate_file_slug(slug_title)
+
+            # Step 4: Determine target directory
+            target_dir = determine_target_dir(move_to)
+            FileUtils.mkdir_p(target_dir)
+
+            # Step 5: Create idea folder
+            folder_name, _ = unique_folder_name(id, folder_slug, target_dir)
+            idea_dir = File.join(target_dir, folder_name)
+            FileUtils.mkdir_p(idea_dir)
+
+            begin
+              # Step 6: Handle attachments
+              if attachments_to_save.any?
+                enhanced_body = save_attachments_and_inject_refs(attachments_to_save, idea_dir, enhanced_body)
+              end
+
+              # Step 7: Write spec file
+              effective_title = title || extract_title(enhanced_body) || "Untitled Idea"
+              frontmatter = Atoms::IdeaFrontmatterDefaults.build(
+                id: id,
+                title: effective_title,
+                tags: tags,
+                status: "pending",
+                created_at: time
+              )
+
+              file_content = build_file_content(frontmatter, enhanced_body, effective_title)
+              spec_filename = Atoms::IdeaFilePattern.spec_filename(id, file_slug)
+              spec_file = File.join(idea_dir, spec_filename)
+              File.write(spec_file, file_content)
+
+              # Step 8: Load and return the created idea
+              loader = IdeaLoader.new
+              special_folder = Ace::Support::Items::Atoms::SpecialFolderDetector.detect_in_path(
+                idea_dir, root: @root_dir
+              )
+              loader.load(idea_dir, id: id, special_folder: special_folder)
+            rescue StandardError
+              FileUtils.rm_rf(idea_dir) if Dir.exist?(idea_dir)
+              raise
+            end
+          end
+        end
+
+        def prepare_create_payload(content, clipboard: false, llm_enhance: false)
           body, attachments_to_save = gather_content(content, clipboard: clipboard)
 
           if body.nil? || body.strip.empty?
             raise ArgumentError, "No content provided. Provide text or use --clipboard."
           end
 
-          # Step 2: Optionally enhance with LLM
           enhanced_body = if llm_enhance
             enhance_with_llm(body, config: @config)
           else
             body
           end
 
-          # Step 3: Generate ID and slugs
-          id = Atoms::IdeaIdFormatter.generate(time)
-          slug_title = title || extract_title(enhanced_body)
-          folder_slug = generate_folder_slug(slug_title)
-          file_slug = generate_file_slug(slug_title)
-
-          # Step 4: Determine target directory
-          target_dir = determine_target_dir(move_to)
-          FileUtils.mkdir_p(target_dir)
-
-          # Step 5: Create idea folder (ensure unique name if ID collision occurs)
-          folder_name, _ = unique_folder_name(id, folder_slug, target_dir)
-          idea_dir = File.join(target_dir, folder_name)
-          FileUtils.mkdir_p(idea_dir)
-
-          # Step 6: Handle attachments
-          if attachments_to_save.any?
-            enhanced_body = save_attachments_and_inject_refs(attachments_to_save, idea_dir, enhanced_body)
-          end
-
-          # Step 7: Write spec file
-          effective_title = title || extract_title(enhanced_body) || "Untitled Idea"
-          frontmatter = Atoms::IdeaFrontmatterDefaults.build(
-            id: id,
-            title: effective_title,
-            tags: tags,
-            status: "pending",
-            created_at: time
-          )
-
-          file_content = build_file_content(frontmatter, enhanced_body, effective_title)
-          spec_filename = Atoms::IdeaFilePattern.spec_filename(id, file_slug)
-          spec_file = File.join(idea_dir, spec_filename)
-          File.write(spec_file, file_content)
-
-          # Step 8: Load and return the created idea
-          loader = IdeaLoader.new
-          special_folder = Ace::Support::Items::Atoms::SpecialFolderDetector.detect_in_path(
-            idea_dir, root: @root_dir
-          )
-          loader.load(idea_dir, id: id, special_folder: special_folder)
+          {
+            enhanced_body: enhanced_body,
+            attachments_to_save: attachments_to_save
+          }
         end
 
         private
 
+        def idea_id_exists?(id)
+          Dir.glob(File.join(@root_dir, "**", "#{id}-*")).any? do |path|
+            File.directory?(path)
+          end
+        end
+
+        def with_id_reservation(id)
+          reservation_path = File.join(@root_dir, ".ace-idea-id-lock-#{id}")
+          acquired = false
+          Dir.mkdir(reservation_path)
+          acquired = true
+          yield
+        rescue Errno::EEXIST
+          raise IdCollisionError, "Idea ID collision detected for #{id}"
+        ensure
+          FileUtils.rm_rf(reservation_path) if acquired && reservation_path && Dir.exist?(reservation_path)
+        end
+
         def gather_content(content, clipboard: false)
           attachments = []
 

data/lib/ace/idea/organisms/idea_doctor.rb

@@ -117,11 +117,18 @@ module Ace
 
           scan_results = scanner.scan
           @stats[:ideas_scanned] = scan_results.size
+          id_locations = Hash.new { |hash, key| hash[key] = [] }
 
           scan_results.each do |scan_result|
             spec_file = scan_result.file_path
             next unless spec_file && File.exist?(spec_file)
 
+            content = File.read(spec_file)
+            frontmatter, _body = Ace::Support::Items::Atoms::FrontmatterParser.parse(content)
+            if frontmatter.is_a?(Hash) && frontmatter["id"] && !frontmatter["id"].to_s.strip.empty?
+              id_locations[frontmatter["id"]] << spec_file
+            end
+
             issues = Molecules::IdeaFrontmatterValidator.validate(
               spec_file,
               special_folder: scan_result.special_folder
@@ -134,6 +141,8 @@ module Ace
               add_issue(issue[:type], issue[:message], issue[:location])
             end
           end
+
+          add_duplicate_id_issues(id_locations)
         end
 
         def run_scope_check
@@ -183,6 +192,18 @@ module Ace
           count
         end
 
+        def add_duplicate_id_issues(id_locations)
+          id_locations.each do |id, locations|
+            next unless locations.size > 1
+
+            add_issue(
+              :error,
+              "Duplicate idea ID '#{id}' found in: #{locations.sort.join(', ')}",
+              locations.first
+            )
+          end
+        end
+
         def add_issue(type, message, location = nil)
           issue = {type: type, message: message}
           issue[:location] = location if location

data/lib/ace/idea/organisms/idea_manager.rb

@@ -15,6 +15,9 @@ module Ace
       # Orchestrates all idea CRUD operations.
       # Entry point for idea management with config-driven root directory.
       class IdeaManager
+        CREATE_RETRY_LIMIT = 3
+        class CreateRetriesExhaustedError < StandardError; end
+
         attr_reader :last_list_total, :last_folder_counts
 
         # @param root_dir [String, nil] Override root directory for ideas
@@ -36,8 +39,30 @@ module Ace
           clipboard: false, llm_enhance: false)
           ensure_root_dir
           creator = Molecules::IdeaCreator.new(root_dir: @root_dir, config: @config)
-          creator.create(content, title: title, tags: tags, move_to: move_to,
-            clipboard: clipboard, llm_enhance: llm_enhance)
+          prepared_payload = creator.prepare_create_payload(
+            content,
+            clipboard: clipboard,
+            llm_enhance: llm_enhance
+          )
+          attempts = 0
+
+          begin
+            attempts += 1
+            creator.create(
+              nil,
+              title: title,
+              tags: tags,
+              move_to: move_to,
+              clipboard: false,
+              llm_enhance: false,
+              time: Time.now.utc + ((attempts - 1) * 2),
+              prepared_payload: prepared_payload
+            )
+          rescue Molecules::IdeaCreator::IdCollisionError
+            retry if attempts < CREATE_RETRY_LIMIT
+            raise CreateRetriesExhaustedError,
+              "Failed to create idea: unable to generate a unique ID after #{CREATE_RETRY_LIMIT} attempts"
+          end
         end
 
         # Create an idea from clipboard

data/lib/ace/idea/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Idea
-    VERSION = '0.18.5'
+    VERSION = '0.21.3'
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-idea
 version: !ruby/object:Gem::Version
-  version: 0.18.5
+  version: 0.21.3
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-04-01 00:00:00.000000000 Z
+date: 2026-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-support-core