ace-git 0.31.0 → 0.33.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 83d5b624eab98d754e4bb770fdd1a80e00237d063bc07ba2b412e31cf0b4fa87
-  data.tar.gz: 1e8a556aedb3f9ba844ebe46a7b3c64adea58b979842bf6df7835742057c20c1
+  metadata.gz: 183166f8ce864a5503f765212e4a0a89e26ec22f03dca7ab8a918c9499ec064a
+  data.tar.gz: 5c3eaa10c29b1873bf504cecaff12ac77806740f1bf1ee1e3c8372081c9d18e4
 SHA512:
-  metadata.gz: 8c33109eb792dea197dc9e29a9f63839ed10d53c95aa7e1817d22cbbe2cbecc51123f8fe90ad420a2e908b35a6aa1bbaef35612340bcd667ad21b5736dbdad49
-  data.tar.gz: a2b337d9084ff29b01cd0834e2e9e9a3ef36299d0c0704bdad61480d844cd1a0165f1d4b9c482c5acf0feb29d0dc6aaa715e992dca1e2fa50d6abeb736e234f7
+  metadata.gz: 21397a89baadadc17c0c18ce73c3fb558a6195133381e6f26df5e4ab897e025cff8aaa563b2cb6169400d8a5a7f43c2ff7c8549d6af261389d0690ba40c35fef
+  data.tar.gz: 2067ddf2e8871231ed33e0392aa922a429114b68c25dd9c3fe914c3d88d0df185ecc3ebebb2b4f9a1433a9a882c9c6aa147978616a2c03c31a2967508fd3e790

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.33.0] - 2026-11-10
+
+### Added
+
+- Include PR authors and semantic issue bodies in provider evidence. Verify scoped formal reviewer identity and exact HEAD; reject oversized or invalid UTF-8 PR bodies instead of truncating them.
+## [0.32.0] - 2026-10-30
+
+### Added
+
+- `wfi://git/mirror-sync` (task 8xs.t.pu0.d): the repeatable host
+  mirror-sync operation — explicit source/target/ref, both full SHAs read
+  before acting, identity no-op, fast-forward only (`--force-with-lease`
+  with the read SHA), divergence escalated for reviewed reconciliation
+  (never reset/force/ref deletion), reversed-direction detection in the
+  plan, and a mutation-free dry-run.
+
 ## [0.31.0] - 2026-10-23
 
 ### Added

data/handbook/workflow-instructions/git/mirror-sync.wf.md

@@ -0,0 +1,84 @@
+---
+name: git-mirror-sync
+description: Repeatable host mirror-sync operation — explicit source/target/ref, both full SHAs read before acting, identity no-op, fast-forward only, divergence escalated for reviewed reconciliation
+allowed-tools: Bash, Read
+doc-type: workflow
+title: Host Mirror Sync Workflow
+purpose: Bind the host operator's forge-mirror sync as a repeatable, evidenced operation: never destructive, always checkable, with the actual source and target SHAs in the result.
+ace-docs:
+  last-updated: '2026-10-30'
+  last-checked: '2026-10-30'
+---
+# Host Mirror Sync Workflow
+
+## Goal
+
+Synchronize an explicitly named target ref from an explicitly named source
+ref (task 8xs.t.pu0.d — for this family: source `fg` Forgejo `cs3b/ace`,
+target `origin` GitHub `cs3b/ace`) as a REPEATABLE host operation with a
+checkable result. This is an ordinary Git workflow — no new script, no
+hardcoded lab topology, no tool change; if a capability is missing it
+belongs in ace-git's adapters.
+
+## Instructions
+
+Run the loaded workflow as the source of truth and execute it end-to-end
+instead of only summarizing it.
+
+### 1) Name the operation and read BOTH full SHAs first
+
+Before ANY action, read and record the full SHAs of the exact source and
+target refs. An operation without both SHAs is not runnable:
+
+```bash
+git ls-remote fg refs/heads/main     # source SHA (record it)
+git ls-remote origin refs/heads/main # target SHA (record it)
+```
+
+### 2) Classify
+
+- **Identity** (source SHA == target SHA): the sync is a NO-OP. Report both
+  SHAs and the result `identity`; do not touch anything.
+- **Fast-forward** (target SHA is an ancestor of source): proceed.
+- **Divergence** (neither of the above): STOP. Divergence needs its own
+  reviewed reconciliation decision — NEVER resolve it here with a reset,
+  force push, or ref deletion. Report both SHAs and the divergence; a
+  historical SHA (e.g. a recorded closeout base like `af68f8fc1…`) is INPUT
+  EVIDENCE for the review, never a SHA to impose unconditionally on the
+  live target.
+- **Reversed direction** (the plan shows the target ahead of the source):
+  report it explicitly — a dry-run that names source and target swapped is
+  a caught error, not a sync.
+
+### 3) Execute (fast-forward only)
+
+```bash
+git fetch fg main
+git push origin <source-SHA>:refs/heads/main --force-with-lease=refs/heads/main:<target-SHA>
+```
+
+`--force-with-lease` with the READ target SHA is the guard: if anything
+moved the target between the read and the push, the push is REFUSED — the
+operation restarts from step 1. Plain `--force` is forbidden.
+
+### 4) Verify and report
+
+Re-read the target SHA; the result names the ref, the before/after SHAs of
+BOTH sides, and the verification (`git ls-remote origin` equals the source
+SHA). Repetition after success reports `identity` — the repeatable
+operation is idempotent at the evidence level.
+
+### 5) Dry-run
+
+The same classification with no mutation: report source/target/ref, both
+  SHAs, the planned action (no-op / fast-forward / divergence-blocked /
+  reversed), and NOTHING else changed.
+
+## Boundaries
+
+- Never delete refs, never reset, never `--force` without a lease.
+- Salvage branches, open HITL cases, and active resources on either side
+  are untouched by a mirror sync; an active resource conflicting with the
+  plan is reported as preserved with its reason.
+- Closing a single Herdr pane remains a separate follow-up — never close a
+  whole tab as a substitute.

data/lib/ace/git/cli/commands/pr.rb

@@ -121,6 +121,7 @@ module Ace
                 number: pr.number,
                 url: pr.url,
                 title: pr.title,
+                author: pr.author,
                 state: pr.state,
                 draft: pr.draft,
                 head: pr.head_sha,

data/lib/ace/git/organisms/pull_request_lifecycle.rb

@@ -363,7 +363,14 @@ module Ace
           raise ArgumentError, "--body-file is required" unless path
           raise ArgumentError, "Body file not found: #{path}" unless File.file?(path)
 
-          File.read(path, limit)
+          body = File.binread(path, limit) || +""
+          if limit && body.bytesize >= limit
+            raise ArgumentError, "Body file exceeds #{limit - 1} bytes: #{path}"
+          end
+          body.force_encoding(Encoding::UTF_8)
+          raise ArgumentError, "Body file must contain valid UTF-8: #{path}" unless body.valid_encoding?
+
+          body
         rescue SystemCallError => e
           raise ArgumentError, "Cannot read body file #{path}: #{e.message}"
         end

data/lib/ace/git/providers/evidence.rb

@@ -16,7 +16,11 @@ module Ace
       :head_repository_url, :base_repository_url, :merge_commit_sha
     )
 
-    ProviderIssue = Data.define(:server_name, :number, :title, :state, :author, :url, :labels)
+    ProviderIssue = Data.define(:server_name, :number, :title, :state, :author, :url, :labels, :body) do
+      def initialize(body: nil, **fields)
+        super(body: body, **fields)
+      end
+    end
 
     # Normalized check/CI evidence for one check run.
     ProviderCheck = Data.define(:server_name, :name, :state, :conclusion, :url)

data/lib/ace/git/providers/formal_approval.rb

@@ -16,9 +16,10 @@ module Ace
         CORRELATION = /\A[a-zA-Z0-9][a-zA-Z0-9._:-]{0,127}\z/
         MARKER = /\n\n<!-- ace-approval:([a-zA-Z0-9][a-zA-Z0-9._:-]{0,127}) sha256:([0-9a-f]{64}) -->\z/
 
-        def initialize(provider:, request:, list:, official: false, pending_reuse: false)
+        def initialize(provider:, request:, list:, official: false, pending_reuse: false, expected_reviewer: nil)
           @provider, @request, @list, @official = provider, request, list, official
           @pending_reuse = pending_reuse
+          @expected_reviewer = expected_reviewer
         end
 
         def approve(number:, expected_head:, body:, correlation:)
@@ -44,7 +45,7 @@ module Ace
             end
             lock.flock(File::LOCK_EX)
             pr = current!(number, expected_head)
-            actor = identity!(@request.call(:get, :actor, nil))
+            actor = @expected_reviewer ? [nil, @expected_reviewer] : identity!(@request.call(:get, :actor, nil))
             deny_author!(pr, actor)
             rows = reviews!(number)
             matches = rows.select { |row| row.fetch("body").include?("<!-- ace-approval:#{correlation} ") }
@@ -52,14 +53,18 @@ module Ace
             existing = matches.first
             row!(existing) if existing
             if existing && (existing["body"] != sent_body || existing["commit_id"] != expected_head ||
-                identity!(existing["user"]) != actor)
+                !matches_actor?(actor, identity!(existing["user"])))
               raise ProviderConflictingMatchesError, "Approval correlation is already bound to different evidence"
             end
             # A provider may reuse its current pending object on direct create.
             # Only an exact known, comment-free pending review is resumable, and
             # only when the adapter proves explicit commit preservation on reuse.
             owned_pending = rows.select do |row|
-              row["state"] == "PENDING" && row["user"].is_a?(Hash) && row["user"]["id"] == actor.first
+              next false unless row["state"] == "PENDING"
+
+              # A repository-scoped Forgejo token can only see its own
+              # pending reviews. Preserve every visible unrelated pending.
+              @expected_reviewer || (row["user"].is_a?(Hash) && row["user"]["id"] == actor.first)
             end
             unrelated = owned_pending.any? { |row| !existing || row["id"] != existing["id"] }
             if unrelated
@@ -140,6 +145,10 @@ module Ace
           [user["id"], user["login"]]
         end
 
+        def matches_actor?(expected, actual)
+          expected.first ? expected == actual : expected.last.casecmp?(actual.last)
+        end
+
         def deny_author!(pr, actor)
           unless pr.author.is_a?(String) && !pr.author.empty?
             raise ProviderMalformedOutputError, "PR author is unverified"
@@ -199,7 +208,7 @@ module Ace
               row["state"] == "APPROVED" && row["commit_id"] == expected_head &&
               !row["dismissed"] && !row["stale"] && (!@official || row["official"] == true) &&
               (!latest || latest["id"] == row["id"]) && (!expected_body || row["body"] == expected_body) &&
-              (!actor || actor == actual_actor) && row["html_url"].is_a?(String) &&
+              (!actor || matches_actor?(actor, actual_actor)) && row["html_url"].is_a?(String) &&
               row["html_url"].start_with?("#{pr.url}#")
             raise ProviderIdentityMismatchError, "Review is not the effective exact-head formal approval"
           end

data/lib/ace/git/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Git
-    VERSION = "0.31.0"
+    VERSION = "0.33.0"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-git
 version: !ruby/object:Gem::Version
-  version: 0.31.0
+  version: 0.33.0
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-10-23 00:00:00.000000000 Z
+date: 2026-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-support-config
@@ -133,6 +133,7 @@ files:
 - handbook/templates/pr/bugfix.template.md
 - handbook/templates/pr/default.template.md
 - handbook/templates/pr/feature.template.md
+- handbook/workflow-instructions/git/mirror-sync.wf.md
 - handbook/workflow-instructions/git/pr/create.wf.md
 - handbook/workflow-instructions/git/pr/update.wf.md
 - handbook/workflow-instructions/git/rebase.wf.md