ace-git-forgejo 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e06e7ebace5fc96a24f3e1ea11c26a858864acc02be4ff0e8da43823fdc4a01
-  data.tar.gz: 98b6f9244d4d965302a22bd9a7ef0faf1ca91d55801043e961cc9409c66feb0f
+  metadata.gz: 2f9063026140a927fbd346c52d1bcad410b23dc0fbaa8e8d69eae206688afd72
+  data.tar.gz: d2731b929dc9c5adde5d1a21259bc071ad54771424be3d5f3a7e2465891a3eb7
 SHA512:
-  metadata.gz: b07df628f1428cf4599ec991429c0767c03787196e866260ce8efeebb7dc948a0adfee15d22f290b8978c1ad46205147f7b01262929f02d78b135b5449b17527
-  data.tar.gz: 3a4308e47ec2fe95cf9e2f15cc41562a3d627aab7b4466d5029334e0b0b33c280255dd7f6b0542edf8dd4d2c6f5cc1bcdffa2abde9d6b3f22a410f8dab6a75db
+  metadata.gz: b69e571f2eb13eff2a71f082d8630a5610fc4827c7ea2fe6e126cef0a04610257e9bc494053ca615b8fccf88ba49b956e51dbf16768e9c2dc990a55c6d9fde7d
+  data.tar.gz: 2bda0f62a97a58ef95c67495dabb2085401be57d3002f5cfb97fd5f7a6a92b173f8aebc5c5cde5519ca0f64cc03c49de307df3021f70a7fa6988e4a675589377

data/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.9.0] - 2026-11-10
+
+### Added
+
+- Observe repository-bound open issues including body and label changes. Support formal approval with repository-scoped credentials and verify the returned reviewer identity.
+
 ## [0.8.0] - 2026-10-23
 
 ### Added

data/lib/ace/git/forgejo/issue_api.rb

@@ -25,6 +25,10 @@ module Ace
           request(:get, "issues/#{number}")
         end
 
+        def open_issues
+          paginate("issues?state=open", fail_on_repeated_page: true)
+        end
+
         def comments(number)
           paginate("issues/#{number}/comments")
         end
@@ -78,22 +82,28 @@ module Ace
 
         private
 
-        def paginate(suffix)
+        def paginate(suffix, fail_on_repeated_page: false)
           page = 1
           entries = []
           seen = []
           loop do
-            batch = request(:get, "#{suffix}?page=#{page}&limit=50")
+            separator = suffix.include?("?") ? "&" : "?"
+            batch = request(:get, "#{suffix}#{separator}page=#{page}&limit=50")
             unless batch.is_a?(Array)
               raise Ace::Git::ProviderMalformedOutputError, "Forgejo #{suffix} did not return a list"
             end
-            before = entries.length
+            unless batch.all? { |entry| entry.is_a?(Hash) && entry["id"].is_a?(Integer) && entry["id"].positive? }
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo #{suffix} contains an invalid item identity"
+            end
             # Stop when a page adds no new items (unique ids): instances
             # may cap pages below the requested limit, so a short page alone
             # does not prove the end of the collection.
             fresh = batch.reject { |item| seen.include?(item["id"]) }
             entries.concat(fresh)
             fresh.each { |item| seen << item["id"] }
+            if fail_on_repeated_page && !batch.empty? && fresh.empty?
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo #{suffix} repeated a page; completeness cannot be proven"
+            end
             break if fresh.empty?
 
             page += 1

data/lib/ace/git/forgejo/provider.rb

@@ -119,6 +119,39 @@ module Ace
             .first(limit)
         end
 
+        # Open issue intake uses the selected Forgejo repository, and never
+        # substitutes pull requests or an unavailable listing for an empty one.
+        # @return [Array<ProviderIssue>] open issues, newest first
+        # @raise [Ace::Git::ProviderMalformedOutputError] for invalid evidence
+        # @raise [Ace::Git::ProviderIdentityMismatchError] for foreign evidence
+        def recent_issues(limit:)
+          limit = Integer(limit)
+          return [] if limit <= 0
+
+          issue_api.open_issues.filter_map do |entry|
+            next if entry["pull_request"]
+
+            number = entry["number"]
+            unless number.is_a?(Integer) && number.positive? && entry["title"].is_a?(String) &&
+                !entry["title"].strip.empty? && entry["state"] == "open"
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo issue listing contains an invalid issue"
+            end
+            unless entry["html_url"] == issue_url(number)
+              raise Ace::Git::ProviderIdentityMismatchError, "Forgejo issue listing contains foreign issue ##{number}"
+            end
+            unless entry["user"].nil? || entry["user"].is_a?(Hash)
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo issue listing contains an invalid author"
+            end
+            unless (entry["body"].nil? || entry["body"].is_a?(String)) &&
+                (entry["labels"].nil? || entry["labels"].is_a?(Array) && entry["labels"].all? { |label| label.is_a?(Hash) && label["name"].is_a?(String) })
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo issue listing contains invalid body or labels"
+            end
+            Ace::Git::ProviderIssue.new(server_name: server.name, number: number, title: entry["title"],
+              state: :open, author: entry.dig("user", "login"), url: entry["html_url"],
+              body: entry["body"], labels: Array(entry["labels"]).map { |label| label.fetch("name") })
+          end.sort_by { |issue| -issue.number }.first(limit)
+        end
+
         # @return [ProviderIssue] normalized issue evidence
         def issue(number:)
           view = fj(:issue_view, request_number!(number))
@@ -931,7 +964,19 @@ module Ace
             review_http.request(method, path, body: payload)
           end
           Ace::Git::Providers::FormalApproval.new(provider: self, request: request,
-            list: method(:formal_review_rows), official: true, pending_reuse: true)
+            list: method(:formal_review_rows), official: true, pending_reuse: true,
+            expected_reviewer: leased_reviewer_account)
+        end
+
+        # Repository-scoped leases cannot call /api/v1/user. The issuer's
+        # account is an expectation; the forge review supplies the identity.
+        def leased_reviewer_account
+          return unless ENV["ACE_LAB_FORGEJO_ORIGIN"] == RepositoryBinding::Target.resolve(server.url).host_url
+
+          account = ENV["ACE_LAB_FORGEJO_ACCOUNT"]
+          return account if account&.match?(/\A[a-zA-Z0-9_.-]+\z/)
+
+          raise Ace::Git::ProviderAuthenticationError, "Forgejo lease has no valid reviewer account"
         end
 
         # Forgejo lists review requests alongside actual reviews. User and

data/lib/ace/git/forgejo/version.rb

@@ -3,7 +3,7 @@
 module Ace
   module Git
     module Forgejo
-      VERSION = "0.8.0"
+      VERSION = "0.9.0"
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-git-forgejo
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-10-23 00:00:00.000000000 Z
+date: 2026-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-git
@@ -16,6 +16,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.31'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.33.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -23,6 +26,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.31'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.33.0
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement