ace-git-forgejo 0.7.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec7d89b79d4c95330a4610f04ce163e8dcd402f3ff72bb468b27dac082d086ea
-  data.tar.gz: b9a7a5d29fa5fbd4b559ef532018d18e07d9a3b8de20dbd5860938408158d6e9
+  metadata.gz: 2f9063026140a927fbd346c52d1bcad410b23dc0fbaa8e8d69eae206688afd72
+  data.tar.gz: d2731b929dc9c5adde5d1a21259bc071ad54771424be3d5f3a7e2465891a3eb7
 SHA512:
-  metadata.gz: f7a145c24c9720d4748f32cc921f42983f2dc20c56dc0c007de0536972b4b318bba6d35c52b2b360ece6846b24cf4cd6d5b819493a7471d14e13bd59e08dc060
-  data.tar.gz: e308d391be1d1057de4176e58a698cfef161ed9474e46bb29dd1ab0a5ef83efb13af1f51b8d4bccb53d8322c0ffce89db71438f777762f49a6cadb07bab9880a
+  metadata.gz: b69e571f2eb13eff2a71f082d8630a5610fc4827c7ea2fe6e126cef0a04610257e9bc494053ca615b8fccf88ba49b956e51dbf16768e9c2dc990a55c6d9fde7d
+  data.tar.gz: 2bda0f62a97a58ef95c67495dabb2085401be57d3002f5cfb97fd5f7a6a92b173f8aebc5c5cde5519ca0f64cc03c49de307df3021f70a7fa6988e4a675589377

data/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.9.0] - 2026-11-10
+
+### Added
+
+- Observe repository-bound open issues including body and label changes. Support formal approval with repository-scoped credentials and verify the returned reviewer identity.
+
+## [0.8.0] - 2026-10-23
+
+### Added
+
+- Formal reviewer-owned, exact-head provider approval and read-only approval verification through the forge-neutral review flow; comments do not substitute for approval.
+
+
+### Fixed
+
+- Publish formal approval directly at explicit commit_id instead of rebinding pending-submit; retain safe comment-free owned pending recovery, refuse unrelated pending, ignore request/team rows, and require the verified formal-review API floor.
+
 ## [0.7.0] - 2026-10-16
 
 ### Added

data/lib/ace/git/forgejo/issue_api.rb

@@ -25,6 +25,10 @@ module Ace
           request(:get, "issues/#{number}")
         end
 
+        def open_issues
+          paginate("issues?state=open", fail_on_repeated_page: true)
+        end
+
         def comments(number)
           paginate("issues/#{number}/comments")
         end
@@ -78,22 +82,28 @@ module Ace
 
         private
 
-        def paginate(suffix)
+        def paginate(suffix, fail_on_repeated_page: false)
           page = 1
           entries = []
           seen = []
           loop do
-            batch = request(:get, "#{suffix}?page=#{page}&limit=50")
+            separator = suffix.include?("?") ? "&" : "?"
+            batch = request(:get, "#{suffix}#{separator}page=#{page}&limit=50")
             unless batch.is_a?(Array)
               raise Ace::Git::ProviderMalformedOutputError, "Forgejo #{suffix} did not return a list"
             end
-            before = entries.length
+            unless batch.all? { |entry| entry.is_a?(Hash) && entry["id"].is_a?(Integer) && entry["id"].positive? }
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo #{suffix} contains an invalid item identity"
+            end
             # Stop when a page adds no new items (unique ids): instances
             # may cap pages below the requested limit, so a short page alone
             # does not prove the end of the collection.
             fresh = batch.reject { |item| seen.include?(item["id"]) }
             entries.concat(fresh)
             fresh.each { |item| seen << item["id"] }
+            if fail_on_repeated_page && !batch.empty? && fresh.empty?
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo #{suffix} repeated a page; completeness cannot be proven"
+            end
             break if fresh.empty?
 
             page += 1

data/lib/ace/git/forgejo/provider.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "json"
+require "ace/git/providers/formal_approval"
 require "uri"
 require "ace/git/atoms/server_url"
 require_relative "cli_executor"
@@ -118,6 +119,39 @@ module Ace
             .first(limit)
         end
 
+        # Open issue intake uses the selected Forgejo repository, and never
+        # substitutes pull requests or an unavailable listing for an empty one.
+        # @return [Array<ProviderIssue>] open issues, newest first
+        # @raise [Ace::Git::ProviderMalformedOutputError] for invalid evidence
+        # @raise [Ace::Git::ProviderIdentityMismatchError] for foreign evidence
+        def recent_issues(limit:)
+          limit = Integer(limit)
+          return [] if limit <= 0
+
+          issue_api.open_issues.filter_map do |entry|
+            next if entry["pull_request"]
+
+            number = entry["number"]
+            unless number.is_a?(Integer) && number.positive? && entry["title"].is_a?(String) &&
+                !entry["title"].strip.empty? && entry["state"] == "open"
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo issue listing contains an invalid issue"
+            end
+            unless entry["html_url"] == issue_url(number)
+              raise Ace::Git::ProviderIdentityMismatchError, "Forgejo issue listing contains foreign issue ##{number}"
+            end
+            unless entry["user"].nil? || entry["user"].is_a?(Hash)
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo issue listing contains an invalid author"
+            end
+            unless (entry["body"].nil? || entry["body"].is_a?(String)) &&
+                (entry["labels"].nil? || entry["labels"].is_a?(Array) && entry["labels"].all? { |label| label.is_a?(Hash) && label["name"].is_a?(String) })
+              raise Ace::Git::ProviderMalformedOutputError, "Forgejo issue listing contains invalid body or labels"
+            end
+            Ace::Git::ProviderIssue.new(server_name: server.name, number: number, title: entry["title"],
+              state: :open, author: entry.dig("user", "login"), url: entry["html_url"],
+              body: entry["body"], labels: Array(entry["labels"]).map { |label| label.fetch("name") })
+          end.sort_by { |issue| -issue.number }.first(limit)
+        end
+
         # @return [ProviderIssue] normalized issue evidence
         def issue(number:)
           view = fj(:issue_view, request_number!(number))
@@ -340,6 +374,14 @@ module Ace
           raise Ace::Git::ProviderMalformedOutputError, "Malformed Forgejo repository file content: #{e.message}"
         end
 
+        def approve_pull_request(number:, expected_head:, body:, correlation:)
+          formal_approval.approve(number: number, expected_head: expected_head, body: body, correlation: correlation)
+        end
+
+        def pull_request_approval(number:, expected_head:, review_id:)
+          formal_approval.read(number: number, expected_head: expected_head, review_id: review_id)
+        end
+
         def create_pull_request_comment(number:, expected_head:, body:, correlation:)
           number = request_number!(number)
           pr = verify_expected_head!(pull_request(number: number), expected_head)
@@ -914,6 +956,37 @@ module Ace
             "Cannot post review comment to PR ##{pr.number} in #{pr.state} state"
         end
 
+        def formal_approval
+          pr_api.ensure_formal_review_supported!
+          request = lambda do |method, path, payload|
+            path = "/api/v1/user" if path == :actor
+            payload = payload.merge("event" => "APPROVED") if method == :post
+            review_http.request(method, path, body: payload)
+          end
+          Ace::Git::Providers::FormalApproval.new(provider: self, request: request,
+            list: method(:formal_review_rows), official: true, pending_reuse: true,
+            expected_reviewer: leased_reviewer_account)
+        end
+
+        # Repository-scoped leases cannot call /api/v1/user. The issuer's
+        # account is an expectation; the forge review supplies the identity.
+        def leased_reviewer_account
+          return unless ENV["ACE_LAB_FORGEJO_ORIGIN"] == RepositoryBinding::Target.resolve(server.url).host_url
+
+          account = ENV["ACE_LAB_FORGEJO_ACCOUNT"]
+          return account if account&.match?(/\A[a-zA-Z0-9_.-]+\z/)
+
+          raise Ace::Git::ProviderAuthenticationError, "Forgejo lease has no valid reviewer account"
+        end
+
+        # Forgejo lists review requests alongside actual reviews. User and
+        # team requests have no reviewed commit; they are not approval evidence.
+        def formal_review_rows(path)
+          review_http.paginate(path).reject do |row|
+            row.is_a?(Hash) && row["state"] == "REQUEST_REVIEW"
+          end
+        end
+
         def review_http
           @review_http ||= HttpClient.new(server: server, timeout: timeout, runner: runner)
         end

data/lib/ace/git/forgejo/pull_request_api.rb

@@ -70,9 +70,21 @@ module Ace
               "Forgejo server reports #{version}; PR delivery requires #{MINIMUM_SERVER_VERSION} " \
               "(server-enforced expected-head merge is not documented below it)"
           end
+          @server_version = version
           @version_supported = true
         end
 
+        # Formal create-with-event preserves explicit commit_id in the
+        # inspected Forgejo v11.0.0 and v16.0.5 router/service/model sources.
+        # Pending submission does not: it rebinds to current HEAD and is unused.
+        def ensure_formal_review_supported!
+          ensure_version_supported!
+          unless @server_version >= Gem::Version.new("11.0.0")
+            raise Ace::Git::ProviderUnsupportedCapabilityError,
+              "Formal exact-commit approval requires Forgejo 11.0.0 or newer"
+          end
+        end
+
         # @return [Hash] the raw validated pull request payload
         # @raise [Ace::Git::ProviderObjectNotFoundError] when absent
         # @raise [Ace::Git::ProviderMalformedOutputError] on schema violation

data/lib/ace/git/forgejo/version.rb

@@ -3,7 +3,7 @@
 module Ace
   module Git
     module Forgejo
-      VERSION = "0.7.0"
+      VERSION = "0.9.0"
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ace-git-forgejo
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Michal Czyz
 bindir: exe
 cert_chain: []
-date: 2026-10-16 00:00:00.000000000 Z
+date: 2026-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ace-git
@@ -15,14 +15,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.30'
+        version: '0.31'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.33.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.30'
+        version: '0.31'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.33.0
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement