ace-assign 0.69.0 → 0.71.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (63) hide show
  1. checksums.yaml +4 -4
  2. data/.ace-defaults/assign/presets/deliver-release.yml +11 -8
  3. data/.ace-defaults/assign/presets/integrate-batch.yml +10 -5
  4. data/.ace-defaults/assign/presets/supervise-delivery.yml +6 -4
  5. data/CHANGELOG.md +27 -0
  6. data/handbook/skills/as-assign-drive/SKILL.md +5 -2
  7. data/handbook/workflow-instructions/assign/drive.wf.md +77 -0
  8. data/lib/ace/assign/atoms/assignment_scope.rb +5 -0
  9. data/lib/ace/assign/atoms/candidate_limits.rb +20 -0
  10. data/lib/ace/assign/atoms/git_blob_batch.rb +59 -0
  11. data/lib/ace/assign/authority/assignment_definition.rb +35 -0
  12. data/lib/ace/assign/authority/candidate_blob_batch.rb +55 -0
  13. data/lib/ace/assign/authority/candidate_head_comparison.rb +139 -0
  14. data/lib/ace/assign/authority/candidate_transfer.rb +57 -27
  15. data/lib/ace/assign/authority/command_execution.rb +180 -0
  16. data/lib/ace/assign/authority/endcap.rb +4 -2
  17. data/lib/ace/assign/authority/endcap_attempts.rb +1 -1
  18. data/lib/ace/assign/authority/endcap_campaign_rounds.rb +1 -1
  19. data/lib/ace/assign/authority/endcap_publication.rb +0 -166
  20. data/lib/ace/assign/authority/endcap_service_context.rb +38 -0
  21. data/lib/ace/assign/authority/fixed_publication_lifecycle.rb +176 -0
  22. data/lib/ace/assign/authority/{endcap_services.rb → fixed_service_lifecycle.rb} +42 -46
  23. data/lib/ace/assign/authority/launch_control_exclusions.rb +3 -17
  24. data/lib/ace/assign/authority/ordinary_attempt_start.rb +137 -0
  25. data/lib/ace/assign/authority/ordinary_client.rb +70 -0
  26. data/lib/ace/assign/authority/ordinary_completion.rb +104 -0
  27. data/lib/ace/assign/authority/ordinary_effect_settlement.rb +118 -0
  28. data/lib/ace/assign/authority/ordinary_lifecycle.rb +227 -0
  29. data/lib/ace/assign/authority/ordinary_merge_evidence.rb +81 -0
  30. data/lib/ace/assign/authority/ordinary_peer.rb +54 -0
  31. data/lib/ace/assign/authority/ordinary_progress.rb +162 -0
  32. data/lib/ace/assign/authority/ordinary_queue.rb +115 -0
  33. data/lib/ace/assign/authority/ordinary_release_artifacts.rb +143 -0
  34. data/lib/ace/assign/authority/ordinary_results.rb +206 -0
  35. data/lib/ace/assign/authority/ordinary_review_evidence.rb +180 -0
  36. data/lib/ace/assign/authority/ordinary_reviews.rb +214 -0
  37. data/lib/ace/assign/authority/ordinary_server.rb +75 -0
  38. data/lib/ace/assign/authority/ordinary_supervisor.rb +99 -0
  39. data/lib/ace/assign/authority/prepared_work.rb +9 -4
  40. data/lib/ace/assign/authority/protected_assignment_context.rb +3 -3
  41. data/lib/ace/assign/authority/release_artifact_manifest.rb +91 -0
  42. data/lib/ace/assign/authority/retained_input.rb +53 -0
  43. data/lib/ace/assign/authority/router.rb +11 -6
  44. data/lib/ace/assign/authority/server.rb +11 -180
  45. data/lib/ace/assign/authority/socket_server.rb +255 -0
  46. data/lib/ace/assign/authority/transfer_codec.rb +5 -3
  47. data/lib/ace/assign/cli/commands/attempt/evidence.rb +2 -2
  48. data/lib/ace/assign/cli/commands/submit_candidate.rb +1 -1
  49. data/lib/ace/assign/molecules/canonical_evidence.rb +25 -8
  50. data/lib/ace/assign/molecules/canonical_read_commands.rb +84 -0
  51. data/lib/ace/assign/molecules/canonical_read_snapshot.rb +2 -63
  52. data/lib/ace/assign/molecules/evidence_journal.rb +157 -63
  53. data/lib/ace/assign/molecules/installed_journal_read.rb +143 -0
  54. data/lib/ace/assign/molecules/journal_mutation.rb +7 -4
  55. data/lib/ace/assign/molecules/lifecycle_exclusion.rb +13 -2
  56. data/lib/ace/assign/molecules/proposal_journal.rb +32 -4
  57. data/lib/ace/assign/molecules/receipt_verifier.rb +8 -2
  58. data/lib/ace/assign/molecules/runtime_control_surface_runner.rb +2 -1
  59. data/lib/ace/assign/organisms/attempt_coordinator.rb +88 -36
  60. data/lib/ace/assign/organisms/ordinary_driver.rb +310 -0
  61. data/lib/ace/assign/organisms/ordinary_merge_consumer.rb +5 -5
  62. data/lib/ace/assign/version.rb +1 -1
  63. metadata +39 -10
@@ -0,0 +1,70 @@
1
+ # frozen_string_literal: true
2
+
3
+ require_relative "ordinary_peer"
4
+ require_relative "transfer_codec"
5
+
6
+ module Ace
7
+ module Assign
8
+ module Authority
9
+ # Installed selection is supplied by the caller's trusted composition.
10
+ # This client never selects a journal, local fallback or execution identity.
11
+ class OrdinaryClient
12
+ Reply = Struct.new(:data, :replayed, :parts, keyword_init: true)
13
+
14
+ def initialize(project_id:, service:, verify_selection:, peer: OrdinaryPeer.new, scratch_root: nil)
15
+ @project_id, @service, @verify_selection, @peer, @scratch_root = project_id, service, verify_selection, peer, scratch_root
16
+ end
17
+
18
+ def call(operation, params, mutation_id: nil, upload_parts: nil, download: false, purpose: nil, timeout: 30)
19
+ unless operation.is_a?(String) && params.is_a?(Hash) && !params.key?("transfer") &&
20
+ timeout.is_a?(Numeric) && timeout.finite? && timeout.positive?
21
+ raise ArgumentError, "invalid ordinary authority request"
22
+ end
23
+ raise ArgumentError, "ordinary download needs private scratch and forbids upload" if download && (upload_parts || !@scratch_root)
24
+ @verify_selection.call
25
+ wire = Ace::Runtime::Molecules::ProtectedSocket
26
+ path = @service.fetch("socket_path")
27
+ wire.root_path!(File.dirname(path), directory: true, owner: @service.fetch("uid"))
28
+ before = wire.socket_identity(path, mode: 0o660)
29
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary endpoint owner differs" unless before.last == @service.fetch("uid")
30
+ codec = TransferCodec.new(root: download ? @scratch_root : nil)
31
+ descriptor = codec.descriptor(upload_parts, purpose: purpose) if upload_parts
32
+ parameters = descriptor ? params.merge("transfer" => descriptor) : params
33
+ deadline = wire.deadline([timeout, 30].min)
34
+ wire.connect(path, deadline: deadline) do |socket|
35
+ observed = @peer.capture(socket, deadline: deadline)
36
+ unless observed.values_at("uid", "gid") == @service.values_at("uid", "gid") && wire.socket_identity(path, mode: 0o660) == before
37
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary endpoint peer changed"
38
+ end
39
+ @verify_selection.call
40
+ wire.write(socket, {"version" => 1, "operation" => operation, "mutation_id" => mutation_id,
41
+ "project_id" => @project_id, "params" => parameters}, deadline: deadline, limit: 16_384)
42
+ codec.send(socket, parts: upload_parts, descriptor: descriptor, purpose: purpose, deadline: deadline) if upload_parts
43
+ socket.shutdown(Socket::SHUT_WR)
44
+ ingress = wire::Ingress.new(socket)
45
+ result = wire.read(ingress, deadline: deadline, limit: 16_384)
46
+ unless result.is_a?(Hash) && result.keys.sort == %w[data status transport] && result["status"] == "ok" &&
47
+ result["data"].is_a?(Hash) && result["transport"].is_a?(Hash) &&
48
+ result["transport"].keys == ["replayed"] && [true, false].include?(result["transport"]["replayed"])
49
+ code = result.is_a?(Hash) && result["error"].is_a?(Hash) ? result["error"]["code"] : nil
50
+ raise AttemptErrors::EvidenceUnavailable, "ordinary authority refused (#{code || 'invalid_response'}); retain original mutation"
51
+ end
52
+ parts = if download
53
+ codec.receive(ingress, descriptor: result.fetch("data").fetch("transfer"), purpose: purpose, deadline: deadline) do |input|
54
+ Array.new(input.count) { |index| input.bytes(index: index) }
55
+ end
56
+ end
57
+ @verify_selection.call
58
+ @peer.live!(observed, deadline: deadline)
59
+ unless wire.socket_identity(path, mode: 0o660) == before
60
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary endpoint changed before response acceptance"
61
+ end
62
+ Reply.new(data: result.fetch("data"), replayed: result.fetch("transport").fetch("replayed"), parts: parts)
63
+ end
64
+ rescue SystemCallError, IOError, Ace::Runtime::RuntimeUnavailableError
65
+ raise AttemptErrors::EvidenceUnavailable, "ordinary authority outcome unavailable; retain original mutation; no local fallback"
66
+ end
67
+ end
68
+ end
69
+ end
70
+ end
@@ -0,0 +1,104 @@
1
+ # frozen_string_literal: true
2
+
3
+ require_relative "ordinary_effect_settlement"
4
+ require_relative "../organisms/attempt_coordinator"
5
+
6
+ module Ace
7
+ module Assign
8
+ module Authority
9
+ # Terminal acceptance consumes the submitted canonical receipt. The
10
+ # supervisor cannot replace its bytes, worker, scope or candidate.
11
+ module OrdinaryCompletion
12
+ FINISH_KEYS = %w[assignment_id attempt_id expected_generation pane head result_id receipt_digest].freeze
13
+
14
+ private
15
+
16
+ def finish_result(request, peer, role, deadline)
17
+ params = request.fetch("params")
18
+ strict!(params, FINISH_KEYS)
19
+ %w[assignment_id attempt_id result_id].each { |key| token!(params.fetch(key)) }
20
+ token!(request.fetch("mutation_id"))
21
+ unless role == :supervisor
22
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary completion requires the installed supervisor"
23
+ end
24
+ unless params.fetch("expected_generation").is_a?(Integer) && params.fetch("expected_generation").positive? &&
25
+ params.fetch("head").is_a?(String) && params.fetch("head").match?(/\A[0-9a-f]{40}\z/) &&
26
+ params.fetch("receipt_digest").is_a?(String) && params.fetch("receipt_digest").match?(/\A[0-9a-f]{64}\z/)
27
+ raise ArgumentError, "ordinary completion selection is invalid"
28
+ end
29
+ registered = registration(params.fetch("assignment_id"), commit: @journal.ref_value)
30
+ raise AttemptErrors::NotFound, "ordinary work is not registered" unless registered
31
+ verify_result_owner!(request, peer, role, deadline, registered)
32
+ digest = Atoms::EvidenceDigest.digest({"params" => params, "project_id" => @project, "peer_uid" => peer.fetch("uid")})
33
+ @exclusion.with_shared_multi([@exclusion.task_key(registered.fetch("task_id"))], deadline: deadline) do
34
+ @exclusion.with_exclusive(@exclusion.assignment_key(params.fetch("assignment_id")), deadline: deadline) do
35
+ authorize!(request, peer, role, deadline)
36
+ with_result_transport(request, deadline) do |transport|
37
+ @journal.mutate(assignment_id: params.fetch("assignment_id"), attempt_id: params.fetch("attempt_id"),
38
+ mutation_id: request.fetch("mutation_id"), operation: "finish", parameters_digest: digest,
39
+ expected_generation: params.fetch("expected_generation"), with_replay: true, deadline: deadline,
40
+ replay_authorizer: -> { verify_result_owner!(request, peer, role, deadline, registered) }) do |events, prefix, _generation|
41
+ verify_result_owner!(request, peer, role, deadline, registered)
42
+ unless Molecules::CanonicalAttemptState.derive(events) == "running"
43
+ raise AttemptErrors::Conflict, "ordinary completion requires a running attempt"
44
+ end
45
+ result = retained_ordinary_result(params, events, prefix)
46
+ unless result && result.fetch("result_id") == params.fetch("result_id") &&
47
+ result.dig("receipt", "digest") == params.fetch("receipt_digest") && result.dig("binding", "head") == params.fetch("head")
48
+ raise AttemptErrors::ReceiptRejected, "ordinary completion requires its exact submitted result"
49
+ end
50
+ binding = result.fetch("binding")
51
+ observed = @admission.recorded_execution!(binding: binding.fetch("runtime_binding"), head: binding.fetch("head"), deadline: deadline)
52
+ unless observed.fetch(:runtime_binding) == binding.fetch("runtime_binding") && observed.fetch(:checkout) == binding.fetch("checkout")
53
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary result worker checkout changed"
54
+ end
55
+ references = events.select { |event| event["type"] == "inbox_binding" }.map { |event| event.fetch("payload") }
56
+ delivery = transport.call(references: references, attempt_id: params.fetch("attempt_id"), owner: binding.fetch("runtime_binding"))
57
+ scope = events.find { |event| event["type"] == "intent" }.fetch("payload").fetch("scope")
58
+ work = registered_work(registered, prefix, deadline)
59
+ queue = OrdinaryQueue.new(work: work, root: @input_root, bytes: queue_bytes(current_queue_record(registered, prefix), prefix))
60
+ verdict = result.dig("receipt", "verdict")
61
+ complete = verdict == "succeeded" ? queue.status.subtree_complete?(scope) : queue.status.subtree_failed?(scope)
62
+ raise AttemptErrors::Conflict, "ordinary result scope has unfinished progress" unless complete
63
+ settlement = OrdinaryEffectSettlement.new(journal: @journal).verify!(project: @project,
64
+ assignment: params.fetch("assignment_id"), attempt: params.fetch("attempt_id"), events: events, commit: prefix)
65
+ verify_result_owner!(request, peer, role, deadline, registered)
66
+ plan = Organisms::AttemptCoordinator.finished_transition_plan(events: events, receipt: result.fetch("receipt"), authority: :ordinary)
67
+ plan.merge(data: params.slice("assignment_id", "attempt_id", "result_id", "head", "receipt_digest").merge(
68
+ "authority" => "ordinary", "scope" => scope, "state" => verdict, "settlement" => settlement, "inbox_deliveries" => delivery))
69
+ end
70
+ end
71
+ end
72
+ end
73
+ rescue Ace::Herdr::Error => error
74
+ raise AttemptErrors::EvidenceUnavailable, "ordinary transport settlement is unavailable: #{error.message}"
75
+ end
76
+
77
+ def verify_result_owner!(request, peer, role, deadline, registered)
78
+ authorize!(request, peer, role, deadline)
79
+ supervisor = @admission.identity!(peer: peer, pane: request.fetch("params").fetch("pane"), deadline: deadline)
80
+ unless supervisor.role == "coordinator" &&
81
+ supervisor.runtime_binding == supervisor_selection(registered, @journal.ref_value).fetch("binding")
82
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary completion belongs to its original supervisor"
83
+ end
84
+ end
85
+
86
+ def with_result_transport(request, deadline)
87
+ if @journal.mutation_result(request.fetch("mutation_id"), commit: @journal.ref_value)
88
+ # A terminal reply is immutable. Current peer authority is still
89
+ # checked by mutate, but retired transport files are not replay input.
90
+ return yield nil
91
+ end
92
+ if @inbox
93
+ @inbox.with_delivery_settlement(deadline: deadline) { |verify| yield verify }
94
+ else
95
+ yield lambda { |references:, **_|
96
+ raise AttemptErrors::EvidenceUnavailable, "ordinary Inbox owner is not installed" unless references.empty?
97
+ []
98
+ }
99
+ end
100
+ end
101
+ end
102
+ end
103
+ end
104
+ end
@@ -0,0 +1,118 @@
1
+ # frozen_string_literal: true
2
+
3
+ require_relative "service_evidence"
4
+ require_relative "../molecules/ordinary_merge_contract"
5
+
6
+ module Ace
7
+ module Assign
8
+ module Authority
9
+ # Completion reads the existing effect owners at the held CAS prefix.
10
+ # A prompt, acknowledgment or failed dispatch never settles an effect.
11
+ class OrdinaryEffectSettlement
12
+ def initialize(journal:)
13
+ @journal = journal
14
+ end
15
+
16
+ def verify!(project:, assignment:, attempt:, events:, commit:)
17
+ retained = @journal.read_events(assignment, commit: commit).select { |event| event["attempt_id"] == attempt }
18
+ unless retained == events && Models::EvidenceEvent.chain_valid?(events)
19
+ unavailable!("ordinary settlement needs its exact canonical attempt")
20
+ end
21
+ selection = {"project_id" => project, "assignment_id" => assignment, "attempt_id" => attempt}
22
+ services = records!(@journal.service_request_records(commit: commit), events, selection, %w[service_claim service_transition])
23
+ merges = records!(@journal.fixed_merge_request_records(commit: commit), events, selection, %w[merge_admission merge_transition])
24
+ services.each { |record| service!(record, commit) }
25
+ merges.each { |record| merge!(record, commit) }
26
+ assignment_events = @journal.read_events(assignment, commit: commit)
27
+ assignment_events.group_by { |event| event.fetch("attempt_id") }.each_value do |chain|
28
+ unavailable!("ordinary delivery history is corrupt") unless Models::EvidenceEvent.chain_valid?(chain)
29
+ end
30
+ delivery!(events, merges, assignment_events)
31
+ {"journal_commit" => commit, "service_requests" => services.map { |record| record.fetch("request_id") }.sort,
32
+ "merge_requests" => merges.map { |record| record.fetch("request_id") }.sort}
33
+ end
34
+
35
+ private
36
+
37
+ def records!(inventory, events, selection, types)
38
+ records = inventory.select { |record| record.values_at("assignment_id", "attempt_id") == selection.values_at("assignment_id", "attempt_id") }
39
+ references = events.select { |event| types.include?(event["type"]) }
40
+ ids = references.map { |event| event.fetch("payload").fetch("request_id") }.uniq.sort
41
+ unless records.map { |record| record.fetch("request_id") }.sort == ids
42
+ unavailable!("ordinary effect inventory and event set differ")
43
+ end
44
+ records.each do |record|
45
+ latest = references.reverse.find { |event| event.dig("payload", "request_id") == record.fetch("request_id") }
46
+ unless record.slice(*selection.keys) == selection && latest.dig("payload", "state") == record["state"] &&
47
+ latest.dig("payload", "record_digest") == Atoms::EvidenceDigest.digest(record) &&
48
+ latest.dig("payload", "receipt_digest") == (record["receipt"] && Atoms::EvidenceDigest.digest(record["receipt"]))
49
+ unavailable!("ordinary effect record differs from its accepted owner event")
50
+ end
51
+ end
52
+ records
53
+ end
54
+
55
+ def service!(record, commit)
56
+ return if record["state"] == "rejected" && record["consumed"] == false
57
+ pending!("ordinary service effect is unresolved") unless %w[succeeded failed-settled].include?(record["state"])
58
+ receipt = record.fetch("receipt")
59
+ @journal.validate_terminal_receipt_structure!(record, record.fetch("state"), receipt)
60
+ # The installed owner consumes the existing canonical import, never
61
+ # the old local receipt file. This is independent of journal mode.
62
+ owner = ServiceEvidence.new(journal: @journal)
63
+ references = receipt.fetch("evidence")
64
+ if %w[publish prune-preserved-workspace].include?(record["operation"])
65
+ contents = owner.call(references, record, record.fetch("state"), {commit: commit})
66
+ unless contents.is_a?(Array) && contents.size == references.size
67
+ unavailable!("ordinary service evidence collection differs")
68
+ end
69
+ else
70
+ contents = references.map { |reference| owner.call(reference, record, record.fetch("state"), {commit: commit}) }
71
+ end
72
+ references.zip(contents).each do |reference, bytes|
73
+ unavailable!("ordinary service evidence digest differs") unless bytes.is_a?(String) && Digest::SHA256.hexdigest(bytes.b) == reference.fetch("sha256")
74
+ @journal.verify_service_attestation!(bytes, record, record.fetch("state")) unless %w[publish prune-preserved-workspace].include?(record["operation"])
75
+ end
76
+ end
77
+
78
+ def merge!(record, commit)
79
+ unless @journal.fixed_merge_settlement!(record.fetch("request_id"), commit: commit) == record
80
+ unavailable!("ordinary merge settlement differs from its selected record")
81
+ end
82
+ end
83
+
84
+ def delivery!(events, merges, assignment_events)
85
+ deliveries = assignment_events.select { |event| event["type"] == "delivery" }
86
+ events.select { |event| event["type"] == "delivery" }.each do |intent|
87
+ payload = intent.fetch("payload")
88
+ case payload["stage"]
89
+ when "intent"
90
+ settled = deliveries.any? { |event| event.dig("payload", "stage") == "result" &&
91
+ event.dig("payload", "intent_digest") == intent.fetch("digest") &&
92
+ event.dig("payload", "intent_attempt_id") == intent.fetch("attempt_id") &&
93
+ event.dig("payload", "operation") == payload.fetch("operation") &&
94
+ event.dig("payload", "head") == payload.fetch("head") && event.dig("payload", "outcome") == "succeeded" }
95
+ pending!("ordinary delivery intent is unresolved") unless settled
96
+ when "ordinary-merge-intent"
97
+ result = deliveries.reverse.find { |event| event.dig("payload", "stage") == "ordinary-merge-result" &&
98
+ event.dig("payload", "request_id") == payload.fetch("request_id") && event.dig("payload", "input_digest") == payload.fetch("input_digest") }
99
+ pending!("ordinary merge delivery is unresolved") unless result
100
+ accepted = result.fetch("payload")
101
+ record = merges.find { |item| item["request_id"] == payload.fetch("request_id") }
102
+ if accepted["outcome"] == "refused_no_effect" && record.nil?
103
+ refusal = accepted.slice("code", "message", "request_id", "input_digest").merge("schema" => "ace.lab.service.ordinary-merge-refusal/v1")
104
+ Molecules::OrdinaryMergeContract.validate_refusal!(refusal)
105
+ pending!("ordinary merge receiver availability is unresolved") if refusal["code"] == Molecules::OrdinaryMergeContract::UNAVAILABLE_CODE
106
+ elsif !record || record["input_digest"] != payload.fetch("input_digest") || record["receipt"] != accepted["receipt"]
107
+ unavailable!("ordinary delivery result differs from the merge owner")
108
+ end
109
+ end
110
+ end
111
+ end
112
+
113
+ def unavailable!(message) = raise AttemptErrors::EvidenceUnavailable, message
114
+ def pending!(message) = raise AttemptErrors::ServiceSettlementPending, message
115
+ end
116
+ end
117
+ end
118
+ end
@@ -0,0 +1,227 @@
1
+ # frozen_string_literal: true
2
+
3
+ require "ace/herdr"
4
+ require_relative "prepared_work"
5
+ require_relative "assignment_definition"
6
+ require_relative "ordinary_queue"
7
+ require_relative "ordinary_attempt_start"
8
+ require_relative "ordinary_progress"
9
+ require_relative "ordinary_results"
10
+ require_relative "ordinary_completion"
11
+ require_relative "ordinary_supervisor"
12
+ require_relative "ordinary_reviews"
13
+ require_relative "ordinary_merge_evidence"
14
+ require_relative "ordinary_release_artifacts"
15
+ require_relative "../molecules/lifecycle_exclusion"
16
+
17
+ module Ace
18
+ module Assign
19
+ module Authority
20
+ # Ordinary lifecycle uses the existing canonical execution ref and CAS.
21
+ # The installed Lab composition supplies one journal and exclusion owner
22
+ # shared with HITL and merge. No requester cache supplies accepted state.
23
+ class OrdinaryLifecycle
24
+ include OrdinaryAttemptStart
25
+ include OrdinaryProgress
26
+ include OrdinaryResults
27
+ include OrdinaryCompletion
28
+ include OrdinarySupervisor
29
+ include OrdinaryReviews
30
+ include OrdinaryMergeEvidence
31
+ include OrdinaryReleaseArtifacts
32
+ OPERATIONS = (%w[register_assignment registration_status start_attempt finish merge_evidence] + OrdinaryProgress::PROGRESS_OPERATIONS + OrdinaryResults::RESULT_OPERATIONS + OrdinarySupervisor::SUPERVISOR_OPERATIONS + OrdinaryReviews::REVIEW_OPERATIONS + OrdinaryReleaseArtifacts::RELEASE_OPERATIONS).freeze
33
+ TRANSFER_OPERATIONS = {"register_assignment" => {direction: :upload, purpose: :candidate, roles: [:supervisor]}}
34
+ .merge(OrdinaryProgress::PROGRESS_TRANSFERS).merge(OrdinaryResults::RESULT_TRANSFERS).merge(OrdinaryReviews::REVIEW_TRANSFERS).merge(OrdinaryReleaseArtifacts::RELEASE_TRANSFERS).freeze
35
+ REGISTER_KEYS = %w[assignment_id definition_digest prepared_head prepared_tree manifest_sha256 expected_generation pane transfer].freeze
36
+
37
+ def initialize(project:, admission:, journal:, exclusion:, input_root:, inbox: nil, command_evidence: nil, release_authorizer: nil)
38
+ @project, @admission, @journal, @exclusion = project, admission, journal, exclusion
39
+ @input_root = PrivateDirectory.verify!(input_root)
40
+ unless inbox.nil? || inbox.is_a?(Ace::Herdr::Organisms::Inbox)
41
+ raise ArgumentError, "ordinary completion requires the installed Inbox owner"
42
+ end
43
+ unless release_authorizer.nil? || release_authorizer.respond_to?(:call)
44
+ raise ArgumentError, "release artifact authorization requires its installed policy owner"
45
+ end
46
+ @inbox, @command_evidence, @release_authorizer = inbox, command_evidence, release_authorizer
47
+ end
48
+
49
+ def authorize_transfer!(request:, peer:, role:, deadline:)
50
+ authorize!(request, peer, role, deadline)
51
+ if OrdinaryReleaseArtifacts::RELEASE_TRANSFERS.key?(request.fetch("operation"))
52
+ authorize_ordinary_release!(request, peer, role, deadline)
53
+ return
54
+ end
55
+ if OrdinaryReviews::REVIEW_TRANSFERS.key?(request.fetch("operation"))
56
+ authorize_ordinary_review!(request, peer, role, deadline)
57
+ return
58
+ end
59
+ if OrdinaryResults::RESULT_TRANSFERS.key?(request.fetch("operation"))
60
+ validate_result!(request)
61
+ authorize_start_replay!(request, peer, role, deadline) if request.fetch("operation") == "submit_result"
62
+ return
63
+ end
64
+ if OrdinaryProgress::PROGRESS_TRANSFERS.key?(request.fetch("operation"))
65
+ validate_progress!(request)
66
+ return
67
+ end
68
+ unless request.fetch("operation") == "register_assignment" && role == :supervisor
69
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary registration requires the installed supervisor"
70
+ end
71
+ validate_registration!(request)
72
+ end
73
+
74
+ def dispatch(request:, peer:, role:, deadline:, transfer: nil)
75
+ authorize!(request, peer, role, deadline)
76
+ return ordinary_review_operation(request, peer, role, deadline, transfer) if OrdinaryReviews::REVIEW_OPERATIONS.include?(request.fetch("operation"))
77
+ case request.fetch("operation")
78
+ when "retain_release_artifact"
79
+ retain_release_artifact(request, peer, role, deadline, transfer)
80
+ when "merge_evidence"
81
+ raise ArgumentError, "merge evidence read forbids transfer" if transfer
82
+ ordinary_merge_evidence(request, peer, role, deadline)
83
+ when "supervisor_status", "adopt_supervisor"
84
+ raise ArgumentError, "ordinary supervisor operation forbids transfer" if transfer
85
+ supervisor_operation(request, peer, role, deadline)
86
+ when "registration_status"
87
+ strict!(request.fetch("params"), %w[assignment_id])
88
+ raise ArgumentError, "status mutation must be null" unless request.fetch("mutation_id").nil?
89
+ assignment = request.fetch("params").fetch("assignment_id")
90
+ token!(assignment)
91
+ commit = @journal.ref_value
92
+ data = registration(assignment, commit: commit) || {"assignment_id" => assignment, "generation" => 0}
93
+ {data: data.merge("journal_commit" => commit), replayed: false}
94
+ when "register_assignment"
95
+ authorize_transfer!(request: request, peer: peer, role: role, deadline: deadline)
96
+ register(request, peer, deadline, transfer)
97
+ when "start_attempt"
98
+ raise ArgumentError, "ordinary start forbids transfer" if transfer
99
+ start_attempt(request, peer, role, deadline)
100
+ when "assignment_snapshot"
101
+ raise ArgumentError, "ordinary snapshot forbids upload" if transfer
102
+ assignment_snapshot(request, peer, role, deadline)
103
+ when "queue_start", "queue_finish", "queue_fail"
104
+ progress(request, peer, role, deadline, transfer)
105
+ when "submit_result", "result_status", "result_snapshot"
106
+ ordinary_result(request, peer, role, deadline, transfer)
107
+ when "finish"
108
+ raise ArgumentError, "ordinary completion forbids transfer" if transfer
109
+ finish_result(request, peer, role, deadline)
110
+ else
111
+ raise ArgumentError, "unknown ordinary lifecycle operation"
112
+ end
113
+ end
114
+
115
+ private
116
+
117
+ def register(request, peer, deadline, transfer)
118
+ params = request.fetch("params")
119
+ # Native observation and candidate subprocesses happen before CAS.
120
+ identity = @admission.identity!(peer: peer, pane: params.fetch("pane"), deadline: deadline)
121
+ unless identity.role == "coordinator"
122
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary registration native owner differs"
123
+ end
124
+ raise AttemptErrors::MalformedTransfer, "prepared input requires one bundle" unless transfer && transfer.count == 1
125
+ bytes = transfer.bytes.freeze
126
+ descriptor = params.fetch("transfer")
127
+ work = PreparedWork.admit(bytes: bytes, head: params.fetch("prepared_head"), tree: params.fetch("prepared_tree"),
128
+ sha256: descriptor.fetch("sha256"), size: descriptor.fetch("bytes"), root: @input_root, deadline: deadline)
129
+ unless work.manifest.values_at("assignment_id", "project_id") == [params.fetch("assignment_id"), @project] &&
130
+ work.manifest_sha256 == params.fetch("manifest_sha256")
131
+ raise ArgumentError, "ordinary prepared assignment association differs"
132
+ end
133
+ definition = work.definition_bytes(head: params.fetch("prepared_head"), tree: params.fetch("prepared_tree"))
134
+ assignment = AssignmentDefinition.parse(bytes: definition, digest: params.fetch("definition_digest"),
135
+ assignment_id: params.fetch("assignment_id"), project_id: @project)
136
+ # Campaign registration needs its existing canonical campaign owner;
137
+ # it cannot be manufactured by attaching unchecked parent metadata.
138
+ if assignment.review_campaign || assignment.campaign_execution
139
+ raise AttemptErrors::EvidenceUnavailable, "ordinary campaign registration requires its campaign owner"
140
+ end
141
+ principal = {"uid" => peer.fetch("uid"), "actor" => identity.actor}
142
+ queue = OrdinaryQueue.new(work: work, root: @input_root)
143
+ queue_sha = Digest::SHA256.hexdigest(queue.bytes)
144
+ digest = Atoms::EvidenceDigest.digest({"params" => params, "project_id" => @project, "principal" => principal})
145
+ keys = [@exclusion.task_key(assignment.task_id), @exclusion.assignment_key(assignment.id)]
146
+ @exclusion.with_shared_multi(keys, deadline: deadline) do
147
+ # Replay bypasses the CAS callback; current authority is mandatory
148
+ # before that lookup as well as on every fresh CAS attempt.
149
+ authorize!(request, peer, :supervisor, deadline)
150
+ @journal.mutate(assignment_id: assignment.id, attempt_id: "definition-#{assignment.id}",
151
+ mutation_id: request.fetch("mutation_id"), operation: "register_assignment", parameters_digest: digest,
152
+ expected_generation: params.fetch("expected_generation"), with_replay: true, deadline: deadline,
153
+ replay_authorizer: -> { authorize!(request, peer, :supervisor, deadline) }) do |events, commit, _generation|
154
+ authorize!(request, peer, :supervisor, deadline)
155
+ unless events.empty? && registration(assignment.id, commit: commit).nil?
156
+ raise AttemptErrors::Conflict, "ordinary assignment is already registered; retain its original definition"
157
+ end
158
+ bundle_sha = Digest::SHA256.hexdigest(bytes)
159
+ definition_path = "execution/definitions/#{assignment.id}-#{params.fetch('definition_digest')}.json"
160
+ bundle_path = "execution/prepared/#{assignment.id}-#{bundle_sha}.bundle"
161
+ queue_path = "execution/definitions/#{assignment.id}-queue-#{queue_sha}.json"
162
+ {events: [], blobs: {definition_path => definition, bundle_path => bytes, queue_path => queue.bytes}, data: {
163
+ "authority" => "ordinary", "assignment_id" => assignment.id, "project_id" => @project,
164
+ "task_id" => assignment.task_id, "registered_by" => principal, "phase" => "registered",
165
+ "supervisor_binding" => identity.runtime_binding,
166
+ "definition_ref" => definition_path, "definition_digest" => params.fetch("definition_digest"),
167
+ "queue_ref" => queue_path, "queue_sha256" => queue_sha,
168
+ "prepared_work" => work.reference(head: params.fetch("prepared_head"), tree: params.fetch("prepared_tree")),
169
+ "prepared_bundle_ref" => bundle_path, "prepared_bundle_sha256" => bundle_sha,
170
+ "prepared_bundle_bytes" => bytes.bytesize}}
171
+ end
172
+ end
173
+ end
174
+
175
+ def registration(assignment, commit:)
176
+ return nil unless commit
177
+ events = @journal.read_events(assignment, commit: commit)
178
+ events.group_by { |event| event.fetch("attempt_id") }.each_value do |chain|
179
+ raise AttemptErrors::EvidenceUnavailable, "ordinary assignment evidence is corrupt" unless Models::EvidenceEvent.chain_valid?(chain)
180
+ end
181
+ registrations = events.select { |event| event["type"] == "authority_mutation" && event.dig("payload", "operation") == "register_assignment" }
182
+ return nil if registrations.empty?
183
+ data = registrations.one? && registrations.first.dig("payload", "data")
184
+ unless data && data.values_at("authority", "assignment_id", "project_id") == ["ordinary", assignment, @project]
185
+ raise AttemptErrors::EvidenceUnavailable, "ordinary assignment registration owner differs"
186
+ end
187
+ data
188
+ end
189
+
190
+ def authorize!(request, peer, role, deadline)
191
+ unless deadline.is_a?(Numeric) && deadline.finite? && deadline > Process.clock_gettime(Process::CLOCK_MONOTONIC)
192
+ raise AttemptErrors::EvidenceUnavailable, "ordinary lifecycle deadline elapsed"
193
+ end
194
+ unless request.fetch("project_id") == @project && @admission.authorize!(request: request, peer: peer, deadline: deadline) == role
195
+ raise AttemptErrors::UnauthorizedIdentity, "ordinary lifecycle principal differs"
196
+ end
197
+ # Project commands share the canonical journal but never the managed
198
+ # assignment namespace. Reserve their prefix on every ordinary route,
199
+ # including transfer admission, status and registration replay.
200
+ assignment = request.fetch("params")["assignment_id"]
201
+ if assignment.is_a?(String) && assignment.start_with?("command-")
202
+ raise ArgumentError, "ordinary assignment uses the reserved project-command namespace"
203
+ end
204
+ end
205
+
206
+ def validate_registration!(request)
207
+ params = request.fetch("params")
208
+ strict!(params, REGISTER_KEYS)
209
+ token!(request.fetch("mutation_id"))
210
+ token!(params.fetch("assignment_id"))
211
+ token!("definition-#{params.fetch('assignment_id')}")
212
+ unless params.fetch("expected_generation").is_a?(Integer) && params.fetch("expected_generation") >= 0
213
+ raise ArgumentError, "ordinary generation is invalid"
214
+ end
215
+ end
216
+
217
+ def strict!(value, keys)
218
+ raise ArgumentError, "ordinary authority fields differ" unless value.is_a?(Hash) && value.keys.sort == keys.sort
219
+ end
220
+
221
+ def token!(value)
222
+ raise ArgumentError, "ordinary identity is invalid" unless value.is_a?(String) && Molecules::JournalMutation::ID.match?(value)
223
+ end
224
+ end
225
+ end
226
+ end
227
+ end
@@ -0,0 +1,81 @@
1
+ # frozen_string_literal: true
2
+
3
+ module Ace
4
+ module Assign
5
+ module Authority
6
+ # The installed fixed merge consumes this same lifecycle, never a local
7
+ # receipt file. Locks precede journal CAS; no callback acquires an inverted
8
+ # lifecycle lock while holding the journal writer lock.
9
+ module OrdinaryMergeEvidence
10
+ def with_merge_scope(record:, deadline:, exclusive: false)
11
+ assignment, attempt = record.values_at("assignment_id", "attempt_id")
12
+ token!(assignment)
13
+ token!(attempt)
14
+ registered = registration(assignment, commit: @journal.ref_value)
15
+ raise AttemptErrors::EvidenceUnavailable, "merge assignment is unregistered" unless registered
16
+ @exclusion.with_shared_multi([@exclusion.task_key(registered.fetch("task_id"))], deadline: deadline) do
17
+ key = @exclusion.assignment_key(assignment)
18
+ if exclusive
19
+ @exclusion.with_exclusive(key, deadline: deadline) { yield }
20
+ else
21
+ @exclusion.with_shared_multi([key], deadline: deadline) { yield }
22
+ end
23
+ end
24
+ end
25
+
26
+ def verify_merge_evidence_at!(record:, commit:, deadline:)
27
+ unless record.fetch("project_id") == @project
28
+ raise AttemptErrors::ReceiptRejected, "merge evidence project differs"
29
+ end
30
+ request = record.fetch("request")
31
+ events = result_events(record, commit)
32
+ current = ordinary_candidate_event(events)&.dig("payload", "data")
33
+ raise AttemptErrors::ReceiptRejected, "merge candidate is unavailable" unless current
34
+ projection = merge_evidence_at!(events: events, commit: commit, head: request.fetch("candidate_head"),
35
+ generation: current.fetch("candidate_generation"), execution_ids: request.fetch("test_evidence").map { |reference| reference.fetch("reference") }, deadline: deadline)
36
+ unless request.fetch("review_evidence") == projection.fetch("review_evidence") && request.fetch("test_evidence") == projection.fetch("test_evidence")
37
+ raise AttemptErrors::ReceiptRejected, "merge requires exact canonical review and executed test references"
38
+ end
39
+ origin = origin_at!(events: events, commit: commit)
40
+ observed = @admission.recorded_execution!(binding: origin.fetch("runtime_binding"), head: request.fetch("candidate_head"), deadline: deadline)
41
+ unless observed.fetch(:runtime_binding) == origin.fetch("runtime_binding")
42
+ raise AttemptErrors::UnauthorizedIdentity, "merge producer native identity changed"
43
+ end
44
+ true
45
+ rescue KeyError, TypeError
46
+ raise AttemptErrors::ReceiptRejected, "canonical merge evidence is incomplete"
47
+ end
48
+
49
+ def merge_evidence_at!(events:, commit:, head:, generation:, execution_ids:, deadline:)
50
+ unless @command_evidence && @command_evidence.journal.equal?(@journal) && execution_ids.is_a?(Array) &&
51
+ execution_ids.size.between?(1, 16) && execution_ids.uniq == execution_ids
52
+ raise AttemptErrors::EvidenceUnavailable, "merge requires the installed canonical executed-test owner"
53
+ end
54
+ candidate = candidate_at!(events: events, commit: commit, head: head, generation: generation)
55
+ review = review_at!(events: events, commit: commit, head: head, generation: generation)
56
+ tests = execution_ids.map { |id| @command_evidence.test_evidence_at!(execution_id: id, commit: commit,
57
+ head: head, tree: candidate.fetch("tree"), deadline: deadline) }
58
+ {"review_evidence" => {"schema" => "ace.review.acceptance-reference/v1", "reference" => review.fetch("review_id"),
59
+ "reviewer" => review.fetch("reviewer_actor"), "verdict" => "approved", "reviewed_head" => head,
60
+ "recorded_at" => review.fetch("recorded_at"), "record_sha256" => review.fetch("acceptance_event_digest")},
61
+ "test_evidence" => tests}
62
+ end
63
+
64
+ private
65
+
66
+ def ordinary_merge_evidence(request, peer, role, deadline)
67
+ params = request.fetch("params")
68
+ strict!(params, %w[assignment_id attempt_id head candidate_generation test_execution_ids])
69
+ raise ArgumentError, "merge evidence read mutation must be null" unless request.fetch("mutation_id").nil?
70
+ with_scope(assignment: params.fetch("assignment_id"), attempt: params.fetch("attempt_id"), deadline: deadline) do
71
+ prefix = @journal.ref_value
72
+ projection = merge_evidence_at!(events: result_events(params, prefix), commit: prefix, head: params.fetch("head"),
73
+ generation: params.fetch("candidate_generation"), execution_ids: params.fetch("test_execution_ids"), deadline: deadline)
74
+ authorize!(request, peer, role, deadline)
75
+ {data: projection.merge("journal_commit" => prefix), replayed: false}
76
+ end
77
+ end
78
+ end
79
+ end
80
+ end
81
+ end