ace-assign 0.37.0 → 0.40.3

data/lib/ace/assign/organisms/task_assignment_creator.rb

@@ -0,0 +1,176 @@
+# frozen_string_literal: true
+
+require "ace/task"
+require "fileutils"
+require "securerandom"
+require "tempfile"
+require "yaml"
+
+require_relative "../atoms/preset_loader"
+require_relative "../atoms/preset_expander"
+
+module Ace
+  module Assign
+    module Organisms
+      class TaskAssignmentCreator
+        DEFAULT_PRESET = "work-on-task"
+        SUBTASK_PATTERN = /^[0-9a-z]{3}\.[a-z]\.[0-9a-z]{3}\.[a-z0-9]$/
+
+        def initialize(task_manager: nil, executor: nil)
+          @task_manager = task_manager || Ace::Task::Organisms::TaskManager.new
+          @executor = executor || AssignmentExecutor.new
+        end
+
+        def call(task_refs:, preset_name: DEFAULT_PRESET, primary_task_ref: nil)
+          requested_refs = normalize_requested_refs(task_refs)
+          raise Ace::Support::Cli::Error, "--task requires at least one task reference" if requested_refs.empty?
+
+          preset = Atoms::PresetLoader.load(preset_name)
+          resolved_refs, skipped_terminal = resolve_requested_refs(requested_refs)
+
+          if resolved_refs.empty?
+            raise Ace::Support::Cli::Error,
+              "All requested tasks are already terminal (done/skipped/cancelled): #{skipped_terminal.join(', ')}. No assignment created."
+          end
+
+          primary_ref = primary_task_ref.to_s.strip
+          primary_ref = resolved_refs.first[:ref] if primary_ref.empty?
+
+          guard_multi_task_preset!(preset_name, preset, resolved_refs.length)
+
+          expanded_taskrefs = if preset_supports_taskrefs?(preset)
+            expand_task_refs_in_order(resolved_refs)
+          else
+            [primary_ref]
+          end
+
+          params = build_parameters(preset, primary_ref, expanded_taskrefs)
+          validate_parameters!(preset, params)
+
+          steps = Atoms::PresetExpander.expand(preset, params)
+          job_path = write_job_file(
+            session_name: "#{preset_name}-#{primary_ref}",
+            description: preset["description"],
+            steps: steps
+          )
+
+          result = @executor.start(job_path)
+          result.merge(
+            skipped_terminal: skipped_terminal,
+            primary_ref: primary_ref,
+            task_refs: expanded_taskrefs,
+            job_path: job_path
+          )
+        end
+
+        private
+
+        def normalize_requested_refs(task_refs)
+          Array(task_refs)
+            .flat_map { |entry| entry.to_s.split(",") }
+            .map(&:strip)
+            .reject(&:empty?)
+        end
+
+        def resolve_requested_refs(requested_refs)
+          resolved = []
+          skipped_terminal = []
+
+          requested_refs.each do |ref|
+            task = @task_manager.show(ref.to_s)
+            raise Ace::Support::Cli::Error, "Task not found: #{ref}" unless task
+
+            if task.status.to_s == "draft"
+              raise Ace::Support::Cli::Error,
+                "Task #{ref} has status 'draft' and has not been reviewed. " \
+                "Review the spec first with /as-task-review #{ref} " \
+                "(or ace-bundle wfi://task/review), then retry."
+            end
+
+            if Ace::Task::Atoms::TaskValidationRules.terminal_status?(task.status.to_s)
+              skipped_terminal << ref.to_s
+              next
+            end
+
+            resolved << {ref: ref.to_s, task: task, is_subtask: subtask_ref?(ref)}
+          end
+
+          [resolved, skipped_terminal]
+        end
+
+        def subtask_ref?(ref)
+          ref.to_s.match?(SUBTASK_PATTERN)
+        end
+
+        def preset_supports_taskrefs?(preset)
+          (preset["parameters"] || {}).key?("taskrefs")
+        end
+
+        def guard_multi_task_preset!(preset_name, preset, input_count)
+          return unless input_count > 1 && !preset_supports_taskrefs?(preset)
+
+          raise Ace::Support::Cli::Error,
+            "Preset '#{preset_name}' accepts only single taskref. " \
+            "Use a preset with `taskrefs` (e.g., --preset work-on-task)."
+        end
+
+        def expand_task_refs_in_order(resolved_refs)
+          resolved_refs.flat_map do |entry|
+            ref = entry[:ref]
+            task = entry[:task]
+
+            if entry[:is_subtask]
+              [ref]
+            elsif task.respond_to?(:subtasks) && task.subtasks&.any?
+              active_subtasks = task.subtasks
+                .reject { |st| Ace::Task::Atoms::TaskValidationRules.terminal_status?(st.status.to_s) }
+                .map(&:id)
+              active_subtasks.empty? ? [ref] : active_subtasks
+            else
+              [ref]
+            end
+          end
+        end
+
+        def build_parameters(preset, primary_ref, task_refs)
+          param_defs = preset["parameters"] || {}
+          params = {}
+          params["taskref"] = primary_ref if param_defs.key?("taskref")
+          params["taskrefs"] = task_refs if param_defs.key?("taskrefs")
+          params
+        end
+
+        def validate_parameters!(preset, params)
+          errors = Atoms::PresetExpander.validate_parameters(preset, params)
+          return if errors.empty?
+
+          raise Ace::Support::Cli::Error, errors.join(", ")
+        end
+
+        def write_job_file(session_name:, description:, steps:)
+          job = {
+            "session" => {
+              "name" => session_name,
+              "description" => description || "Prepared by ace-assign create --task"
+            },
+            "steps" => steps
+          }
+
+          dir = File.join(Ace::Assign.cache_dir, "jobs")
+          FileUtils.mkdir_p(dir)
+          path = File.join(dir, "#{session_name}-#{SecureRandom.hex(4)}-job.yml")
+          payload = YAML.dump(job)
+
+          Tempfile.create(["#{session_name}-job", ".yml"], dir) do |tmp|
+            tmp.write(payload)
+            tmp.flush
+            tmp.fsync
+            FileUtils.mv(tmp.path, path)
+          end
+
+          path
+        end
+      end
+    end
+  end
+end

data/lib/ace/assign/version.rb

@@ -2,6 +2,6 @@
 
 module Ace
   module Assign
-    VERSION = "0.37.0"
+    VERSION = "0.40.3"
   end
 end

data/lib/ace/assign.rb

@@ -9,6 +9,7 @@ require "pathname"
 
 # CLI and commands
 require_relative "assign/cli"
+require_relative "assign/organisms/task_assignment_creator"
 
 module Ace
   module Assign

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ace-assign
 version: !ruby/object:Gem::Version
-  version: 0.37.0
+  version: 0.40.3
 platform: ruby
 authors:
 - Michal Czyz
@@ -107,6 +107,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.26'
+- !ruby/object:Gem::Dependency
+  name: ace-task
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.18'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.18'
 - !ruby/object:Gem::Dependency
   name: ace-support-test-helpers
   requirement: !ruby/object:Gem::Requirement
@@ -179,6 +193,7 @@ files:
 - ".ace-defaults/assign/catalog/steps/pre-commit-review.step.yml"
 - ".ace-defaults/assign/catalog/steps/push-to-remote.step.yml"
 - ".ace-defaults/assign/catalog/steps/rebase-with-main.step.yml"
+- ".ace-defaults/assign/catalog/steps/record-demo.step.yml"
 - ".ace-defaults/assign/catalog/steps/reflect-and-refactor.step.yml"
 - ".ace-defaults/assign/catalog/steps/release-minor.step.yml"
 - ".ace-defaults/assign/catalog/steps/release.step.yml"
@@ -212,6 +227,7 @@ files:
 - docs/usage.md
 - exe/ace-assign
 - handbook/guides/fork-context.g.md
+- handbook/skills/as-assign-add-task/SKILL.md
 - handbook/skills/as-assign-compose/SKILL.md
 - handbook/skills/as-assign-create/SKILL.md
 - handbook/skills/as-assign-drive/SKILL.md
@@ -219,6 +235,7 @@ files:
 - handbook/skills/as-assign-recover-fork/SKILL.md
 - handbook/skills/as-assign-run-in-batches/SKILL.md
 - handbook/skills/as-assign-start/SKILL.md
+- handbook/workflow-instructions/assign/add-task.wf.md
 - handbook/workflow-instructions/assign/compose.wf.md
 - handbook/workflow-instructions/assign/create.wf.md
 - handbook/workflow-instructions/assign/drive.wf.md
@@ -232,6 +249,8 @@ files:
 - lib/ace/assign/atoms/composition_rules.rb
 - lib/ace/assign/atoms/number_generator.rb
 - lib/ace/assign/atoms/preset_expander.rb
+- lib/ace/assign/atoms/preset_loader.rb
+- lib/ace/assign/atoms/preset_step_resolver.rb
 - lib/ace/assign/atoms/step_file_parser.rb
 - lib/ace/assign/atoms/step_numbering.rb
 - lib/ace/assign/atoms/step_sorter.rb
@@ -255,18 +274,20 @@ files:
 - lib/ace/assign/molecules/assignment_discoverer.rb
 - lib/ace/assign/molecules/assignment_manager.rb
 - lib/ace/assign/molecules/fork_session_launcher.rb
+- lib/ace/assign/molecules/preset_inferrer.rb
 - lib/ace/assign/molecules/queue_scanner.rb
 - lib/ace/assign/molecules/skill_assign_source_resolver.rb
 - lib/ace/assign/molecules/step_renumberer.rb
 - lib/ace/assign/molecules/step_writer.rb
 - lib/ace/assign/organisms/assignment_executor.rb
+- lib/ace/assign/organisms/task_assignment_creator.rb
 - lib/ace/assign/version.rb
 homepage: https://github.com/cs3b/ace
 licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/cs3b/ace
-  source_code_uri: https://github.com/cs3b/ace
+  source_code_uri: https://github.com/cs3b/ace/tree/main/ace-assign/
   changelog_uri: https://github.com/cs3b/ace/blob/main/ace-assign/CHANGELOG.md
 rdoc_options: []
 require_paths: