access-granted 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ce9cfd4d0c980f5f3ba545fa4f2691897b80698fd6fe665c6b29ff226131774
-  data.tar.gz: 82802d1c59a69c201f5f9bfd73de5f17e82e47d8532ca22682a4cef140bada80
+  metadata.gz: 7691e3b04d61e828a960869add4c89b2fcbbb0ff61449ae9a722f1170c776775
+  data.tar.gz: 3d802b85887e1e23027819cf14b2bd4ebb9d9bc4aef62f294bd8dedc1dc98457
 SHA512:
-  metadata.gz: 7e050411bc42573ce3da74a78672974f4cf589e97c5c320a2774093a4c659bd95302f49796fa1f7ec785a36b93823684c4942b828de675fa24d696bc14a1fb89
-  data.tar.gz: '0119c97744988a5c1aea30e5e1e14606cbb53a78c448e2b57d94cc2d7ebcdc0b0ab5220ff7a2672e6c1d56a8ce710f58a20625e288e6d9a4bef069ca1acff56b'
+  metadata.gz: 929211bc395469276092ed2303d5d4bf117161e9df3602cfea3d4caf67ea29516fca0473eb24e8e5326921d042ab8d534eef7a27e9ccdd727b29fd129f7cc622
+  data.tar.gz: d60b8f9c3824c28952daf0a84ee4bd534ec44cc7ef6f183949eb83538b015b2a80b155ee8f91ba6484d620041c2143a4ca9ce7d46c7ef71280b56f25d744821d

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.3.1
+
+- Add information about action and subject when raising AccessDenied exception ([PR #45](https://github.com/chaps-io/access-granted/pull/46)), thanks [jraqula](https://github.com/jraqula)!
+
 # 1.3.0
 
 - Drop support for Ruby 1.9.3, it might still work but we are no longer testing against it.

data/README.md

@@ -19,7 +19,9 @@ Run the bundle command to install it. Then run the generator:
 
 Add the `policies` (and `roles` if you're using it to split up your roles into files) directories to your autoload paths in `application.rb`:
     
-    config.autoload_paths += %W(#{config.root}/app/policies #{config.root}/app/roles)
+```ruby
+config.autoload_paths += %W(#{config.root}/app/policies #{config.root}/app/roles)
+```
 
 ### Supported Ruby versions
 
@@ -210,6 +212,26 @@ class ApplicationController < ActionController::Base
 end
 ```
 
+You can also extract the action and subject which raised the error,
+if you want to handle authorization errors differently for some cases:
+```ruby
+  rescue_from "AccessGranted::AccessDenied" do |exception|
+    status = case exception.action
+      when :read # invocation like `authorize! :read, @something`
+        403
+      else
+        404
+      end
+
+    body = case exception.subject
+      when Post # invocation like `authorize! @some_action, Post`
+        "failed to access a post"
+      else
+        "failed to access something else"
+      end
+  end
+```
+
 #### Checking permissions in controllers
 
 To check if the user has a permission to perform an action, use the `can?` and `cannot?` methods.

data/access-granted.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "access-granted"
-  spec.version       = "1.3.0"
+  spec.version       = "1.3.1"
   spec.authors       = ["Piotrek Okoński"]
   spec.email         = ["piotrek@okonski.org"]
   spec.description   = %q{Role based authorization gem}

data/lib/access-granted/exceptions.rb

@@ -3,5 +3,11 @@ module AccessGranted
 
   class DuplicatePermission < Error; end;
   class DuplicateRole < Error; end;
-  class AccessDenied < Error; end;
+  class AccessDenied < Error
+    attr_reader :action, :subject
+    def initialize(action = nil, subject = nil)
+      @action = action
+      @subject = subject
+    end
+  end
 end

data/lib/access-granted/policy.rb

@@ -58,7 +58,7 @@ module AccessGranted
 
     def authorize!(action, subject)
       if cannot?(action, subject)
-        raise AccessDenied
+        raise AccessDenied.new(action, subject)
       end
       subject
     end

data/spec/controller_methods_spec.rb

@@ -21,7 +21,11 @@ describe AccessGranted::Rails::ControllerMethods do
 
   describe "#authorize!" do
     it "raises exception when authorization fails" do
-      expect { @controller.authorize!(:read, String) }.to raise_error(AccessGranted::AccessDenied)
+      expect { @controller.authorize!(:read, String) }.to raise_error do |err|
+        expect(err).to be_a(AccessGranted::AccessDenied)
+        expect(err.action).to eq(:read)
+        expect(err.subject).to eq(String)
+      end
     end
 
     it "returns subject if authorization succeeds" do

data/spec/policy_spec.rb

@@ -136,7 +136,11 @@ describe AccessGranted::Policy do
       end
 
       it "raises AccessDenied if action is not allowed" do
-        expect { klass.new(@member).authorize!(:create, Integer) }.to raise_error AccessGranted::AccessDenied
+        expect { klass.new(@member).authorize!(:create, Integer) }.to raise_error do |err|
+          expect(err).to be_a(AccessGranted::AccessDenied)
+          expect(err.action).to eq(:create)
+          expect(err.subject).to eq(Integer)
+        end
       end
 
       it "returns the subject if allowed" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: access-granted
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Piotrek Okoński
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-18 00:00:00.000000000 Z
+date: 2018-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler