accepts_nested_ids 0.1.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 17cafe27c546d2cba99337b3fe75a190805c048a
-  data.tar.gz: ccc40cfda5235a83e9ecc0cc036e5a01d809462b
+SHA256:
+  metadata.gz: d46bd5aa6f826717d35c0c85d7250b7483e9d9e6b2db19e528ee2aa4d589dd5e
+  data.tar.gz: e548f69560b40eb4420ad9a7c236a7d2fe76a72d1fd6d791b1c61c0aca06a9ad
 SHA512:
-  metadata.gz: fb214073171ad689b195d39c159eed73555ed42080a84726b53863790a6e535a4f8c666605884dc802b76b25a388ea36bda61b01e9d7bb39e35cd311f3cf6ee0
-  data.tar.gz: c02d8406d6aa4dc8ce0f4e532b9cd9799b66a7c1f5c1556773c31397c9808a089f6fcc2b8ac3c78a4c050d2cdcb4eb5a954e2c7727bbbf959cbed3d8499381c8
+  metadata.gz: 64b38ffe75735cf1959795f83dba1c3c94741bcf2cd93e2fd0cdcee631a7969f3a09b96888b584c23ac9acefc0b01f5760564e2b4676b1f3818de32ea14ee540
+  data.tar.gz: bcd80ed8f969985f315e2717fa5ee78928616f52503e86fc133dc0121fe504344b722664539904326b4eb2893a3990ed02cb0d815061b36758a570e22453cf18

data/.travis.yml

@@ -1,4 +1,4 @@
 language: ruby
 rvm:
   - 2.2.2
-before_install: gem install bundler -v 1.10.3
+before_install: gem install bundler -v 2.2.7

data/CHANGELOG.md

@@ -0,0 +1,23 @@
+## 0.2.2 (2021-02-04)
+
+Ensure this works with Ruby 3.0.0 by adding the #attribute method within any class to extend ActiveRecord in order to create those helper methods.
+Example:
+`class Company < ActiveRecord::Base
+  include AcceptsNestedIds
+  has_many :users
+  accepts_nested_ids_for :users
+  attribute :user_ids
+end`
+
+
+## 0.2.1 (2016-02-05)
+
+Ensure empty array of nested associations is loaded, to handle situations where a sub class does not define its own associations and the intersection between base and sub class associations was failing.
+
+## 0.2.0 (2016-02-05)
+
+Fix for associations defined on a subclass not being saved.
+
+## 0.1.2 (2015-08-12)
+
+Fix for STI.

data/README.md

@@ -17,11 +17,7 @@ class Project < ActiveRecord::Base
   has_many :project_users
   has_many :users, through: :project_users
   validates :name, presence: true
-end
-
-class User < ActiveRecord::Base
-  has_many :project_users
-  has_many :projects, through: :project_users
+  attribute :user_ids
 end
 ```
 
@@ -84,7 +80,10 @@ class Project < ActiveRecord::Base
   has_many :project_users
   has_many :users, through: :project_users
   accepts_nested_ids_for :users
+  attribute :user_ids
 end
+
+project.user_ids = [...]
 ```
 
 ### When your association has a custom name:
@@ -95,9 +94,14 @@ class Project < ActiveRecord::Base
   has_many :project_users
   has_many :included_users, through: :project_users, source: :user
   accepts_nested_ids_for included_users: "User"
+  attribute :user_ids
 end
+
+project.included_user_ids = [...]
 ```
 
+When using a custom association name, you must specify the actual class name as a second arg, in this case "User".
+
 ### Mix and match as desired:
 
 ```ruby
@@ -107,10 +111,12 @@ class Project < ActiveRecord::Base
   has_many :project_users
   has_many :included_users, through: :project_users, source: :user
   accepts_nested_ids_for :documents, included_users: "User"
+  attribute :user_ids
 end
-```
 
-You can now comfortably set `document_ids` or `user_ids` on a `Project` without making a mess of things.
+project.document_ids = [...]
+project.included_user_ids = [...]
+```
 
 ## Development
 
@@ -118,6 +124,9 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+## Requirements
+Requires Activemodel & Activerecord `6.1.1` or higher
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/uberllama/accepts_nested_ids.

data/accepts_nested_ids.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.add_dependency "activesupport", ">= 3.0.0"
   spec.add_development_dependency "activerecord", ">= 4.2.3"
-  spec.add_development_dependency "bundler", "~> 1.10"
+  spec.add_development_dependency "bundler", "~> 2.2.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "sqlite3"

data/lib/accepts_nested_ids.rb

@@ -1,4 +1,5 @@
 require "accepts_nested_ids/version"
+require "accepts_nested_ids/nested_id_association"
 require "active_support/concern"
 require "active_support/core_ext/string/inflections"
 
@@ -23,7 +24,8 @@ module AcceptsNestedIds
     #   end
     #
     def save_nested_id_associations
-      self.class.nested_id_associations.each do |nested_id_association|
+      aggregated_id_associations = self.class.nested_id_associations | self.class.base_class.nested_id_associations
+      aggregated_id_associations.each do |nested_id_association|
         if instance_variable_get("@#{nested_id_association.ids_attr}")
           association_class = nested_id_association.class_name.constantize
           ids               = send(nested_id_association.ids_attr)
@@ -34,22 +36,15 @@ module AcceptsNestedIds
 
     module ClassMethods
 
-      # Simple object that contains information about a nested ID association
-      #
-      # @param attr [Symbol]       association attribute (ex: :documents)
-      # @param ids_attr [String]   ids association attribute (ex: 'document_ids')
-      # @param class_name [String] association class name (ex: 'Document')
-      class NestedIdAssociation < Struct.new(:attr, :ids_attr, :class_name); end
-
       # Sets up defered save and dirty tracking for the specified associations
       #
       # @example When class_name can be inferred from association name
       #   include AcceptsNestedIds
-      #   accepts_nested_ids_for :documents, :carrier_companies
+      #   accepts_nested_ids_for :documents, :users
       #
       # @example When class_name is different from association name
       #   include AcceptsNestedIds
-      #   accepts_nested_ids_for :documents, included_carrier_companies: "CarrierCompany"
+      #   accepts_nested_ids_for :documents, included_users: "User"
       #
       # @param args [Array]
       def accepts_nested_ids_for(*args)
@@ -82,14 +77,14 @@ module AcceptsNestedIds
           define_method("#{nested_id_association.ids_attr}=") do |value|
             return if send(nested_id_association.ids_attr) == value
             attribute_will_change!(nested_id_association.ids_attr)
-            instance_variable_set("@#{nested_id_association.ids_attr}", value)
+            instance_variable_set(:"@#{nested_id_association.ids_attr}", value)
           end
 
         end
       end
 
       def nested_id_associations
-        @_nested_id_associations
+        @_nested_id_associations || []
       end
 
       private
@@ -97,11 +92,11 @@ module AcceptsNestedIds
       # Map module args into array of NestedIdAssociation objects with supporting properties
       #
       # @example
-      #   accepts_nested_ids_for :documents, included_carrier_companies: "CarrierCompany"
+      #   accepts_nested_ids_for :documents, included_users: "User"
       #   =>
       #   [
       #     { attr: :documents:, ids_attr: "document_ids", class_name: "Document"},
-      #     { attr: :included_carrier_companies, ids_attr: "included_carrier_company_ids", class_name: "CarrierCompany" }
+      #     { attr: :included_users, ids_attr: "included_user_ids", class_name: "User" }
       #   ]
       #
       # @param args [Array]

data/lib/accepts_nested_ids/nested_id_association.rb

@@ -0,0 +1,11 @@
+module AcceptsNestedIds
+
+  # Simple object that contains information about a nested ID association
+  #
+  # @param attr [Symbol]       association attribute (ex: :documents)
+  # @param ids_attr [String]   ids association attribute (ex: 'document_ids')
+  # @param class_name [String] association class name (ex: 'Document')
+  class NestedIdAssociation < Struct.new(:attr, :ids_attr, :class_name)
+  end
+
+end

data/lib/accepts_nested_ids/version.rb

@@ -1,3 +1,3 @@
 module AcceptsNestedIds
-  VERSION = "0.1.0"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: accepts_nested_ids
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Yuval Kordov
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-07-26 00:00:00.000000000 Z
+date: 2021-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: 2.2.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: 2.2.7
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -106,6 +106,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -114,6 +115,7 @@ files:
 - bin/console
 - bin/setup
 - lib/accepts_nested_ids.rb
+- lib/accepts_nested_ids/nested_id_association.rb
 - lib/accepts_nested_ids/version.rb
 homepage: http://github.com/uberllama/accepts_nested_ids
 licenses:
@@ -134,8 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Predictable nesting of associations via ID