ac-summarization-utils 0.0.47.rc1

data/spec/summarization_utils_spec.rb

@@ -0,0 +1,210 @@
+require 'rspec'
+require 'redis'
+require 'mysql2'
+require_relative '../lib/ac-summarization-utils/summarization_utils'
+
+include ACSummarizationUtils
+include ACSummarizationUtils::SummUtils
+
+describe "Summarization Utils#" do
+
+  context "duplicate records#" do
+    it "should duplicate fields with multiple values" do
+      record1 = Record.new({ :required => {"ad_id" => 10},:group_fields=>{}})
+
+      input = [record1]
+      result = duplicate_records(input, "topic_id", [100,200,300])
+      result.should == [Record.new({:required => {"ad_id" => 10, "topic_id" => 100}, :group_fields=>{}}),
+                                             Record.new({:required => {"ad_id" => 10, "topic_id" => 200}, :group_fields=>{}}),
+                                             Record.new({:required => {"ad_id" => 10, "topic_id" => 300}, :group_fields=>{}})]
+    end
+
+    it "should duplicate fields one value" do
+      record1 = Record.new({ :required => {"ad_id" => 10},:group_fields=>{}})
+
+      input = [record1]
+
+      result = duplicate_records(input, "topic_id", [100])
+      result.should == [Record.new({:required => {"ad_id" => 10, "topic_id" => 100}, :group_fields=>{}})]
+    end
+
+    it "should duplicate multiple records with mupltiple values" do
+      record1 = Record.new({ :required => {"ad_id" => 10},:group_fields=>{}})
+      record2 = Record.new({ :required => {"ad_id" => 11},:group_fields=>{}})
+
+      input = [record1, record2]
+
+      result = duplicate_records(input, "topic_id", [100,200])
+      result.should == [Record.new({:required => {"ad_id" => 10, "topic_id" => 100}, :group_fields=>{}}),
+                        Record.new({:required => {"ad_id" => 11, "topic_id" => 100}, :group_fields=>{}}),
+                        Record.new({:required => {"ad_id" => 10, "topic_id" => 200}, :group_fields=>{}}),
+                        Record.new({:required => {"ad_id" => 11, "topic_id" => 200}, :group_fields=>{}})]
+    end
+
+    it "should keep fields to group by" do
+      record1 = Record.new({ :required => {"ad_id" => 10},:group_fields=>{"ad_id" => 10}})
+      record2 = Record.new({ :required => {"ad_id" => 11},:group_fields=>{"ad_id" => 10}})
+
+      input = [record1, record2]
+
+      result = duplicate_records(input, "topic_id", [100,200])
+      result.should == [Record.new({:required => {"ad_id" => 10, "topic_id" => 100}, :group_fields=>{"ad_id" => 10}}),
+                        Record.new({:required => {"ad_id" => 11, "topic_id" => 100}, :group_fields=>{"ad_id" => 10}}),
+                        Record.new({:required => {"ad_id" => 10, "topic_id" => 200}, :group_fields=>{"ad_id" => 10}}),
+                        Record.new({:required => {"ad_id" => 11, "topic_id" => 200}, :group_fields=>{"ad_id" => 10}})]
+    end
+
+    it "should return given records if input array is null or expanded fileds are not good" do
+
+      duplicate_records(nil, nil, nil).should == nil
+      duplicate_records(nil, "topic_id", [100,200]).should == nil
+      duplicate_records([], "topic_id", [100,200]).should == []
+
+      record1 = Record.new({ :required => {"ad_id" => 10},:group_fields=>{"ad_id" => 10}})
+      record2 = Record.new({ :required => {"ad_id" => 11},:group_fields=>{"ad_id" => 10}})
+
+      input = [record1, record2]
+
+      duplicate_records(input, nil, [100,200]).should == input
+      duplicate_records(input, "topic_id", nil).should == input
+      duplicate_records(input, "topic_id", []).should == input
+    end
+
+  end
+
+  context "summarize records#" do
+    it "should handle nil and empty values correctly" do
+
+      summarize_records(nil, [{:method => method(:sum), :input_field_name => "cpc", :output_field_name => "spend"}]).should == []
+      summarize_records([], [{:method => method(:sum), :input_field_name => "cpc", :output_field_name => "spend"}]).should == []
+    end
+
+
+    it "should summarize records with sum for 1 record" do
+
+      input = [Record.new({:required => {"ad_id" => 10} , :group_fields => { "cpc" => 0.6}})]
+      summarize_records(input, [{:method => method(:sum), :input_field_name => "cpc", :output_field_name => "spend"}]).should == [{"ad_id" => 10, "spend" => 0.6}]
+    end
+
+    it "should summarize records with count for 1 record" do
+
+      input = [Record.new({:required => {"ad_id" => 10} , :group_fields => { "ad_id" => 10}})]
+      summarize_records(input, [{:method => method(:count), :input_field_name => "ad_id", :output_field_name => "clicks"}]).should == [{"ad_id" => 10, "clicks" => 1}]
+    end
+
+    it "should summarize records with count for more than 1 record" do
+
+      input = [Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "ad_id" => 10}}),
+               Record.new({:required => {"ad_id" => 20, "adgroup_id" => 5} , :group_fields => { "ad_id" => 20}}),
+               Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "ad_id" => 10}})]
+
+      group_options = [{:method => method(:count), :input_field_name => "ad_id", :output_field_name => "clicks"}]
+
+      summarize_records(input,group_options).should == [{"ad_id" => 10, "adgroup_id" => 5, "clicks" => 2}, {"ad_id" => 20, "adgroup_id" => 5, "clicks" => 1}]
+    end
+
+    it "should summarize records with sum for more than 1 record" do
+
+      input = [Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => 0.1}}),
+               Record.new({:required => {"ad_id" => 20, "adgroup_id" => 5} , :group_fields => { "cpc" => 0.2}}),
+               Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => 0.3}})]
+
+      group_options = [{:method => method(:sum), :input_field_name => "cpc", :output_field_name => "spend"}]
+
+      summarize_records(input,group_options ).should == [{"ad_id" => 10, "adgroup_id" => 5, "spend" => 0.4}, {"ad_id" => 20, "adgroup_id" => 5, "spend" => 0.2}]
+    end
+
+    it "should summarize records with sum and count for more than 1 record" do
+
+      input = [Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => 0.1, "ad_id" => 10}}),
+               Record.new({:required => {"ad_id" => 20, "adgroup_id" => 5} , :group_fields => { "cpc" => 0.2, "ad_id" => 20}}),
+               Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => 0.3, "ad_id" => 10}})]
+      group_options = [{:method => method(:sum), :input_field_name => "cpc", :output_field_name => "spend"},
+                       {:method => method(:count), :input_field_name => "ad_id", :output_field_name => "clicks"}]
+
+      summarize_records(input,group_options).should == [{"ad_id" => 10, "adgroup_id" => 5, "spend" => 0.4, "clicks" => 2}, {"ad_id" => 20, "adgroup_id" => 5, "spend" => 0.2, "clicks" => 1}]
+    end
+
+    it "should summarize records with sum and count for more than 1 record even if they are strings" do
+
+      input = [Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.1", "ad_id" => 10}}),
+               Record.new({:required => {"ad_id" => 20, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.2", "ad_id" => 20}}),
+               Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.3", "ad_id" => 10}})]
+      group_options = [{:method => method(:sum), :input_field_name => "cpc", :output_field_name => "spend"},
+                       {:method => method(:count), :input_field_name => "ad_id", :output_field_name => "clicks"}]
+
+      summarize_records(input,group_options).should == [{"ad_id" => 10, "adgroup_id" => 5, "spend" => 0.4, "clicks" => 2}, {"ad_id" => 20, "adgroup_id" => 5, "spend" => 0.2, "clicks" => 1}]
+    end
+
+    it "should find min records with cpc more than 1 record even if they are strings" do
+
+      input = [Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.1", "ad_id" => 10}}),
+               Record.new({:required => {"ad_id" => 20, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.2", "ad_id" => 20}}),
+               Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.3", "ad_id" => 10}})]
+      group_options = [{:method => method(:minimum), :input_field_name => "cpc", :output_field_name => "min_cpc"}]
+
+      summarize_records(input,group_options).should == [{"ad_id" => 10, "adgroup_id" => 5, "min_cpc" => 0.1}, {"ad_id" => 20, "adgroup_id" => 5, "min_cpc" => 0.2}]
+    end
+
+    it "should find max records with cpc more than 1 record even if they are strings" do
+
+      input = [Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.1", "ad_id" => 10}}),
+               Record.new({:required => {"ad_id" => 20, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.2", "ad_id" => 20}}),
+               Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.3", "ad_id" => 10}})]
+      group_options = [{:method => method(:maximum), :input_field_name => "cpc", :output_field_name => "max_cpc"}]
+
+      summarize_records(input,group_options).should == [{"ad_id" => 10, "adgroup_id" => 5, "max_cpc" => 0.3}, {"ad_id" => 20, "adgroup_id" => 5, "max_cpc" => 0.2}]
+    end
+
+    it "should find average CPC records more than 1 record even if they are strings" do
+
+      input = [Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.1", "ad_id" => 10}}),
+               Record.new({:required => {"ad_id" => 20, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.2", "ad_id" => 20}}),
+               Record.new({:required => {"ad_id" => 10, "adgroup_id" => 5} , :group_fields => { "cpc" => "0.3", "ad_id" => 10}})]
+      group_options = [{:method => method(:average), :input_field_name => "cpc", :output_field_name => "avg_cpc"}]
+
+      summarize_records(input,group_options).should == [{"ad_id" => 10, "adgroup_id" => 5, "avg_cpc" => 0.2,"avg_cpc_sum"=>0.4, "avg_cpc_count"=>2}, {"ad_id" => 20, "adgroup_id" => 5, "avg_cpc" => 0.2,"avg_cpc_sum"=>0.2, "avg_cpc_count"=>1}]
+    end
+
+    it "should raise error if group by field doesn't exist" do
+
+      input = [Record.new({:required => {"ad_id" => 10} , :group_fields => { }})]
+      group_options = [{:method => method(:sum), :input_field_name => "cpc", :output_field_name => "spend"}]
+
+      lambda {summarize_records(input,group_options)}.should raise_error(ArgumentError)
+    end
+
+  end
+
+  context "create_records#" do
+    it "should call spefific create records block after downcase for each message" do
+      messages = [{"A" => "b"}, {"a" => "b"}, {"A" => "b"}]
+      records, input_errors = create_records(nil, nil, messages) do |m|
+        m["a"].should == "b"
+        [m]
+      end
+      records.size.should == 3
+      input_errors.size.should == 0
+    end
+
+    it "should create error messages for each erroneous message" do
+      def print_error(logger, msg)
+        puts "Correctly printed error during test"
+      end
+      messages = [{"A" => "b"}, {"a" => "b"}, {"A" => "b"}]
+      error_message = {:messages => {"A" => "b"}}
+      mock_error_handler = mock("ErrorsHandler")
+      mock_error_handler.should_receive(:generate_error_message).with(any_args()).exactly(3).times.and_return(error_message)
+      mock_logger = mock("logger")
+      mock_logger.stub(:log)
+
+      records, input_errors = create_records(mock_logger, mock_error_handler, messages) do |m|
+        raise ArgumentError.new
+      end
+      records.size.should == 0
+      input_errors.size.should == 3
+    end
+
+  end
+
+end

data/spec/validation_utils_spec.rb

@@ -0,0 +1,328 @@
+require 'rspec'
+require 'redis'
+require 'mysql2'
+require_relative '../lib/ac-summarization-utils/validation_utils'
+
+include ACSummarizationUtils
+include ACSummarizationUtils::ValidationUtils
+
+CPC_CAMPAIGN = 1
+CPV_CAMPAIGN = 3
+
+describe "Validation Utils#" do
+
+  context "is_valid_real_click#" do
+
+    it "should return true if all fields are correct" do
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == true
+      is_valid_real_click?(click,CPV_CAMPAIGN).should == true
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ct" => 1}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == true
+      is_valid_real_click?(click,CPV_CAMPAIGN).should == true
+      click = { "ad_id" => "1", "validitytype" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == true
+      is_valid_real_click?(click,CPV_CAMPAIGN).should == true
+    end
+
+    it "should return false if the click has ad_id = -1" do
+      click = { "ad_id" => "-1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == false
+      is_valid_real_click?(click,CPV_CAMPAIGN).should == false
+    end
+
+    it "should  return false if the click doesn't have advertiser_id of 8" do
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 9, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == false
+      is_valid_real_click?(click,CPV_CAMPAIGN).should == false
+    end
+
+    it "should  return false if the click doesn't have allowed clicktype or ct" do
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 55}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == false
+      is_valid_real_click?(click,CPV_CAMPAIGN).should == false
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ct" => 55}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == false
+      is_valid_real_click?(click,CPV_CAMPAIGN).should == false
+    end
+
+    it "should  return false if the click dis not valid" do
+      click = { "ad_id" => "1", "valid" => 2, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_real_click?(click,CPC_CAMPAIGN).should == false
+    end
+
+  end
+
+  context "common_click_validations#" do
+
+    it "should return click type and valid value (ad_id of class Fixnum)" do
+      click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1, "ad_id" => 12}
+      common_click_validations(click).should == [click["clicktype"], click["valid"]]
+    end
+
+    it "should return click type and valid value (ad_id of class String)" do
+      click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1, "ad_id" => "12"}
+      common_click_validations(click).should == [click["clicktype"], click["valid"]]
+    end
+
+    it "should raise ArgumentError if ad_id doesn't exist" do
+      click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      lambda {common_click_validations(click)}.should raise_error(ArgumentError,"message required field 'ad_id' doesn't exist")
+    end
+
+    it "should raise ArgumentError if valid doesn't exist" do
+      click = { "ad_id" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      lambda {common_click_validations(click)}.should raise_error(ArgumentError,"message required field valid not validitytype doesn't exist")
+    end
+
+    it "should raise ArgumentError if advertiserid doesn't exist" do
+      click = { "valid" => 1, "ad_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      lambda {common_click_validations(click)}.should raise_error(ArgumentError,"message required field 'advertiser_id' doesn't exist")
+    end
+
+    it "should raise ArgumentError if cpc doesn't exist" do
+      click = { "valid" => 1, "advertiser_id" => 8, "ad_id" => "1", "clicktype" => 1}
+      lambda {common_click_validations(click)}.should raise_error(ArgumentError,"message required field 'cpc' doesn't exist")
+    end
+
+    it "should raise ArgumentError if clicktype doesn't exist, but click url exists" do
+      click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ad_id" => 1, "clickurl" => 'http://stam.com'}
+      lambda {common_click_validations(click)}.should raise_error(ArgumentError,"message required field click_type not ct doesn't exist")
+    end
+    
+    it "should return invalid click if no click type and no clickurl" do
+      click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ad_id" => 1}
+      common_click_validations(click).should == [-1,-1]
+    end
+
+		it "should return invalid click if no click type and clickurl is NULL" do
+		  click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ad_id" => 1, "clickurl" => "NULL"}
+		  common_click_validations(click).should == [-1,-1]
+		end
+
+    it "should raise ArgumentError if ad id contains something other than numbers" do
+      click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ad_id" => "1qwer;", "clicktype" => 1}
+      lambda {common_click_validations(click)}.should raise_error(ArgumentError,"invalid ad id: 1qwer;")
+    end
+    
+  end
+
+  context "is_valid_direct_click#" do
+
+    it "should return true if all fields are correct" do
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_direct_click?(click).should == true
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ct" => 1}
+      is_valid_direct_click?(click).should == true
+      click = { "ad_id" => "1", "validitytype" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_direct_click?(click).should == true
+    end
+
+    it "should return false if the click has ad_id = -1" do
+      click = { "ad_id" => "-1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_direct_click?(click).should == false
+    end
+
+    it "should  return false if the click doesn't have valid or validitytype of 1" do
+      click = { "ad_id" => "1", "valid" => 2, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_direct_click?(click).should == false
+      click = { "ad_id" => "1", "validitytype" => 2, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_direct_click?(click).should == false
+    end
+
+    it "should  return false if the click doesn't have advertiser_id of 8" do
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 9, "cpc" => "0.1", "clicktype" => 1}
+      is_valid_direct_click?(click).should == false
+    end
+
+    it "should  return false if the click doesn't have cpc larger than 0.0" do
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "-0.1", "clicktype" => 1}
+      is_valid_direct_click?(click).should == false
+    end
+
+    it "should  return false if the click doesn't have allowed clicktype or ct" do
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "clicktype" => 55}
+      is_valid_direct_click?(click).should == false
+      click = { "ad_id" => "1", "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ct" => 55}
+      is_valid_direct_click?(click).should == false
+    end
+
+  end
+
+  context "is_valid_direct_layer_impr#" do
+
+    it "should return true if all fields are correct" do
+      layer_impr = { "ad_id" => "1", "advertiserid" => 8}
+      is_valid_direct_layer_impr?(layer_impr).should == true
+    end
+
+    it "should return false if the layer has ad_id = -1" do
+      layer_impr = { "ad_id" => "-1", "advertiserid" => 8}
+      is_valid_direct_layer_impr?(layer_impr).should == false
+    end
+
+
+    it "should  return false if the layer doesn't have advertiserid of 8" do
+      layer_impr = { "ad_id" => "1","advertiserid" => 9}
+      is_valid_direct_layer_impr?(layer_impr).should == false
+    end
+
+    it "should raise ArgumentError if ad_id doesn't exist" do
+      layer_impr = { "advertiserid" => 8}
+      lambda {is_valid_direct_layer_impr?(layer_impr)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if advertiserid doesn't exist" do
+      layer_impr = { "ad_id" => 8}
+      lambda {is_valid_direct_layer_impr?(layer_impr)}.should raise_error(ArgumentError)
+    end
+
+  end
+
+  context "is_valid_layer_impr#" do
+
+    it "should return true if all field values are correct and there are no missing values" do
+      layer_impr = { "validitytype" => "1", "cpc" => 0.8, "advertiserid" => 1234, "ad_id" => -1}
+      is_valid_layer_impr?(layer_impr).should == true
+    end
+
+
+    it "should return false if the layer doesn't have cpc value greater than or equal to 0.0" do
+      layer_impr = { "validitytype" => "2", "cpc" => -1.2, "advertiserid" => 55, "ad_id" => -1}
+      is_valid_layer_impr?(layer_impr).should == false
+    end
+
+    it "should raise ArgumentError if cpc doesn't exist" do
+      layer_impr = { "validitytype" => "2", "advertiserid" => 55, "ad_id" => -1}
+      lambda {is_valid_layer_impr?(layer_impr)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if advertiserid doesn't exist" do
+      layer_impr = { "valid" => "1", "cpc" => 0.2, "ad_id" => 121212}
+      lambda {is_valid_layer_impr?(layer_impr)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if ad_id doesn't exist" do
+      layer_impr = { "cpc" => 0.2, "advertiserid" => 303, "validitytype" => 1}
+      lambda {is_valid_layer_impr?(layer_impr)}.should raise_error(ArgumentError)
+    end
+
+  end
+
+  context "is_valid_click#" do
+
+    it "should return true if all field values are correct and there are no missing values" do
+      click = { "validitytype" => "1", "cpc" => 0.8, "advertiser_id" => 1234, "clicktype" => 5, "publisher_id" => 131821, "ad_id" => -1}
+      is_valid_click?(click).should == true
+      click = { "valid" => "1", "cpc" => 0.9, "advertiser_id" => 8, "clicktype" => 1, "p" => 55452, "ad_id" => 150231}
+      is_valid_click?(click).should == true
+      click = { "validitytype" => "1", "cpc" => 0.4, "advertiser_id" => 7, "ct" => 1005, "p" => 653351, "ad_id" => -1}
+      is_valid_click?(click).should == true
+      click = { "validitytype" => "1", "cpc" => 0.8, "advertiser_id" => 8, "clicktype" => 2, "publisher_id" => 884223, "ad_id" => 54544}
+      is_valid_click?(click).should == true
+      click = { "valid" => "1", "cpc" => 1.2, "advertiser_id" => 61, "ct" => 6, "publisher_id" => 131821, "ad_id" => -1}
+      is_valid_click?(click).should == true
+    end
+
+    it "should return false if validitytype is not 1" do
+      click = { "valid" => "2", "cpc" => 1.2, "advertiser_id" => 61, "clicktype" => 6, "publisher_id" => 131821, "ad_id" => -1}
+      is_valid_click?(click).should == false
+      click = { "validitytype" => "2", "cpc" => 1.2, "advertiser_id" => 61, "clicktype" => 6, "publisher_id" => 131821, "ad_id" => -1}
+      is_valid_click?(click).should == false
+    end
+
+
+    it "should return false if the clicktype is not allowed" do
+      click = { "valid" => "1", "cpc" => 1.2, "advertiser_id" => 61, "clicktype" => 7, "p" => 131821, "ad_id" => -1}
+      is_valid_click?(click).should == false
+      click = { "validitytype" => "1", "cpc" => 1.2, "advertiser_id" => 8, "ct" => 1006, "publisher_id" => 131821, "ad_id" => -1}
+      is_valid_click?(click).should == false
+    end
+
+    it "should return false if the cpc is below 0.0" do
+      click = { "valid" => "1", "cpc" => -0.5, "advertiser_id" => 61, "clicktype" => 5, "p" => 131821, "ad_id" => -1}
+      is_valid_click?(click).should == false
+    end
+
+    it "should raise ArgumentError if cpc doesn't exist" do
+      click = { "valid" => "1", "advertiser_id" => 61, "clicktype" => 5, "p" => 131821, "ad_id" => -1}
+      lambda {is_valid_click?(click)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if advertiser_id doesn't exist" do
+      click = { "valid" => "1", "cpc" => 0.55, "ct" => 5, "p" => 131821, "ad_id" => -1}
+      lambda {is_valid_click?(click)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if publisher_id doesn't exist" do
+      click = { "valid" => "1", "cpc" => 0.55, "clicktype" => 2,"advertiser_id" => 3216, "ad_id" => -1}
+      lambda {is_valid_click?(click)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if ad_id doesn't exist" do
+      click = { "validitytype" => "1", "cpc" => 0.55, "clicktype" => 1005,"advertiser_id" => 3216, "publisher_id" => 4042}
+      lambda {is_valid_click?(click)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if validitytype doesn't exist" do
+      click = { "ad_id" => 55422, "cpc" => 0.55, "ct" => 5,"advertiser_id" => 8, "p" => 4042}
+      lambda {is_valid_click?(click)}.should raise_error(ArgumentError)
+    end
+
+    it "should return invalid click if no click type and no clickurl" do
+      click = { "valid" => 1, "advertiser_id" => 8, "cpc" => "0.1", "ad_id" => 1, "p" => 4}
+      is_valid_click?(click).should == false
+    end
+
+  end
+
+  context "is_valid_impression#" do
+
+    it "should return true if all field values are correct and there are no missing values" do
+      imp = { "pid" => 131821, "itid" => 3}
+      is_valid_impression?(imp).should == true
+
+    end
+
+    it "should return false if impression type id  is not 3" do
+      imp = { "pid" => 131821, "itid" => 2}
+      is_valid_impression?(imp).should == false
+      imp = { "pid" => 131821, "itid" => 12}
+      is_valid_impression?(imp).should == false
+    end
+
+    it "should raise ArgumentError if pid doesn't exist" do
+      imp = { "pid2" => 131821, "itid" => 3}
+      lambda { is_valid_impression?(imp)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if itid doesn't exist" do
+      imp = { "pid" => 131821, "itid2" => 3}
+      lambda { is_valid_impression?(imp)}.should raise_error(ArgumentError)
+    end
+  end
+
+  context "is_valid_inimage_report#" do
+
+    it "should return true if value exists and there is an account_id" do
+      click = { "value" => {"account_id" => "119b99ec63b", "campaign_data" => {"iid" => "1234", "kid" => "56342"}}}
+      is_valid_inimage_report?(click).should == true
+    end
+
+    it "should return false if account_id is an empty string" do
+      click = { "value" => {"account_id" => "", "campaign_data" => {"iid" => "1234", "kid" => "56342"}}}
+      is_valid_inimage_report?(click).should == false
+    end
+
+    it "should raise ArgumentError if value exists and account_id is nil" do
+      click = { "value" => {"campaign_data" => {"iid" => "1234", "kid" => "56342"}}}
+      lambda { is_valid_impression?(click)}.should raise_error(ArgumentError)
+    end
+
+    it "should raise ArgumentError if value doesn't exist'" do
+      imp = {"category" => "inimage", "campaign_data" => {"iid" => "1234", "kid" => "56342"}}
+      lambda { is_valid_impression?(imp)}.should raise_error(ArgumentError)
+    end
+
+  end
+end