abt-cli 0.0.3 → 0.0.4

data/lib/abt/providers/asana/commands/harvest_time_entry_data.rb

@@ -13,7 +13,7 @@ module Abt
             'Print Harvest time entry data for Asana task as json. Used by harvest start script.'
           end
 
-          def call
+          def call # rubocop:disable Metrics/MethodLength
             ensure_current_is_valid!
 
             body = {
@@ -41,7 +41,7 @@ module Abt
           end
 
           def task
-            @task ||= api.get("tasks/#{task_gid}")
+            @task ||= api.get("tasks/#{task_gid}", opt_fields: 'name,permalink_url,memberships.project')
           end
         end
       end

data/lib/abt/providers/asana/commands/init.rb

@@ -14,7 +14,7 @@ module Abt
           end
 
           def call
-            cli.warn 'Loading projects'
+            cli.abort 'Must be run inside a git repository' unless config.local_available?
 
             projects # Load projects up front to make it obvious that searches are instant
             project = find_search_result
@@ -53,8 +53,13 @@ module Abt
           end
 
           def projects
-            @projects ||=
-              api.get_paged('projects', workspace: config.workspace_gid, archived: false)
+            @projects ||= begin
+              cli.warn 'Fetching projects...'
+              api.get_paged('projects',
+                            workspace: config.workspace_gid,
+                            archived: false,
+                            opt_fields: 'name,permalink_url')
+            end
           end
         end
       end

data/lib/abt/providers/asana/commands/{pick_task.rb → pick.rb}

@@ -4,9 +4,9 @@ module Abt
   module Providers
     module Asana
       module Commands
-        class PickTask < BaseCommand
+        class Pick < BaseCommand
           def self.command
-            'pick-task asana[:<project-gid>]'
+            'pick asana[:<project-gid>]'
           end
 
           def self.description
@@ -14,7 +14,10 @@ module Abt
           end
 
           def call
+            cli.abort 'Must be run inside a git repository' unless config.local_available?
+
             cli.warn project['name']
+
             task = cli.prompt_choice 'Select a task', tasks
 
             config.project_gid = project_gid # We might have gotten the project ID as an argument
@@ -32,14 +35,18 @@ module Abt
           def tasks
             @tasks ||= begin
               section = cli.prompt_choice 'Which section?', sections
-              api.get_paged('tasks', section: section['gid'])
+              cli.warn 'Fetching tasks...'
+              api.get_paged('tasks', section: section['gid'], opt_fields: 'name,permalink_url')
             end
           end
 
           def sections
-            api.get_paged("projects/#{project_gid}/sections")
-          rescue Abt::HttpError::HttpError
-            []
+            @sections ||= begin
+              cli.warn 'Fetching sections...'
+              api.get_paged("projects/#{project_gid}/sections", opt_fields: 'name')
+                          rescue Abt::HttpError::HttpError
+                            []
+            end
           end
         end
       end

data/lib/abt/providers/asana/commands/projects.rb

@@ -22,8 +22,15 @@ module Abt
           private
 
           def projects
-            @projects ||=
-              api.get_paged('projects', workspace: config.workspace_gid, archived: false)
+            @projects ||= begin
+              cli.warn 'Fetching projects...'
+              api.get_paged(
+                'projects',
+                workspace: config.workspace_gid,
+                archived: false,
+                opt_fields: 'name'
+              )
+            end
           end
         end
       end

data/lib/abt/providers/asana/commands/share.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module Abt
+  module Providers
+    module Asana
+      module Commands
+        class Share < BaseCommand
+          def self.command
+            'share asana[:<project-gid>[/<task-gid>]]'
+          end
+
+          def self.description
+            'Print project/task config string'
+          end
+
+          def call
+            if project_gid.nil?
+              cli.warn 'No project selected'
+            elsif task_gid.nil?
+              cli.print_provider_command('asana', project_gid)
+            else
+              cli.print_provider_command('asana', "#{project_gid}/#{task_gid}")
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/abt/providers/asana/commands/start.rb

@@ -14,18 +14,53 @@ module Abt
           end
 
           def call
-            Current.new(arg_str: arg_str, cli: cli).call unless arg_str.nil?
+            abort 'No current/provided task' if task_gid.nil?
+
+            maybe_override_current_task
+
+            update_assignee_if_needed
+            move_if_needed
+          end
+
+          private
+
+          def maybe_override_current_task
+            return if arg_str.nil?
+            return if same_args_as_config?
+            return unless config.local_available?
+
+            should_override = cli.prompt_boolean 'Set selected task as current?'
+            Current.new(arg_str: arg_str, cli: cli).call if should_override
+          end
+
+          def update_assignee_if_needed
+            current_assignee = task.dig('assignee')
+
+            if current_assignee.nil?
+              cli.warn "Assigning task to user: #{current_user['name']}"
+              update_assignee
+            elsif current_assignee['gid'] == current_user['gid']
+              cli.warn 'You are already assigned to this task'
+            elsif cli.prompt_boolean "Task is assigned to: #{current_assignee['name']}, take over?"
+              cli.warn "Reassigning task to user: #{current_user['name']}"
+              update_assignee
+            end
+          end
+
+          def move_if_needed
+            unless project_gid == config.project_gid
+              cli.warn 'Task was not moved, this is not implemented for tasks outside current project'
+              return
+            end
 
             if task_already_in_wip_section?
-              cli.warn "Task already in #{current_task_section['name']}"
+              cli.warn "Task already in section: #{current_task_section['name']}"
             else
-              cli.warn "Moving task to #{wip_section['name']}"
+              cli.warn "Moving task to section: #{wip_section['name']}"
               move_task
             end
           end
 
-          private
-
           def task_already_in_wip_section?
             !task_section_membership.nil?
           end
@@ -50,8 +85,18 @@ module Abt
             api.post("sections/#{config.wip_section_gid}/addTask", body_json)
           end
 
+          def update_assignee
+            body = { data: { assignee: current_user['gid'] } }
+            body_json = Oj.dump(body, mode: :json)
+            api.put("tasks/#{task_gid}", body_json)
+          end
+
+          def current_user
+            @current_user ||= api.get('users/me', opt_fields: 'name')
+          end
+
           def task
-            @task ||= api.get("tasks/#{task_gid}")
+            @task ||= api.get("tasks/#{task_gid}", opt_fields: 'name,memberships.section.name,assignee.name')
           end
         end
       end

data/lib/abt/providers/asana/commands/tasks.rb

@@ -28,7 +28,10 @@ module Abt
           end
 
           def tasks
-            @tasks ||= api.get_paged('tasks', project: project['gid'])
+            @tasks ||= begin
+              cli.warn 'Fetching tasks...'
+              api.get_paged('tasks', project: project['gid'], opt_fields: 'name')
+            end
           end
         end
       end

data/lib/abt/providers/asana/configuration.rb

@@ -8,19 +8,24 @@ module Abt
 
         def initialize(cli:)
           @cli = cli
+          @git = GitConfig.new(namespace: 'abt.asana')
+        end
+
+        def local_available?
+          GitConfig.local_available?
         end
 
         def project_gid
-          Abt::GitConfig.local('abt.asana.projectGid')
+          local_available? ? git['projectGid'] : nil
         end
 
         def task_gid
-          Abt::GitConfig.local('abt.asana.taskGid')
+          local_available? ? git['taskGid'] : nil
         end
 
         def workspace_gid
           @workspace_gid ||= begin
-            current = Abt::GitConfig.global('abt.asana.workspaceGid')
+            current = git.global['workspaceGid']
             if current.nil?
               prompt_workspace['gid']
             else
@@ -30,69 +35,84 @@ module Abt
         end
 
         def wip_section_gid
-          @wip_section_gid ||= begin
-            current = Abt::GitConfig.global('abt.asana.wipSectionGid')
-            if current.nil?
-              prompt_wip_section['gid']
-            else
-              current
-            end
-          end
+          return nil unless local_available?
+
+          @wip_section_gid ||= git['wipSectionGid'] || prompt_wip_section['gid']
+        end
+
+        def finalized_section_gid
+          return nil unless local_available?
+
+          @finalized_section_gid ||= git['finalizedSectionGid'] || prompt_finalized_section['gid']
         end
 
         def project_gid=(value)
           return if project_gid == value
 
           clear_local
-          Abt::GitConfig.local('abt.asana.projectGid', value) unless value.nil?
+          git['projectGid'] = value unless value.nil?
         end
 
         def task_gid=(value)
-          if value.nil?
-            Abt::GitConfig.unset_local('abt.asana.taskGid')
-          elsif task_gid != value
-            Abt::GitConfig.local('abt.asana.taskGid', value)
-          end
+          git['taskGid'] = value
         end
 
         def clear_local
-          Abt::GitConfig.unset_local('abt.asana.projectGid')
-          Abt::GitConfig.unset_local('abt.asana.taskGid')
-          Abt::GitConfig.unset_local('abt.asana.wipSectionGid')
+          cli.abort 'No local configuration was found' unless local_available?
+
+          git['projectGid'] = nil
+          git['taskGid'] = nil
+          git['wipSectionGid'] = nil
+          git['finalizedSectionGid'] = nil
         end
 
         def clear_global
-          Abt::GitConfig.unset_global('abt.asana.workspaceGid')
-          Abt::GitConfig.unset_global('abt.asana.accessToken')
+          git.global['workspaceGid'] = nil
+          git.global['accessToken'] = nil
         end
 
         def access_token
-          Abt::GitConfig.prompt_global(
-            'abt.asana.accessToken',
-            'Please enter your personal asana access_token',
-            'Create a personal access token here: https://app.asana.com/0/developer-console'
-          )
+          return git.global['accessToken'] unless git.global['accessToken'].nil?
+
+          git.global['accessToken'] = cli.prompt([
+            'Please provide your personal access token for Asana.',
+            'If you don\'t have one, create one here: https://app.asana.com/0/developer-console',
+            '',
+            'Enter access token'
+          ].join("\n"))
         end
 
         private
 
-        def prompt_wip_section
-          sections = api.get_paged("projects/#{project_gid}/sections")
+        attr_reader :git
 
-          section = cli.prompt_choice('Select WIP (Work In Progress) section', sections)
-          Abt::GitConfig.global('abt.asana.wipSectionGid', section['gid'])
+        def prompt_finalized_section
+          section = prompt_section('Select section for finalized tasks (E.g. "Merged")')
+          git['finalizedSectionGid'] = section['gid']
           section
         end
 
+        def prompt_wip_section
+          section = prompt_section('Select WIP (Work In Progress) section')
+          git['wipSectionGid'] = section['gid']
+          section
+        end
+
+        def prompt_section(message)
+          cli.warn 'Fetching sections...'
+          sections = api.get_paged("projects/#{project_gid}/sections")
+          cli.prompt_choice(message, sections)
+        end
+
         def prompt_workspace
+          cli.warn 'Fetching workspaces...'
           workspaces = api.get_paged('workspaces')
           if workspaces.empty?
             cli.abort 'Your asana access token does not have access to any workspaces'
           end
 
-          # TODO: Handle if there are multiple workspaces
-          workspace = workspaces.first
-          Abt::GitConfig.global('abt.asana.workspaceGid', workspace['gid'])
+          workspace = cli.prompt_choice('Select Asana workspace', workspaces)
+          git.global['workspaceGid'] = workspace['gid']
           workspace
         end
 

data/lib/abt/providers/harvest.rb

@@ -1,60 +1,18 @@
 # frozen_string_literal: true
 
-Dir.glob("#{File.expand_path(__dir__)}/harvest/*.rb").sort.each do |file|
-  require file
-end
+Dir.glob("#{File.expand_path(__dir__)}/harvest/*.rb").sort.each { |file| require file }
+Dir.glob("#{File.expand_path(__dir__)}/harvest/commands/*.rb").sort.each { |file| require file }
 
 module Abt
   module Providers
-    class Harvest
-      class << self
-        def command_names
-          constants.sort.map { |constant_name| Helpers.const_to_command(constant_name) }
-        end
-
-        def command_class(name)
-          const_name = Helpers.command_to_const(name)
-          const_get(const_name) if const_defined?(const_name)
-        end
-
-        def user_id
-          Abt::GitConfig.prompt_global(
-            'abt.harvest.userId',
-            'Please enter your harvest User ID',
-            'In harvest open "My profile". The ID is the number part of the URL you are taken to'
-          )
-        end
-
-        def access_token
-          Abt::GitConfig.prompt_global(
-            'abt.harvest.accessToken',
-            'Please enter your personal harvest access token',
-            'Create your personal access token here: https://id.getharvest.com/developers'
-          )
-        end
-
-        def account_id
-          Abt::GitConfig.prompt_global(
-            'abt.harvest.accountId',
-            'Please enter the harvest account id',
-            'This information is shown next to your generated access token'
-          )
-        end
-
-        def clear
-          Abt::GitConfig.unset_local('abt.harvest.projectId')
-          Abt::GitConfig.unset_local('abt.harvest.taskId')
-        end
-
-        def clear_global
-          Abt::GitConfig.unset_global('abt.harvest.userId')
-          Abt::GitConfig.unset_global('abt.harvest.accountId')
-          Abt::GitConfig.unset_global('abt.harvest.accessToken')
-        end
+    module Harvest
+      def self.command_names
+        Commands.constants.sort.map { |constant_name| Helpers.const_to_command(constant_name) }
+      end
 
-        def client
-          @client ||= Abt::HarvestClient.new(access_token: access_token, account_id: account_id)
-        end
+      def self.command_class(name)
+        const_name = Helpers.command_to_const(name)
+        Commands.const_get(const_name) if Commands.const_defined?(const_name)
       end
     end
   end

data/lib/abt/providers/harvest/api.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+module Abt
+  module Providers
+    module Harvest
+      class Api
+        API_ENDPOINT = 'https://api.harvestapp.com/v2'
+        VERBS = %i[get post patch].freeze
+
+        attr_reader :access_token, :account_id
+
+        def initialize(access_token:, account_id:)
+          @access_token = access_token
+          @account_id = account_id
+        end
+
+        VERBS.each do |verb|
+          define_method(verb) do |*args|
+            request(verb, *args)
+          end
+        end
+
+        def get_paged(path, query = {})
+          result_key = path.split('?').first.split('/').last
+
+          page = 1
+          records = []
+
+          loop do
+            result = get(path, query.merge(page: page))
+            records += result[result_key]
+            break if result['total_pages'] == page
+
+            page += 1
+          end
+
+          records
+        end
+
+        def request(*args)
+          response = connection.public_send(*args)
+
+          if response.success?
+            Oj.load(response.body)
+          else
+            error_class = Abt::HttpError.error_class_for_status(response.status)
+            encoded_response_body = response.body.force_encoding('utf-8')
+            raise error_class, "Code: #{response.status}, body: #{encoded_response_body}"
+          end
+        end
+
+        def connection
+          @connection ||= Faraday.new(API_ENDPOINT) do |connection|
+            connection.headers['Authorization'] = "Bearer #{access_token}"
+            connection.headers['Harvest-Account-Id'] = account_id
+            connection.headers['Content-Type'] = 'application/json'
+          end
+        end
+      end
+    end
+  end
+end