abt-cli 0.0.19 → 0.0.24

data/lib/abt/providers/asana/api.rb

@@ -4,8 +4,8 @@ module Abt
   module Providers
     module Asana
       class Api
-        API_ENDPOINT = 'https://app.asana.com/api/1.0'
-        VERBS = %i[get post put].freeze
+        API_ENDPOINT = "https://app.asana.com/api/1.0"
+        VERBS = [:get, :post, :put].freeze
 
         attr_reader :access_token
 
@@ -15,7 +15,7 @@ module Abt
 
         VERBS.each do |verb|
           define_method(verb) do |*args|
-            request(verb, *args)['data']
+            request(verb, *args)["data"]
           end
         end
 
@@ -24,10 +24,10 @@ module Abt
 
           loop do
             result = request(:get, path, query.merge(limit: 100))
-            records += result['data']
-            break if result['next_page'].nil?
+            records += result["data"]
+            break if result["next_page"].nil?
 
-            path = result['next_page']['path'][1..-1]
+            path = result["next_page"]["path"][1..-1]
           end
 
           records
@@ -40,15 +40,15 @@ module Abt
             Oj.load(response.body)
           else
             error_class = Abt::HttpError.error_class_for_status(response.status)
-            encoded_response_body = response.body.force_encoding('utf-8')
+            encoded_response_body = response.body.force_encoding("utf-8")
             raise error_class, "Code: #{response.status}, body: #{encoded_response_body}"
           end
         end
 
         def connection
           @connection ||= Faraday.new(API_ENDPOINT) do |connection|
-            connection.headers['Authorization'] = "Bearer #{access_token}"
-            connection.headers['Content-Type'] = 'application/json'
+            connection.headers["Authorization"] = "Bearer #{access_token}"
+            connection.headers["Content-Type"] = "application/json"
           end
         end
       end

data/lib/abt/providers/asana/base_command.rb

@@ -20,26 +20,28 @@ module Abt
 
         private
 
+        def require_local_config!
+          abort("Must be run inside a git repository") unless config.local_available?
+        end
+
         def require_project!
-          abort 'No current/specified project. Did you initialize Asana?' if project_gid.nil?
+          abort("No current/specified project. Did you initialize Asana?") if project_gid.nil?
         end
 
         def require_task!
-          if project_gid.nil?
-            abort 'No current/specified project. Did you initialize Asana and pick a task?'
-          end
-          abort 'No current/specified task. Did you pick an Asana task?' if task_gid.nil?
+          abort("No current/specified project. Did you initialize Asana and pick a task?") if project_gid.nil?
+          abort("No current/specified task. Did you pick an Asana task?") if task_gid.nil?
         end
 
         def print_project(project)
-          cli.print_ari('asana', project['gid'], project['name'])
-          warn project['permalink_url'] if project.key?('permalink_url') && cli.output.isatty
+          cli.print_ari("asana", project["gid"], project["name"])
+          warn(project["permalink_url"]) if project.key?("permalink_url") && cli.output.isatty
         end
 
         def print_task(project, task)
-          project = { 'gid' => project } if project.is_a?(String)
-          cli.print_ari('asana', "#{project['gid']}/#{task['gid']}", task['name'])
-          warn task['permalink_url'] if task.key?('permalink_url') && cli.output.isatty
+          project = { "gid" => project } if project.is_a?(String)
+          cli.print_ari("asana", "#{project['gid']}/#{task['gid']}", task["name"])
+          warn(task["permalink_url"]) if task.key?("permalink_url") && cli.output.isatty
         end
 
         def api

data/lib/abt/providers/asana/commands/add.rb

@@ -6,22 +6,22 @@ module Abt
       module Commands
         class Add < BaseCommand
           def self.usage
-            'abt add asana[:<project-gid>]'
+            "abt add asana[:<project-gid>]"
           end
 
           def self.description
-            'Create a new task for the current/specified Asana project'
+            "Create a new task for the current/specified Asana project"
           end
 
           def perform
             require_project!
 
             task
-            warn 'Task created'
+            warn("Task created")
 
             if section
               move_task
-              warn "Moved to section: #{section['name']}"
+              warn("Moved to section: #{section['name']}")
             end
 
             print_task(project, task)
@@ -38,36 +38,37 @@ module Abt
                   projects: [project_gid]
                 }
               }
-              api.post('tasks', Oj.dump(body, mode: :json))
+              api.post("tasks", Oj.dump(body, mode: :json))
             end
           end
 
           def move_task
-            body = { data: { task: task['gid'] } }
+            body = { data: { task: task["gid"] } }
             body_json = Oj.dump(body, mode: :json)
             api.post("sections/#{section['gid']}/addTask", body_json)
           end
 
           def name
-            @name ||= cli.prompt.text 'Enter task description'
+            @name ||= cli.prompt.text("Enter task description")
           end
 
           def notes
-            @notes ||= cli.prompt.text 'Enter task notes'
+            @notes ||= cli.prompt.text("Enter task notes")
           end
 
           def project
-            @project ||= api.get("projects/#{project_gid}", opt_fields: 'name')
+            @project ||= api.get("projects/#{project_gid}", opt_fields: "name")
           end
 
           def section
-            @section ||= cli.prompt.choice 'Add to section?', sections, ['q', 'Don\'t add to section']
+            @section ||= cli.prompt.choice("Add to section?", sections,
+                                           nil_option: ["q", "Don't add to section"])
           end
 
           def sections
             @sections ||= begin
-              warn 'Fetching sections...'
-              api.get_paged("projects/#{project_gid}/sections", opt_fields: 'name')
+              warn("Fetching sections...")
+              api.get_paged("projects/#{project_gid}/sections", opt_fields: "name")
             end
           end
         end

data/lib/abt/providers/asana/commands/branch_name.rb

@@ -6,11 +6,11 @@ module Abt
       module Commands
         class BranchName < BaseCommand
           def self.usage
-            'abt branch-name asana[:<project-gid>/<task-gid>]'
+            "abt branch-name asana[:<project-gid>/<task-gid>]"
           end
 
           def self.description
-            'Suggest a git branch name for the current/specified task.'
+            "Suggest a git branch name for the current/specified task."
           end
 
           def perform
@@ -23,21 +23,21 @@ module Abt
           private
 
           def name
-            task['name'].downcase.gsub(/[^\w]+/, '-')
+            task["name"].downcase.gsub(/[^\w]+/, "-").gsub(/(^-|-$)/, "")
           end
 
           def ensure_current_is_valid!
-            abort "Invalid task gid: #{task_gid}" if task.nil?
+            abort("Invalid task gid: #{task_gid}") if task.nil?
 
-            return if task['memberships'].any? { |m| m.dig('project', 'gid') == project_gid }
+            return if task["memberships"].any? { |m| m.dig("project", "gid") == project_gid }
 
-            abort "Invalid or unmatching project gid: #{project_gid}"
+            abort("Invalid or unmatching project gid: #{project_gid}")
           end
 
           def task
             @task ||= begin
-              warn 'Fetching task...'
-              api.get("tasks/#{task_gid}", opt_fields: 'name,memberships.project')
+              warn("Fetching task...")
+              api.get("tasks/#{task_gid}", opt_fields: "name,memberships.project")
             rescue Abt::HttpError::NotFoundError
               nil
             end

data/lib/abt/providers/asana/commands/clear.rb

@@ -6,29 +6,28 @@ module Abt
       module Commands
         class Clear < BaseCommand
           def self.usage
-            'abt clear asana'
+            "abt clear asana"
           end
 
           def self.description
-            'Clear asana configuration'
+            "Clear asana configuration"
           end
 
           def self.flags
             [
-              ['-g', '--global', 'Clear global instead of local asana configuration (credentials etc.)'],
-              ['-a', '--all', 'Clear all asana configuration']
+              ["-g", "--global",
+               "Clear global instead of local asana configuration (credentials etc.)"],
+              ["-a", "--all", "Clear all asana configuration"]
             ]
           end
 
           def perform
-            if flags[:global] && flags[:all]
-              abort('Flags --global and --all cannot be used at the same time')
-            end
+            abort("Flags --global and --all cannot be used at the same time") if flags[:global] && flags[:all]
 
             config.clear_local unless flags[:global]
             config.clear_global if flags[:global] || flags[:all]
 
-            warn 'Configuration cleared'
+            warn("Configuration cleared")
           end
         end
       end

data/lib/abt/providers/asana/commands/current.rb

@@ -6,22 +6,21 @@ module Abt
       module Commands
         class Current < BaseCommand
           def self.usage
-            'abt current asana[:<project-gid>[/<task-gid>]]'
+            "abt current asana[:<project-gid>[/<task-gid>]]"
           end
 
           def self.description
-            'Get or set project and or task for current git repository'
+            "Get or set project and or task for current git repository"
           end
 
           def perform
-            abort 'Must be run inside a git repository' unless config.local_available?
-
+            require_local_config!
             require_project!
             ensure_valid_configuration!
 
             if path != config.path
               config.path = path
-              warn 'Configuration updated'
+              warn("Configuration updated")
             end
 
             print_configuration
@@ -34,25 +33,25 @@ module Abt
           end
 
           def ensure_valid_configuration!
-            abort "Invalid project: #{project_gid}" if project.nil?
-            abort "Invalid task: #{task_gid}" if task_gid && task.nil?
+            abort("Invalid project: #{project_gid}") if project.nil?
+            abort("Invalid task: #{task_gid}") if task_gid && task.nil?
           end
 
           def project
             @project ||= begin
-              warn 'Fetching project...'
-              api.get("projects/#{project_gid}", opt_fields: 'name,permalink_url')
-                         rescue Abt::HttpError::NotFoundError
-                           nil
+              warn("Fetching project...")
+              api.get("projects/#{project_gid}", opt_fields: "name,permalink_url")
+            rescue Abt::HttpError::NotFoundError
+              nil
             end
           end
 
           def task
             @task ||= begin
-              warn 'Fetching task...'
-              api.get("tasks/#{task_gid}", opt_fields: 'name,permalink_url')
-                      rescue Abt::HttpError::NotFoundError
-                        nil
+              warn("Fetching task...")
+              api.get("tasks/#{task_gid}", opt_fields: "name,permalink_url")
+            rescue Abt::HttpError::NotFoundError
+              nil
             end
           end
         end

data/lib/abt/providers/asana/commands/finalize.rb

@@ -6,47 +6,49 @@ module Abt
       module Commands
         class Finalize < BaseCommand
           def self.usage
-            'abt finalize asana[:<project-gid>/<task-gid>]'
+            "abt finalize asana[:<project-gid>/<task-gid>]"
           end
 
           def self.description
-            'Move current/specified task to section (column) for finalized tasks'
+            "Move current/specified task to section (column) for finalized tasks"
           end
 
           def perform
-            unless config.local_available?
-              abort 'This is a no-op for tasks outside the current project'
-            end
+            abort("This is a no-op for tasks outside the current project") unless project_gid == config.path.project_gid
             require_task!
             print_task(project_gid, task)
 
+            maybe_move_task
+          end
+
+          private
+
+          def maybe_move_task
             if task_already_in_finalized_section?
-              warn "Task already in section: #{current_task_section['name']}"
+              warn("Task already in section: #{current_task_section['name']}")
             else
-              warn "Moving task to section: #{finalized_section['name']}"
+              warn("Moving task to section: #{finalized_section['name']}")
               move_task
             end
           end
 
-          private
-
           def task_already_in_finalized_section?
             !task_section_membership.nil?
           end
 
           def current_task_section
-            task_section_membership&.dig('section')
+            task_section_membership&.dig("section")
           end
 
           def task_section_membership
-            task['memberships'].find do |membership|
-              membership.dig('section', 'gid') == config.finalized_section_gid
+            task["memberships"].find do |membership|
+              membership.dig("section", "gid") == config.finalized_section_gid
             end
           end
 
           def finalized_section
             @finalized_section ||= api.get("sections/#{config.finalized_section_gid}",
-                                           opt_fields: 'name')
+                                           opt_fields: "name")
           end
 
           def move_task
@@ -57,11 +59,8 @@ module Abt
 
           def task
             @task ||= begin
-              if task_gid.nil?
-                nil
-              else
-                api.get("tasks/#{task_gid}", opt_fields: 'name,memberships.section.name,permalink_url')
-              end
+              api.get("tasks/#{task_gid}",
+                      opt_fields: "name,memberships.section.name,permalink_url")
             end
           end
         end

data/lib/abt/providers/asana/commands/harvest_time_entry_data.rb

@@ -6,45 +6,47 @@ module Abt
       module Commands
         class HarvestTimeEntryData < BaseCommand
           def self.usage
-            'abt harvest-time-entry-data asana[:<project-gid>/<task-gid>]'
+            "abt harvest-time-entry-data asana[:<project-gid>/<task-gid>]"
           end
 
           def self.description
-            'Print Harvest time entry data for Asana task as json. Used by harvest start script.'
+            "Print Harvest time entry data for Asana task as json. Used by harvest start script."
           end
 
           def perform
             require_task!
             ensure_current_is_valid!
 
-            body = {
-              notes: task['name'],
+            puts Oj.dump(body, mode: :json)
+          end
+
+          private
+
+          def body
+            {
+              notes: task["name"],
               external_reference: {
                 id: task_gid.to_i,
                 group_id: project_gid.to_i,
-                permalink: task['permalink_url']
+                permalink: task["permalink_url"]
               }
             }
-
-            puts Oj.dump(body, mode: :json)
           end
 
-          private
-
           def ensure_current_is_valid!
-            abort "Invalid task gid: #{task_gid}" if task.nil?
+            abort("Invalid task gid: #{task_gid}") if task.nil?
 
-            return if task['memberships'].any? { |m| m.dig('project', 'gid') == project_gid }
+            return if task["memberships"].any? { |m| m.dig("project", "gid") == project_gid }
 
-            abort "Invalid or unmatching project gid: #{project_gid}"
+            abort("Invalid or unmatching project gid: #{project_gid}")
           end
 
           def task
             @task ||= begin
-              warn 'Fetching task...'
-              api.get("tasks/#{task_gid}", opt_fields: 'name,permalink_url,memberships.project')
-                      rescue Abt::HttpError::NotFoundError
-                        nil
+              warn("Fetching task...")
+              api.get("tasks/#{task_gid}", opt_fields: "name,permalink_url,memberships.project")
+            rescue Abt::HttpError::NotFoundError
+              nil
             end
           end
         end