abt-cli 0.0.15 → 0.0.20

data/lib/abt/providers/asana/commands/current.rb

@@ -5,69 +5,54 @@ module Abt
     module Asana
       module Commands
         class Current < BaseCommand
-          def self.command
-            'current asana[:<project-gid>[/<task-gid>]]'
+          def self.usage
+            'abt current asana[:<project-gid>[/<task-gid>]]'
           end
 
           def self.description
             'Get or set project and or task for current git repository'
           end
 
-          def call
+          def perform
+            abort 'Must be run inside a git repository' unless config.local_available?
+
             require_project!
+            ensure_valid_configuration!
 
-            if same_args_as_config? || !config.local_available?
-              show_current_configuration
-            else
-              cli.warn 'Updating configuration'
-              update_configuration
+            if path != config.path
+              config.path = path
+              warn 'Configuration updated'
             end
-          end
 
-          private
-
-          def show_current_configuration
-            if task_gid.nil?
-              print_project(project)
-            else
-              print_task(project, task)
-            end
+            print_configuration
           end
 
-          def update_configuration
-            ensure_project_is_valid!
-            config.project_gid = project_gid
-
-            if task_gid.nil?
-              print_project(project)
-              config.task_gid = nil
-            else
-              ensure_task_is_valid!
-              config.task_gid = task_gid
-
-              print_task(project, task)
-            end
-          end
+          private
 
-          def ensure_project_is_valid!
-            cli.abort "Invalid project: #{project_gid}" if project.nil?
+          def print_configuration
+            task_gid.nil? ? print_project(project) : print_task(project, task)
           end
 
-          def ensure_task_is_valid!
-            cli.abort "Invalid task: #{task_gid}" if task.nil?
+          def ensure_valid_configuration!
+            abort "Invalid project: #{project_gid}" if project.nil?
+            abort "Invalid task: #{task_gid}" if task_gid && task.nil?
           end
 
           def project
             @project ||= begin
-              cli.warn 'Fetching project...'
+              warn 'Fetching project...'
               api.get("projects/#{project_gid}", opt_fields: 'name,permalink_url')
+                         rescue Abt::HttpError::NotFoundError
+                           nil
             end
           end
 
           def task
             @task ||= begin
-              cli.warn 'Fetching task...'
+              warn 'Fetching task...'
               api.get("tasks/#{task_gid}", opt_fields: 'name,permalink_url')
+                      rescue Abt::HttpError::NotFoundError
+                        nil
             end
           end
         end

data/lib/abt/providers/asana/commands/finalize.rb

@@ -5,25 +5,25 @@ module Abt
     module Asana
       module Commands
         class Finalize < BaseCommand
-          def self.command
-            'finalize asana[:<project-gid>/<task-gid>]'
+          def self.usage
+            'abt finalize asana[:<project-gid>/<task-gid>]'
           end
 
           def self.description
             'Move current/specified task to section (column) for finalized tasks'
           end
 
-          def call
-            unless config.local_available?
-              cli.abort 'This is a no-op for tasks outside the current project'
+          def perform
+            unless project_gid == config.path.project_gid
+              abort 'This is a no-op for tasks outside the current project'
             end
             require_task!
             print_task(project_gid, task)
 
             if task_already_in_finalized_section?
-              cli.warn "Task already in section: #{current_task_section['name']}"
+              warn "Task already in section: #{current_task_section['name']}"
             else
-              cli.warn "Moving task to section: #{finalized_section['name']}"
+              warn "Moving task to section: #{finalized_section['name']}"
               move_task
             end
           end
@@ -57,11 +57,7 @@ module Abt
 
           def task
             @task ||= begin
-              if task_gid.nil?
-                nil
-              else
-                api.get("tasks/#{task_gid}", opt_fields: 'name,memberships.section.name,permalink_url')
-              end
+              api.get("tasks/#{task_gid}", opt_fields: 'name,memberships.section.name,permalink_url')
             end
           end
         end

data/lib/abt/providers/asana/commands/harvest_time_entry_data.rb

@@ -5,15 +5,15 @@ module Abt
     module Asana
       module Commands
         class HarvestTimeEntryData < BaseCommand
-          def self.command
-            'harvest-time-entry-data asana[:<project-gid>/<task-gid>]'
+          def self.usage
+            'abt harvest-time-entry-data asana[:<project-gid>/<task-gid>]'
           end
 
           def self.description
             'Print Harvest time entry data for Asana task as json. Used by harvest start script.'
           end
 
-          def call
+          def perform
             require_task!
             ensure_current_is_valid!
 
@@ -26,21 +26,26 @@ module Abt
               }
             }
 
-            cli.puts Oj.dump(body, mode: :json)
+            puts Oj.dump(body, mode: :json)
           end
 
           private
 
           def ensure_current_is_valid!
-            cli.abort "Invalid task gid: #{task_gid}" if task.nil?
+            abort "Invalid task gid: #{task_gid}" if task.nil?
 
             return if task['memberships'].any? { |m| m.dig('project', 'gid') == project_gid }
 
-            cli.abort "Invalid project gid: #{project_gid}"
+            abort "Invalid or unmatching project gid: #{project_gid}"
           end
 
           def task
-            @task ||= api.get("tasks/#{task_gid}", opt_fields: 'name,permalink_url,memberships.project')
+            @task ||= begin
+              warn 'Fetching task...'
+              api.get("tasks/#{task_gid}", opt_fields: 'name,permalink_url,memberships.project')
+                      rescue Abt::HttpError::NotFoundError
+                        nil
+            end
           end
         end
       end

data/lib/abt/providers/asana/commands/init.rb

@@ -5,8 +5,8 @@ module Abt
     module Asana
       module Commands
         class Init < BaseCommand
-          def self.command
-            'init asana'
+          def self.usage
+            'abt init asana'
           end
 
           def self.description
@@ -18,13 +18,13 @@ module Abt
             @cli = cli
           end
 
-          def call
-            cli.abort 'Must be run inside a git repository' unless config.local_available?
+          def perform
+            abort 'Must be run inside a git repository' unless config.local_available?
 
             projects # Load projects up front to make it obvious that searches are instant
             project = find_search_result
 
-            config.project_gid = project['gid']
+            config.path = Path.from_ids(project['gid'])
 
             print_project(project)
           end
@@ -32,16 +32,16 @@ module Abt
           private
 
           def find_search_result
-            cli.warn 'Select a project'
+            warn 'Select a project'
 
             loop do
               matches = matches_for_string cli.prompt.text('Enter search')
               if matches.empty?
-                cli.warn 'No matches'
+                warn 'No matches'
                 next
               end
 
-              cli.warn 'Showing the 10 first matches' if matches.size > 10
+              warn 'Showing the 10 first matches' if matches.size > 10
               choice = cli.prompt.choice 'Select a project', matches[0...10], true
               break choice unless choice.nil?
             end
@@ -61,7 +61,7 @@ module Abt
 
           def projects
             @projects ||= begin
-              cli.warn 'Fetching projects...'
+              warn 'Fetching projects...'
               api.get_paged('projects',
                             workspace: config.workspace_gid,
                             archived: false,

data/lib/abt/providers/asana/commands/pick.rb

@@ -5,42 +5,49 @@ module Abt
     module Asana
       module Commands
         class Pick < BaseCommand
-          def self.command
-            'pick asana[:<project-gid>]'
+          def self.usage
+            'abt pick asana[:<project-gid>]'
           end
 
           def self.description
             'Pick task for current git repository'
           end
 
-          def call
-            cli.abort 'Must be run inside a git repository' unless config.local_available?
+          def self.flags
+            [
+              ['-d', '--dry-run', 'Keep existing configuration']
+            ]
+          end
+
+          def perform
+            abort 'Must be run inside a git repository' unless config.local_available?
             require_project!
 
-            cli.warn project['name']
+            warn project['name']
 
             task = select_task
 
-            config.project_gid = project_gid # We might have gotten the project ID as an argument
-            config.task_gid = task['gid']
-
             print_task(project, task)
+
+            return if flags[:"dry-run"]
+
+            config.path = Path.from_ids(project_gid, task['gid'])
           end
 
           private
 
           def project
-            @project ||= api.get("projects/#{project_gid}")
+            @project ||= api.get("projects/#{project_gid}", opt_fields: 'name')
           end
 
           def select_task
             loop do
               section = cli.prompt.choice 'Which section?', sections
-              cli.warn 'Fetching tasks...'
+              warn 'Fetching tasks...'
               tasks = tasks_in_section(section)
 
               if tasks.length.zero?
-                cli.warn 'Section is empty'
+                warn 'Section is empty'
                 next
               end
 
@@ -50,15 +57,21 @@ module Abt
           end
 
           def tasks_in_section(section)
-            api.get_paged('tasks', section: section['gid'], opt_fields: 'name,permalink_url')
+            tasks = api.get_paged(
+              'tasks',
+              section: section['gid'],
+              opt_fields: 'name,completed,permalink_url'
+            )
+
+            # The below filtering is the best we can do with Asanas api, see this:
+            # https://forum.asana.com/t/tasks-query-completed-since-is-broken-for-sections/21461
+            tasks.select { |task| !task['completed'] }
           end
 
           def sections
             @sections ||= begin
-              cli.warn 'Fetching sections...'
+              warn 'Fetching sections...'
               api.get_paged("projects/#{project_gid}/sections", opt_fields: 'name')
-                          rescue Abt::HttpError::HttpError
-                            []
             end
           end
         end

data/lib/abt/providers/asana/commands/projects.rb

@@ -5,15 +5,15 @@ module Abt
     module Asana
       module Commands
         class Projects < BaseCommand
-          def self.command
-            'projects asana'
+          def self.usage
+            'abt projects asana'
           end
 
           def self.description
             'List all available projects - useful for piping into grep etc.'
           end
 
-          def call
+          def perform
             projects.map do |project|
               print_project(project)
             end
@@ -23,7 +23,7 @@ module Abt
 
           def projects
             @projects ||= begin
-              cli.warn 'Fetching projects...'
+              warn 'Fetching projects...'
               api.get_paged(
                 'projects',
                 workspace: config.workspace_gid,

data/lib/abt/providers/asana/commands/share.rb

@@ -5,22 +5,18 @@ module Abt
     module Asana
       module Commands
         class Share < BaseCommand
-          def self.command
-            'share asana[:<project-gid>[/<task-gid>]]'
+          def self.usage
+            'abt share asana[:<project-gid>[/<task-gid>]]'
           end
 
           def self.description
-            'Print project/task config string'
+            'Print project/task ARI'
           end
 
-          def call
+          def perform
             require_project!
 
-            if task_gid.nil?
-              cli.print_provider_command('asana', project_gid)
-            else
-              cli.print_provider_command('asana', "#{project_gid}/#{task_gid}")
-            end
+            cli.print_ari('asana', path)
           end
         end
       end

data/lib/abt/providers/asana/commands/start.rb

@@ -5,58 +5,66 @@ module Abt
     module Asana
       module Commands
         class Start < BaseCommand
-          def self.command
-            'start asana[:<project-gid>/<task-gid>]'
+          def self.usage
+            'abt start asana[:<project-gid>/<task-gid>]'
           end
 
           def self.description
-            'Set current task and move it to a section (column) of your choice'
+            'Move current or specified task to WIP section (column) and assign it to you'
           end
 
-          def call
+          def self.flags
+            [
+              ['-s', '--set', 'Set specified task as current']
+            ]
+          end
+
+          def perform
             require_task!
 
-            maybe_override_current_task
+            print_task(project_gid, task)
 
             update_assignee_if_needed
             move_if_needed
+            maybe_override_current_task
           end
 
           private
 
           def maybe_override_current_task
-            return if arg_str.nil?
-            return if same_args_as_config?
+            return unless flags[:set]
+            return if path.nil?
+            return if path == config.path
             return unless config.local_available?
 
-            should_override = cli.prompt.boolean 'Set selected task as current?'
-            Current.new(arg_str: arg_str, cli: cli).call if should_override
+            config.path = path
+            warn 'Current task updated'
           end
 
           def update_assignee_if_needed
             current_assignee = task.dig('assignee')
 
             if current_assignee.nil?
-              cli.warn "Assigning task to user: #{current_user['name']}"
+              warn "Assigning task to user: #{current_user['name']}"
               update_assignee
             elsif current_assignee['gid'] == current_user['gid']
-              cli.warn 'You are already assigned to this task'
+              warn 'You are already assigned to this task'
             elsif cli.prompt.boolean "Task is assigned to: #{current_assignee['name']}, take over?"
-              cli.warn "Reassigning task to user: #{current_user['name']}"
+              warn "Reassigning task to user: #{current_user['name']}"
               update_assignee
             end
           end
 
           def move_if_needed
-            unless project_gid == config.project_gid
-              cli.warn 'Task was not moved, this is not implemented for tasks outside current project'
+            unless project_gid == config.path.project_gid
+              warn 'Task was not moved, this is not implemented for tasks outside current project'
               return
             end
 
             if task_already_in_wip_section?
-              cli.warn "Task already in section: #{current_task_section['name']}"
+              warn "Task already in section: #{current_task_section['name']}"
             else
-              cli.warn "Moving task to section: #{wip_section['name']}"
+              warn "Moving task to section: #{wip_section['name']}"
               move_task
             end
           end
@@ -76,7 +84,7 @@ module Abt
           end
 
           def wip_section
-            @wip_section ||= api.get("sections/#{config.wip_section_gid}")
+            @wip_section ||= api.get("sections/#{config.wip_section_gid}", opt_fields: 'name')
           end
 
           def move_task
@@ -96,7 +104,7 @@ module Abt
           end
 
           def task
-            @task ||= api.get("tasks/#{task_gid}", opt_fields: 'name,memberships.section.name,assignee.name')
+            @task ||= api.get("tasks/#{task_gid}", opt_fields: 'name,memberships.section.name,assignee.name,permalink_url')
           end
         end
       end