abstract_notifier 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5441072e0ded98cb24401c568df58e4917cb33211b04427b624498f1d622541
-  data.tar.gz: 5bde27d338590df550fd8cc74c8301a0c694510e6277e94c3f014a0e2033d16d
+  metadata.gz: 4f53c7d7582adccf56af7c488e41063cf5b344cbe198a548885d52b60f030772
+  data.tar.gz: d13d22f8e543f15c4bbf48bb29838746cdf0843430a1eb55e1c89cafa3c417da
 SHA512:
-  metadata.gz: e2c5d63ed5065c83bcb9bad41c8209cb2292d8703fedf326e7b44e4d03a7474758e3eae388283c5638c381584527652b34ccd9b584f5ecf7f6de056fd21402c9
-  data.tar.gz: ebc4e4e33bc64a77a9e01d31cf123f06d62337c8d88ad35264aee947153def02584766ca3ce3c8a1e7cc07f195ad573ef6632057dd6b7af8127c4d905ef30b16
+  metadata.gz: 462d22226d63a1c862f089f5a4b78cac6c457ca78160510b82588129c3d914a649daf4349945a989429202fde18ac87eff4ec3c42d670240eaa90959a5d7a010
+  data.tar.gz: 86f83533acc72205f77d7c83486e4cee9f9b59b5d6efe6ab6692dac18c3fbd58959c5d96b2537eaf5f7c9b95a9810297908ea0f6366cd8dec6cc2db2eed7f1cd

data/.rubocop.yml

@@ -16,6 +16,9 @@ AllCops:
 Standard/SemanticBlocks:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Enabled: true
+
 Style/TrailingCommaInArrayLiteral:
   EnforcedStyleForMultiline: no_comma
 

data/Gemfile

@@ -3,6 +3,7 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in abstract_notifier.gemspec
 gemspec
 
+gem "pry-byebug"
 gem "rspec-rails"
 
 local_gemfile = File.join(__dir__, "Gemfile.local")

data/README.md

@@ -157,7 +157,23 @@ expect { EventsNotifier.with(profile: profile).canceled(event).notify_later}.
 
 ## Related projects
 
-- [`active_delivery`](https://github.com/palkan/active_delivery) – next-level abstraction which allows to combine multiple notification channels in one place.
+### [`active_delivery`](https://github.com/palkan/active_delivery)
+
+Active Delivery is the next-level abstraction which allows to combine multiple notification channels in one place.
+
+Abstract Notifier provides a _notifier_ line for Active Delivery:
+
+```ruby
+class ApplicationDelivery < ActiveDelivery::Base
+  # Add notifier line to you delivery
+  register_line :notifier, ActiveDelivery::Lines::Notifier,
+                # you may provide a resolver, which infers notifier class
+                # from delivery name (resolver is a callable).
+                rsolver: ->(name) { resolve_somehow(name) }
+end
+```
+
+**NOTE:** we automatically add `:notifier` line with `"*Delivery" -> *Notifier` resolution mechanism if `#safe_constantize` method is defined for String, i.e. you don't have to configure the default notifier line when running Rails.
 
 ## Contributing
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "rubocop/rake_task"

data/abstract_notifier.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "abstract_notifier/version"
@@ -16,6 +18,8 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ["lib"]
 
+  spec.add_development_dependency "active_delivery"
+
   spec.add_development_dependency "bundler", "~> 1.16"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"

data/gemfiles/rails42.gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gem "rails", "~> 4.2"

data/gemfiles/railsmaster.gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gem "rails", github: "rails/rails"

data/lib/abstract_notifier.rb

@@ -72,3 +72,7 @@ require "abstract_notifier/async_adapters"
 require "abstract_notifier/async_adapters/active_job" if defined?(ActiveJob)
 
 require "abstract_notifier/testing" if ENV["RACK_ENV"] == "test" || ENV["RAILS_ENV"] == "test"
+
+if defined?(ActiveDelivery::Base) && defined?(ActiveDelivery::Lines::Base)
+  require "active_delivery/lines/notifier"
+end

data/lib/abstract_notifier/testing/rspec.rb

@@ -4,7 +4,7 @@ module AbstractNotifier
   class HaveSentNotification < RSpec::Matchers::BuiltIn::BaseMatcher
     attr_reader :payload
 
-    def initialize(payload)
+    def initialize(payload = nil)
       @payload = payload
       set_expected_number(:exactly, 1)
     end
@@ -55,7 +55,7 @@ module AbstractNotifier
 
       @matching_deliveries, @unmatching_deliveries =
         in_block_deliveries.partition do |actual_payload|
-          payload === actual_payload
+          payload.nil? || (payload === actual_payload)
         end
 
       @matching_count = @matching_deliveries.size

data/lib/abstract_notifier/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractNotifier
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/active_delivery/lines/notifier.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module ActiveDelivery
+  module Lines
+    # AbstractNotifier line for Active Delivery.
+    #
+    # You must provide custom `resolver` to infer notifier class
+    # (if String#safe_constantize is defined, we convert "*Delivery" -> "*Notifier").
+    #
+    # Resolver is a callable object.
+    class Notifier < ActiveDelivery::Lines::Base
+      DEFAULT_RESOLVER = ->(name) { name.gsub(/Delivery$/, "Notifier").safe_constantize }
+
+      def initialize(*)
+        super
+        @resolver = options[:resolver]
+      end
+
+      def resolve_class(name)
+        resolver&.call(name)
+      end
+
+      def notify?(method_name)
+        handler_class.action_methods.include?(method_name.to_s)
+      end
+
+      def notify_now(handler, mid, *args)
+        handler.public_send(mid, *args).notify_now
+      end
+
+      def notify_later(handler, mid, *args)
+        handler.public_send(mid, *args).notify_later
+      end
+
+      private
+
+      attr_reader :resolver
+    end
+
+    # Only automatically register line when we can resolve the class
+    # easily.
+    if "".respond_to?(:safe_constantize)
+      ActiveDelivery::Base.register_line :notifier, Notifier, resolver: Notifier::DEFAULT_RESOLVER
+    end
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: abstract_notifier
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-20 00:00:00.000000000 Z
+date: 2018-12-21 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: active_delivery
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -93,6 +107,7 @@ files:
 - lib/abstract_notifier/testing.rb
 - lib/abstract_notifier/testing/rspec.rb
 - lib/abstract_notifier/version.rb
+- lib/active_delivery/lines/notifier.rb
 homepage: https://github.com/palkan/abstract_notifier
 licenses:
 - MIT