abstract_importer 1.3.4 → 1.4.0

data/test/support/mock_objects.rb

@@ -41,8 +41,14 @@ end
 
 class Cat < ActiveRecord::Base
   has_one :student, as: :pet
+  has_many :abilities, as: :pet, inverse_of: :pet
 end
 
 class Owl < ActiveRecord::Base
   has_one :student, as: :pet
+  has_many :abilities, as: :pet, inverse_of: :pet
+end
+
+class Ability < ActiveRecord::Base
+  belongs_to :pet, inverse_of: :abilities, polymorphic: true
 end

data/test/support/schema.rb

@@ -11,6 +11,7 @@ ActiveRecord::Schema.define(:version => 1) do
     t.string   "pet_type"
     t.integer  "pet_id"
     t.index    "name", :unique => true
+    t.index    "legacy_id", :unique => true
   end
 
   create_table "parents", :force => true do |t|
@@ -18,12 +19,14 @@ ActiveRecord::Schema.define(:version => 1) do
     t.integer  "student_id"
     t.integer  "legacy_id"
     t.string   "name"
+    t.index    "legacy_id", :unique => true
   end
 
   create_table "locations", :force => true do |t|
     t.integer  "account_id"
     t.integer  "legacy_id"
     t.string   "slug"
+    t.index    "legacy_id", :unique => true
   end
 
   create_table "students_subjects", :force => true do |t|
@@ -35,6 +38,7 @@ ActiveRecord::Schema.define(:version => 1) do
     t.integer  "account_id"
     t.integer  "legacy_id"
     t.string   "name"
+    t.index    "legacy_id", :unique => true
   end
 
   create_table "grades", :force => true do |t|
@@ -43,18 +47,29 @@ ActiveRecord::Schema.define(:version => 1) do
     t.integer  "student_id"
     t.integer  "legacy_id"
     t.string   "value"
+    t.index    "legacy_id", :unique => true
   end
 
   create_table "owls", :force => true do |t|
     t.integer  "account_id"
     t.integer  "legacy_id"
     t.string   "name"
+    t.index    "legacy_id", :unique => true
   end
 
   create_table "cats", :force => true do |t|
     t.integer  "account_id"
     t.integer  "legacy_id"
     t.string   "name"
+    t.index    "legacy_id", :unique => true
+  end
+
+  create_table "abilities", :force => true do |t|
+    t.string   "pet_type"
+    t.integer  "pet_id"
+    t.integer  "legacy_id"
+    t.string   "name"
+    t.index    "legacy_id", :unique => true
   end
 
 end

data/test/test_helper.rb

@@ -5,9 +5,9 @@ SimpleCov.start do
   add_filter "test/"
 end
 
-require "rails"
-require "rails/test_help"
-require "turn"
+require "minitest/reporters/turn_reporter"
+MiniTest::Reporters.use! Minitest::Reporters::TurnReporter.new
+
 require "pry"
 require "rr"
 require "database_cleaner"
@@ -16,13 +16,17 @@ require "shoulda/context"
 require "active_record"
 require "support/mock_data_source"
 require "support/mock_objects"
+require "minitest/autorun"
+
 
 
+system "psql -c 'create database abstract_importer_test'"
 
 ActiveRecord::Base.establish_connection(
-  :adapter => "sqlite3",
-  :database => ":memory:",
-  :verbosity => "quiet")
+  adapter: "postgresql",
+  host: "localhost",
+  database: "abstract_importer_test",
+  verbosity: "quiet")
 
 load File.join(File.dirname(__FILE__), "support", "schema.rb")
 

data/test/upsert_strategy_test.rb

@@ -0,0 +1,92 @@
+require "test_helper"
+
+
+class UpsertStrategyTest < ActiveSupport::TestCase
+
+  setup do
+    options.merge!(strategy: {students: :upsert})
+  end
+
+
+
+  context "with a simple data source" do
+    setup do
+      plan do |import|
+        import.students
+      end
+    end
+
+    should "import the records in batches" do
+      mock.proxy(Student).insert_many(satisfy { |arg| arg.length == 3 }, anything)
+      import!
+      assert_equal [456, 457, 458], account.students.pluck(:legacy_id)
+    end
+
+    should "report that it found 3 records" do
+      summary = import!
+      assert_equal 3, summary[:students].total
+    end
+
+    should "report that it created 3 records" do
+      summary = import!
+      assert_equal 3, summary[:students].created
+    end
+  end
+
+  context "with a complex data source" do
+    setup do
+      plan do |import|
+        import.students
+        import.parents
+      end
+    end
+
+    should "preserve mappings" do
+      import!
+      harry = account.students.find_by_name("Harry Potter")
+      assert_equal ["James Potter", "Lily Potter"], harry.parents.pluck(:name)
+    end
+
+    should "preserve mappings even when a record was previously imported" do
+      harry = account.students.create!(name: "Harry Potter", legacy_id: 456)
+      import!
+      assert_equal ["James Potter", "Lily Potter"], harry.parents.pluck(:name)
+    end
+  end
+
+  context "When records already exist" do
+    setup do
+      plan do |import|
+        import.students
+      end
+      account.students.create!(name: "Ronaldo Weasley", legacy_id: 457)
+    end
+
+    should "not import existing records twice" do
+      import!
+      assert_equal 3, account.students.count
+    end
+
+    should "update the existing record" do
+      import!
+      assert_equal ["Ron Weasley"], account.students.where(legacy_id: 457).pluck(:name)
+    end
+  end
+
+  context "When the imported records belong to a parent polymorphically" do
+    setup do
+      @account = Owl.create!(name: "Pigwidgeon")
+      plan do |import|
+        import.abilities
+      end
+    end
+
+    should "import records just fine" do
+      pet = @account
+      import!
+      assert_equal [["Owl", pet.id]], Ability.pluck(:pet_type, :pet_id)
+    end
+  end
+
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: abstract_importer
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.4.0
 platform: ruby
 authors:
 - Bob Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-23 00:00:00.000000000 Z
+date: 2016-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,28 +16,56 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: activerecord-insert_many
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.4.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.4.0
+- !ruby/object:Gem::Dependency
+  name: progressbar
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -53,21 +81,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest-reporters-turn_reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: turn
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -220,21 +248,25 @@ files:
 - lib/abstract_importer/reporters/dot_reporter.rb
 - lib/abstract_importer/reporters/null_reporter.rb
 - lib/abstract_importer/reporters/performance_reporter.rb
+- lib/abstract_importer/reporters/progress_reporter.rb
 - lib/abstract_importer/strategies.rb
 - lib/abstract_importer/strategies/base.rb
 - lib/abstract_importer/strategies/default_strategy.rb
 - lib/abstract_importer/strategies/insert_strategy.rb
 - lib/abstract_importer/strategies/replace_strategy.rb
+- lib/abstract_importer/strategies/upsert_strategy.rb
 - lib/abstract_importer/summary.rb
 - lib/abstract_importer/version.rb
 - test/callback_test.rb
 - test/default_strategy_test.rb
+- test/id_map_test.rb
 - test/insert_strategy_test.rb
 - test/replace_strategy_test.rb
 - test/support/mock_data_source.rb
 - test/support/mock_objects.rb
 - test/support/schema.rb
 - test/test_helper.rb
+- test/upsert_strategy_test.rb
 homepage: https://github.com/concordia-publishing-house/abstract_importer
 licenses:
 - MIT
@@ -255,16 +287,18 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Provides services for the mass-import of complex relational data
 test_files:
 - test/callback_test.rb
 - test/default_strategy_test.rb
+- test/id_map_test.rb
 - test/insert_strategy_test.rb
 - test/replace_strategy_test.rb
 - test/support/mock_data_source.rb
 - test/support/mock_objects.rb
 - test/support/schema.rb
 - test/test_helper.rb
+- test/upsert_strategy_test.rb