abstract_importer 1.2.1 → 1.3.0

data/test/insert_strategy_test.rb

@@ -0,0 +1,82 @@
+require "test_helper"
+
+
+class ImporterTest < ActiveSupport::TestCase
+
+  setup do
+    options.merge!(strategy: {students: :insert})
+  end
+
+
+
+  context "with a simple data source" do
+    setup do
+      plan do |import|
+        import.students
+      end
+    end
+
+    should "import the records in batches" do
+      mock.proxy(Student).insert_many(satisfy { |arg| arg.length == 3 })
+      import!
+      assert_equal [456, 457, 458], account.students.pluck(:legacy_id)
+    end
+  end
+
+  context "with a complex data source" do
+    setup do
+      plan do |import|
+        import.students
+        import.parents
+      end
+    end
+
+    should "preserve mappings" do
+      import!
+      harry = account.students.find_by_name("Harry Potter")
+      assert_equal ["James Potter", "Lily Potter"], harry.parents.pluck(:name)
+    end
+
+    should "preserve mappings even when a record was previously imported" do
+      harry = account.students.create!(name: "Harry Potter", legacy_id: 456)
+      import!
+      assert_equal ["James Potter", "Lily Potter"], harry.parents.pluck(:name)
+    end
+  end
+
+  context "When records already exist" do
+    setup do
+      plan do |import|
+        import.students
+      end
+      account.students.create!(name: "Ron Weasley", legacy_id: 457)
+    end
+
+    should "not import existing records twice" do
+      import!
+      assert_equal 3, account.students.count
+    end
+  end
+
+  context "When the import would create a duplicate record" do
+    setup do
+      plan do |import|
+        import.students do |options|
+          options.rescue_batch do |batch|
+            names = parent.students.pluck :name
+            batch.reject! { |student| names.member? student[:name] }
+          end
+        end
+      end
+      account.students.create!(name: "Ron Weasley")
+    end
+
+    should "not import existing records twice" do
+      import!
+      assert_equal 3, account.students.count
+    end
+  end
+
+
+
+end

data/test/replace_strategy_test.rb

@@ -0,0 +1,29 @@
+require "test_helper"
+
+
+class ReplaceStrategyTest < ActiveSupport::TestCase
+
+  setup do
+    options.merge!(strategy: {students: :replace})
+  end
+
+
+
+  context "When records already exist" do
+    setup do
+      plan do |import|
+        import.students
+      end
+      account.students.create!(name: "Ron Weasley", legacy_id: 457)
+    end
+
+    should "reimport the existing records" do
+      import!
+      assert_equal "Gryffindor", account.students.find_by_name("Ron Weasley").house,
+        "Expected Ron's record to have been replaced with one that has a house"
+    end
+  end
+
+
+
+end

data/test/support/mock_data_source.rb

@@ -1,6 +1,6 @@
 class MockDataSource
-  
-  
+
+
   def students
     Enumerator.new do |e|
       e.yield id: 456, name: "Harry Potter", pet_type: "Owl", pet_id: 901, house: "Gryffindor"
@@ -8,21 +8,21 @@ class MockDataSource
       e.yield id: 458, name: "Hermione Granger", pet_type: "Cat", pet_id: 901, house: "Gryffindor"
     end
   end
-  
+
   def parents
     Enumerator.new do |e|
       e.yield id: 88, name: "James Potter", student_id: 456
       e.yield id: 89, name: "Lily Potter", student_id: 456
     end
   end
-  
+
   def locations
     Enumerator.new do |e|
       e.yield id: 5, slug: "godric's-hollow" # <-- invalid
       e.yield id: 6, slug: "azkaban"
     end
   end
-  
+
   def subjects
     Enumerator.new do |e|
       e.yield id: 49, name: "Care of Magical Creatures", student_ids: [456]
@@ -32,25 +32,25 @@ class MockDataSource
       e.yield id: 53, name: "Study of Ancient Runes", student_ids: [458]
     end
   end
-  
+
   def grades
     Enumerator.new do |e|
       e.yield id: 500, subject_id: 50, student_id: 457, value: "Acceptable"
       e.yield id: 501, subject_id: 51, student_id: 457, value: "Troll"
     end
   end
-  
+
   def cats
     Enumerator.new do |e|
       e.yield id: 901, name: "Crookshanks"
     end
   end
-  
+
   def owls
     Enumerator.new do |e|
       e.yield id: 901, name: "Hedwig"
     end
   end
-  
-  
+
+
 end

data/test/support/mock_objects.rb

@@ -3,7 +3,7 @@ class Student < ActiveRecord::Base
   has_many :grades
   has_many :parents
   belongs_to :pet, polymorphic: true
-  
+
   def report_card
     subjects.map do |subject|
       grade = grades.find_by_subject_id(subject.id)

data/test/support/schema.rb

@@ -1,8 +1,8 @@
 ActiveRecord::Schema.define(:version => 1) do
-  
+
   create_table "accounts", :force => true do |t|
   end
-  
+
   create_table "students", :force => true do |t|
     t.integer  "account_id"
     t.integer  "legacy_id"
@@ -10,26 +10,27 @@ ActiveRecord::Schema.define(:version => 1) do
     t.string   "house"
     t.string   "pet_type"
     t.integer  "pet_id"
+    t.index    "name", :unique => true
   end
-  
+
   create_table "parents", :force => true do |t|
     t.integer  "account_id"
     t.integer  "student_id"
     t.integer  "legacy_id"
     t.string   "name"
   end
-  
+
   create_table "locations", :force => true do |t|
     t.integer  "account_id"
     t.integer  "legacy_id"
     t.string   "slug"
   end
-  
+
   create_table "students_subjects", :force => true do |t|
     t.integer  "student_id"
     t.integer  "subject_id"
   end
-  
+
   create_table "subjects", :force => true do |t|
     t.integer  "account_id"
     t.integer  "legacy_id"

data/test/test_helper.rb

@@ -34,39 +34,39 @@ $io = ENV['VERBOSE'] ? $stderr : File.open("/dev/null", "w")
 
 
 class ActiveSupport::TestCase
-  
+
   setup do
     DatabaseCleaner.start
-    
+
     @data_source = MockDataSource.new
     @klass = Class.new(AbstractImporter::Base)
     @account = Account.create!
     @options = {}
   end
-  
+
   teardown do
     DatabaseCleaner.clean
     @importer = nil
   end
-  
+
 protected
-  
+
   attr_reader :account, :results, :data_source, :options
-  
+
   def plan(&block)
     @klass.import(&block)
   end
-  
+
   def depends_on(*args)
     @klass.depends_on(*args)
   end
-  
+
   def import!
     @results = importer.perform!
   end
-  
+
   def importer
     @importer ||= @klass.new(@account, @data_source, options.merge(io: $io))
   end
-  
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: abstract_importer
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Bob Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-29 00:00:00.000000000 Z
+date: 2015-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: activerecord-insert_many
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -186,6 +200,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".ruby-version"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -207,11 +222,14 @@ files:
 - lib/abstract_importer/strategies.rb
 - lib/abstract_importer/strategies/base.rb
 - lib/abstract_importer/strategies/default_strategy.rb
+- lib/abstract_importer/strategies/insert_strategy.rb
 - lib/abstract_importer/strategies/replace_strategy.rb
 - lib/abstract_importer/summary.rb
 - lib/abstract_importer/version.rb
 - test/callback_test.rb
-- test/importer_test.rb
+- test/default_strategy_test.rb
+- test/insert_strategy_test.rb
+- test/replace_strategy_test.rb
 - test/support/mock_data_source.rb
 - test/support/mock_objects.rb
 - test/support/schema.rb
@@ -236,13 +254,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Provides services for the mass-import of complex relational data
 test_files:
 - test/callback_test.rb
-- test/importer_test.rb
+- test/default_strategy_test.rb
+- test/insert_strategy_test.rb
+- test/replace_strategy_test.rb
 - test/support/mock_data_source.rb
 - test/support/mock_objects.rb
 - test/support/schema.rb