abstract_command 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c36ad254ea1fcfe9f031d3f32e2d1f394c9c8b604b6acc4fe800ee56f5bac43c
-  data.tar.gz: b0ff9b75a15365439c8a2705aa26decab42689ba1325fa47aa8d81f3d8689b2e
+  metadata.gz: d7d962f4d270e21692dc110cd7b1ad2fef5b53be412a3c647f480747ba5f78e0
+  data.tar.gz: 610073595394448b95394c5f778bc7768afe88c19040aa9b45169cb3a49ef462
 SHA512:
-  metadata.gz: aec380b77cb3d78b722a2bc8e894af21c3eb5ea1924302df029071af709f277466ffbb51fe5b90835b2e46c4a63d7c8acaccd348cd1e59be281215747f2fc674
-  data.tar.gz: 2fd99ae104f6116967103e53c826b70b76376541c57c623a085049419f9867fabad317613cce4e064e98c1087c82c85dca27a1cc32199412b79eace47173a88b
+  metadata.gz: 48d1dc40f33242eb194071aab72619ada6a4b2422308e856076e0a1f0e0cce024d2aa254124fe0ebc4518043cb14997be0d9ad400672cb23542669c61a3f0235
+  data.tar.gz: ad6414be1b6f4aad84282b6f75293eac55d7e07c268dde7edc57481ec8a996c5d3aa0c694127f34f10bcecb0ad0e16e7c3035077c348477a7bb87f8318b4165e

data/lib/abstract_command.rb

@@ -1,19 +1,28 @@
 require 'open3'
 require 'shellwords'
+require './lib/formatter.rb'
 
 # Shell Command Abstraction.
 #
 # Hides away all the details to generate a command.
-# And privides an easy interface to interact with shell commands as if
+# And provides an easy interface to interact with shell commands as if
 # they were objects.
 #
 # This is good for the following reasons:
 #
-# 1. Stadardization.
-# 2. Simplicity of code.
-# 3. Reduces smells in methods that interpolate values.
-# 4. Provides an elegant way to interact shell objects.
-# 5. Secure ensures that shell commands are executed safely.
+# - Enforces standardization.
+# - Enforces separation of command definition and consumption.
+# - Enforces configuration over code.
+# - Enforces configuration over refactoring.
+# - Enforces simple shell-command definition.
+# - Enforces automatic sanitization of variables that get interpolated.
+# - Provides a simple Object Oriented Interface.
+# - Provides a scope for variables that belong to the command.
+# - Provides getters and setter for every interpolation in command.
+# - Provides a neat interface that plugs to data structures transparently.
+# - Avoids methods with many arguments.
+# - Avoids changes in the standared libarary: system, backtick, etc.
+#
 class AbstractCommand
 
   # '%<name>s'.scan(/(%<)(\w+)(>)/)
@@ -48,7 +57,15 @@ class AbstractCommand
       value = instance_variable_get("@#{variable}")
       bindings[variable.to_sym] = "#{value}".shellescape
     end
-    format(template % bindings)
+    format(template, bindings)
+  end
+
+  def format(template, bindings)
+    if RUBY_VERSION <= '1.9.1'
+      Formatter.format(template, bindings)
+    else
+      super(template, bindings)
+    end
   end
 
   def system

data/lib/formatter.rb

@@ -0,0 +1,17 @@
+
+# before ruby 1.9.1 the format method does not support
+# the syntax we want, so we have a simplified version of
+# format for older versions of ruby.
+# its placed in the AbstractCommand class because we want
+# to avoid possible collisions for people requiring our code.
+# It can live on a better place though..
+class AbstractCommand
+  class Formatter
+    REGEXP = /(%<)(\S+)(>\w)/
+    def self.format(template, params)
+      template.gsub(REGEXP) do
+        params[$2.to_sym]
+      end
+    end
+  end
+end

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: abstract_command
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - Kazuyoshi Tlacaelel
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
 date: 2018-10-22 00:00:00.000000000 Z
@@ -17,11 +17,12 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/abstract_command.rb
+- lib/formatter.rb
 homepage: http://rubygems.org/gems/abstract_command
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -36,9 +37,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Shell Command Abstraction
 test_files: []