absolutize 0.0.5 → 0.0.6

data/README.textile

@@ -1,5 +1,5 @@
 
-h1. Absolutize v0.0.5
+h1. Absolutize v0.0.6
 
 h2. Intro 
 

data/lib/absolutize.rb

@@ -8,9 +8,9 @@ class Absolutize
     @base_url = base_url
     @options = options
     
-    @options[:remove_anchors] = false
-    @options[:force_escaping] = true
-    @options[:output_debug] = false
+    @options[:remove_anchors] = false if @options[:remove_anchors].nil? 
+    @options[:force_escaping] = true if @options[:force_escaping].nil?
+    @options[:output_debug] = false if @options[:output_debug].nil?
   end
   
   def url(relative_url)

data/lib/absolutize.rb~

@@ -8,9 +8,9 @@ class Absolutize
     @base_url = base_url
     @options = options
     
-    @options[:remove_anchors] = false
-    @options[:force_escaping] = true
-    @options[:output_debug] = false
+    @options[:remove_anchors] = false if @options[:remove_anchors].nil? 
+    @options[:force_escaping] = true if @options[:force_escaping].nil?
+    @options[:output_debug] = false if @options[:output_debug].nil?
   end
   
   def url(relative_url)

data/spec/absolutize/absolutize_spec.rb

@@ -3,36 +3,59 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 describe Absolutize do
 
   before(:each) do
-    @base_url = "http://www.baseurl.com/" 
-    @absolutize = Absolutize.new(@base_url)
+    @base_url = "http://www.baseurl.com/"   
   end
 
-  it "should create an Absolutize object" do
-    @absolutize.should be_an_instance_of Absolutize
-  end
+  describe "with default parameters" do
+    before(:each) do
+      @absolutize = Absolutize.new(@base_url)
+    end
   
-  it "should return the same url for an absolute url" do
-    @absolutize.url("http://www.bbc.co.uk/").to_s.should == "http://www.bbc.co.uk/" 
-  end
-  it "should return the same url for an absolute url" do
-    @absolutize.url("http://www.bbc.co.uk//asdf/asdf.html").to_s.should == "http://www.bbc.co.uk/asdf/asdf.html" 
-  end
-  it "should return the absolute url for a relative to root url" do
-    @absolutize.url("/asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
-  end
-  it "should return the absolute url for a relative to folder url" do
-    @absolutize.url("asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
-  end  
-  it "should handle urls with spaces" do
-    @absolutize.url("/root folder/asdf.html").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html"     
+    it "should create an Absolutize object" do
+      @absolutize.should be_an_instance_of Absolutize
+    end
+    
+    it "should return the same url for an absolute url" do
+      @absolutize.url("http://www.bbc.co.uk/").to_s.should == "http://www.bbc.co.uk/" 
+    end
+    it "should return the same url for an absolute url" do
+      @absolutize.url("http://www.bbc.co.uk//asdf/asdf.html").to_s.should == "http://www.bbc.co.uk/asdf/asdf.html" 
+    end
+    it "should return the absolute url for a relative to root url" do
+      @absolutize.url("/asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
+    end
+    it "should return the absolute url for a relative to folder url" do
+      @absolutize.url("asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
+    end  
+    it "should handle urls with spaces" do
+      @absolutize.url("/root folder/asdf.html").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html"     
+    end
+    it "should handle urls with ['s" do
+      @absolutize.url("/folder/asdf.html?id=[asdf]").to_s.should == "http://www.baseurl.com/folder/asdf.html?id=%5Basdf%5D"         
+    end
+    it "should not encode urls with %'s" do
+      @absolutize.url("/root%20folder/asdf.html?id=asdf").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html?id=asdf"         
+    end
+    it "should not encode existing encoded characters" do
+      @absolutize.url("/root%20folder/asdf.html?id=[asdf]").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html?id=%5Basdf%5D"         
+    end
   end
-  it "should handle urls with ['s" do
-    @absolutize.url("/folder/asdf.html?id=[asdf]").to_s.should == "http://www.baseurl.com/folder/asdf.html?id=%5Basdf%5D"         
-  end
-  it "should not encode urls with %'s" do
-    @absolutize.url("/root%20folder/asdf.html?id=asdf").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html?id=asdf"         
+  
+  describe "with remove_anchors true" do
+    before(:each) do 
+      @absolutize = Absolutize.new(@base_url, :remove_anchors => true)
+    end
+    it "should remove an anchor" do
+      @absolutize.url("/root folder/asdf.html#anchor").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html"     
+    end
   end
-  it "should not encode existing encoded characters" do
-    @absolutize.url("/root%20folder/asdf.html?id=[asdf]").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html?id=%5Basdf%5D"         
+  
+  describe "with force_escaping false" do
+    before(:each) do
+      @absolutize = Absolutize.new(@base_url, :force_escaping => false)
+    end
+    it "should not escape invalid characters" do
+      lambda { @absolutize.url("/root folder/asdf.html#anchor")}.should raise_error     
+    end
   end
 end 

data/spec/absolutize/absolutize_spec.rb~

@@ -3,34 +3,59 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 describe Absolutize do
 
   before(:each) do
-    @base_url = "http://www.baseurl.com/" 
-    @absolutize = Absolutize.new(@base_url)
+    @base_url = "http://www.baseurl.com/"   
   end
 
-  it "should create an Absolutize object" do
-    @absolutize.should be_an_instance_of Absolutize
-  end
+  describe "with default parameters" do
+    before(:each) do
+      @absolutize = Absolutize.new(@base_url)
+    end
   
-  it "should return the same url for an absolute url" do
-    @absolutize.url("http://www.bbc.co.uk/").to_s.should == "http://www.bbc.co.uk/" 
-  end
-  it "should return the same url for an absolute url" do
-    @absolutize.url("http://www.bbc.co.uk//asdf/asdf.html").to_s.should == "http://www.bbc.co.uk/asdf/asdf.html" 
-  end
-  it "should return the absolute url for a relative to root url" do
-    @absolutize.url("/asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
-  end
-  it "should return the absolute url for a relative to folder url" do
-    @absolutize.url("asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
-  end  
-  it "should handle urls with spaces" do
-    @absolutize.url("/root folder/asdf.html").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html"     
+    it "should create an Absolutize object" do
+      @absolutize.should be_an_instance_of Absolutize
+    end
+    
+    it "should return the same url for an absolute url" do
+      @absolutize.url("http://www.bbc.co.uk/").to_s.should == "http://www.bbc.co.uk/" 
+    end
+    it "should return the same url for an absolute url" do
+      @absolutize.url("http://www.bbc.co.uk//asdf/asdf.html").to_s.should == "http://www.bbc.co.uk/asdf/asdf.html" 
+    end
+    it "should return the absolute url for a relative to root url" do
+      @absolutize.url("/asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
+    end
+    it "should return the absolute url for a relative to folder url" do
+      @absolutize.url("asdf.html").to_s.should == "http://www.baseurl.com/asdf.html" 
+    end  
+    it "should handle urls with spaces" do
+      @absolutize.url("/root folder/asdf.html").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html"     
+    end
+    it "should handle urls with ['s" do
+      @absolutize.url("/folder/asdf.html?id=[asdf]").to_s.should == "http://www.baseurl.com/folder/asdf.html?id=%5Basdf%5D"         
+    end
+    it "should not encode urls with %'s" do
+      @absolutize.url("/root%20folder/asdf.html?id=asdf").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html?id=asdf"         
+    end
+    it "should not encode existing encoded characters" do
+      @absolutize.url("/root%20folder/asdf.html?id=[asdf]").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html?id=%5Basdf%5D"         
+    end
   end
-  it "should handle urls with ['s" do
-    @absolutize.url("/folder/asdf.html?id=[asdf]").to_s.should == "http://www.baseurl.com/folder/asdf.html?id=%5Basdf%5D"         
+  
+  describe "with remove_anchors true" do
+    before(:each) do 
+      @absolutize = Absolutize.new(@base_url, :remove_anchors => true)
+    end
+    it "should remove an anchor" do
+      @absolutize.url("/root folder/asdf.html#anchor").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html"     
+    end
   end
-  it "should not encode urls with %'s" do
-    @absolutize.url("/root%20folder/asdf.html?id=asdf").to_s.should == "http://www.baseurl.com/root%20folder/asdf.html?id=asdf"         
+  
+  describe "with force_escaping false" do
+    before(:each) do
+      @absolutize = Absolutize.new(@base_url, :force_escaping => false)
+    end
+    it "should not escape invalid characters" do
+      lambda { @absolutize.url("/root folder/asdf.html#anchor")}.should raise_error     
+    end
   end
-
 end 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: absolutize
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 0
-  - 5
-  version: 0.0.5
+  - 6
+  version: 0.0.6
 platform: ruby
 authors: 
 - Stewart McKee