absolution 0.0.4 → 0.0.5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MGVjNzcyODYzNTc5ODk1NWM3ZmE5ZWEyMWI2ZTdlOGUxYTI4YmU0YQ==
+    NjEyN2VhZDI3ZGM5OWZiZjMwOWQ3NzhhOWFmM2ViNDZjY2RlM2NlMg==
   data.tar.gz: !binary |-
-    MTQyMTZjMWI3ODQ5ZTI1MWJhMjAxYzkxM2EwNTdhMDA0MmNmZDQ5Ng==
+    NDE2YzVkMTZkMDI4YmVhMjhkOTUwYjkwOGQ1MWM2ZWYzNjVhYjcxOA==
 SHA512:
   metadata.gz: !binary |-
-    N2Y0NGM0NWZjNGRiZmE0ZGM5Mjg0YWMwNmE4NTkzZWI4YTMyZGI0ZjZjYjMx
-    YjAxODcyNDM0NTU1ODk2MDc0NTBjNTNjZmNmY2FlZTExNDZkMTUxNzU0OThh
-    M2U5NTVkOWYzMWFlODU1OThlNGM5Y2Q1NGMxOWVkYTQ4ODA5NGU=
+    MWViZDMyMmE5MzU4ZmNiZWJjNTE4OGM2OTY5MjdjZTFlOGM5YzMzNzIxZjdj
+    YTY1YzM3NWJiM2U5Yzg3MjU4NzAxYzBjZDYzZDExZTQzMGVkNTAzZWFjYzZh
+    Yjc0ZDg2N2QwMjU2M2NiZDViNWNmZTQ5YzE2NmRlMWMwNjE3MjY=
   data.tar.gz: !binary |-
-    MmJiNzY2ZTVhMjkyYjVjNTQ5YTU2NmY3MmUyZWEyNTNiMDE1YjVlNzA4YzU5
-    NDYxZDU0ZmYzZjMxNTdhMmZiMzBlYjMyMmJkOTU0M2YyN2VjZjUxMzk1YjA5
-    OTZmNGI2N2IyOTU5OGQyY2EyMjc5ODJmZjY0ODM3OTBlZjE0MmI=
+    Y2NlMWE5ZTRhZDVmZWIzNjlmYzBkMDBjOWY4OGVjYmM4ZDE4MmI5M2QxM2Zi
+    NzU3YzEzNzRlMjRmNWY4YjQ4NmYzMjcyY2FkYTdmYWJmOWQ5ZmQ5M2Q2ODUz
+    ZTczOTQ4ZDUxMzE2MTAxMjRmZDE0ZmE1ZWE3OTQwNTgyMGY5YTg=

data/README.md

@@ -60,6 +60,7 @@ Do you use git-flow? I sure do. Please base anything you do off of
 
 ## History ##
 
+* 0.0.5 - Better relative path handling
 * 0.0.4 - Query strings are handled properly
 * 0.0.2 - Initial release
 

data/lib/absolution/version.rb

@@ -1,3 +1,3 @@
 module Absolution
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/lib/absolution.rb

@@ -7,12 +7,15 @@ module Absolution
   end
 
   def construct_absolute_url(base_url, path)
-    u = URI.parse(base_url)
-    path.split('?').tap do |path_array|
-      u.path = path_array.first.start_with?('/') ? path_array.first : "/#{path_array.first}"
-      u.query = path_array.last if path_array.length > 1
+    uri = URI.parse(base_url)
+
+    URI.parse(path.start_with?('/') ? path : "/#{path}").tap do |path_uri|
+      uri.path = path_uri.path
+      uri.query = path_uri.query
+      uri.fragment = path_uri.fragment
     end
-    u.to_s
+
+    uri.to_s
   end
 
   extend self

data/spec/absolution_spec.rb

@@ -34,13 +34,14 @@ describe Absolution do
   end
 
   describe '.construct_absolute_url' do
+    let(:base_url) {'http://fake.url'}
+
     it 'combines a base url with a path' do
       expect(klass.construct_absolute_url('http://fake.url', '/asset.file')).
         to eql('http://fake.url/asset.file')
     end
 
     it 'separates the base url from the asset with at least 1 /' do
-      base_url = 'http://fake.url'
       asset_path = 'asset.file'
       expected_url = base_url + '/' + asset_path
       expect(klass.construct_absolute_url(base_url, asset_path)).
@@ -48,20 +49,25 @@ describe Absolution do
     end
 
     it 'removes an extra / when both the base url and the asset path have it' do
-      base_url = 'http://fake.url/'
       asset_path = '/asset.file'
       expected_url = base_url.chomp('/') + asset_path
-      expect(klass.construct_absolute_url(base_url, asset_path)).
+      expect(klass.construct_absolute_url(base_url + '/', asset_path)).
         to eql(expected_url)
     end
 
     it 'handles query strings appropriately' do
-      base_url = 'http://fake.url'
       asset_path = '/asset.file?key=val'
       expected_url = base_url + asset_path
       expect(klass.construct_absolute_url(base_url, asset_path)).
         to eql(expected_url)
     end
+
+    it 'handles fragments appropriately' do
+      asset_path = '#fortytwo'
+      expected_url = base_url + '/' + asset_path
+      expect(klass.construct_absolute_url(base_url, asset_path)).
+        to eql(expected_url)
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: absolution
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Dennis Walters