absolutely 1.1.2 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7c97a6f83461fbf9ae3f14ae28af40dc6385b4237224b57fa5450eabdc60a97
-  data.tar.gz: dcd8fc9c3ec0b2c59786ed36fdbc16b3dea55613138725e4e5607a411a366a62
+  metadata.gz: 9f16f86035665614b32d4fa91b9f87095c567bf62c4905bf08281f9dc06f9b00
+  data.tar.gz: affcb6d3a59693727e4354cea0d52ff7813332ddd006d1370ab15c8253cfebca
 SHA512:
-  metadata.gz: 7eb3f3a83b2c3ea000bc12794c621e147303b27d453d226e974472ecffce60c3de979baade6073d199ca046aba09c8b649820e65033ef9b0d716a7ea4b8bd3a9
-  data.tar.gz: debf9c03a3c36d34ccd3d364bc4401c10a7b90ec77104d09aa574e75cfb45fc70bf48a4ee50c9f8ae54ce7974e4568cf22f4c0250977e8969d07f6baab1c8c42
+  metadata.gz: 43f2451ce53d29070180c5889fdfce3f31c542db7508c0a50d7f4e195deab3a58b14f6bb9b08fca8e6b7e739ff453849561deaded3b543b6b78ae83692a0f397
+  data.tar.gz: 14411e64c9ca529968c2333b90db9f306a119af0049e3e96ec3c7aee45a25633e57b37c1fd0a4bc3673dbf643f0655bfd62b81025518e010e997150adecb9a2d

data/.editorconfig

@@ -1,4 +1,4 @@
-# EditorConfig is awesome: http://EditorConfig.org
+# EditorConfig is awesome: https://EditorConfig.org
 root = true
 
 [*]

data/.reek.yml

@@ -0,0 +1,6 @@
+detectors:
+  IrresponsibleModule:
+    enabled: false
+
+exclude_paths:
+  - vendor/

data/.rubocop.yml

@@ -1,4 +1,5 @@
 require:
+  - rubocop-performance
   - rubocop-rspec
 
 Metrics/BlockLength:
@@ -8,8 +9,14 @@ Metrics/BlockLength:
 Metrics/LineLength:
   Enabled: false
 
+Naming/RescuedExceptionsVariableName:
+  PreferredName: exception
+
 Style/Documentation:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+Style/SymbolArray:
+  Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.4.5
+2.4.6

data/.travis.yml

@@ -1,19 +1,17 @@
 language: ruby
 rvm:
-  - 2.4.5
-  - 2.5.3
-  - 2.6.0
+  - 2.4.6
+  - 2.5.5
+  - 2.6.2
 cache:
   - bundler
 before_install:
-  - gem install bundler -v '~> 1.17'
+  - gem update --system
+  - gem install bundler
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
   - chmod +x ./cc-test-reporter
   - ./cc-test-reporter before-build
-script:
-  - bundle exec rubocop
-  - bundle exec rake
 after_script:
   - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
 notifications:

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 2.0.0 / 2019-04-25
+
+- The `URI` class' `base` and `relative` methods are now read-only ([7879f78](https://github.com/jgarber623/absolutely/commit/7879f78)).
+- Add Reek and configuration ([fb60f9c](https://github.com/jgarber623/absolutely/commit/fb60f9c)).
+
 ## 1.1.2 / 2019-01-03
 
 - Expand supported Ruby versions to include 2.6 ([866d58a](https://github.com/jgarber623/absolutely/commit/866d58a)).

data/CONTRIBUTING.md

@@ -8,9 +8,9 @@ There are a couple ways you can help improve Absolutely:
 
 ## Getting Started
 
-Absolutely is developed using Ruby 2.4.5 and is additionally tested against Ruby 2.5.3 and 2.6.0 using [Travis CI](https://travis-ci.com/jgarber623/absolutely).
+Absolutely is developed using Ruby 2.4.6 and is additionally tested against Ruby 2.5.5 and 2.6.2 using [Travis CI](https://travis-ci.com/jgarber623/absolutely).
 
-Before making changes to Absolutely, you'll want to install Ruby 2.4.5. It's recommended that you use a Ruby version managment tool like [rbenv](https://github.com/rbenv/rbenv), [chruby](https://github.com/postmodern/chruby), or [rvm](https://github.com/rvm/rvm). Once you've installed Ruby 2.4.5 using your method of choice, install the project's gems by running:
+Before making changes to Absolutely, you'll want to install Ruby 2.4.6. It's recommended that you use a Ruby version managment tool like [rbenv](https://github.com/rbenv/rbenv), [chruby](https://github.com/postmodern/chruby), or [rvm](https://github.com/rvm/rvm). Once you've installed Ruby 2.4.6 using your method of choice, install the project's gems by running:
 
 ```sh
 bundle install

data/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2018 Jason Garber
+Copyright (c) 2018–present Jason Garber
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -18,7 +18,7 @@
 
 Before installing and using Absolutely, you'll want to have [Ruby](https://www.ruby-lang.org) 2.4 (or newer) installed. It's recommended that you use a Ruby version managment tool like [rbenv](https://github.com/rbenv/rbenv), [chruby](https://github.com/postmodern/chruby), or [rvm](https://github.com/rvm/rvm).
 
-Absolutely is developed using Ruby 2.4.5 and is additionally tested against Ruby 2.5.3 and 2.6.0 using [Travis CI](https://travis-ci.com/jgarber623/absolutely).
+Absolutely is developed using Ruby 2.4.6 and is additionally tested against Ruby 2.5.5 and 2.6.2 using [Travis CI](https://travis-ci.com/jgarber623/absolutely).
 
 ## Installation
 

data/Rakefile

@@ -1,6 +1,11 @@
 require 'bundler/gem_tasks'
+
+require 'reek/rake/task'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
+Reek::Rake::Task.new
 RSpec::Core::RakeTask.new
+RuboCop::RakeTask.new
 
-task default: :spec
+task default: [:rubocop, :reek, :spec]

data/absolutely.gemspec

@@ -20,13 +20,14 @@ Gem::Specification.new do |spec|
 
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.17'
   spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'reek', '~> 5.4'
   spec.add_development_dependency 'rspec', '~> 3.8'
-  spec.add_development_dependency 'rubocop', '~> 0.62.0'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.31'
+  spec.add_development_dependency 'rubocop', '~> 0.67.2'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.1'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.32'
   spec.add_development_dependency 'simplecov', '~> 0.16.1'
   spec.add_development_dependency 'simplecov-console', '~> 0.4.2'
 
-  spec.add_runtime_dependency 'addressable', '~> 2.5'
+  spec.add_runtime_dependency 'addressable', '~> 2.6'
 end

data/lib/absolutely.rb

@@ -1,7 +1,8 @@
 require 'addressable/uri'
 
 require 'absolutely/version'
-require 'absolutely/error'
+require 'absolutely/exceptions'
+
 require 'absolutely/uri'
 
 module Absolutely

data/lib/absolutely/uri.rb

@@ -1,6 +1,6 @@
 module Absolutely
   class URI
-    attr_accessor :base, :relative
+    attr_reader :base, :relative
 
     def initialize(base:, relative:)
       raise ArgumentError, "base must be a String (given #{base.class.name})" unless base.is_a?(String)
@@ -9,21 +9,20 @@ module Absolutely
       @base = base
       @relative = relative
 
-      raise ArgumentError, 'base must be an absolute URI (e.g. https://example.com)' unless base_uri.absolute?
-
+      base_uri
       relative_uri
+
+      raise ArgumentError, 'base must be an absolute URI (e.g. https://example.com)' unless base_uri.absolute?
+    rescue Addressable::URI::InvalidURIError => exception
+      raise InvalidURIError, exception
     end
 
     def base_uri
       @base_uri ||= Addressable::URI.parse(base)
-    rescue Addressable::URI::InvalidURIError => error
-      raise InvalidURIError, error
     end
 
     def relative_uri
       @relative_uri ||= Addressable::URI.parse(relative)
-    rescue Addressable::URI::InvalidURIError => error
-      raise InvalidURIError, error
     end
 
     def to_absolute_uri

data/lib/absolutely/version.rb

@@ -1,3 +1,3 @@
 module Absolutely
-  VERSION = '1.1.2'.freeze
+  VERSION = '2.0.0'.freeze
 end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: absolutely
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 2.0.0
 platform: ruby
 authors:
 - Jason Garber
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-03 00:00:00.000000000 Z
+date: 2019-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '5.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '5.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -58,28 +58,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.62.0
+        version: 0.67.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.67.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.62.0
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.31'
+        version: '1.32'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.31'
+        version: '1.32'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '2.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '2.6'
 description: Convert relative paths to absolute URIs.
 email:
 - jason@sixtwothree.org
@@ -131,6 +145,7 @@ extra_rdoc_files: []
 files:
 - ".editorconfig"
 - ".gitignore"
+- ".reek.yml"
 - ".rspec"
 - ".rubocop"
 - ".rubocop.yml"
@@ -145,7 +160,7 @@ files:
 - Rakefile
 - absolutely.gemspec
 - lib/absolutely.rb
-- lib/absolutely/error.rb
+- lib/absolutely/exceptions.rb
 - lib/absolutely/uri.rb
 - lib/absolutely/version.rb
 homepage: https://github.com/jgarber623/absolutely
@@ -170,7 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Convert relative paths to absolute URIs.