aboutyou-sdk 0.0.24 → 0.0.25

data/lib/{aboutyou-sdk/Factory/DefaultModelFactory.rb → AboutYou/Factory/default_model_factory.rb}

@@ -10,124 +10,137 @@ module AboutYou
       ###
       class DefaultModelFactory
         # The client which performs the api calls
-        attr_accessor :shopApi
+        attr_accessor :shop_api
         # the category manager responsible for managing the categories
-        attr_accessor :categoryManager
+        attr_accessor :category_manager
         # the facet manager responsible for managing the facets
-        attr_accessor :facetManager
+        attr_accessor :facet_manager
 
         ###
         # Constructor for AboutYou::SDK::Factory::DefaultModelFactory
         #
         # * *Args*    :
-        #   - +shopApi+ -> the client which should perform the api calls
-        #   - +categoryManager+ -> the category manager responsible for managing the categories
-        #   - +:facetManager+ -> the facet manager responsible for managing the facets
+        #   - +shop_api+ -> the client which should perform the api calls
+        #   - +category_manager+ -> the category manager responsible for managing the categories
+        #   - +:facet_manager+ -> the facet manager responsible for managing the facets
         #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Factory::DefaultModelFactory
         ###
-        def initialize(shopApi = nil)
-          self.shopApi = shopApi
+        def initialize(shop_api = nil)
+          self.shop_api = shop_api
         end
-        
-        def initializeManagers(facetManager, categoryManager)
-          self.categoryManager = categoryManager
-          self.facetManager = facetManager
-          AboutYou::SDK::Model::FacetGroupSet.facetManager = self.facetManager
+
+        def initialize_managers(facet_manager, category_manager)
+          self.category_manager = category_manager
+          self.facet_manager = facet_manager
+          AboutYou::SDK::Model::FacetGroupSet.facet_manager = self.facet_manager
         end
 
         ###
         # sets the baseimage url for the image model
         #
         # * *Args*    :
-        #   - +baseUrl+ -> the url which should be used by the image model
+        #   - +base_url+ -> the url which should be used by the image model
         ###
-        def baseImageUrl=(baseUrl)
-          AboutYou::SDK::Model::Image.baseUrl=baseUrl
+        def base_image_url=(base_url)
+          AboutYou::SDK::Model::Image.base_url = base_url
         end
 
         ###
         # creates an autocomplete model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +query+ -> the query sent to the api
-        #   
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Autocomplete
         ###
-        def createAutocomplete(jsonObject, query)
-          AboutYou::SDK::Model::Autocomplete.createFromJson(jsonObject, self)
+        def create_autocomplete(json_object, _query)
+          AboutYou::SDK::Model::Autocomplete.create_from_json(json_object, self)
         end
 
         ###
         # creates a basket model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +query+ -> the query sent to the api
-        #   
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Basket
         ###
-        def createBasket(jsonObject, query)
-          AboutYou::SDK::Model::Basket.createFromJson(jsonObject, self)
+        def create_basket(json_object, _query)
+          AboutYou::SDK::Model::Basket.create_from_json(json_object, self)
         end
 
         ###
         # creates a basket item model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +products+ -> the product models for which items should be created
-        #   
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::BasketItem
         ###
-        def createBasketItem(jsonObject, products)
-          AboutYou::SDK::Model::Basket::BasketItem.createFromJson(jsonObject, products)
+        def create_basket_item(json_object, products)
+          AboutYou::SDK::Model::Basket::BasketItem.create_from_json(
+            json_object,
+            products
+          )
         end
 
         ###
         # creates a basket set model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +products+ -> the product models for which items should be created
-        #   
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::BasketSet
         ###
-        def createBasketSet(jsonObject, products)
-          AboutYou::SDK::Model::BasketSet::createFromJson(jsonObject, self, products)
+        def create_basket_set(json_object, products)
+          AboutYou::SDK::Model::BasketSet.create_from_json(
+            json_object,
+            self,
+            products
+          )
         end
 
         ###
         # creates a basket setitem model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +products+ -> the product models for which items should be created
-        #   
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::BasketSetItem
         ###
-        def createBasketSetItem(jsonObject, products)
-          AboutYou::SDK::Model::BasketSetItem::createFromJson(jsonObject, products);
+        def create_basket_set_item(json_object, products)
+          AboutYou::SDK::Model::BasketSetItem.create_from_json(
+            json_object,
+            products
+          )
         end
 
         ###
         # creates a category model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Category
         ###
-        def createCategory(jsonObject)
-          AboutYou::SDK::Model::Category.createFromJson(jsonObject, self.categoryManager)
+        def create_category(json_object)
+          AboutYou::SDK::Model::Category.create_from_json(
+            json_object,
+            category_manager
+          )
         end
 
         ###
@@ -135,27 +148,27 @@ module AboutYou
         #
         # * *Args*    :
         #   - +jsonArray+ -> an Array containing the api response
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::CategoryTree
         ###
-        def createCategoryTree(jsonArray, query)
-          self.initializeCategoryManager(jsonArray)
-          AboutYou::SDK::Model::CategoryTree.new(self.categoryManager)
+        def create_category_tree(json_array, _query)
+          initialize_category_manager(json_array)
+          AboutYou::SDK::Model::CategoryTree.new(category_manager)
         end
 
         ###
         # creates a facet model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Facet
         ###
-        def createFacet(jsonObject)
-          AboutYou::SDK::Model::Facet.createFromJson(jsonObject)
+        def create_facet(json_object)
+          AboutYou::SDK::Model::Facet.create_from_json(json_object)
         end
 
         ###
@@ -164,15 +177,15 @@ module AboutYou
         #
         # * *Args*    :
         #   - +jsonArray+ -> an Array containing the api response
-        #   
+        #
         # * *Returns* :
         #   - a Hash containing pairs of facetKey => AboutYou::SDK::Model::Facet
         ###
-        def createFacetList(jsonArray, query)
+        def create_facet_list(json_array, _query)
           facets = {}
-          jsonArray.each do |jsonFacet|
-            facet = self.createFacet(jsonFacet)
-            key = facet.uniqueKey
+          json_array.each do |json_facet|
+            facet = create_facet(json_facet)
+            key = facet.unique_key
             facets[key] = facet
           end
 
@@ -184,142 +197,151 @@ module AboutYou
         # facetKey => AboutYou::SDK::Model::Facet
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +query+ -> the query sent to the api
-        #   
+        #
         # * *Returns* :
         #   - a Hash containing pairs of facetKey => AboutYou::SDK::Model::Facet
         ###
-        def createFacetsList(jsonObject, query=nil)
-          self.createFacetList(jsonObject["facet"], query)
+        def create_facets_list(json_object, query = nil)
+          create_facet_list(json_object['facet'], query)
         end
-        
 
         ###
         # creates a Hash containing one or multiple pairs of
         # group_id => instance of AboutYou::SDK::Model::FacetCounts
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - a Hash containing pairs of group_id => instance of AboutYou::SDK::Model::FacetCounts
         ###
-        def createFacetsCounts(jsonObject)
-          facetsCounts = {}
+        def create_facets_counts(json_object)
+          facets_counts = {}
 
-          jsonObject["facets"].each do |groupId, jsonResultFacet|
-            unless groupId[/\d/] 
-              next
-            end
-            facetCounts = self.termFacets(groupId, jsonResultFacet["terms"])    
-            facetsCounts[groupId] = AboutYou::SDK::Model::FacetCounts.createFromJson(
-              groupId,
-              jsonResultFacet,
-              facetCounts
+          json_object['facets'].each do |group_id, json_result_facet|
+            next unless group_id[/\d/]
+
+            facet_counts = term_facets(
+              group_id,
+              json_result_facet['terms']
             )
+            facets_counts[group_id] =
+              AboutYou::SDK::Model::FacetCounts.create_from_json(
+                group_id,
+                json_result_facet,
+                facet_counts
+              )
           end
 
-          facetsCounts
+          facets_counts
         end
-          
+
         ###
         # creates an Array containing one or multiple instances of
         # AboutYou::SDK::Model::FacetCount
         #
         # * *Args*    :
-        #   - +groupId+ -> the group id of the facets
+        #   - +group_id+ -> the group id of the facets
         #   - +jsonTerms+ -> the single facet terms in json format
-        #   
+        #
         # * *Returns* :
         #   - an Array containing instances of AboutYou::SDK::Model::FacetCount
         ###
-        def termFacets(groupId, jsonTerms)
-          facetCounts = []
-          jsonTerms.each do |jsonTerm|
-            id = Integer(jsonTerm["term"])
-            facet = self.facetManager.facet(groupId, id)
-            unless facet
-              next
-            end
+        def term_facets(group_id, json_terms)
+          facet_counts = []
+          json_terms.each do |json_term|
+            id = Integer(json_term['term'])
+            facet = facet_manager.facet(group_id, id)
+            next unless facet
+
             # TODO: Handle error, write test
-            facetCounts.push(AboutYou::SDK::Model::FacetCount.new(facet, jsonTerm["count"]))
+            facet_counts.push(AboutYou::SDK::Model::FacetCount.new(
+                facet,
+                json_term['count']
+              )
+            )
           end
 
-          facetCounts
-        end     
-          
+          facet_counts
+        end
+
         ###
         # creates an Array containing all facet types available
         #
         # * *Args*    :
         #   - +jsonArray+ -> an Array containing the api response
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an Array containing all facet types available
         ###
-        def createFacetTypes(jsonArray, query)
-            jsonArray
+        def create_facet_types(json_array, _query)
+          json_array
         end
 
         ###
         # creates an image model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Image
         ###
-        def createImage(jsonObject)
-          AboutYou::SDK::Model::Image.createFromJson(jsonObject)
+        def create_image(json_object)
+          AboutYou::SDK::Model::Image.create_from_json(json_object)
         end
 
         ###
         # creates a product model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Product
         ###
-        def createProduct(jsonObject)
-          AboutYou::SDK::Model::Product.createFromJson(jsonObject, self, self.shopApi.appId)
+        def create_product(json_object)
+          AboutYou::SDK::Model::Product.create_from_json(
+            json_object,
+            self,
+            shop_api.app_id
+          )
         end
 
         ###
         # creates a variants result model
         #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +json_object+ -> the api response in json format
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::VariantsResult
         ###
-        def createVariantsResult(jsonObject, query)
+        def create_variants_result(json_object, _query)
           variants = {}
           errors = []
-          productIds = []
-          productSearchResult = false
+          product_ids = []
+          product_search_result = false
 
-          jsonObject.each do |id, data|
-            if data["error_code"]
+          json_object.each do |id, data|
+            if data['error_code']
               errors.push(id)
             else
-              variants[data["id"]] = data["product_id"]
-              productIds.push(data["product_id"])
+              variants[data['id']] = data['product_id']
+              product_ids.push(data['product_id'])
             end
           end
 
-          if productIds.count > 0
-            productIds = productIds.uniq
+          if product_ids.count > 0
+            product_ids = product_ids.uniq
             # search products for valid variants
-            productSearchResult = self.shopApi.
-              fetchProductsByIds(
-                productIds, [
+
+            product_search_result = shop_api.fetch_products_by_ids(
+                product_ids, [
                   AboutYou::SDK::Criteria::ProductFields::ATTRIBUTES_MERGED,
                   AboutYou::SDK::Criteria::ProductFields::BRAND,
                   AboutYou::SDK::Criteria::ProductFields::CATEGORIES,
@@ -335,152 +357,173 @@ module AboutYou
                 ]
               )
           end
-          
-          AboutYou::SDK::Model::VariantsResult.create(variants, errors, productSearchResult)
+
+          AboutYou::SDK::Model::VariantsResult.create(
+            variants,
+            errors,
+            product_search_result
+          )
         end
 
         ###
         # creates a single product model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Product
         ###
-        def createSingleProduct(jsonObject)
-          self.createProduct(jsonObject)
+        def create_single_product(json_object)
+          createProduct(json_object)
         end
 
         ###
         # creates a products result model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +json_object+ -> the api response in json format
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::ProductsResult
         ###
-        def createProductsResult(jsonObject, query)
-          AboutYou::SDK::Model::ProductsResult.createFromJson(jsonObject, self)
+        def create_products_result(json_object, _query)
+          AboutYou::SDK::Model::ProductsResult.create_from_json(
+            json_object,
+            self
+          )
         end
 
         ###
         # creates a products eanresult model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +json_object+ -> the api response in json format
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::ProductsEanResult
         ###
-        def createProductsEansResult(jsonObject, query)
-          AboutYou::SDK::Model::ProductsEansResult.createFromJson(jsonObject, self)
+        def create_products_ean_result(json_object, _query)
+          AboutYou::SDK::Model::ProductsEansResult.create_from_json(
+            json_object,
+            self
+          )
         end
 
         ###
         # creates a product searchresult model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +json_object+ -> the api response in json format
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::ProductSearchResult
         ###
-        def createProductSearchResult(jsonObject, query)
-          return AboutYou::SDK::Model::ProductSearchResult.createFromJson(jsonObject, self)
+        def create_product_search_result(json_object, _query)
+          AboutYou::SDK::Model::ProductSearchResult.create_from_json(
+            json_object,
+            self
+          )
         end
 
         ###
         # creates a categories result model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +query+ -> the query sent to the api
-        #   
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::CategoriesResult
         ###
-        def createCategoriesResult(jsonObject, query)
-          AboutYou::SDK::Model::CategoriesResult.createFromJson(jsonObject, query["ids"], self)
+        def create_categories_result(json_object, query)
+          AboutYou::SDK::Model::CategoriesResult.create_from_json(
+            json_object,
+            query['ids'],
+            self
+          )
         end
 
         ###
         # creates an Array containing suggests
-        # 
+        #
         # * *Args*    :
         #   - +jsonArray+ -> an Array with the api response
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an Array containing suggests
         ###
-        def createSuggest(jsonArray, query)
+        def create_suggest(jsonArray, _query)
           jsonArray
         end
 
         ###
         # creates a variant model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +product+ -> the product of the variant which should be created
-        #   
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Variant
         ###
-        def createVariant(jsonObject, product)
-          AboutYou::SDK::Model::Variant.createFromJson(jsonObject, self, product)
+        def create_variant(json_object, product)
+          AboutYou::SDK::Model::Variant.create_from_json(
+            json_object,
+            self,
+            product
+          )
         end
 
         ###
         # creates an order model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +json_object+ -> the api response in json format
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::Order
         ###
-        def createOrder(jsonObject, query)
-          basket = self.createBasket(jsonObject["basket"])
+        def create_order(json_object, _query)
+          basket = create_basket(json_object['basket'])
 
-          AboutYou::SDK::Model::Order.new(jsonObject["order_id"], basket);
+          AboutYou::SDK::Model::Order.new(json_object['order_id'], basket)
         end
 
         ###
         # creates an initiate order model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +json_object+ -> the api response in json format
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::InitiateOrder
         ###
-        def initiateOrder(jsonObject, query)
-          AboutYou::SDK::Model::InitiateOrder.createFromJson(jsonObject)
+        def initiate_order(json_object, _query)
+          AboutYou::SDK::Model::InitiateOrder.create_from_json(json_object)
         end
 
         ###
         # creates a Has containing one or multiple pairs of
         # app_id => instance of AboutYou::SDK::Model::App
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   - +query+ -> the query sent to the api
-        #   
+        #   - +json_object+ -> the api response in json format
+        #   - +_query+ -> the _query sent to the api
+        #
         # * *Returns* :
         #   - a Hash containing pairs of app_id => instance of AboutYou::SDK::Model::App
         ###
-        def createChildApps(jsonObject, query)
+        def create_child_apps(json_object, _query)
           apps = {}
-          jsonObject["child_apps"].each do |jsonApp|
-            app = self.createApp(jsonApp)
+          json_object['child_apps'].each do |json_app|
+            app = create_app(json_app)
             apps[app.id] = app
           end
 
@@ -489,112 +532,112 @@ module AboutYou
 
         ###
         # creates an app model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::App
         ###
-        def createApp(jsonObject)
-          AboutYou::SDK::Model::App.createFromJson(jsonObject)
+        def create_app(json_object)
+          AboutYou::SDK::Model::App.create_from_json(json_object)
         end
 
         ###
         # this methods initiates the category manager
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         ###
-        def initializeCategoryManager(jsonObject)
-          self.categoryManager.parseJson(jsonObject, self)
+        def initialize_category_manager(json_object)
+          category_manager.parse_json(json_object, self)
         end
-        
+
         ###
         # this methods updates the facet manager
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
+        #   - +json_object+ -> the api response in json format
         #   - +query+ -> the query sent to the api
         ###
-        def updateFacetManager(jsonObject, query)
-          self.facetManager.parseJson(jsonObject, self, query)
+        def update_facet_manager(json_object, query)
+          facet_manager.parse_json(json_object, self, query)
         end
 
         ###
         # this method creates a price range model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an Array containing instances of AboutYou::SDK::Model::PriceRange
         ###
-        def createPriceRanges(jsonObject)
-          priceRanges = []
-          jsonObject["ranges"].each do |range|
-            priceRanges.push(AboutYou::SDK::Model::PriceRange.createFromJson(range))
+        def create_price_ranges(json_object)
+          price_ranges = []
+          json_object['ranges'].each do |range|
+            price_ranges.push(
+              AboutYou::SDK::Model::PriceRange.create_from_json(
+                range
+              )
+            )
           end
-          priceRanges
+
+          price_ranges
         end
 
         ###
         # this method creates a sale counts model
-        # 
+        #
         # * *Args*    :
-        #   - +jsonObject+ -> the api response in json format
-        #   
+        #   - +json_object+ -> the api response in json format
+        #
         # * *Returns* :
         #   - an instance of AboutYou::SDK::Model::SaleCounts
         ###
-        def createSaleFacet(jsonObject)
-          AboutYou::SDK::Model::SaleCounts.createFromJson(jsonObject)
+        def create_sale_facet(json_object)
+          AboutYou::SDK::Model::SaleCounts.create_from_json(json_object)
         end
 
         ###
         # this method creates the facets for given categories
-        # 
+        #
         # * *Args*    :
         #   - +jsonArray+ -> an Array containing the Api response
-        #   
+        #
         # * *Returns* :
         #   - a Hash containing pairs of category_id => category
         ###
-        def createCategoriesFacets(jsonArray)
-          categoryManager =self.categoryManager
+        def create_categories_facets(json_array)
+          category_manager = self.category_manager
 
-          flattenCategories = {}
-          jsonArray.each do |item|
-            id = item["term"]
-            category = categoryManager.category(id)
+          flatten_categories = {}
+          json_array.each do |item|
+            id = item['term']
+            category = category_manager.category(id)
             next unless category
 
-            category.productCount = item["count"]
-            flattenCategories[id] = category
+            category.product_count = item['count']
+            flatten_categories[id] = category
           end
 
-          flattenCategories
+          flatten_categories
         end
-        
+
         ###
         # this method tries to handle errors which are received from the api
-        # 
+        #
         # * *Args*    :
         #   - +json+ -> the api response in json format
         #   - +resultKey+ -> the result key received from the api
         #   - +isMultiRequest+ -> determines whether the api-request was multiquery or not
         ###
-        def preHandleError(json, resultKey, isMultiRequest)
-          if resultKey == 'basket' && json["order_lines"]
-            return false
-          end
+        def pre_handle_error(json, result_key, is_multi_request)
+          return false if result_key == 'basket' && json['order_lines']
 
-          if isMultiRequest
-            raise 'ResultError!' + json
-          end
-          raise 'ResultError!' + json
+          fail 'ResultError!' + json + is_multi_request
         end
       end
     end
-  end 
-end
+  end
+end