ably 1.0.7 → 1.1.0

data/spec/unit/realtime/client_spec.rb

@@ -28,6 +28,18 @@ describe Ably::Realtime::Client do
     end
   end
 
+  context 'push' do
+    let(:client_options) { { key: 'appid.keyuid:keysecret' } }
+
+    specify '#device is not supported and raises an exception' do
+      expect { subject.device }.to raise_error Ably::Exceptions::PushNotificationsNotSupported
+    end
+
+    specify '#push returns a Push object' do
+      expect(subject.push).to be_a(Ably::Realtime::Push)
+    end
+  end
+
   after(:all) do
     sleep 1 # let realtime library shut down any open clients
   end

data/spec/unit/realtime/push_channel_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Ably::Realtime::Channel::PushChannel do
+  subject { Ably::Realtime::Channel::PushChannel }
+
+  let(:channel_name) { 'unique' }
+  let(:client) { double('client').as_null_object }
+  let(:channel) { Ably::Realtime::Channel.new(client, channel_name) }
+
+  it 'is constructed with a channel' do
+    expect(subject.new(channel)).to be_a(Ably::Realtime::Channel::PushChannel)
+  end
+
+  it 'raises an exception if constructed with an invalid type' do
+    expect { subject.new(Hash.new) }.to raise_error(ArgumentError)
+  end
+
+  it 'exposes the channel as attribute #channel' do
+    expect(subject.new(channel).channel).to eql(channel)
+  end
+
+  it 'is available in the #push attribute of the channel' do
+    expect(channel.push).to be_a(Ably::Realtime::Channel::PushChannel)
+    expect(channel.push.channel).to eql(channel)
+  end
+
+  context 'methods not implemented as push notifications' do
+    subject { Ably::Realtime::Channel::PushChannel.new(channel) }
+
+    %w(subscribe_device subscribe_client_id unsubscribe_device unsubscribe_client_id get_subscriptions).each do |method_name|
+      specify "##{method_name} raises an unsupported exception" do
+        expect { subject.public_send(method_name, 'foo') }.to raise_error(Ably::Exceptions::PushNotificationsNotSupported)
+      end
+    end
+  end
+end

data/spec/unit/rest/channel_spec.rb

@@ -2,7 +2,14 @@
 require 'spec_helper'
 
 describe Ably::Rest::Channel do
-  let(:client)       { instance_double('Ably::Rest::Client', encoders: [], post: instance_double('Faraday::Response', status: 201)) }
+  let(:client) do
+    instance_double(
+      'Ably::Rest::Client',
+      encoders: [],
+      post: instance_double('Faraday::Response', status: 201),
+      idempotent_rest_publishing: false,
+    )
+  end
   let(:channel_name) { 'unique' }
 
   subject { Ably::Rest::Channel.new(client, channel_name) }

data/spec/unit/rest/client_spec.rb

@@ -20,6 +20,24 @@ describe Ably::Rest::Client do
       end
     end
 
+    context 'fallback_retry_timeout (#RSC15f)' do
+      context 'default' do
+        let(:client_options) { { key: 'appid.keyuid:keysecret' } }
+
+        it 'is set to 10 minutes' do
+          expect(subject.options.fetch(:fallback_retry_timeout)).to eql(10 * 60)
+        end
+      end
+
+      context 'when provided' do
+        let(:client_options) { { key: 'appid.keyuid:keysecret', fallback_retry_timeout: 30 } }
+
+        it 'configures a new timeout' do
+          expect(subject.options.fetch(:fallback_retry_timeout)).to eql(30)
+        end
+      end
+    end
+
     context ':use_token_auth' do
       context 'set to false' do
         context 'with a key and :tls => false' do
@@ -57,4 +75,16 @@ describe Ably::Rest::Client do
       expect(subject.add_request_ids).to eql(true)
     end
   end
+
+  context 'push' do
+    let(:client_options) { { key: 'appid.keyuid:keysecret' } }
+
+    specify '#device is not supported and raises an exception' do
+      expect { subject.device }.to raise_error Ably::Exceptions::PushNotificationsNotSupported
+    end
+
+    specify '#push returns a Push object' do
+      expect(subject.push).to be_a(Ably::Rest::Push)
+    end
+  end
 end

data/spec/unit/rest/push_channel_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Ably::Rest::Channel::PushChannel do
+  subject { Ably::Rest::Channel::PushChannel }
+
+  let(:channel_name) { 'unique' }
+  let(:client) { double('client').as_null_object }
+  let(:channel) { Ably::Rest::Channel.new(client, channel_name) }
+
+  it 'is constructed with a channel' do
+    expect(subject.new(channel)).to be_a(Ably::Rest::Channel::PushChannel)
+  end
+
+  it 'raises an exception if constructed with an invalid type' do
+    expect { subject.new(Hash.new) }.to raise_error(ArgumentError)
+  end
+
+  it 'exposes the channel as attribute #channel' do
+    expect(subject.new(channel).channel).to eql(channel)
+  end
+
+  it 'is available in the #push attribute of the channel' do
+    expect(channel.push).to be_a(Ably::Rest::Channel::PushChannel)
+    expect(channel.push.channel).to eql(channel)
+  end
+
+  context 'methods not implemented as push notifications' do
+    subject { Ably::Rest::Channel::PushChannel.new(channel) }
+
+    %w(subscribe_device subscribe_client_id unsubscribe_device unsubscribe_client_id get_subscriptions).each do |method_name|
+      specify "##{method_name} raises an unsupported exception" do
+        expect { subject.public_send(method_name, 'foo') }.to raise_error(Ably::Exceptions::PushNotificationsNotSupported)
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ably
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.1.0
 platform: ruby
 authors:
 - Lewis Marshall
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-18 00:00:00.000000000 Z
+date: 2019-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -185,28 +185,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 3.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 3.3.0
 - !ruby/object:Gem::Dependency
   name: rspec-retry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -221,6 +221,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: rspec-instafail
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -249,6 +263,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: parallel_tests
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -285,6 +313,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".editorconfig"
 - ".gitignore"
 - ".gitmodules"
 - ".rspec"
@@ -305,6 +334,8 @@ files:
 - lib/ably/models/cipher_params.rb
 - lib/ably/models/connection_details.rb
 - lib/ably/models/connection_state_change.rb
+- lib/ably/models/device_details.rb
+- lib/ably/models/device_push_details.rb
 - lib/ably/models/error_info.rb
 - lib/ably/models/http_paginated_response.rb
 - lib/ably/models/idiomatic_ruby_wrapper.rb
@@ -318,6 +349,7 @@ files:
 - lib/ably/models/paginated_result.rb
 - lib/ably/models/presence_message.rb
 - lib/ably/models/protocol_message.rb
+- lib/ably/models/push_channel_subscription.rb
 - lib/ably/models/stats.rb
 - lib/ably/models/stats_types.rb
 - lib/ably/models/token_details.rb
@@ -330,6 +362,7 @@ files:
 - lib/ably/modules/enum.rb
 - lib/ably/modules/event_emitter.rb
 - lib/ably/modules/event_machine_helpers.rb
+- lib/ably/modules/exception_codes.rb
 - lib/ably/modules/http_helpers.rb
 - lib/ably/modules/message_emitter.rb
 - lib/ably/modules/message_pack.rb
@@ -345,6 +378,8 @@ files:
 - lib/ably/realtime/channel.rb
 - lib/ably/realtime/channel/channel_manager.rb
 - lib/ably/realtime/channel/channel_state_machine.rb
+- lib/ably/realtime/channel/publisher.rb
+- lib/ably/realtime/channel/push_channel.rb
 - lib/ably/realtime/channels.rb
 - lib/ably/realtime/client.rb
 - lib/ably/realtime/client/incoming_message_dispatcher.rb
@@ -358,8 +393,13 @@ files:
 - lib/ably/realtime/presence/members_map.rb
 - lib/ably/realtime/presence/presence_manager.rb
 - lib/ably/realtime/presence/presence_state_machine.rb
+- lib/ably/realtime/push.rb
+- lib/ably/realtime/push/admin.rb
+- lib/ably/realtime/push/channel_subscriptions.rb
+- lib/ably/realtime/push/device_registrations.rb
 - lib/ably/rest.rb
 - lib/ably/rest/channel.rb
+- lib/ably/rest/channel/push_channel.rb
 - lib/ably/rest/channels.rb
 - lib/ably/rest/client.rb
 - lib/ably/rest/middleware/encoder.rb
@@ -370,6 +410,10 @@ files:
 - lib/ably/rest/middleware/parse_json.rb
 - lib/ably/rest/middleware/parse_message_pack.rb
 - lib/ably/rest/presence.rb
+- lib/ably/rest/push.rb
+- lib/ably/rest/push/admin.rb
+- lib/ably/rest/push/channel_subscriptions.rb
+- lib/ably/rest/push/device_registrations.rb
 - lib/ably/util/crypto.rb
 - lib/ably/util/pub_sub.rb
 - lib/ably/util/safe_deferrable.rb
@@ -384,6 +428,8 @@ files:
 - spec/acceptance/realtime/message_spec.rb
 - spec/acceptance/realtime/presence_history_spec.rb
 - spec/acceptance/realtime/presence_spec.rb
+- spec/acceptance/realtime/push_admin_spec.rb
+- spec/acceptance/realtime/push_spec.rb
 - spec/acceptance/realtime/stats_spec.rb
 - spec/acceptance/realtime/time_spec.rb
 - spec/acceptance/rest/auth_spec.rb
@@ -394,9 +440,12 @@ files:
 - spec/acceptance/rest/encoders_spec.rb
 - spec/acceptance/rest/message_spec.rb
 - spec/acceptance/rest/presence_spec.rb
+- spec/acceptance/rest/push_admin_spec.rb
+- spec/acceptance/rest/push_spec.rb
 - spec/acceptance/rest/stats_spec.rb
 - spec/acceptance/rest/time_spec.rb
 - spec/rspec_config.rb
+- spec/run_parallel_tests
 - spec/shared/client_initializer_behaviour.rb
 - spec/shared/model_behaviour.rb
 - spec/shared/protocol_msgbus_behaviour.rb
@@ -420,6 +469,8 @@ files:
 - spec/unit/models/cipher_params_spec.rb
 - spec/unit/models/connection_details_spec.rb
 - spec/unit/models/connection_state_change_spec.rb
+- spec/unit/models/device_details_spec.rb
+- spec/unit/models/device_push_details_spec.rb
 - spec/unit/models/error_info_spec.rb
 - spec/unit/models/http_paginated_result_spec.rb
 - spec/unit/models/idiomatic_ruby_wrapper_spec.rb
@@ -431,6 +482,7 @@ files:
 - spec/unit/models/paginated_result_spec.rb
 - spec/unit/models/presence_message_spec.rb
 - spec/unit/models/protocol_message_spec.rb
+- spec/unit/models/push_channel_subscription_spec.rb
 - spec/unit/models/stats_spec.rb
 - spec/unit/models/token_details_spec.rb
 - spec/unit/models/token_request_spec.rb
@@ -445,12 +497,14 @@ files:
 - spec/unit/realtime/connection_spec.rb
 - spec/unit/realtime/incoming_message_dispatcher_spec.rb
 - spec/unit/realtime/presence_spec.rb
+- spec/unit/realtime/push_channel_spec.rb
 - spec/unit/realtime/realtime_spec.rb
 - spec/unit/realtime/safe_deferrable_spec.rb
 - spec/unit/realtime/websocket_transport_spec.rb
 - spec/unit/rest/channel_spec.rb
 - spec/unit/rest/channels_spec.rb
 - spec/unit/rest/client_spec.rb
+- spec/unit/rest/push_channel_spec.rb
 - spec/unit/rest/rest_spec.rb
 - spec/unit/util/crypto_spec.rb
 - spec/unit/util/pub_sub_spec.rb
@@ -473,8 +527,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: A Ruby client library for ably.io realtime messaging implemented using EventMachine
@@ -489,6 +542,8 @@ test_files:
 - spec/acceptance/realtime/message_spec.rb
 - spec/acceptance/realtime/presence_history_spec.rb
 - spec/acceptance/realtime/presence_spec.rb
+- spec/acceptance/realtime/push_admin_spec.rb
+- spec/acceptance/realtime/push_spec.rb
 - spec/acceptance/realtime/stats_spec.rb
 - spec/acceptance/realtime/time_spec.rb
 - spec/acceptance/rest/auth_spec.rb
@@ -499,9 +554,12 @@ test_files:
 - spec/acceptance/rest/encoders_spec.rb
 - spec/acceptance/rest/message_spec.rb
 - spec/acceptance/rest/presence_spec.rb
+- spec/acceptance/rest/push_admin_spec.rb
+- spec/acceptance/rest/push_spec.rb
 - spec/acceptance/rest/stats_spec.rb
 - spec/acceptance/rest/time_spec.rb
 - spec/rspec_config.rb
+- spec/run_parallel_tests
 - spec/shared/client_initializer_behaviour.rb
 - spec/shared/model_behaviour.rb
 - spec/shared/protocol_msgbus_behaviour.rb
@@ -525,6 +583,8 @@ test_files:
 - spec/unit/models/cipher_params_spec.rb
 - spec/unit/models/connection_details_spec.rb
 - spec/unit/models/connection_state_change_spec.rb
+- spec/unit/models/device_details_spec.rb
+- spec/unit/models/device_push_details_spec.rb
 - spec/unit/models/error_info_spec.rb
 - spec/unit/models/http_paginated_result_spec.rb
 - spec/unit/models/idiomatic_ruby_wrapper_spec.rb
@@ -536,6 +596,7 @@ test_files:
 - spec/unit/models/paginated_result_spec.rb
 - spec/unit/models/presence_message_spec.rb
 - spec/unit/models/protocol_message_spec.rb
+- spec/unit/models/push_channel_subscription_spec.rb
 - spec/unit/models/stats_spec.rb
 - spec/unit/models/token_details_spec.rb
 - spec/unit/models/token_request_spec.rb
@@ -550,12 +611,14 @@ test_files:
 - spec/unit/realtime/connection_spec.rb
 - spec/unit/realtime/incoming_message_dispatcher_spec.rb
 - spec/unit/realtime/presence_spec.rb
+- spec/unit/realtime/push_channel_spec.rb
 - spec/unit/realtime/realtime_spec.rb
 - spec/unit/realtime/safe_deferrable_spec.rb
 - spec/unit/realtime/websocket_transport_spec.rb
 - spec/unit/rest/channel_spec.rb
 - spec/unit/rest/channels_spec.rb
 - spec/unit/rest/client_spec.rb
+- spec/unit/rest/push_channel_spec.rb
 - spec/unit/rest/rest_spec.rb
 - spec/unit/util/crypto_spec.rb
 - spec/unit/util/pub_sub_spec.rb