ably 0.8.7 → 0.8.8

data/spec/acceptance/rest/auth_spec.rb

@@ -689,12 +689,12 @@ describe Ably::Auth do
             stub_const 'Ably::Models::TokenDetails::TOKEN_EXPIRY_BUFFER', 0
             old_token_defaults = Ably::Auth::TOKEN_DEFAULTS
             stub_const 'Ably::Auth::TOKEN_DEFAULTS', old_token_defaults.merge(renew_token_buffer: 0)
+            @block_called = 0
           end
 
           let(:token_client)   { Ably::Rest::Client.new(default_options.merge(key: api_key, token_params: { ttl: 3 })) }
           let(:client_options) {
             default_options.merge(token: token_client.auth.request_token.token, auth_callback: Proc.new do
-              @block_called ||= 0
               @block_called += 1
               token_client.auth.create_token_request
             end)

data/spec/acceptance/rest/base_spec.rb

@@ -130,7 +130,7 @@ describe Ably::Rest do
           if [1, 3].include?(@publish_attempts)
             { status: 201, :body => '[]', :headers => { 'Content-Type' => 'application/json' } }
           else
-            raise Ably::Exceptions::TokenExpired.new('Authentication failure', 401, 40140)
+            raise Ably::Exceptions::TokenExpired.new('Authentication failure', 401, 40142)
           end
         end
       end

data/spec/shared/safe_deferrable_behaviour.rb

@@ -16,7 +16,7 @@ shared_examples 'a safe Deferrable' do
       subject.errback do |*args|
         expect(args).to eql(arguments)
       end
-      subject.fail *arguments
+      subject.fail(*arguments)
     end
 
     it 'catches exceptions in the callback and logs the error to the logger' do
@@ -34,7 +34,7 @@ shared_examples 'a safe Deferrable' do
         subject.errback  { errback_calls << true }
         subject.callback { success_calls << true }
       end
-      subject.fail *arguments
+      subject.fail(*arguments)
       expect(errback_calls.count).to eql(3)
       expect(success_calls.count).to eql(0)
     end
@@ -45,7 +45,7 @@ shared_examples 'a safe Deferrable' do
       subject.callback do |*args|
         expect(args).to eql(arguments)
       end
-      subject.succeed *arguments
+      subject.succeed(*arguments)
     end
 
     it 'catches exceptions in the callback and logs the error to the logger' do
@@ -63,7 +63,7 @@ shared_examples 'a safe Deferrable' do
         subject.errback  { errback_calls << true }
         subject.callback { success_calls << true }
       end
-      subject.succeed *arguments
+      subject.succeed(*arguments)
       expect(success_calls.count).to eql(3)
       expect(errback_calls.count).to eql(0)
     end

data/spec/unit/models/message_encoders/cipher_spec.rb

@@ -85,7 +85,7 @@ describe Ably::Models::MessageEncoders::Cipher do
         let(:decode_method) { subject.decode message, { encrypted: true, cipher_params: cipher_params } }
 
         it 'raise an exception' do
-          expect { decode_method }.to raise_error Ably::Exceptions::CipherError, /Cipher algorithm [\w\d-]+ does not match message cipher algorithm of AES-128-CBC/
+          expect { decode_method }.to raise_error Ably::Exceptions::CipherError, /Cipher algorithm [\w-]+ does not match message cipher algorithm of AES-128-CBC/
         end
       end
 

data/spec/unit/models/token_details_spec.rb

@@ -23,31 +23,33 @@ describe Ably::Models::TokenDetails do
       end
     end
 
-    { :issued => :issued, :expires => :expires }.each do |method_name, attribute|
+    context do
       let(:time) { Time.now }
-      context "##{method_name} with :#{method_name} option as milliseconds in constructor" do
-        subject { Ably::Models::TokenDetails.new({ attribute.to_sym => time.to_i * 1000 }) }
-
-        it "retrieves attribute :#{attribute} as Time" do
-          expect(subject.public_send(method_name)).to be_a(Time)
-          expect(subject.public_send(method_name).to_i).to eql(time.to_i)
+      { :issued => :issued, :expires => :expires }.each do |method_name, attribute|
+        context "##{method_name} with :#{method_name} option as milliseconds in constructor" do
+          subject { Ably::Models::TokenDetails.new({ attribute.to_sym => time.to_i * 1000 }) }
+
+          it "retrieves attribute :#{attribute} as Time" do
+            expect(subject.public_send(method_name)).to be_a(Time)
+            expect(subject.public_send(method_name).to_i).to eql(time.to_i)
+          end
         end
-      end
 
-      context "##{method_name} with :#{method_name} option as a Time in constructor" do
-        subject { Ably::Models::TokenDetails.new({ attribute.to_sym => time }) }
+        context "##{method_name} with :#{method_name} option as a Time in constructor" do
+          subject { Ably::Models::TokenDetails.new({ attribute.to_sym => time }) }
 
-        it "retrieves attribute :#{attribute} as Time" do
-          expect(subject.public_send(method_name)).to be_a(Time)
-          expect(subject.public_send(method_name).to_i).to eql(time.to_i)
+          it "retrieves attribute :#{attribute} as Time" do
+            expect(subject.public_send(method_name)).to be_a(Time)
+            expect(subject.public_send(method_name).to_i).to eql(time.to_i)
+          end
         end
-      end
 
-      context "##{method_name} when converted to JSON" do
-        subject { Ably::Models::TokenDetails.new({ attribute.to_sym => time }) }
+        context "##{method_name} when converted to JSON" do
+          subject { Ably::Models::TokenDetails.new({ attribute.to_sym => time }) }
 
-        it 'is in milliseconds' do
-          expect(JSON.parse(JSON.dump(subject))[convert_to_mixed_case(attribute)]).to eql((time.to_f * 1000).round)
+          it 'is in milliseconds' do
+            expect(JSON.parse(JSON.dump(subject))[convert_to_mixed_case(attribute)]).to eql((time.to_f * 1000).round)
+          end
         end
       end
     end

data/spec/unit/modules/event_emitter_spec.rb

@@ -75,8 +75,8 @@ describe Ably::Modules::EventEmitter do
           2.times do
             subject.on(:message) do |msg|
               obj.received_message msg
-              subject.on(:message) do |msg|
-                obj.received_message_from_new_callbacks msg
+              subject.on(:message) do |message|
+                obj.received_message_from_new_callbacks message
               end
             end
           end

data/spec/unit/modules/state_emitter_spec.rb

@@ -30,11 +30,11 @@ describe Ably::Modules::StateEmitter do
   end
 
   specify '#state= sets current state' do
-    expect { subject.state = :connecting }.to change { subject.state }.to(:connecting)
+    expect { subject.state = :connecting }.to change { subject.state.to_sym }.to(:connecting)
   end
 
   specify '#change_state sets current state' do
-    expect { subject.change_state :connecting }.to change { subject.state }.to(:connecting)
+    expect { subject.change_state :connecting }.to change { subject.state.to_sym }.to(:connecting)
   end
 
   context '#change_state with arguments' do
@@ -46,7 +46,7 @@ describe Ably::Modules::StateEmitter do
         expect(callback_args).to eql(args)
         callback_status[:called] = true
       end
-      expect { subject.change_state :connecting, *args }.to change { subject.state }.to(:connecting)
+      expect { subject.change_state :connecting, *args }.to change { subject.state.to_sym }.to(:connecting)
       expect(callback_status).to eql(called: true)
     end
   end
@@ -320,13 +320,13 @@ describe Ably::Modules::StateEmitter do
     end
 
     it 'is not called if the state does not change' do
-      subject.once_state_changed &block
+      subject.once_state_changed(&block)
       subject.change_state initial_state
       expect(block_calls.count).to eql(0)
     end
 
     it 'calls the block for any state change once' do
-      subject.once_state_changed &block
+      subject.once_state_changed(&block)
       3.times do
         subject.change_state :connected
         subject.change_state :connecting
@@ -335,7 +335,7 @@ describe Ably::Modules::StateEmitter do
     end
 
     it 'emits arguments to the block' do
-      subject.once_state_changed &block
+      subject.once_state_changed(&block)
       subject.change_state :connected, 1, 2
       expect(block_calls.count).to eql(1)
       expect(block_calls.first).to contain_exactly(1, 2)

data/spec/unit/realtime/channel_spec.rb

@@ -212,25 +212,25 @@ describe Ably::Realtime::Channel do
       end
 
       specify 'with no event name specified unsubscribes that block from all events' do
-        subject.unsubscribe &callback
+        subject.unsubscribe(&callback)
         subject.__incoming_msgbus__.publish(:message, click_message)
         expect(message_history[:received]).to eql(0)
       end
 
       specify 'with a single event name argument unsubscribes the provided block with the matching event name' do
-        subject.unsubscribe click_event, &callback
+        subject.unsubscribe(click_event, &callback)
         subject.__incoming_msgbus__.publish(:message, click_message)
         expect(message_history[:received]).to eql(0)
       end
 
       specify 'with multiple event name arguments unsubscribes each of those matching event names with the provided block' do
-        subject.unsubscribe focus_event, click_event, &callback
+        subject.unsubscribe(focus_event, click_event, &callback)
         subject.__incoming_msgbus__.publish(:message, click_message)
         expect(message_history[:received]).to eql(0)
       end
 
       specify 'with a non-matching event name argument has no effect' do
-        subject.unsubscribe 'move', &callback
+        subject.unsubscribe('move', &callback)
         subject.__incoming_msgbus__.publish(:message, click_message)
         expect(message_history[:received]).to eql(1)
       end

data/spec/unit/realtime/connection_spec.rb

@@ -54,7 +54,7 @@ describe Ably::Realtime::Connection do
       it 'registers a callback' do
         subject.on_resume { callbacks << true }
         additional_proc = proc { raise 'This should not be called' }
-        subject.off_resume &additional_proc
+        subject.off_resume(&additional_proc)
         subject.resumed
         expect(callbacks.count).to eql(1)
       end

data/spec/unit/realtime/presence_spec.rb

@@ -104,31 +104,31 @@ describe Ably::Realtime::Presence do
       end
 
       specify 'with no action specified unsubscribes that block from all events' do
-        subject.unsubscribe &callback
+        subject.unsubscribe(&callback)
         subject.__incoming_msgbus__.publish(:presence, enter_message)
         expect(message_history[:received]).to eql(0)
       end
 
       specify 'with a single action argument unsubscribes the provided block with the matching action' do
-        subject.unsubscribe enter_action, &callback
+        subject.unsubscribe(enter_action, &callback)
         subject.__incoming_msgbus__.publish(:presence, enter_message)
         expect(message_history[:received]).to eql(0)
       end
 
       specify 'with multiple action arguments unsubscribes each of those matching actions with the provided block' do
-        subject.unsubscribe :update, :leave, enter_action, &callback
+        subject.unsubscribe(:update, :leave, enter_action, &callback)
         subject.__incoming_msgbus__.publish(:presence, enter_message)
         expect(message_history[:received]).to eql(0)
       end
 
       specify 'with a non-matching action argument has no effect' do
-        subject.unsubscribe :leave, &callback
+        subject.unsubscribe(:leave, &callback)
         subject.__incoming_msgbus__.publish(:presence, enter_message)
         expect(message_history[:received]).to eql(1)
       end
 
       specify 'with no block argument unsubscribes all blocks for the action argument' do
-        subject.unsubscribe enter_action
+        subject.unsubscribe(enter_action)
         subject.__incoming_msgbus__.publish(:presence, enter_message)
         expect(message_history[:received]).to eql(0)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ably
 version: !ruby/object:Gem::Version
-  version: 0.8.7
+  version: 0.8.8
 platform: ruby
 authors:
 - Lewis Marshall
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-31 00:00:00.000000000 Z
+date: 2016-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -87,14 +87,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: msgpack
   requirement: !ruby/object:Gem::Requirement
@@ -301,7 +301,7 @@ files:
 - lib/ably/models/paginated_result.rb
 - lib/ably/models/presence_message.rb
 - lib/ably/models/protocol_message.rb
-- lib/ably/models/stat.rb
+- lib/ably/models/stats.rb
 - lib/ably/models/stats_types.rb
 - lib/ably/models/token_details.rb
 - lib/ably/models/token_request.rb