ably 0.8.14 → 0.8.15

data/spec/unit/modules/event_emitter_spec.rb

@@ -128,17 +128,34 @@ describe Ably::Modules::EventEmitter do
   end
 
   context '#on' do
-    it 'calls the block every time an event is emitted only' do
-      block_called = 0
-      subject.on('event') { block_called += 1 }
-      3.times { subject.emit 'event', 'data' }
-      expect(block_called).to eql(3)
+    context 'with event specified' do
+      it 'calls the block every time an event is emitted only' do
+        block_called = 0
+        subject.on('event') { block_called += 1 }
+        3.times { subject.emit 'event', 'data' }
+        expect(block_called).to eql(3)
+      end
+
+      it 'catches exceptions in the provided block, logs the error and continues' do
+        expect(subject.logger).to receive(:error).with(/Intentional exception/)
+        subject.on(:event) { raise 'Intentional exception' }
+        subject.emit :event
+      end
     end
 
-    it 'catches exceptions in the provided block, logs the error and continues' do
-      expect(subject.logger).to receive(:error).with(/Intentional exception/)
-      subject.on(:event) { raise 'Intentional exception' }
-      subject.emit :event
+    context 'with no event specified' do
+      it 'calls the block every time an event is emitted only' do
+        block_called = 0
+        subject.on { block_called += 1 }
+        3.times { subject.emit 'event', 'data' }
+        expect(block_called).to eql(3)
+      end
+
+      it 'catches exceptions in the provided block, logs the error and continues' do
+        expect(subject.logger).to receive(:error).with(/Intentional exception/)
+        subject.on { raise 'Intentional exception' }
+        subject.emit :event
+      end
     end
   end
 
@@ -157,25 +174,50 @@ describe Ably::Modules::EventEmitter do
   end
 
   context '#once' do
-    it 'calls the block the first time an event is emitted only' do
-      block_called = 0
-      subject.once('event') { block_called += 1 }
-      3.times { subject.emit 'event', 'data' }
-      expect(block_called).to eql(1)
-    end
+    context 'with event specified' do
+      it 'calls the block the first time an event is emitted only' do
+        block_called = 0
+        subject.once('event') { block_called += 1 }
+        3.times { subject.emit 'event', 'data' }
+        expect(block_called).to eql(1)
+      end
 
-    it 'does not remove other blocks after it is called' do
-      block_called = 0
-      subject.once('event') { block_called += 1 }
-      subject.on('event')   { block_called += 1 }
-      3.times { subject.emit 'event', 'data' }
-      expect(block_called).to eql(4)
+      it 'does not remove other blocks after it is called' do
+        block_called = 0
+        subject.once('event') { block_called += 1 }
+        subject.on('event')   { block_called += 1 }
+        3.times { subject.emit 'event', 'data' }
+        expect(block_called).to eql(4)
+      end
+
+      it 'catches exceptions in the provided block, logs the error and continues' do
+        expect(subject.logger).to receive(:error).with(/Intentional exception/)
+        subject.once(:event) { raise 'Intentional exception' }
+        subject.emit :event
+      end
     end
 
-    it 'catches exceptions in the provided block, logs the error and continues' do
-      expect(subject.logger).to receive(:error).with(/Intentional exception/)
-      subject.once(:event) { raise 'Intentional exception' }
-      subject.emit :event
+    context 'with no event specified' do
+      it 'calls the block the first time an event is emitted only' do
+        block_called = 0
+        subject.once { block_called += 1 }
+        3.times { subject.emit 'event', 'data' }
+        expect(block_called).to eql(1)
+      end
+
+      it 'does not remove other blocks after it is called' do
+        block_called = 0
+        subject.once { block_called += 1 }
+        subject.on   { block_called += 1 }
+        3.times { subject.emit 'event', 'data' }
+        expect(block_called).to eql(4)
+      end
+
+      it 'catches exceptions in the provided block, logs the error and continues' do
+        expect(subject.logger).to receive(:error).with(/Intentional exception/)
+        subject.once { raise 'Intentional exception' }
+        subject.emit :event
+      end
     end
   end
 
@@ -196,41 +238,57 @@ describe Ably::Modules::EventEmitter do
   context '#off' do
     let(:callback) { Proc.new { |msg| obj.received_message msg } }
 
-    before do
-      subject.on(:message, &callback)
-    end
-
-    after do
-      subject.emit :message, msg
-    end
+    context 'with event specified in on handler' do
+      before do
+        subject.on(:message, &callback)
+      end
 
-    context 'with event names as arguments' do
-      it 'deletes matching callbacks' do
-        expect(obj).to_not receive(:received_message).with(msg)
-        subject.off(:message, &callback)
+      after do
+        subject.emit :message, msg
       end
 
-      it 'deletes all callbacks if not block given' do
-        expect(obj).to_not receive(:received_message).with(msg)
-        subject.off(:message)
+      context 'with event names as arguments' do
+        it 'deletes matching callbacks' do
+          expect(obj).to_not receive(:received_message).with(msg)
+          subject.off(:message, &callback)
+        end
+
+        it 'deletes all callbacks if not block given' do
+          expect(obj).to_not receive(:received_message).with(msg)
+          subject.off(:message)
+        end
+
+        it 'continues if the block does not exist' do
+          expect(obj).to receive(:received_message).with(msg)
+          subject.off(:message) { true }
+        end
       end
 
-      it 'continues if the block does not exist' do
-        expect(obj).to receive(:received_message).with(msg)
-        subject.off(:message) { true }
+      context 'without any event names' do
+        it 'deletes all matching callbacks' do
+          expect(obj).to_not receive(:received_message).with(msg)
+          subject.off(&callback)
+        end
+
+        it 'deletes all callbacks if not block given' do
+          expect(obj).to_not receive(:received_message).with(msg)
+          subject.off
+        end
       end
     end
 
-    context 'without any event names' do
-      it 'deletes all matching callbacks' do
-        expect(obj).to_not receive(:received_message).with(msg)
-        subject.off(&callback)
-      end
+    it 'removes handler added with no event specified' do
+      subject.on(&callback)
+      expect(obj).to_not receive(:received_message).with(msg)
+      subject.off(&callback)
+      subject.emit :message, msg
+    end
 
-      it 'deletes all callbacks if not block given' do
-        expect(obj).to_not receive(:received_message).with(msg)
-        subject.off
-      end
+    it 'leaves handler when event specified' do
+      subject.on(&callback)
+      expect(obj).to receive(:received_message).with(msg)
+      subject.off(:foo, &callback)
+      subject.emit :message, msg
     end
   end
 end

data/spec/unit/realtime/presence_spec.rb

@@ -49,13 +49,13 @@ describe Ably::Realtime::Presence do
     let(:message_history) { Hash.new { |hash, key| hash[key] = 0 } }
     let(:enter_action) { Ably::Models::PresenceMessage::ACTION.Enter }
     let(:enter_message) do
-      instance_double('Ably::Models::PresenceMessage', action: enter_action, connection_id: random_str, decode: true, member_key: random_str)
+      instance_double('Ably::Models::PresenceMessage', action: enter_action, connection_id: random_str, decode: true, member_key: random_str, to_safe_json: true)
     end
     let(:leave_message) do
-      instance_double('Ably::Models::PresenceMessage', action: Ably::Models::PresenceMessage::ACTION.Leave, connection_id: random_str, decode: true, member_key: random_str)
+      instance_double('Ably::Models::PresenceMessage', action: Ably::Models::PresenceMessage::ACTION.Leave, connection_id: random_str, decode: true, member_key: random_str, to_safe_json: true)
     end
     let(:update_message) do
-      instance_double('Ably::Models::PresenceMessage', action: Ably::Models::PresenceMessage::ACTION.Update, connection_id: random_str, decode: true, member_key: random_str)
+      instance_double('Ably::Models::PresenceMessage', action: Ably::Models::PresenceMessage::ACTION.Update, connection_id: random_str, decode: true, member_key: random_str, to_safe_json: true)
     end
 
     context '#subscribe' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ably
 version: !ruby/object:Gem::Version
-  version: 0.8.14
+  version: 0.8.15
 platform: ruby
 authors:
 - Lewis Marshall
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2017-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -211,16 +211,16 @@ dependencies:
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -291,6 +291,7 @@ files:
 - lib/ably/models/connection_details.rb
 - lib/ably/models/connection_state_change.rb
 - lib/ably/models/error_info.rb
+- lib/ably/models/http_paginated_response.rb
 - lib/ably/models/idiomatic_ruby_wrapper.rb
 - lib/ably/models/message.rb
 - lib/ably/models/message_encoders/base.rb
@@ -402,6 +403,7 @@ files:
 - spec/unit/models/connection_details_spec.rb
 - spec/unit/models/connection_state_change_spec.rb
 - spec/unit/models/error_info_spec.rb
+- spec/unit/models/http_paginated_result_spec.rb
 - spec/unit/models/idiomatic_ruby_wrapper_spec.rb
 - spec/unit/models/message_encoders/base64_spec.rb
 - spec/unit/models/message_encoders/cipher_spec.rb
@@ -454,7 +456,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: A Ruby client library for ably.io realtime messaging implemented using EventMachine
@@ -503,6 +505,7 @@ test_files:
 - spec/unit/models/connection_details_spec.rb
 - spec/unit/models/connection_state_change_spec.rb
 - spec/unit/models/error_info_spec.rb
+- spec/unit/models/http_paginated_result_spec.rb
 - spec/unit/models/idiomatic_ruby_wrapper_spec.rb
 - spec/unit/models/message_encoders/base64_spec.rb
 - spec/unit/models/message_encoders/cipher_spec.rb
@@ -535,4 +538,3 @@ test_files:
 - spec/unit/rest/rest_spec.rb
 - spec/unit/util/crypto_spec.rb
 - spec/unit/util/pub_sub_spec.rb
-has_rdoc: