ably 0.8.10 → 0.8.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ebdb3de0d61032d4177a8fe51975ac1967e7fe9e
-  data.tar.gz: 5cdaef2668a7e4fd9eac0027115bac896c8438f7
+  metadata.gz: c2940c3999a909ad6243c5c9f7b58577bb754a65
+  data.tar.gz: a26e8dcb896d65db2ac1037fda94229a6cafa0b7
 SHA512:
-  metadata.gz: 4aa4df9755c680ddb24e927bfd82fcce0cb8909bad91b8d91e367a1d14b14ff3accc83dd4c668e4dec0a734be9ef82e56c8eb31f2d20f6b71bec8432ca1082ab
-  data.tar.gz: 8dc667ac95090f550e9606fac468f89f4029979955967da6aba5b31ded8ac7a3d3be24c40b6f2074a519ff8aae52e038bb5d983c5cc11b2122ccadd43267482f
+  metadata.gz: 17a1afa89167265c13c1f63ed0a534f8af6cfbe799684cdac328331e24fe33851341cc5ac2ff214feb8fa5092ec6d461eb8c8d37e56032b870e294bca32c3d4b
+  data.tar.gz: c69805bf390839041e2d82283e0aedc1d22baa181386deeb870f267093f235d97419399c246fa7ed04dedd22c4430b6ec8f22f5325d2890559c12619fbb48c66

data/lib/ably/modules/message_emitter.rb

@@ -4,6 +4,9 @@ module Ably::Modules
   # Message emitter, subscriber and unsubscriber (Pub/Sub) functionality common to Channels and Presence
   # In addition to standard Pub/Sub functionality, it allows subscribers to subscribe to :all.
   module MessageEmitter
+
+    include Ably::Modules::SafeYield
+
     # Subscribe to events on this object
     #
     # @param names [String,Symbol] Optional, the event name(s) to subscribe to. Defaults to `:all` events
@@ -50,8 +53,8 @@ module Ably::Modules
     #
     # @api private
     def emit_message(name, payload)
-      message_emitter_subscriptions[:all].each { |cb| cb.call(payload) }
-      message_emitter_subscriptions[name].each { |cb| cb.call(payload) } if name
+      message_emitter_subscriptions[:all].each { |cb| safe_yield(cb, payload) }
+      message_emitter_subscriptions[name].each { |cb| safe_yield(cb, payload) } if name
     end
 
     private

data/lib/ably/version.rb

@@ -1,3 +1,3 @@
 module Ably
-  VERSION = '0.8.10'
+  VERSION = '0.8.11'
 end

data/spec/acceptance/realtime/channel_spec.rb

@@ -908,6 +908,25 @@ describe Ably::Realtime::Channel, :event_machine do
         end
       end
 
+      context 'with a callback that raises an exception' do
+        let(:exception) { StandardError.new("Intentional error") }
+
+        it 'logs the error and continues' do
+          emitted_exception = false
+          expect(client.logger).to receive(:error).with(/#{exception.message}/)
+          channel.subscribe('click') do |message|
+            emitted_exception = true
+            raise exception
+          end
+          channel.publish('click', 'data') do
+            EventMachine.add_timer(1) do
+              expect(emitted_exception).to eql(true)
+              stop_reactor
+            end
+          end
+        end
+      end
+
       context 'many times with different event names' do
         it 'filters events accordingly to each callback' do
           click_callback = proc { |message| messages << message }

data/spec/acceptance/realtime/presence_spec.rb

@@ -1463,6 +1463,25 @@ describe Ably::Realtime::Presence, :event_machine do
           stop_reactor
         end
       end
+
+      context 'with a callback that raises an exception' do
+        let(:exception) { StandardError.new("Intentional error") }
+
+        it 'logs the error and continues' do
+          emitted_exception = false
+          expect(client_one.logger).to receive(:error).with(/#{exception.message}/)
+          presence_client_one.subscribe do |presence_message|
+            emitted_exception = true
+            raise exception
+          end
+          presence_client_one.enter do
+            EventMachine.add_timer(1) do
+              expect(emitted_exception).to eql(true)
+              stop_reactor
+            end
+          end
+        end
+      end
     end
 
     context '#unsubscribe' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ably
 version: !ruby/object:Gem::Version
-  version: 0.8.10
+  version: 0.8.11
 platform: ruby
 authors:
 - Lewis Marshall
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-01 00:00:00.000000000 Z
+date: 2016-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine