ably 0.6.2 → 0.7.0

data/spec/unit/rest/rest_spec.rb

@@ -0,0 +1,10 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Ably::Rest do
+  let(:options) { { api_key: 'app.key:secret' } }
+
+  specify 'constructor returns an Ably::Rest::Client' do
+    expect(Ably::Rest.new(options)).to be_instance_of(Ably::Rest::Client)
+  end
+end

data/spec/unit/util/crypto_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'msgpack'
 
 describe Ably::Util::Crypto do
-  let(:seret_key)  { SecureRandom.hex }
+  let(:seret_key)  { random_str }
   let(:cipher_options) { { key: seret_key } }
   subject { Ably::Util::Crypto.new(cipher_options) }
 
@@ -22,10 +22,15 @@ describe Ably::Util::Crypto do
   end
 
   context 'encrypts & decrypt' do
-    let(:string) { SecureRandom.hex }
-    let(:byte_array) { SecureRandom.hex.to_msgpack.unpack('C*') }
+    let(:string) { random_str }
+    let(:byte_array) { random_str.to_msgpack.unpack('C*') }
 
-    specify 'a string' do
+    specify '#encrypt encrypts a string' do
+      encrypted = subject.encrypt(string)
+      expect(subject.decrypt(encrypted)).to eql(string)
+    end
+
+    specify '#decrypt decrypts a string' do
       encrypted = subject.encrypt(string)
       expect(subject.decrypt(encrypted)).to eql(string)
     end
@@ -34,7 +39,7 @@ describe Ably::Util::Crypto do
   context 'encrypting an empty string' do
     let(:empty_string) { '' }
 
-    it 'raises an ErgumentError' do
+    it 'raises an ArgumentError' do
       expect { subject.encrypt(empty_string) }.to raise_error ArgumentError, /data must not be empty/
     end
   end

data/spec/unit/util/pub_sub_spec.rb

@@ -8,7 +8,7 @@ describe Ably::Util::PubSub do
   subject { Ably::Util::PubSub.new(options) }
 
   context 'event fan out' do
-    specify 'allows publishing to more than on subscriber' do
+    specify '#publish allows publishing to more than on subscriber' do
       expect(obj).to receive(:received_message).with(msg).twice
       2.times do
         subject.subscribe(:message) { |msg| obj.received_message msg }
@@ -16,7 +16,7 @@ describe Ably::Util::PubSub do
       subject.publish :message, msg
     end
 
-    it 'sends only messages to matching event names' do
+    it '#publish sends only messages to #subscribe callbacks matching event names' do
       expect(obj).to receive(:received_message).with(msg).once
       subject.subscribe(:valid) { |msg| obj.received_message msg }
       subject.publish :valid, msg
@@ -24,7 +24,7 @@ describe Ably::Util::PubSub do
       subject.publish 'valid', msg
     end
 
-    context 'with coercion' do
+    context 'with coercion', api_private: true do
       let(:options) do
         { coerce_into: Proc.new { |event| String(event) } }
       end
@@ -48,7 +48,7 @@ describe Ably::Util::PubSub do
       end
     end
 
-    context 'without coercion' do
+    context 'without coercion', api_private: true do
       it 'only matches event names on type matches' do
         expect(obj).to_not receive(:received_message).with(msg)
         subject.subscribe('valid') { |msg| obj.received_message msg }
@@ -57,7 +57,7 @@ describe Ably::Util::PubSub do
     end
   end
 
-  context '#off' do
+  context '#unsubscribe' do
     let(:callback) { Proc.new { |msg| obj.received_message msg } }
 
     before do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ably
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.0
 platform: ruby
 authors:
 - Lewis Marshall
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-10 00:00:00.000000000 Z
+date: 2015-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -143,14 +143,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -188,11 +188,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".ruby-version.old"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- SPEC.md
 - ably.gemspec
 - lib/ably.rb
 - lib/ably/auth.rb
@@ -206,10 +209,12 @@ files:
 - lib/ably/models/message_encoders/cipher.rb
 - lib/ably/models/message_encoders/json.rb
 - lib/ably/models/message_encoders/utf8.rb
+- lib/ably/models/nil_logger.rb
 - lib/ably/models/paginated_resource.rb
 - lib/ably/models/presence_message.rb
 - lib/ably/models/protocol_message.rb
 - lib/ably/models/token.rb
+- lib/ably/modules/ably.rb
 - lib/ably/modules/async_wrapper.rb
 - lib/ably/modules/channels_collection.rb
 - lib/ably/modules/conversions.rb
@@ -221,8 +226,13 @@ files:
 - lib/ably/modules/message_pack.rb
 - lib/ably/modules/model_common.rb
 - lib/ably/modules/state_emitter.rb
+- lib/ably/modules/state_machine.rb
+- lib/ably/modules/statesman_monkey_patch.rb
+- lib/ably/modules/uses_state_machine.rb
 - lib/ably/realtime.rb
 - lib/ably/realtime/channel.rb
+- lib/ably/realtime/channel/channel_manager.rb
+- lib/ably/realtime/channel/channel_state_machine.rb
 - lib/ably/realtime/channels.rb
 - lib/ably/realtime/client.rb
 - lib/ably/realtime/client/incoming_message_dispatcher.rb
@@ -250,6 +260,8 @@ files:
 - lib/ably/version.rb
 - spec/acceptance/realtime/channel_history_spec.rb
 - spec/acceptance/realtime/channel_spec.rb
+- spec/acceptance/realtime/client_spec.rb
+- spec/acceptance/realtime/connection_failures_spec.rb
 - spec/acceptance/realtime/connection_spec.rb
 - spec/acceptance/realtime/message_spec.rb
 - spec/acceptance/realtime/presence_history_spec.rb
@@ -260,21 +272,27 @@ files:
 - spec/acceptance/rest/base_spec.rb
 - spec/acceptance/rest/channel_spec.rb
 - spec/acceptance/rest/channels_spec.rb
+- spec/acceptance/rest/client_spec.rb
+- spec/acceptance/rest/encoders_spec.rb
 - spec/acceptance/rest/message_spec.rb
 - spec/acceptance/rest/presence_spec.rb
 - spec/acceptance/rest/stats_spec.rb
 - spec/acceptance/rest/time_spec.rb
-- spec/integration/modules/state_emitter_spec.rb
-- spec/integration/rest/auth.rb
 - spec/resources/crypto-data-128.json
 - spec/resources/crypto-data-256.json
 - spec/rspec_config.rb
+- spec/shared/client_initializer_behaviour.rb
+- spec/shared/model_behaviour.rb
+- spec/shared/protocol_msgbus_behaviour.rb
 - spec/spec_helper.rb
 - spec/support/api_helper.rb
 - spec/support/event_machine_helper.rb
-- spec/support/model_helper.rb
-- spec/support/protocol_msgbus_helper.rb
+- spec/support/markdown_spec_formatter.rb
+- spec/support/private_api_formatter.rb
+- spec/support/protocol_helper.rb
+- spec/support/random_helper.rb
 - spec/support/test_app.rb
+- spec/unit/auth_spec.rb
 - spec/unit/logger_spec.rb
 - spec/unit/models/error_info_spec.rb
 - spec/unit/models/idiomatic_ruby_wrapper_spec.rb
@@ -291,6 +309,7 @@ files:
 - spec/unit/modules/conversions_spec.rb
 - spec/unit/modules/enum_spec.rb
 - spec/unit/modules/event_emitter_spec.rb
+- spec/unit/modules/state_emitter_spec.rb
 - spec/unit/realtime/channel_spec.rb
 - spec/unit/realtime/channels_spec.rb
 - spec/unit/realtime/client_spec.rb
@@ -299,8 +318,10 @@ files:
 - spec/unit/realtime/presence_spec.rb
 - spec/unit/realtime/realtime_spec.rb
 - spec/unit/realtime/websocket_transport_spec.rb
+- spec/unit/rest/channel_spec.rb
 - spec/unit/rest/channels_spec.rb
 - spec/unit/rest/client_spec.rb
+- spec/unit/rest/rest_spec.rb
 - spec/unit/util/crypto_spec.rb
 - spec/unit/util/pub_sub_spec.rb
 homepage: http://github.com/ably/ably-ruby
@@ -330,6 +351,8 @@ summary: A Ruby client library for ably.io, the real-time messaging service
 test_files:
 - spec/acceptance/realtime/channel_history_spec.rb
 - spec/acceptance/realtime/channel_spec.rb
+- spec/acceptance/realtime/client_spec.rb
+- spec/acceptance/realtime/connection_failures_spec.rb
 - spec/acceptance/realtime/connection_spec.rb
 - spec/acceptance/realtime/message_spec.rb
 - spec/acceptance/realtime/presence_history_spec.rb
@@ -340,21 +363,27 @@ test_files:
 - spec/acceptance/rest/base_spec.rb
 - spec/acceptance/rest/channel_spec.rb
 - spec/acceptance/rest/channels_spec.rb
+- spec/acceptance/rest/client_spec.rb
+- spec/acceptance/rest/encoders_spec.rb
 - spec/acceptance/rest/message_spec.rb
 - spec/acceptance/rest/presence_spec.rb
 - spec/acceptance/rest/stats_spec.rb
 - spec/acceptance/rest/time_spec.rb
-- spec/integration/modules/state_emitter_spec.rb
-- spec/integration/rest/auth.rb
 - spec/resources/crypto-data-128.json
 - spec/resources/crypto-data-256.json
 - spec/rspec_config.rb
+- spec/shared/client_initializer_behaviour.rb
+- spec/shared/model_behaviour.rb
+- spec/shared/protocol_msgbus_behaviour.rb
 - spec/spec_helper.rb
 - spec/support/api_helper.rb
 - spec/support/event_machine_helper.rb
-- spec/support/model_helper.rb
-- spec/support/protocol_msgbus_helper.rb
+- spec/support/markdown_spec_formatter.rb
+- spec/support/private_api_formatter.rb
+- spec/support/protocol_helper.rb
+- spec/support/random_helper.rb
 - spec/support/test_app.rb
+- spec/unit/auth_spec.rb
 - spec/unit/logger_spec.rb
 - spec/unit/models/error_info_spec.rb
 - spec/unit/models/idiomatic_ruby_wrapper_spec.rb
@@ -371,6 +400,7 @@ test_files:
 - spec/unit/modules/conversions_spec.rb
 - spec/unit/modules/enum_spec.rb
 - spec/unit/modules/event_emitter_spec.rb
+- spec/unit/modules/state_emitter_spec.rb
 - spec/unit/realtime/channel_spec.rb
 - spec/unit/realtime/channels_spec.rb
 - spec/unit/realtime/client_spec.rb
@@ -379,8 +409,10 @@ test_files:
 - spec/unit/realtime/presence_spec.rb
 - spec/unit/realtime/realtime_spec.rb
 - spec/unit/realtime/websocket_transport_spec.rb
+- spec/unit/rest/channel_spec.rb
 - spec/unit/rest/channels_spec.rb
 - spec/unit/rest/client_spec.rb
+- spec/unit/rest/rest_spec.rb
 - spec/unit/util/crypto_spec.rb
 - spec/unit/util/pub_sub_spec.rb
 has_rdoc: 

data/spec/integration/modules/state_emitter_spec.rb

@@ -1,80 +0,0 @@
-require 'spec_helper'
-
-describe Ably::Modules::StateEmitter do
-  class ExampleStateWithEventEmitter
-    include Ably::Modules::EventEmitter
-    extend  Ably::Modules::Enum
-
-    STATE = ruby_enum('STATE',
-      :initializing,
-      :connecting,
-      :connected,
-      :disconnected
-    )
-    include Ably::Modules::StateEmitter
-
-    def initialize
-      @state = :initializing
-    end
-  end
-
-  let(:initial_state) { :initializing }
-
-  subject { ExampleStateWithEventEmitter.new }
-
-  specify '#state returns current state' do
-    expect(subject.state).to eq(:initializing)
-  end
-
-  specify '#state= sets current state' do
-    expect { subject.state = :connecting }.to change { subject.state }.to(:connecting)
-  end
-
-  specify '#change_state sets current state' do
-    expect { subject.change_state :connecting }.to change { subject.state }.to(:connecting)
-  end
-
-  context '#change_state with arguments' do
-    let(:args) { [5,3,1] }
-    let(:callback_status) { { called: false } }
-
-    it 'passes the arguments through to the triggered callback' do
-      subject.on(:connecting) do |*callback_args|
-        expect(callback_args).to eql(args)
-        callback_status[:called] = true
-      end
-      expect { subject.change_state :connecting, *args }.to change { subject.state }.to(:connecting)
-      expect(callback_status).to eql(called: true)
-    end
-  end
-
-  context '#state?' do
-    it 'returns true if state matches' do
-      expect(subject.state?(initial_state)).to eql(true)
-    end
-
-    it 'returns false if state does not match' do
-      expect(subject.state?(:connecting)).to eql(false)
-    end
-
-    context 'and convenience predicates for states' do
-      it 'returns true if state matches' do
-        expect(subject.initializing?).to eql(true)
-      end
-
-      it 'returns false if state does not match' do
-        expect(subject.connecting?).to eql(false)
-      end
-    end
-  end
-
-  context '#state STATE coercion' do
-    it 'allows valid STATE values' do
-      expect { subject.state = :connected }.to_not raise_error
-    end
-
-    it 'prevents invalid STATE values' do
-      expect { subject.state = :invalid }.to raise_error KeyError
-    end
-  end
-end

data/spec/integration/rest/auth.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe Ably::Auth do
-  let(:client) { Ably::Rest::Client.new(key_id: 'id', key_secret: 'secret') }
-
-  it 'has immutable options' do
-    expect { client.auth.options['key_id'] = 'new_id' }.to raise_error RuntimeError, /can't modify frozen Hash/
-  end
-end