ably-rest 1.1.4.rc → 1.1.7

data/lib/submodules/ably-ruby/spec/unit/realtime/incoming_message_dispatcher_spec.rb

@@ -32,5 +32,43 @@ describe Ably::Realtime::Client::IncomingMessageDispatcher, :api_private do
       expect(subject).to receive_message_chain(:logger, :warn)
       msgbus.publish :protocol_message, Ably::Models::ProtocolMessage.new(:action => :attached, channel: 'unknown')
     end
+
+    context 'TO3l8' do
+      context 'on action presence' do
+        let(:presence) { 101.times.map { { data: 'x' * 655 } } }
+
+        let(:protocol_message) do
+          Ably::Models::ProtocolMessage.new(action: :presence, channel: 'default', presence: presence, connection_serial: 123123123)
+        end
+
+        it 'should raise a protocol error when message size exceeded 65536 bytes' do
+          allow(connection).to receive(:serial).and_return(12312312)
+          allow(subject).to receive(:update_connection_recovery_info)
+          allow(subject).to receive_message_chain(:logger, :debug)
+          allow(subject).to receive_message_chain(:logger, :warn)
+          expect(subject).to receive_message_chain(:logger, :fatal)
+
+          msgbus.publish :protocol_message, protocol_message
+        end
+      end
+
+      context 'on action message' do
+        let(:messages) { 101.times.map { { data: 'x' * 655 } } }
+
+        let(:protocol_message) do
+          Ably::Models::ProtocolMessage.new(action: :message, channel: 'default', messages: messages, connection_serial: 123123123)
+        end
+
+        it 'should raise a protocol error when message size exceeded 65536 bytes' do
+          allow(connection).to receive(:serial).and_return(12312312)
+          allow(subject).to receive(:update_connection_recovery_info)
+          allow(subject).to receive_message_chain(:logger, :debug)
+          allow(subject).to receive_message_chain(:logger, :warn)
+          expect(subject).to receive_message_chain(:logger, :fatal)
+
+          msgbus.publish :protocol_message, protocol_message
+        end
+      end
+    end
   end
 end

data/lib/submodules/ably-ruby/spec/unit/rest/channel_spec.rb

@@ -14,6 +14,10 @@ describe Ably::Rest::Channel do
 
   subject { Ably::Rest::Channel.new(client, channel_name) }
 
+  it 'should return Ably::Rest::Channel::MAX_MESSAGE_SIZE equal 65536 (TO3l8)' do
+    expect(Ably::Rest::Channel::MAX_MESSAGE_SIZE).to eq(65536)
+  end
+
   describe '#initializer' do
     let(:channel_name) { random_str.encode(encoding) }
 
@@ -126,5 +130,11 @@ describe Ably::Rest::Channel do
         expect { subject.publish(encoded_value, 'data') }.to raise_error ArgumentError, /must be a String/
       end
     end
+
+    context 'max message size exceeded' do
+      it 'should raise Ably::Exceptions::MaxMessageSizeExceeded' do
+        expect { subject.publish('x' * 65537, 'data') }.to raise_error Ably::Exceptions::MaxMessageSizeExceeded
+      end
+    end
   end
 end

data/lib/submodules/ably-ruby/spec/unit/rest/client_spec.rb

@@ -38,6 +38,26 @@ describe Ably::Rest::Client do
       end
     end
 
+    context 'use agent' do
+      context 'set agent to non-default value' do
+        context 'default agent' do
+          let(:client_options) { { key: 'appid.keyuid:keysecret' } }
+
+          it 'should return default ably agent' do
+            expect(subject.agent).to eq(Ably::AGENT)
+          end
+        end
+
+        context 'custom agent' do
+          let(:client_options) { { key: 'appid.keyuid:keysecret', agent: 'example-gem/1.1.4 ably-ruby/1.1.5 ruby/3.0.0' } }
+
+          it 'should overwrite client.agent' do
+            expect(subject.agent).to eq('example-gem/1.1.4 ably-ruby/1.1.5 ruby/3.0.0')
+          end
+        end
+      end
+    end
+
     context ':use_token_auth' do
       context 'set to false' do
         context 'with a key and :tls => false' do

data/spec/spec_helper.rb

@@ -15,6 +15,11 @@ require 'support/private_api_formatter'
 require 'support/protocol_helper'
 require 'support/random_helper'
 require 'support/test_logger_helper'
+require 'support/serialization_helper'
+
+RSpec.configure do |config|
+  config.include SerializationHelper
+end
 
 # Load in all shared behaviours
 Dir.glob(File.expand_path("../lib/submodules/ably-ruby/spec/shared/*.rb", File.dirname(__FILE__))).each do |file|

data/spec/unit/client_spec.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Ably::Rest::Client do
+  subject do
+    Ably::Rest::Client.new(client_options)
+  end
+
+  context 'initializer options' do
+    context 'default agent' do
+      let(:client_options) { { key: 'appid.keyuid:keysecret' } }
+
+      it 'should return Ably::AGENT identifier' do
+        expect(subject.agent).to eq(Ably::AGENT)
+      end
+
+      it 'should show ably-ruby ruby and ably-ruby-rest identifier' do
+        expect(subject.agent).to match(/^ably-ruby\/\d.\d.\d ruby\/\d.\d.\d ably-ruby-rest$/)
+      end
+    end
+
+    context 'custom agent' do
+      let(:client_options) { { key: 'appid.keyuid:keysecret', agent: 'my-custom-agent/1.1' } }
+
+      it 'should show my-custom-agent/1.1' do
+        expect(subject.agent).to eq('my-custom-agent/1.1')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ably-rest
 version: !ruby/object:Gem::Version
-  version: 1.1.4.rc
+  version: 1.1.7
 platform: ruby
 authors:
 - Matthew O'Riordan
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-16 00:00:00.000000000 Z
+date: 2021-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: excon
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.55'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.55'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
@@ -81,33 +95,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 2.0.0
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.1
+        version: '11.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.1
+        version: '11.3'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
@@ -128,28 +142,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.10.0
+        version: 3.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.10.0
+        version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: rspec-retry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.4'
+- !ruby/object:Gem::Dependency
+  name: webrick
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -235,6 +263,7 @@ files:
 - CHANGELOG.md
 - Gemfile
 - LICENSE
+- MAINTAINERS.md
 - README.md
 - Rakefile
 - SPEC.md
@@ -242,18 +271,21 @@ files:
 - lib/ably-rest.rb
 - lib/ably-rest/modules/eventmachine_deferrable.rb
 - lib/submodules/ably-ruby/.editorconfig
+- lib/submodules/ably-ruby/.github/workflows/check.yml
 - lib/submodules/ably-ruby/.gitignore
 - lib/submodules/ably-ruby/.gitmodules
 - lib/submodules/ably-ruby/.rspec
-- lib/submodules/ably-ruby/.travis.yml
 - lib/submodules/ably-ruby/CHANGELOG.md
+- lib/submodules/ably-ruby/COPYRIGHT
 - lib/submodules/ably-ruby/Gemfile
 - lib/submodules/ably-ruby/LICENSE
+- lib/submodules/ably-ruby/MAINTAINERS.md
 - lib/submodules/ably-ruby/README.md
 - lib/submodules/ably-ruby/Rakefile
 - lib/submodules/ably-ruby/SPEC.md
 - lib/submodules/ably-ruby/ably.gemspec
 - lib/submodules/ably-ruby/lib/ably.rb
+- lib/submodules/ably-ruby/lib/ably/agent.rb
 - lib/submodules/ably-ruby/lib/ably/auth.rb
 - lib/submodules/ably-ruby/lib/ably/exceptions.rb
 - lib/submodules/ably-ruby/lib/ably/logger.rb
@@ -305,6 +337,7 @@ files:
 - lib/submodules/ably-ruby/lib/ably/realtime/auth.rb
 - lib/submodules/ably-ruby/lib/ably/realtime/channel.rb
 - lib/submodules/ably-ruby/lib/ably/realtime/channel/channel_manager.rb
+- lib/submodules/ably-ruby/lib/ably/realtime/channel/channel_properties.rb
 - lib/submodules/ably-ruby/lib/ably/realtime/channel/channel_state_machine.rb
 - lib/submodules/ably-ruby/lib/ably/realtime/channel/publisher.rb
 - lib/submodules/ably-ruby/lib/ably/realtime/channel/push_channel.rb
@@ -388,6 +421,7 @@ files:
 - lib/submodules/ably-ruby/spec/support/protocol_helper.rb
 - lib/submodules/ably-ruby/spec/support/random_helper.rb
 - lib/submodules/ably-ruby/spec/support/rest_testapp_before_retry.rb
+- lib/submodules/ably-ruby/spec/support/serialization_helper.rb
 - lib/submodules/ably-ruby/spec/support/test_app.rb
 - lib/submodules/ably-ruby/spec/support/test_logger_helper.rb
 - lib/submodules/ably-ruby/spec/unit/auth_spec.rb
@@ -439,6 +473,7 @@ files:
 - spec/acceptance/rest_spec.rb
 - spec/spec_helper.rb
 - spec/unit/base_spec.rb
+- spec/unit/client_spec.rb
 - spec/unit/models_spec.rb
 - spec/unit/modules_spec.rb
 - spec/unit/rest_spec.rb
@@ -447,7 +482,7 @@ homepage: http://github.com/ably/ably-ruby-rest
 licenses:
 - Apache 2
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -458,18 +493,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: A Ruby REST only client library for ably.io realtime messaging
 test_files:
 - spec/acceptance/rest_spec.rb
 - spec/spec_helper.rb
 - spec/unit/base_spec.rb
+- spec/unit/client_spec.rb
 - spec/unit/models_spec.rb
 - spec/unit/modules_spec.rb
 - spec/unit/rest_spec.rb

data/lib/submodules/ably-ruby/.travis.yml

@@ -1,18 +0,0 @@
-env:
-  - RSPEC_RETRY=true PARALLEL_TEST_PROCESSORS=2 PROTOCOL=json
-  - RSPEC_RETRY=true PARALLEL_TEST_PROCESSORS=2 PROTOCOL=msgpack
-language: ruby
-rvm:
-  - 1.9.3
-  - 2.1.10
-  - 2.2.10
-  - 2.3.8
-  - 2.5.5
-  - 2.6.0
-  - 2.6.1
-  - 2.6.2
-  - 2.6.3
-script: spec/run_parallel_tests
-notifications:
-  slack:
-    secure: Xe8MwDcV2C8XLGk6O6Co31LpQiRSxsmS7Toy5vM7rHds5fnVRBNn5iX6Q5mXMdLOlnsMhjKLt7zl4fsBOZv+siQ+Us0omZSIYpXCYSCIj8nofReF0Lj8M4oa6lFSL5OuygO7PH+wLKTRxQURGZ6Pi1nHU+RE5izRmsewQHkhtY0=