abizvn-clients 0.1.0 → 0.2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef742b6a267f3681db526125dcd92b3debea320184a198fb6f8a6c8814e039f8
-  data.tar.gz: ea321c3605284a566af605fa9f63db5949339507216131727c80097117630b0d
+  metadata.gz: 34d7b9c57ab919d849a9df3baf5545748e50a76ae84fba272267bf7e35f83d80
+  data.tar.gz: aa093abfd3d327fc6aee9224bfd758e626fb11377be8447cae481217797c5e0d
 SHA512:
-  metadata.gz: ab72146c6ef395db0bfd93d9388cd49733aee584aabe084e4ae9470ac271ecc693177a80ad60d699d7084bf6f2994fa5e400b5a10f70df9ba6c83280dbecf740
-  data.tar.gz: b218fedc33357fe0fa882460a8a4c2443ff5d15267267b6fa996a1915f577d7e9c57c7d6f679a1ae3cf59c42928c56df3299160223deafa640b4c743acbb4181
+  metadata.gz: d13429a774a5920a95d161b54e63c315f091df0ae55a6cfe96670dbc0b6d6633cf2051ab54615be0584e2228418f72c770b11cc91a55227cdba0d4799e0431f3
+  data.tar.gz: 369833ead7ee61d1a34a8af8c49d3d84681d367a2b11398b302ff055d0b72fcd51af79804cc1b1901759e5d8f26e9a5cc4e4f8c24bf5df2c8858cee1499ae020

data/app/models/abizvn/clients/client.rb

@@ -8,7 +8,7 @@ module Abizvn
       has_many :domains, class_name: 'Abizvn::Clients::Domain', foreign_key: :client_id
       accepts_nested_attributes_for :domains, allow_destroy: true
 
-      validates :admin_user_email, presence: true, uniqueness: { case_sensitive: false }, 'valid_email_2/email': true
+      validates :admin_user_email, presence: true, 'valid_email_2/email': true
 
       validates :name, presence: true, uniqueness: { case_sensitive: false }, length: { maximum: 128 }
       validates :contact_email, 'valid_email_2/email': true

data/app/models/abizvn/clients/domain.rb

@@ -5,7 +5,7 @@ module Abizvn
       
       self.table_name = 'clients_management_domains'
 
-      belongs_to :client, class_name: 'Abizvn::Clients::Client', foreign_key: 'client_id'
+      belongs_to :client, class_name: 'Abizvn::Clients::Client', foreign_key: 'client_id', optional: true
 
       validates :name, presence: true, uniqueness: { case_sensitive: false }, length: { maximum: 255 }
     end

data/db/migrate/20250311104419_update_domains_client_to_optional.rb

@@ -0,0 +1,5 @@
+class UpdateDomainsClientToOptional < ActiveRecord::Migration[7.2]
+  def change
+    change_column_null :clients_management_domains, :client_id, true
+  end
+end

data/db/migrate/20250311111640_remove_unique_for_admin_user_email_on_clients.rb

@@ -0,0 +1,5 @@
+class RemoveUniqueForAdminUserEmailOnClients < ActiveRecord::Migration[7.2]
+  def change
+    remove_index :clients_management_clients, :admin_user_email
+  end
+end

data/lib/abizvn/clients/version.rb

@@ -1,5 +1,5 @@
 module Abizvn
   module Clients
-    VERSION = "0.1.0"
+    VERSION = "0.2.0.1"
   end
 end

data/spec/factories/abizvn/clients/clients.rb

@@ -0,0 +1,6 @@
+FactoryBot.define do
+  factory :client, class: 'Abizvn::Clients::Client' do
+    sequence(:name) { |n| "Test Name #{n}" }
+    sequence(:admin_user_email) { |n| "admin#{n}@example.com" }
+  end
+end

data/spec/factories/abizvn/clients/domains.rb

@@ -0,0 +1,7 @@
+FactoryBot.define do
+  factory :domain, class: 'Abizvn::Clients::Domain' do
+    sequence(:name) { |n| "subdomain#{n}.example.com" }
+    
+    association :client, factory: :client
+  end
+end

data/spec/models/abizvn/clients/client_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+RSpec.describe Abizvn::Clients::Client, type: :model do
+  describe "validations" do
+    context 'name validations' do
+      before { FactoryBot.create(:client) }
+
+      it { should validate_presence_of(:name) }
+      it { should validate_uniqueness_of(:name).case_insensitive }
+      it { should validate_length_of(:name).is_at_most(128) }
+    end
+
+    context 'email fields validations' do
+      it { should validate_presence_of(:admin_user_email) }
+
+      invalid_samples = ['invalid_email', 'invalid@email', 'invalid@email@com'].each do |sample|
+        it { should_not allow_value(sample).for(:admin_user_email) }
+        it { should_not allow_value(sample).for(:contact_email) }
+      end
+  
+      valid_samples = ['valid@example.com', 'valid_123@example.com', 'valid@sub.example.com'].each do |sample|
+        it { should allow_value(sample).for(:admin_user_email) }
+        it { should allow_value(sample).for(:contact_email) }
+      end
+    end
+    
+    context 'contact_phone_number' do
+      it 'is valid when blank' do
+        model = FactoryBot.build(:client, contact_phone_number: nil)
+        expect(model).to be_valid
+        model = FactoryBot.build(:client, contact_phone_number: "")
+        expect(model).to be_valid
+      end
+
+      it 'is valid with a possible phone number' do
+        model = FactoryBot.build(:client, contact_phone_number: '+15551234567')
+        expect(model).to be_valid
+      end
+
+      it 'is invalid with an impossible phone number' do
+        model = FactoryBot.build(:client, contact_phone_number: '123')
+        expect(model).not_to be_valid
+        expect(model.errors[:contact_phone_number]).to include('is invalid')
+      end
+
+      it 'is invalid with a badly formatted phone number' do
+        model = FactoryBot.build(:client, contact_phone_number: 'abcde')
+        expect(model).not_to be_valid
+        expect(model.errors[:contact_phone_number]).to include('is invalid')
+      end
+    end
+  end
+
+  describe 'associations' do
+    it { should have_many(:domains) }
+  end
+
+end

data/spec/models/abizvn/clients/domain_spec.rb

@@ -0,0 +1,15 @@
+require 'rails_helper'
+
+RSpec.describe Abizvn::Clients::Domain, type: :model do
+  describe "validations" do
+    before { FactoryBot.create(:domain) }
+
+    it { should validate_presence_of(:name) }
+    it { should validate_uniqueness_of(:name).case_insensitive }
+    it { should validate_length_of(:name).is_at_most(255) }
+  end
+
+  describe 'associations' do
+    it { should belong_to(:client).optional }
+  end
+end

data/spec/rails_helper.rb

@@ -0,0 +1,81 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+require 'spec_helper'
+ENV['RAILS_ENV'] ||= 'test'
+require_relative '../spec/dummy/config/environment'
+# Prevent database truncation if the environment is production
+abort("The Rails environment is running in production mode!") if Rails.env.production?
+# Uncomment the line below in case you have `--require rails_helper` in the `.rspec` file
+# that will avoid rails generators crashing because migrations haven't been run yet
+# return unless Rails.env.test?
+require 'rspec/rails'
+# Add additional requires below this line. Rails is not loaded until this point!
+
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+#
+# The following line is provided for convenience purposes. It has the downside
+# of increasing the boot-up time by auto-requiring all files in the support
+# directory. Alternatively, in the individual `*_spec.rb` files, manually
+# require only the support files necessary.
+#
+# Rails.root.glob('spec/support/**/*.rb').sort_by(&:to_s).each { |f| require f }
+
+# Checks for pending migrations and applies them before tests are run.
+# If you are not using ActiveRecord, you can remove these lines.
+begin
+  ActiveRecord::Migration.maintain_test_schema!
+rescue ActiveRecord::PendingMigrationError => e
+  abort e.to_s.strip
+end
+
+# Requires factories for testing
+Dir.glob(File.join(File.dirname(__FILE__), 'factories', '**', '*.rb')).each { |file|  require file }
+
+RSpec.configure do |config|
+  Shoulda::Matchers.configure do |shoulda_config|
+    shoulda_config.integrate do |with|
+      with.test_framework :rspec
+      with.library :rails
+    end
+  end
+  
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_paths = [
+    Rails.root.join('spec/fixtures')
+  ]
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+
+  # You can uncomment this line to turn off ActiveRecord support entirely.
+  # config.use_active_record = false
+
+  # RSpec Rails uses metadata to mix in different behaviours to your tests,
+  # for example enabling you to call `get` and `post` in request specs. e.g.:
+  #
+  #     RSpec.describe UsersController, type: :request do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://rspec.info/features/7-1/rspec-rails
+  #
+  # You can also this infer these behaviours automatically by location, e.g.
+  # /spec/models would pull in the same behaviour as `type: :model` but this
+  # behaviour is considered legacy and will be removed in a future version.
+  #
+  # To enable this behaviour uncomment the line below.
+  # config.infer_spec_type_from_file_location!
+
+  # Filter lines from Rails gems in backtraces.
+  config.filter_rails_from_backtrace!
+  # arbitrary gems may also be filtered via:
+  # config.filter_gems_from_backtrace("gem name")
+end

data/spec/spec_helper.rb

@@ -0,0 +1,94 @@
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See https://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  # https://rspec.info/features/3-12/rspec-core/configuration/zero-monkey-patching-mode/
+  config.disable_monkey_patching!
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = "doc"
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: abizvn-clients
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0.1
 platform: ruby
 authors:
 - Juan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2025-03-11 00:00:00.000000000 Z
+date: 2025-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -133,10 +133,18 @@ files:
 - config/routes.rb
 - db/migrate/20250208042258_adding_clients_table.rb
 - db/migrate/20250208072035_adding_client_domains_table.rb
+- db/migrate/20250311104419_update_domains_client_to_optional.rb
+- db/migrate/20250311111640_remove_unique_for_admin_user_email_on_clients.rb
 - lib/abizvn/clients.rb
 - lib/abizvn/clients/engine.rb
 - lib/abizvn/clients/version.rb
 - lib/tasks/abizvn/clients_tasks.rake
+- spec/factories/abizvn/clients/clients.rb
+- spec/factories/abizvn/clients/domains.rb
+- spec/models/abizvn/clients/client_spec.rb
+- spec/models/abizvn/clients/domain_spec.rb
+- spec/rails_helper.rb
+- spec/spec_helper.rb
 homepage: http://dev.abizvn.com
 licenses:
 - MIT