abak-flow 0.3.2 → 1.0.0

data/spec/abak-flow/pull_request_spec.rb

@@ -0,0 +1,353 @@
+# coding: utf-8
+require "spec_helper"
+
+describe Abak::Flow::PullRequest do
+  describe "Interface" do
+    subject { described_class.new }
+
+    it { should respond_to :valid? }
+    it { should respond_to :invalid? }
+    it { should respond_to :publish }
+    it { should respond_to :publish! }
+
+    it { should respond_to :recommendations }
+    it { should respond_to :github_link }
+    it { should respond_to :exception }
+  end
+
+  describe "Initialize process" do
+    let(:attributes) { {target: "develop", title: "Fix some problem", body: "Check this request"} }
+    let(:request) { described_class.new attributes }
+
+    before do
+      Abak::Flow::System.any_instance.stub(:ready).and_return true
+      Abak::Flow::System.any_instance.stub(:recommendations).and_return []
+    end
+
+    subject { request }
+    its(:options) { should_not be_nil }
+
+    describe "#recommendations" do
+      subject { request.recommendations }
+
+      its(:first) { should be_empty }
+      its(:last) { should be_empty }
+    end
+  end
+
+  describe "#title" do
+    before { Abak::Flow::Branches.stub(:current_branch).and_return branch }
+
+    context "when have only branch name" do
+      let(:branch) { double("Branch", tracker_task: "hello")  }
+      subject { described_class.new }
+
+      its(:title) { should eq "hello" }
+    end
+
+    context "when have only option task" do
+      let(:branch) { double("Branch", tracker_task: nil)  }
+      subject { described_class.new(title: "megusta") }
+
+      its(:title) { should eq "megusta" }
+    end
+
+    context "when have option task and branch name" do
+      let(:branch) { double("Branch", tracker_task: "tako")  }
+      subject { described_class.new(title: "burito") }
+
+      its(:title) { should eq "tako :: burito" }
+    end
+  end
+
+  describe "#comment" do
+    before { Abak::Flow::Branches.stub(:current_branch).and_return branch }
+
+    describe "when have nothing" do
+      let(:branch) { double("Branch", tracker_task: nil, task?: false)  }
+
+      before { Abak::Flow::Messages.any_instance.should_receive(:t).with(:forgot_task).and_return "I forgot my task" }
+      subject { described_class.new }
+
+      its(:comment) { should eq "I forgot my task" }
+    end
+
+    describe "when have only branch name" do
+      let(:branch) { double("Branch", tracker_task: "hello", task?: true)  }
+
+      before { described_class.any_instance.stub(:default_comment).and_return "Default comment" }
+      subject { described_class.new }
+
+      its(:comment) { should eq "Default comment" }
+    end
+
+    describe "when have only option comment" do
+      let(:branch) { double("Branch", tracker_task: "hello", task?: false)  }
+
+      subject { described_class.new(comment: "megusta") }
+
+      its(:comment) { should eq "megusta" }
+    end
+
+    describe "when have option comment and branch name" do
+      let(:branch) { double("Branch", tracker_task: "tako", task?: true)  }
+
+      before { described_class.any_instance.stub(:default_comment).and_return "Default comment" }
+      subject { described_class.new(comment: "burito") }
+
+      its(:comment) { should include "Default comment" }
+      its(:comment) { should include "burito" }
+    end
+  end
+
+  describe "#branch" do
+    before { Abak::Flow::Branches.stub(:current_branch).and_return branch }
+
+    describe "when have only option branch" do
+      let(:branch) { double("Branch", tracker_task: nil) }
+      subject { described_class.new(branch: "tako") }
+
+      its(:branch) { should eq "tako" }
+    end
+
+    describe "when have only feature branch" do
+      let(:branch) { double("Branch", tracker_task: "tako", hotfix?: false, feature?: true) }
+
+      subject { described_class.new }
+
+      its(:branch) { should eq "develop" }
+    end
+
+    describe "when have only hotfix branch" do
+      let(:branch) { double("Branch", tracker_task: "tako", feature?: false, hotfix?: true) }
+
+      subject { described_class.new }
+
+      its(:branch) { should eq "master" }
+    end
+
+    describe "when have hotfix branch and option branch" do
+      let(:branch) { double("Branch", tracker_task: "tako", feature?: false, hotfix?: true) }
+
+      subject { described_class.new(branch: "pewpew") }
+
+      its(:branch) { should eq "pewpew" }
+    end
+  end
+
+
+  describe "Publishing process" do
+    let(:pull_request) { Abak::Flow::PullRequest.new }
+
+    subject { pull_request }
+
+    describe "when something goes wrong" do
+      describe "when system is not ready" do
+        before { Abak::Flow::System.any_instance.stub(:ready).and_return false }
+        before { pull_request.stub(:invalid?).and_return true }
+
+        its(:publish) { should be_false }
+
+        describe "#exception" do
+          before { pull_request.publish }
+
+          its(:exception) { should_not be_nil }
+        end
+      end
+
+      describe "when pull request is invalid" do
+        before { Abak::Flow::System.any_instance.stub(:ready).and_return true }
+        before { pull_request.stub(:invalid?).and_return true }
+
+        its(:publish) { should be_false }
+      end
+
+      describe "when something raise exception" do
+        before do
+          Abak::Flow::System.any_instance.stub(:ready).and_return true
+          pull_request.stub(:invalid?).and_return false
+          pull_request.stub(:publish_pull_request).and_raise Exception
+        end
+
+        it { expect { pull_request.publish }.not_to raise_error }
+
+        describe "#exception" do
+          before { pull_request.publish }
+
+          its(:exception) { should_not be_nil }
+        end
+      end
+    end
+
+    describe "when all right" do
+      before do
+        Abak::Flow::System.any_instance.stub(:ready).and_return true
+        pull_request.stub(:invalid?).and_return false
+        pull_request.stub(:publish_pull_request).and_return double("Result").as_null_object
+      end
+
+      its(:publish) { should be_true }
+    end
+
+    describe "when use bang! method" do
+      describe "when something goes wrong" do
+        describe "when we raise exception" do
+          before { Abak::Flow::System.any_instance.stub(:ready).and_return false }
+
+          it { expect { pull_request.publish! }.to raise_error Exception }
+        end
+
+        describe "when something raise exception" do
+          before { Abak::Flow::System.any_instance.stub(:ready).and_return false }
+          before { pull_request.stub(:publish_pull_request).and_raise Exception }
+
+          it { expect { pull_request.publish! }.to raise_error Exception }
+        end
+      end
+
+      describe "when all right" do
+        before do
+          Abak::Flow::System.any_instance.stub(:ready).and_return true
+          pull_request.stub(:invalid?).and_return false
+          pull_request.stub(:publish_pull_request).and_return double("Result").as_null_object
+        end
+
+        it { expect { pull_request.publish! }.not_to raise_error }
+      end
+    end
+
+    describe "#github_link" do
+      describe "when request not published" do
+        its(:github_link) { should be_nil }
+      end
+
+      describe "when request successfully published" do
+        before do
+          Abak::Flow::System.any_instance.stub(:ready).and_return true
+          pull_request.stub(:invalid?).and_return false
+          pull_request.stub(:publish_pull_request).and_return double("Result", href: "wow").as_null_object
+
+          pull_request.publish
+        end
+
+        its(:github_link) { should eq "wow" }
+      end
+    end
+  end
+
+  # describe "Validation process" do
+  #   describe "when system is not ready" do
+  #     before do
+  #       Abak::Flow::PullRequest::System.ready = false
+  #       Abak::Flow::PullRequest::System.recommendations = %w[one two three]
+  #     end
+  #
+  #     subject { Abak::Flow::PullRequest.new }
+  #
+  #     describe "when pull request is valid" do
+  #       it "should not be valid pull request" do
+  #         subject.stub(:requirements_satisfied?, true) do
+  #           subject.valid?.must_equal false
+  #         end
+  #       end
+  #
+  #       it "should be invalid request" do
+  #         subject.stub(:requirements_satisfied?, true) do
+  #           subject.invalid?.must_equal true
+  #         end
+  #       end
+  #
+  #       it "should have system recommendations" do
+  #         subject.stub(:requirements_satisfied?, true) do
+  #           subject.valid?
+  #           subject.recommendations[0].wont_be_empty
+  #         end
+  #       end
+  #     end
+  #
+  #     describe "when pull request is invalid" do
+  #       it "should have only system recommendations" do
+  #         subject.stub(:requirements_satisfied?, false) do
+  #           subject.valid?
+  #           subject.recommendations[0].wont_be_empty
+  #           subject.recommendations[1].must_be_empty
+  #         end
+  #       end
+  #     end
+  #   end
+  #
+  #   describe "when system is ready" do
+  #     before do
+  #       Abak::Flow::PullRequest::System.ready = true
+  #       Abak::Flow::PullRequest::System.recommendations = []
+  #     end
+  #
+  #     subject { Abak::Flow::PullRequest.new }
+  #
+  #     describe "when pull request is valid" do
+  #       it "should be valid pull request" do
+  #         subject.stub(:requirements_satisfied?, true) do
+  #           subject.valid?.must_equal true
+  #         end
+  #       end
+  #
+  #       it "should not be invalid request" do
+  #         subject.stub(:requirements_satisfied?, true) do
+  #           subject.invalid?.must_equal false
+  #         end
+  #       end
+  #
+  #       it "should not have system recommendations" do
+  #         subject.stub(:requirements_satisfied?, true) do
+  #           subject.valid?
+  #           subject.recommendations[0].must_be_empty
+  #         end
+  #       end
+  #     end
+  #
+  #     describe "when pull request is invalid" do
+  #       describe "when title not specified" do
+  #         let(:branch) { CurrentBranchMock.new(nil, "hotfix") }
+  #         before { Abak::Flow::PullRequest::Branches.current_branch = branch }
+  #
+  #         it "should not satisfy requirements" do
+  #           subject.send(:requirements_satisfied?).must_equal false
+  #         end
+  #
+  #         it "should have recommendations" do
+  #           subject.valid?
+  #           subject.recommendations[1].wont_be_empty
+  #         end
+  #       end
+  #
+  #       describe "when branch not specified" do
+  #         let(:branch) { CurrentBranchMock.new("SG-001", "pewpew") }
+  #         before { Abak::Flow::PullRequest::Branches.current_branch = branch }
+  #
+  #         it "should not satisfy requirements" do
+  #           subject.send(:requirements_satisfied?).must_equal false
+  #         end
+  #
+  #         it "should have recommendations" do
+  #           subject.valid?
+  #           subject.recommendations[1].wont_be_empty
+  #         end
+  #       end
+  #
+  #       describe "when branch and title not specified" do
+  #         let(:branch) { CurrentBranchMock.new(nil, "pewpew") }
+  #         before { Abak::Flow::PullRequest::Branches.current_branch = branch }
+  #
+  #         it "should not satisfy requirements" do
+  #           subject.send(:requirements_satisfied?).must_equal false
+  #         end
+  #
+  #         it "should have recommendations" do
+  #           subject.valid?
+  #           subject.recommendations[1].wont_be_empty
+  #         end
+  #       end
+  #     end
+  #   end
+  # end
+end

data/spec/abak-flow/system_spec.rb

@@ -0,0 +1,97 @@
+# coding: utf-8
+require "spec_helper"
+
+describe Abak::Flow::System do
+  let(:instance) { described_class.clone.instance }
+  let(:remotes) { {origin: "origin_repo", upstream: "upstream_repo"} }
+  let(:params) { double("Params", oauth_user: "User", oauth_token: "Token", proxy_server: "http://proxy.com", locale: "en") }
+  let(:empty_params) { double("Params", oauth_user: nil, oauth_token: nil, proxy_server: nil, locale: nil) }
+
+  describe "#ready?" do
+    subject { instance.ready? }
+
+    context "when all requirements is not set" do
+      before do
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return({})
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return empty_params
+      end
+
+      it { should be_false }
+    end
+
+    context "when upstream is not set" do
+      before do
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return({origin: "not_nil"})
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return params
+      end
+
+      it { should be_false }
+    end
+
+    context "when origin is not set" do
+      before do
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return({upstream: "not_nil"})
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return params
+      end
+
+      it { should be_false }
+    end
+
+    context "when all config params is not set" do
+      before do
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return remotes
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return empty_params
+      end
+
+      it { should be_false }
+    end
+
+    context "when proxy server config is not set" do
+      before do
+        params.stub(:proxy).and_return nil
+
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return remotes
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return params
+      end
+
+      it { should be_true }
+    end
+
+    context "when all config params is set" do
+      before do
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return remotes
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return params
+      end
+
+      it { should be_true }
+    end
+  end
+
+  describe "#information" do
+    context "when proxy is set" do
+      before do
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return remotes
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return params
+      end
+
+      before { instance.ready? }
+      subject { instance.information }
+
+      it { should_not be_empty }
+    end
+
+    context "when proxy is not set" do
+      before do
+        params.stub(:proxy_server).and_return nil
+
+        Abak::Flow::Project.any_instance.stub(:remotes).and_return remotes
+        Abak::Flow::Configuration.any_instance.stub(:params).and_return params
+      end
+
+      before { instance.ready? }
+      subject { instance.information }
+
+      it { should be_empty }
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,17 @@
+# coding: utf-8
+if ENV["COVERAGE"]
+  require "simplecov"
+
+  SimpleCov.minimum_coverage 95
+  SimpleCov.start :test_frameworks do
+    add_filter "/spec/"
+  end
+end
+
+require "abak-flow"
+
+Dir["spec/support/**/*.rb"].sort.each { |f| require f }
+
+RSpec.configure do |config|
+  # ...
+end

metadata

@@ -1,64 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: abak-flow
 version: !ruby/object:Gem::Version
-  version: 0.3.2
-  prerelease: 
+  version: 1.0.0
 platform: ruby
 authors:
 - Strech (aka Sergey Fedorov)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-21 00:00:00.000000000 Z
+date: 2013-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: hub
-  requirement: !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: 1.19.0
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  name: octokit
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: 1.19.0
 - !ruby/object:Gem::Dependency
-  name: commander
-  requirement: !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.1.2
+        version: 1.2.5
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  name: git
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.1.2
+        version: 1.2.5
 - !ruby/object:Gem::Dependency
-  name: octokit
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 4.1.3
+  type: :runtime
+  prerelease: false
+  name: commander
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: 4.1.3
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.4.2
   type: :runtime
   prerelease: false
+  name: ruler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.4.2
+- !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: 0.6.1
+  type: :runtime
+  prerelease: false
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.6.1
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.4.3
+  type: :runtime
+  prerelease: false
+  name: ansi
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.4.3
 description: Простой набор правил и комманд, заточеных для работы в git-flow с использование
   в качестве удаленного репозитория github
 email:
@@ -69,6 +104,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
@@ -76,34 +112,49 @@ files:
 - abak-flow.gemspec
 - bin/request
 - lib/abak-flow.rb
-- lib/abak-flow/config.rb
-- lib/abak-flow/extensions.rb
-- lib/abak-flow/github_client.rb
+- lib/abak-flow/branch.rb
+- lib/abak-flow/branches.rb
+- lib/abak-flow/configuration.rb
+- lib/abak-flow/locales/en.yml
+- lib/abak-flow/locales/ru.yml
+- lib/abak-flow/manager.rb
+- lib/abak-flow/messages.rb
 - lib/abak-flow/pull_request.rb
+- lib/abak-flow/repository.rb
 - lib/abak-flow/request.rb
 - lib/abak-flow/version.rb
+- lib/abak-flow/visitor.rb
+- spec/abak-flow/branch_spec.rb
+- spec/abak-flow/branches_spec.rb
+- spec/abak-flow/configuration_spec.rb
+- spec/abak-flow/git_spec.rb
+- spec/abak-flow/github_client_spec.rb
+- spec/abak-flow/messages_spec.rb
+- spec/abak-flow/project_spec.rb
+- spec/abak-flow/pull_request_spec.rb
+- spec/abak-flow/system_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/Strech/abak-flow
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: abak-flow
-rubygems_version: 1.8.24
+rubygems_version: 2.0.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Совмещение 2-х подходов разработки Git-flow & Github-flow
 test_files: []

data/lib/abak-flow/config.rb

@@ -1,20 +0,0 @@
-# -*- encoding: utf-8 -*-
-module Abak::Flow
-  class Config < Struct.new(:api_user, :api_token, :proxy)
-    [:api_user, :api_token, :proxy].each {|attribute| define_method("#{attribute}?") { !send(attribute).to_s.empty? } }
-
-    def self.current
-      return @current_config unless @current_config.nil?
-
-      HighLine.color_scheme = HighLine::SampleColorScheme.new
-      git_reader = Hub::Commands.send(:git_reader)
-
-      api_user  = git_reader.read_config('abak.apiuser')
-      api_token = git_reader.read_config('abak.apitoken')
-      proxy     = git_reader.read_config('abak.proxy')
-      env_proxy = ENV['http_proxy'] || ENV['HTTP_PROXY']
-
-      @current_config = new(api_user, api_token, proxy || env_proxy)
-    end
-  end
-end