aba 0.1.0 → 1.0.0

data/spec/lib/aba/return_spec.rb

@@ -0,0 +1,67 @@
+# encoding: UTF-8
+
+require "spec_helper"
+
+describe Aba::Return do
+  subject(:transaction) { Aba::Return.new(transaction_params) }
+
+  let(:transaction_attributes) { {amount: 50050, transaction_code: 53} }
+  let(:transaction_params) do
+    {
+      :trace_account_number => 23432342,
+      :transaction_code => transaction_attributes[:transaction_code],
+      :amount => transaction_attributes[:amount],
+      :account_name => "John Doe",
+      :trace_bsb => "345-453",
+      :return_code => 8,
+      :lodgement_reference => "R45343",
+      :bsb => "123-234",
+      :account_number => "4647642",
+      :name_of_remitter => "Remitter",
+      :original_processing_day => "07",
+      :original_user_id => "054321",
+    }
+  end
+
+  describe "#to_s" do
+    it "should create a transaction row" do
+      expect(subject.to_s).to include(
+        "2123-234  46476428530000050050John Doe                        R45343            345-453 23432342Remitter        07054321")
+        # |      |        || |         |                               |                 |      |        |               | |
+        # +-bsb  |        || +-amount  +-account_name                  |                 |      |        |               | +-original_user_id
+        #        |        |+-transaction_code                          |                 |      |        |               +-original_processing_day
+        #        |        +-return_code                                |                 |      |        +-name_of_remitter
+        #        +-account_number                                      |                 |      +-trace_account_number
+        #                                                              |                 +-trace_bsb
+        #                                                              +-lodgement_reference
+    end
+
+    context 'when supplied amount is negative' do
+      let(:transaction_attributes) { {amount: -50050, transaction_code: 53} }
+
+      it "should create a transaction row where the amount does not have a sign" do
+        expect(subject.to_s).to include(
+          "2123-234  46476428530000050050John Doe                        R45343            345-453 23432342Remitter        07054321")
+          # |      |        || |         |                               |                 |      |        |               | |
+          # +-bsb  |        || +-amount  +-account_name                  |                 |      |        |               | +-original_user_id
+          #        |        |+-transaction_code                          |                 |      |        |               +-original_processing_day
+          #        |        +-return_code                                |                 |      |        +-name_of_remitter
+          #        +-account_number                                      |                 |      +-trace_account_number
+          #                                                              |                 +-trace_bsb
+          #                                                              +-lodgement_reference
+      end
+    end
+  end
+
+  describe "#valid?" do
+    it "should be valid" do
+      expect(subject.valid?).to eq true
+    end
+
+    it "should not be valid" do
+      transaction_params.delete(:bsb)
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["bsb format is incorrect"]
+    end
+  end
+end

data/spec/lib/aba/transaction_spec.rb

@@ -0,0 +1,51 @@
+# encoding: UTF-8
+
+require "spec_helper"
+
+describe Aba::Transaction do
+  subject(:transaction) { Aba::Transaction.new(transaction_params) }
+
+  let(:transaction_attributes) { {amount: 50050, transaction_code: 53} }
+
+  let(:transaction_params) do
+    {
+      :account_number => 23432342,
+      :transaction_code => transaction_attributes[:transaction_code],
+      :amount => transaction_attributes[:amount],
+      :account_name => "John Doe",
+      :bsb => "345-453",
+      :witholding_amount => 87,
+      :indicator => "W",
+      :lodgement_reference => "R45343",
+      :trace_bsb => "123-234",
+      :trace_account_number => "4647642",
+      :name_of_remitter => "Remitter",
+    }
+  end
+
+  describe "#to_s" do
+    it "should create a transaction row" do
+      expect(subject.to_s).to include("1345-453 23432342W530000050050John Doe                        R45343            123-234  4647642Remitter        00000087")
+    end
+
+    context 'when supplied amount is negative' do
+      let(:transaction_attributes) { {amount: -50050, transaction_code: 53} }
+
+      it "should create a transaction row where the amount does not have a sign" do
+        expect(subject.to_s).to include("1345-453 23432342W530000050050John Doe                        R45343            123-234  4647642Remitter        00000087")
+      end
+    end
+  end
+
+  describe "#valid?" do
+    it "should be valid" do
+      expect(subject.valid?).to eq true
+    end
+
+    it "should not be valid" do
+      transaction_params.delete(:bsb)
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["bsb format is incorrect"]
+    end
+  end
+end

data/spec/lib/aba/validations_spec.rb

@@ -0,0 +1,211 @@
+# encoding: UTF-8
+
+require "spec_helper"
+
+describe Aba::Validations do
+  let(:clean_room) do
+    Class.new(Object) do
+      include Aba::Validations
+    end
+  end
+
+  subject(:test_instance) { clean_room.new }
+
+  describe "#valid?" do
+    it "should validate presence of attrs" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_presence_of :attr1
+      end
+
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 is empty"]
+
+      subject.attr1 = "hello!"
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate bsb format" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_bsb :attr1
+      end
+
+      subject.attr1 = "234456"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 format is incorrect"]
+
+      subject.attr1 = "234-456"
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate max length" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_max_length :attr1, 5
+      end
+
+      subject.attr1 = "234456642"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 length must not exceed 5 characters"]
+
+      subject.attr1 = "23445"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = "2344"
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate length" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_length :attr1, 5
+      end
+
+      subject.attr1 = "234456642"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 length must be exactly 5 characters"]
+
+      subject.attr1 = "23445"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = "2344"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 length must be exactly 5 characters"]
+    end
+
+    it "should validate signed integer" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_integer :attr1
+      end
+
+      subject.attr1 = "+1234A"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be a number"]
+
+      subject.attr1 = "+1234"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = "-1234"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = "1234"
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate unsigned integer" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_integer :attr1, false
+      end
+
+      subject.attr1 = "1234A"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be an unsigned number"]
+
+      subject.attr1 = "+1234"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be an unsigned number"]
+
+      subject.attr1 = "-1234"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be an unsigned number"]
+
+      subject.attr1 = "1234"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = 1234
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate account number" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_account_number :attr1
+      end
+
+      subject.attr1 = "      "
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be a valid account number"]
+
+      subject.attr1 = "000000"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be a valid account number"]
+
+      subject.attr1 = "00 0 0"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be a valid account number"]
+
+      subject.attr1 = "00 0A0"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must be a valid account number"]
+
+      subject.attr1 = "00 111"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = "0a 111"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = "aaaaaa"
+      expect(subject.valid?).to eq true
+
+      subject.attr1 = "aa aaa"
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate becs" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_becs :attr1
+      end
+
+      subject.attr1 = "abc123 é"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must not contain invalid characters"]
+
+      subject.attr1 = "abc123 ~"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["attr1 must not contain invalid characters"]
+
+      subject.attr1 = "abc123"
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate indicator" do
+      clean_room.instance_eval do
+        attr_accessor :attr1
+        validates_indicator :attr1
+      end
+
+      subject.attr1 = "$"
+      expect(subject.valid?).to eq false
+      list = described_class::INDICATORS.join('\', \'')
+      expect(subject.errors).to eq ["attr1 must be a one of '#{list}'"]
+
+      subject.attr1 = described_class::INDICATORS.sample
+      expect(subject.valid?).to eq true
+    end
+
+    it "should validate transaction code" do
+      clean_room.instance_eval do
+        attr_accessor :transaction_code
+        validates_transaction_code :transaction_code
+      end
+
+      subject.transaction_code = "AA"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["transaction_code must be one of #{described_class::transaction_codes.join(', ')}"]
+
+      subject.transaction_code = "1"
+      expect(subject.valid?).to eq false
+      expect(subject.errors).to eq ["transaction_code must be one of #{described_class::transaction_codes.join(', ')}"]
+
+      subject.transaction_code = "13"
+      expect(subject.valid?).to eq true
+
+      subject.transaction_code = 50
+      expect(subject.valid?).to eq true
+    end
+  end
+end

data/spec/lib/aba_spec.rb

@@ -0,0 +1,21 @@
+# encoding: UTF-8
+
+require "spec_helper"
+
+describe Aba do
+  describe ".batch" do
+    it "initialize instance of Aba::Batch with passed arguments" do
+      attributes = double.as_null_object
+      transactions = double.as_null_object
+
+      expect(Aba::Batch).to receive(:new).with(attributes, transactions)
+      described_class.batch(attributes, transactions)
+    end
+
+    it "returns instance of Aba::Batch" do
+      obj = described_class.batch(double.as_null_object, double.as_null_object)
+
+      expect(obj).to be_a(Aba::Batch)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -2,7 +2,10 @@ require 'bundler/setup'
 Bundler.setup
 
 require "aba"
+require "pry"
 
 RSpec.configure do |config|
   config.order = :random
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
 end

metadata

@@ -1,43 +1,44 @@
 --- !ruby/object:Gem::Specification
 name: aba
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Andrey Bazhutkin
+- Trevor Wistaff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-24 00:00:00.000000000 Z
+date: 2020-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.13'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -55,25 +56,33 @@ dependencies:
 description: ABA (Australian Bankers Association) File Generator
 email:
 - andrey.bazhutkin@gmail.com
+- trev@a07.com.au
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - aba.gemspec
 - lib/aba.rb
+- lib/aba/batch.rb
+- lib/aba/entry.rb
+- lib/aba/return.rb
 - lib/aba/transaction.rb
 - lib/aba/validations.rb
 - lib/aba/version.rb
-- spec/aba_spec.rb
+- spec/lib/aba/batch_spec.rb
+- spec/lib/aba/return_spec.rb
+- spec/lib/aba/transaction_spec.rb
+- spec/lib/aba/validations_spec.rb
+- spec/lib/aba_spec.rb
 - spec/spec_helper.rb
-- spec/transaction_spec.rb
-- spec/validations_spec.rb
 homepage: https://github.com/andrba/aba
 licenses:
 - MIT
@@ -86,20 +95,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.4
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: ABA File Generator
 test_files:
-- spec/aba_spec.rb
+- spec/lib/aba/batch_spec.rb
+- spec/lib/aba/return_spec.rb
+- spec/lib/aba/transaction_spec.rb
+- spec/lib/aba/validations_spec.rb
+- spec/lib/aba_spec.rb
 - spec/spec_helper.rb
-- spec/transaction_spec.rb
-- spec/validations_spec.rb