ab_switcher 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22b2df9efba9b7560b2b61c580c5a8a7c5bf6f84c9c6f851a9fd99e568cbbe03
-  data.tar.gz: b5fb6833293878afef9cda60f96cb3d7c455b0148885553facc00fbae048a65f
+  metadata.gz: 50e6edf04ae56186c3ab3b9672bf799e38ab58a1df8359372ff256bd16abd5f3
+  data.tar.gz: 2fce66b154711a752db3784393e5ac324d32e7a7bdec908fc551071f42734ddd
 SHA512:
-  metadata.gz: ee838852922e6d63442da72f139ce125127ad1116eafb8b7fd23a47e0e87c9240f8f6fac395dda78cd2a0d3ba01718990fc67946c4257eaa91f10b92061cecd4
-  data.tar.gz: b3aa3a2c459e739f7d2f94b9dda139e73a115640343fac15e12a94a7cc4c5ec65f8449f1e186e3e240301f2b233d8978a7bd93cf892a2c78de0a5357a8f5d527
+  metadata.gz: 245141f05c81c178702d8c01b7e6b3497edddf78e106c14abeca63573a39e656c46eadec514e623ccff9d4b329ea7cc1fee36390226bc4b8428984d2ccafbb8f
+  data.tar.gz: 6f2c317fec2a80ecb3974ca7485cc7fe91a1ea5e172a277f5699c0c90d00534ba6afade2538af0d8e86bda25e9fc390151bb22ba67688b9cb24185563f02269a

data/lib/ab_switcher/switcher.rb

@@ -2,52 +2,36 @@ module ABSwitcher
   class Switcher
     HEX_MAX = 15.0
 
-    attr_reader :major_probability, :major_value, :minor_value
+    attr_reader :major_probability
 
-    def initialize(ratio, another_ratio = nil, major: true, minor: false)
-      @major_probability = calc_major_probability(ratio, another_ratio)
-      @major_value, @minor_value = major, minor
+    def initialize(ratio)
+      @major_probability = calc_major_probability(ratio)
     end
 
-    def hex_switch(hex_str)
-      hex = hex_str[0].hex rescue HEX_MAX
-      flt = hex / HEX_MAX
-
-      if flt <= major_probability
-        major_value
-      else
-        minor_value
-      end
+    def major_hex?(hex_str)
+      hex_probability(hex_str) <= major_probability
     end
 
     private
 
-    def calc_major_probability(ratio, another_ratio = nil)
-      ratio = ratio.to_f
-
-      probability = if another_ratio.nil?
-        convert_ratio_into_probability(ratio)
-      else
-        calc_probability(ratio, another_ratio)
-      end
-
+    def calc_major_probability(ratio)
+      probability = convert_ratio_into_probability(ratio.to_f)
       probability > 0.5 ? probability : 1 - probability
     end
 
     def convert_ratio_into_probability(ratio)
-      if ratio.between?(1, 100)
-        # 1 goes here
-        ratio / 100
-      elsif ratio.between?(0, 1)
+      if ratio.between?(0, 1)
         ratio
       else
         # TODO handle
-        raise DOUSHIYOU
+        raise NotImplementedError
       end
     end
 
-    def calc_probability(ratio, another_ratio)
-      ratio / (ratio + another_ratio)
+    def hex_probability(hex_str)
+      # switch by first char
+      hex = hex_str[0].hex rescue 0
+      hex / HEX_MAX
     end
   end
 end

data/lib/ab_switcher/version.rb

@@ -1,3 +1,3 @@
 module ABSwitcher
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ab_switcher
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - nishisuke
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-08 00:00:00.000000000 Z
+date: 2018-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler